[jira] [Assigned] (KAFKA-17619) Remove zk type and instance from ClusterTest

2024-09-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17619: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > Remove zk type and instance from Cluster

Re: [PR] KAFKA-17116: New consumer may not send effective leave group if member ID received after close [kafka]

2024-09-26 Thread via GitHub
frankvicky closed pull request #16649: KAFKA-17116: New consumer may not send effective leave group if member ID received after close URL: https://github.com/apache/kafka/pull/16649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776430833 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776567400 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Commented] (KAFKA-17547) Write large number of mirror maker logs when Kafka crashes

2024-09-26 Thread George Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884911#comment-17884911 ] George Yang commented on KAFKA-17547: - Could someone who has a deep understanding of

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776624490 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776624490 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-15931: Reopen TransactionIndex if channel is closed [kafka]

2024-09-26 Thread via GitHub
mjd95 commented on PR #15241: URL: https://github.com/apache/kafka/pull/15241#issuecomment-2376460752 We were the ones discussing with @jeqo - the "caching closed channels" issue was happening regularly for us on 3.8 in production, the thread doing a remote read was interrupted while iterat

[jira] [Commented] (KAFKA-17617) New GitHub Actions build builds Java 8 with 2.13 instead of 2.12

2024-09-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884912#comment-17884912 ] Chia-Ping Tsai commented on KAFKA-17617: Scala 2.12 will be dropped in 4.0 (KAFK

[jira] [Commented] (KAFKA-12895) KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

2024-09-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884917#comment-17884917 ] Chia-Ping Tsai commented on KAFKA-12895: [~frankvicky] Please review the KIP ([

[jira] [Commented] (KAFKA-17606) Include Rat errors in GitHub workflow summary

2024-09-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884919#comment-17884919 ] Chia-Ping Tsai commented on KAFKA-17606: [~loganzhu] I have assigned this Jira t

[jira] [Assigned] (KAFKA-17606) Include Rat errors in GitHub workflow summary

2024-09-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17606: -- Assignee: Logan Zhu > Include Rat errors in GitHub workflow summary > ---

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776452137 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Commented] (KAFKA-12895) KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

2024-09-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884913#comment-17884913 ] Chia-Ping Tsai commented on KAFKA-12895: Our new CI has already dropped support

[jira] [Assigned] (KAFKA-12895) KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

2024-09-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-12895: -- Assignee: TengYao Chi (was: Ismael Juma) > KIP-751: Drop support for Scala 2.12 in K

[jira] [Commented] (KAFKA-17587) Move test infrastructure out of core

2024-09-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884923#comment-17884923 ] Chia-Ping Tsai commented on KAFKA-17587: [~davidarthur] I open the https://issue

[jira] [Created] (KAFKA-17619) Remove zk type and instance from ClusterTest

2024-09-26 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17619: -- Summary: Remove zk type and instance from ClusterTest Key: KAFKA-17619 URL: https://issues.apache.org/jira/browse/KAFKA-17619 Project: Kafka Issue Type:

[PR] KAFKA-17500: Metadata redirection for NOT_LEADER_OR_FOLLOWER [kafka]

2024-09-26 Thread via GitHub
AndrewJSchofield opened a new pull request, #17279: URL: https://github.com/apache/kafka/pull/17279 This PR implements the metadata redirection feature of the ShareFetch and ShareAcknowledge responses where an error code of NOT_LEADER_OR_FOLLOWER or FENCED_LEADER_EPOCH along with current le

[PR] KAFKA-17606: Include Rat errors in GitHub workflow summary [kafka]

2024-09-26 Thread via GitHub
LoganZhuZzz opened a new pull request, #17280: URL: https://github.com/apache/kafka/pull/17280 In the current GitHub workflow, it has become difficult to locate Rat errors when running `check -x test`. To improve readability and make it easier to identify Rat errors, we need to include them

Re: [PR] KAFKA-17606: Include Rat errors in GitHub workflow summary [kafka]

2024-09-26 Thread via GitHub
LoganZhuZzz commented on PR #17280: URL: https://github.com/apache/kafka/pull/17280#issuecomment-2376561401 @chia7712 please take a look,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-16792: Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0) [kafka]

2024-09-26 Thread via GitHub
lianetm commented on code in PR #16982: URL: https://github.com/apache/kafka/pull/16982#discussion_r1776792978 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2486,68 +2492,96 @@ public void testCurrentLag(GroupProtocol groupProtocol) {

Re: [PR] KAFKA-16792: Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0) [kafka]

2024-09-26 Thread via GitHub
lianetm commented on code in PR #16982: URL: https://github.com/apache/kafka/pull/16982#discussion_r1776796286 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2486,68 +2492,96 @@ public void testCurrentLag(GroupProtocol groupProtocol) {

[jira] [Created] (KAFKA-17620) Simplify share partition acquire API

2024-09-26 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-17620: - Summary: Simplify share partition acquire API Key: KAFKA-17620 URL: https://issues.apache.org/jira/browse/KAFKA-17620 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-13938) Jenkins builds are timing out after streams integration tests

2024-09-26 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884953#comment-17884953 ] João Pedro Fonseca commented on KAFKA-13938: Hi, [~mumrah]! Since Jenkins wa

Re: [PR] KAFKA-17488: Cleanup (test) code for Kafka Streams "metric version" [kafka]

2024-09-26 Thread via GitHub
fonsdant commented on code in PR #17182: URL: https://github.com/apache/kafka/pull/17182#discussion_r1776825720 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -3030,7 +3030,7 @@ private StreamTask createSingleSourceStateless(fina

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-26 Thread via GitHub
lianetm commented on code in PR #17165: URL: https://github.com/apache/kafka/pull/17165#discussion_r1776831516 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -458,14 +466,24 @@ String memberIdInfoForLog() { }

Re: [PR] KAFKA-17505: New consumer seekToBeginning/End should run in background thread [kafka]

2024-09-26 Thread via GitHub
lianetm commented on code in PR #17230: URL: https://github.com/apache/kafka/pull/17230#discussion_r1776850858 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -842,8 +843,8 @@ public void seekToEnd(Collection partitions) {

Re: [PR] KAFKA-17505: New consumer seekToBeginning/End should run in background thread [kafka]

2024-09-26 Thread via GitHub
lianetm commented on code in PR #17230: URL: https://github.com/apache/kafka/pull/17230#discussion_r1776850858 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -842,8 +843,8 @@ public void seekToEnd(Collection partitions) {

[jira] [Resolved] (KAFKA-17496) Add heterogeneous configuration to TargetAssignmentBuilderBenchmark

2024-09-26 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-17496. - Fix Version/s: 4.0.0 Resolution: Fixed > Add heterogeneous configuration to TargetAssignm

[jira] [Commented] (KAFKA-17616) Remove KafkaServer

2024-09-26 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17884885#comment-17884885 ] Dmitry Werner commented on KAFKA-17616: --- [~cmccabe] Hello, if you are not start wo

Re: [PR] KAFKA-17571; Revert "MINOR: Log pending join members (#17219)" [kafka]

2024-09-26 Thread via GitHub
dajac commented on PR #17274: URL: https://github.com/apache/kafka/pull/17274#issuecomment-2376097825 @mumrah @chia7712 Long story short, I did not find any correctness issue in the new group coordinator. All the failed tests where due to pending members in the classic group preventing the

Re: [PR] KAFKA-17571; Revert "MINOR: Log pending join members (#17219)" [kafka]

2024-09-26 Thread via GitHub
dajac merged PR #17274: URL: https://github.com/apache/kafka/pull/17274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-17571) Revert #17219

2024-09-26 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-17571. - Fix Version/s: 4.0.0 Resolution: Fixed > Revert #17219 > - > >

Re: [PR] KAFKA-17109: Move lock backoff retry to streams TaskManager [kafka]

2024-09-26 Thread via GitHub
cadonna commented on PR #17209: URL: https://github.com/apache/kafka/pull/17209#issuecomment-2376116982 @aliehsaeedii the following test fails consistently with a NPE with this PR: `StreamThreadTest.shouldRecordCommitLatency()`. See https://github.com/apache/kafka/actions/runs/110306753

[jira] [Resolved] (KAFKA-17584) Fix incorrect synonym handling for dynamic log configurations

2024-09-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-17584. --- Fix Version/s: 3.9.0 3.8.1 Resolution: Fixed > Fix incorrect synonym handl

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776535621 ## share-coordinator/src/test/java/org/apache/kafka/coordinator/share/StateBatchUtilTest.java: ## @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776452137 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
smjn commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776535621 ## share-coordinator/src/test/java/org/apache/kafka/coordinator/share/StateBatchUtilTest.java: ## @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Updated] (KAFKA-17618) group consumer heartbeat interval should be less than session timeout

2024-09-26 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-17618: -- Labels: kip-848 (was: ) > group consumer heartbeat interval should be less than session timeout > ---

[jira] [Created] (KAFKA-17618) group consumer heartbeat interval should be less than session timeout

2024-09-26 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17618: - Summary: group consumer heartbeat interval should be less than session timeout Key: KAFKA-17618 URL: https://issues.apache.org/jira/browse/KAFKA-17618 Project: Kafka

Re: [PR] KAFKA-15859: Add timeout field to the ListOffsets request [kafka]

2024-09-26 Thread via GitHub
mumrah commented on PR #17112: URL: https://github.com/apache/kafka/pull/17112#issuecomment-2377323567 @satishd @showuon this PR broke some tests and has caused trunk builds to fail. The latest CI run for this PR was https://github.com/apache/kafka/actions/runs/11027485627 which sho

[jira] [Assigned] (KAFKA-17617) New GitHub Actions build builds Java 8 with 2.13 instead of 2.12

2024-09-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-17617: Assignee: David Arthur > New GitHub Actions build builds Java 8 with 2.13 instead of 2.12

Re: [PR] HOTFIX: fix failed cases in FeatureCommandTest [kafka]

2024-09-26 Thread via GitHub
kamalcph commented on PR #17287: URL: https://github.com/apache/kafka/pull/17287#issuecomment-2377344257 Thanks @FrankYang0529 for fixing this test! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-15859: Add timeout field to the ListOffsets request [kafka]

2024-09-26 Thread via GitHub
kamalcph commented on PR #17112: URL: https://github.com/apache/kafka/pull/17112#issuecomment-2377346567 The failed test are fixed in #17287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] KAFKA-17621; Reduce logging verbosity on ConsumerGroupHeartbeat path [kafka]

2024-09-26 Thread via GitHub
dajac commented on code in PR #17288: URL: https://github.com/apache/kafka/pull/17288#discussion_r1777317218 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1984,8 +1986,10 @@ private CoordinatorResult classicGroupJoinToCo

Re: [PR] KAFKA-17621; Reduce logging verbosity on ConsumerGroupHeartbeat path [kafka]

2024-09-26 Thread via GitHub
dajac commented on code in PR #17288: URL: https://github.com/apache/kafka/pull/17288#discussion_r1777312193 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1984,8 +1986,10 @@ private CoordinatorResult classicGroupJoinToCo

Re: [PR] HOTFIX: fix failed cases in FeatureCommandTest [kafka]

2024-09-26 Thread via GitHub
mumrah merged PR #17287: URL: https://github.com/apache/kafka/pull/17287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-17078: Add SecurityManagerCompatibility shim [kafka]

2024-09-26 Thread via GitHub
gharris1727 commented on PR #16522: URL: https://github.com/apache/kafka/pull/16522#issuecomment-2377340024 Hey @danishnawab thanks for reminding us. Since this may only be included in future releases (3.7.2, 3.8.1, 3.9.1, 4.0.0), existing releases you can use the workaround of settin

Re: [PR] KAFKA-16792: Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0) [kafka]

2024-09-26 Thread via GitHub
lianetm merged PR #16982: URL: https://github.com/apache/kafka/pull/16982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-17623) Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback

2024-09-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17623: -- Component/s: clients > Flaky > testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCall

Re: [PR] KAFKA-14562 [1/2]: Implement epoch bump after every transaction [kafka]

2024-09-26 Thread via GitHub
jolshan merged PR #16719: URL: https://github.com/apache/kafka/pull/16719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-26 Thread via GitHub
kirktrue commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1777422783 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1279,7 +1281,7 @@ private void releaseAssignmentAndLeaveGroup(fina

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-26 Thread via GitHub
FrankYang0529 commented on code in PR #17165: URL: https://github.com/apache/kafka/pull/17165#discussion_r1776908662 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -458,14 +466,24 @@ String memberIdInfoForLog() { }

[PR] KAFKA-16733: Add share group record support to OffsetsMessageParser [kafka]

2024-09-26 Thread via GitHub
AndrewJSchofield opened a new pull request, #17282: URL: https://github.com/apache/kafka/pull/17282 KIP-932 added a bunch of new record schemas to the consumer offsets topic which need to be added to the OffsetsMessageParser in kafka-dump-log.sh. ### Committer Checklist (excluded from

[jira] [Commented] (KAFKA-16394) ForeignKey LEFT join propagates null value on foreignKey change

2024-09-26 Thread Andras Hatvani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885016#comment-17885016 ] Andras Hatvani commented on KAFKA-16394: [~mjsax] Any update on the fix and rele

[PR] KAFKA-17619: Remove zk type and instance from ClusterTest [kafka]

2024-09-26 Thread via GitHub
FrankYang0529 opened a new pull request, #17284: URL: https://github.com/apache/kafka/pull/17284 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
AndrewJSchofield commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1777017514 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundat

[PR] MINOR: Cache topic resolution in TopicIds set [kafka]

2024-09-26 Thread via GitHub
squah-confluent opened a new pull request, #17285: URL: https://github.com/apache/kafka/pull/17285 Looking up topics in a TopicsImage is relatively slow. Cache the results in TopicIds to improve assignor performance. In benchmarks, we see a noticeable improvement in performance in the h

[jira] [Created] (KAFKA-17624) Remove the E2E uses of accessing ACLs from zk

2024-09-26 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17624: -- Summary: Remove the E2E uses of accessing ACLs from zk Key: KAFKA-17624 URL: https://issues.apache.org/jira/browse/KAFKA-17624 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-17624) Remove the E2E uses of accessing ACLs from zk

2024-09-26 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885050#comment-17885050 ] TengYao Chi commented on KAFKA-17624: - Hi [~chia7712]  If you are not start working

[PR] MINOR: fix failed cases in FeatureCommandTest [kafka]

2024-09-26 Thread via GitHub
FrankYang0529 opened a new pull request, #17287: URL: https://github.com/apache/kafka/pull/17287 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

Re: [PR] KAFKA-17317: Validate and maybe trigger downgrade after static member replacement [kafka]

2024-09-26 Thread via GitHub
dongnuo123 commented on PR #17008: URL: https://github.com/apache/kafka/pull/17008#issuecomment-2377169743 Reopened https://github.com/apache/kafka/pull/17286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-26 Thread via GitHub
mumrah commented on code in PR #17204: URL: https://github.com/apache/kafka/pull/17204#discussion_r1777223177 ## committer-tools/update-cache.sh: ## @@ -0,0 +1,35 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-26 Thread via GitHub
mumrah commented on PR #17204: URL: https://github.com/apache/kafka/pull/17204#issuecomment-2377207907 > Maybe, we keep it more agnostic and print a message guiding the user to fetch. WDYT? Good point on different remote names. Let's still attempt to update the ref in this script. If

[jira] [Updated] (KAFKA-17617) New GitHub Actions build builds Java 8 with 2.13 instead of 2.12

2024-09-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-17617: - Fix Version/s: 3.9.1 > New GitHub Actions build builds Java 8 with 2.13 instead of 2.12 > --

[jira] [Updated] (KAFKA-17617) New GitHub Actions build builds Java 8 with 2.13 instead of 2.12

2024-09-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-17617: - Priority: Minor (was: Critical) > New GitHub Actions build builds Java 8 with 2.13 instead of 2

[jira] [Updated] (KAFKA-17617) New GitHub Actions build builds Java 8 with 2.13 instead of 2.12

2024-09-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-17617: - Fix Version/s: 3.7.2 3.8.1 > New GitHub Actions build builds Java 8 with 2.13

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-26 Thread via GitHub
lianetm commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1777270499 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerSubscriptionTest.scala: ## @@ -244,6 +245,9 @@ class PlaintextConsumerSubscriptionTest extends AbstractCo

Re: [PR] HOTFIX: fix failed cases in FeatureCommandTest [kafka]

2024-09-26 Thread via GitHub
mumrah commented on PR #17287: URL: https://github.com/apache/kafka/pull/17287#issuecomment-2377227125 Looks like the tests were failing on the PR, so this should not have been merged. https://github.com/apache/kafka/actions/runs/11027485627 -- This is an automated message from the

Re: [PR] HOTFIX: fix failed cases in FeatureCommandTest [kafka]

2024-09-26 Thread via GitHub
mumrah commented on PR #17287: URL: https://github.com/apache/kafka/pull/17287#issuecomment-2377232171 @chia7712 I agree we should eventually have some "acceptance" tests which do some high level sanity checks. In this case, a change to MetadataVersion (located in server-common) will cause

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2024-09-26 Thread via GitHub
wrwksexahatvani commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2376945505 @mjsax @wcarlson5 @gongxuanzhang This is a major blocker as it leads to data loss as happened in dozens of my projects. When will the fix for this be integrated? -- This is an

Re: [PR] KAFKA-17480: New consumer commit all consumed should retrieve offsets in background thread [kafka]

2024-09-26 Thread via GitHub
lianetm commented on code in PR #17150: URL: https://github.com/apache/kafka/pull/17150#discussion_r1777058782 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -162,23 +163,44 @@ private void process(final PollEven

Re: [PR] KAFKA-17488: Cleanup (test) code for Kafka Streams "metric version" [kafka]

2024-09-26 Thread via GitHub
fonsdant commented on PR #17182: URL: https://github.com/apache/kafka/pull/17182#issuecomment-2376967494 Accidentally, I must have reverted the removal of the `builtInMetricsVersion` passing argument to `StreamsMetricsImpl` in `TopologyTestDriver`, which has caused the build to fail. The la

[jira] [Updated] (KAFKA-17622) Kafka Streams Timeout During Partition Rebalance

2024-09-26 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi updated KAFKA-17622: - Summary: Kafka Streams Timeout During Partition Rebalance (was: Kafka Streams Timeout During P

[jira] [Commented] (KAFKA-17582) Unpredictable consumer position after transaction abort

2024-09-26 Thread Kyle Kingsbury (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885032#comment-17885032 ] Kyle Kingsbury commented on KAFKA-17582: I've done some more digging here, and w

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-26 Thread via GitHub
lianetm commented on PR #17244: URL: https://github.com/apache/kafka/pull/17244#issuecomment-2377319827 Regarding: > I haven't had a chance to dig into the root cause as I'm curious what can be done at that layer so that the consumer doesn't have to be aware of it. My thoughts in c

Re: [PR] KAFKA-16792: Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0) [kafka]

2024-09-26 Thread via GitHub
FrankYang0529 commented on code in PR #16982: URL: https://github.com/apache/kafka/pull/16982#discussion_r1776899718 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2486,68 +2492,96 @@ public void testCurrentLag(GroupProtocol groupProtoc

Re: [PR] KAFKA-16792: Enable consumer unit tests that fail to fetch offsets only for new consumer with poll(0) [kafka]

2024-09-26 Thread via GitHub
FrankYang0529 commented on code in PR #16982: URL: https://github.com/apache/kafka/pull/16982#discussion_r1776899718 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2486,68 +2492,96 @@ public void testCurrentLag(GroupProtocol groupProtoc

Re: [PR] KAFKA-17505: New consumer seekToBeginning/End should run in background thread [kafka]

2024-09-26 Thread via GitHub
lianetm commented on code in PR #17230: URL: https://github.com/apache/kafka/pull/17230#discussion_r1776850858 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -842,8 +843,8 @@ public void seekToEnd(Collection partitions) {

[jira] [Resolved] (KAFKA-15266) Static configs set for non primary synonyms are ignored for Log configs

2024-09-26 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash resolved KAFKA-15266. -- Resolution: Duplicate > Static configs set for non primary synonyms are ignore

Re: [PR] Refactored and fixed minor share fetch code (KIP-932) [kafka]

2024-09-26 Thread via GitHub
mumrah merged PR #17269: URL: https://github.com/apache/kafka/pull/17269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[PR] KAFKA-17618: group consumer heartbeat interval should be less than session timeout [kafka]

2024-09-26 Thread via GitHub
FrankYang0529 opened a new pull request, #17281: URL: https://github.com/apache/kafka/pull/17281 [KIP-848](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=217387038#KIP848:TheNextGenerationoftheConsumerRebalanceProtocol-Heartbeat&Session) mentions: > The member is expect

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
mumrah commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776991897 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/StateBatchUtil.java: ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-17612: Remove some tests that only apply to ZK mode or migration [kafka]

2024-09-26 Thread via GitHub
chia7712 merged PR #17276: URL: https://github.com/apache/kafka/pull/17276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-17621) Reduce logging verbosity on ConsumerGroupHeartbeat path

2024-09-26 Thread David Jacot (Jira)
David Jacot created KAFKA-17621: --- Summary: Reduce logging verbosity on ConsumerGroupHeartbeat path Key: KAFKA-17621 URL: https://issues.apache.org/jira/browse/KAFKA-17621 Project: Kafka Issue T

[jira] [Updated] (KAFKA-17618) group consumer heartbeat interval should be less than session timeout

2024-09-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17618: -- Component/s: clients consumer > group consumer heartbeat interval should be less than

Re: [PR] KAFKA-16343: Add unit tests of foreignKeyJoin classes [kafka]

2024-09-26 Thread via GitHub
wrwksexahatvani commented on PR #15564: URL: https://github.com/apache/kafka/pull/15564#issuecomment-2376930948 @wcarlson5 @mjsax In which release will these tests and of course the fix in KAFKA-16394 be integrated? -- This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (KAFKA-17618) group consumer heartbeat interval should be less than session timeout

2024-09-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17618: -- Component/s: (was: clients) (was: consumer) > group consumer heartbeat interv

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-26 Thread via GitHub
lianetm commented on PR #17165: URL: https://github.com/apache/kafka/pull/17165#issuecomment-2377143597 FYI, I filed https://issues.apache.org/jira/browse/KAFKA-17623 for a flaky consumer integration test that I noticed here, has been flaky for a while. -- This is an automated message fro

[jira] [Created] (KAFKA-17623) Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback

2024-09-26 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17623: -- Summary: Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback Key: KAFKA-17623 URL: https://issues.apache.org/jira/browse/KAFKA-17623

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-26 Thread via GitHub
FrankYang0529 commented on PR #17165: URL: https://github.com/apache/kafka/pull/17165#issuecomment-2377164009 > FYI, I filed https://issues.apache.org/jira/browse/KAFKA-17623 for a flaky consumer integration test that I noticed here, has been flaky for a while. Okay. I will take a loo

[jira] [Commented] (KAFKA-17623) Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback

2024-09-26 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885047#comment-17885047 ] PoAn Yang commented on KAFKA-17623: --- Hi [~lianetm], may I take this? Thank you. > Fla

Re: [PR] (WIP) MINOR: Cache topic resolution in TopicIds set [kafka]

2024-09-26 Thread via GitHub
dajac closed pull request #16527: (WIP) MINOR: Cache topic resolution in TopicIds set URL: https://github.com/apache/kafka/pull/16527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-17317: Validate and maybe trigger downgrade after static member replacement [kafka]

2024-09-26 Thread via GitHub
dongnuo123 closed pull request #17008: KAFKA-17317: Validate and maybe trigger downgrade after static member replacement URL: https://github.com/apache/kafka/pull/17008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-17623) Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback

2024-09-26 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885049#comment-17885049 ] Lianet Magrans commented on KAFKA-17623: Sure, thanks! > Flaky > testSeekPosit

[PR] KAFKA-17317: Validate and maybe trigger downgrade after static member replacement [kafka]

2024-09-26 Thread via GitHub
dongnuo123 opened a new pull request, #17286: URL: https://github.com/apache/kafka/pull/17286 https://issues.apache.org/jira/browse/KAFKA-17317 This patch makes the online downgrade trigger asynchronous by scheduling a timer to downgrade the group in the appendFuture of the coordinato

Re: [PR] (WIP) MINOR: Cache topic resolution in TopicIds set [kafka]

2024-09-26 Thread via GitHub
dajac commented on PR #16527: URL: https://github.com/apache/kafka/pull/16527#issuecomment-2377167228 Replaced by https://github.com/apache/kafka/pull/17285. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Assigned] (KAFKA-17623) Flaky testSeekPositionAndPauseNewlyAssignedPartitionOnPartitionsAssignedCallback

2024-09-26 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-17623: -- Assignee: PoAn Yang > Flaky > testSeekPositionAndPauseNewlyAssignedPartitionOnPartit

Re: [PR] KAFKA-17367: Share coordinator impl. New merge batches algorithm. [3/N] [kafka]

2024-09-26 Thread via GitHub
mumrah commented on code in PR #17149: URL: https://github.com/apache/kafka/pull/17149#discussion_r1776956765 ## share-coordinator/src/test/java/org/apache/kafka/coordinator/share/StateBatchUtilTest.java: ## @@ -60,36 +60,60 @@ static class BatchTestHolder { this.sh

Re: [PR] MINOR: Fix a race and add JMH bench for HdrHistogram [kafka]

2024-09-26 Thread via GitHub
jeffkbkim commented on code in PR #17221: URL: https://github.com/apache/kafka/pull/17221#discussion_r1776938178 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/HdrHistogramTest.java: ## @@ -172,4 +178,39 @@ public void testHistogramDataReset() {

  1   2   3   >