kamalcph commented on PR #17112:
URL: https://github.com/apache/kafka/pull/17112#issuecomment-278433
This PR can be reviewed independently of #16602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jirar created KAFKA-17490:
-
Summary: UpdateMetadataRequest failed because of failed
authorization
Key: KAFKA-17490
URL: https://issues.apache.org/jira/browse/KAFKA-17490
Project: Kafka
Issue Type: B
[
https://issues.apache.org/jira/browse/KAFKA-17490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jirar updated KAFKA-17490:
--
Description:
I build a kafka cluster with kafka-2.8.1, use ranger as the authorization
platform. After the in
dajac commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r174684
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Override
chia7712 commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1746736242
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Overr
fred-ro commented on PR #17086:
URL: https://github.com/apache/kafka/pull/17086#issuecomment-2333571961
I had a look at those consumer constructors and I do not think that just
swapping lines will do the job as some exceptions might been raised before.
So solutions would be to remove the
TaiJuWu commented on PR #12331:
URL: https://github.com/apache/kafka/pull/12331#issuecomment-2333654213
> > Hi @showuon @vinothchandar , I think this is not only write permission
problem, when I run `logCleanerTest` and `UnifiedLogTest`, ther error message is
> > ```
> > [2024-09-06 09
showuon commented on code in PR #16602:
URL: https://github.com/apache/kafka/pull/16602#discussion_r1746751416
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1601,21 +1601,25 @@ class Partition(val topicPartition: TopicPartition,
s"high watermark (${localL
apoorvmittal10 closed pull request #17009: KAFKA-17287: Added integration tests
for ShareConsumer
URL: https://github.com/apache/kafka/pull/17009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Dmitry Werner created KAFKA-17491:
-
Summary: Move BrokerServerMetrics to server module
Key: KAFKA-17491
URL: https://issues.apache.org/jira/browse/KAFKA-17491
Project: Kafka
Issue Type: Sub-t
[
https://issues.apache.org/jira/browse/KAFKA-17491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Werner reassigned KAFKA-17491:
-
Assignee: Dmitry Werner
> Move BrokerServerMetrics to server module
> -
wernerdv opened a new pull request, #17114:
URL: https://github.com/apache/kafka/pull/17114
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade note
FrankYang0529 commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1746944955
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -1053,12 +1053,20 @@ public void
testFetchStableOffsetThrowInCommitted(G
cadonna opened a new pull request, #17115:
URL: https://github.com/apache/kafka/pull/17115
Failed tasks discovered when removed from the state updater during
assignment or revocation are added to the task registry. From there they are
retrieved and handled as normal tasks. This leads to a c
lianetm commented on code in PR #16885:
URL: https://github.com/apache/kafka/pull/16885#discussion_r1746966454
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##
@@ -182,6 +215,234 @@ public CompletableFuture> fetchO
fonsdant commented on code in PR #17038:
URL: https://github.com/apache/kafka/pull/17038#discussion_r1746786740
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -262,12 +264,13 @@ private void createInternalTopics() {
aliehsaeedii commented on code in PR #17116:
URL: https://github.com/apache/kafka/pull/17116#discussion_r1747024247
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##
@@ -681,4 +706,19 @@ public int hashCode() {
}
}
+
rich-c-shop commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1747027687
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -2397,7 +2399,12 @@ public ProducerRecord
onSend(ProducerRecord reco
rich-c-shop commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1747034130
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -2397,7 +2399,12 @@ public ProducerRecord
onSend(ProducerRecord reco
FrankYang0529 commented on PR #17075:
URL: https://github.com/apache/kafka/pull/17075#issuecomment-2333943120
@kirktrue, thanks for reviewing and suggestions. I addressed all comments
and add Javadoc for the `SeekUnvalidatedEvent`. Could you take a look when you
have time? Thank you.
--
rich-c-shop commented on PR #17099:
URL: https://github.com/apache/kafka/pull/17099#issuecomment-2333956366
> Could you implement two different interceptor classes in
ProducerInterceptorsTest, one with the new signature of onAcknowledgement and
one with the old, and then run the same parame
rich-c-shop commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1747052310
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -2397,7 +2399,15 @@ public ProducerRecord
onSend(ProducerRecord reco
m1a2st commented on code in PR #16899:
URL: https://github.com/apache/kafka/pull/16899#discussion_r1747059604
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -355,6 +355,14 @@ public Map
valuesWithPrefixAllOrNothing(String prefix) {
r
chia7712 commented on code in PR #17104:
URL: https://github.com/apache/kafka/pull/17104#discussion_r1747065830
##
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##
@@ -554,12 +554,12 @@ public void
shouldInvokeUserDefinedGlobalStateRest
lianetm commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1747073433
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -1053,12 +1053,20 @@ public void
testFetchStableOffsetThrowInCommitted(GroupPr
[
https://issues.apache.org/jira/browse/KAFKA-16792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879861#comment-17879861
]
Lianet Magrans commented on KAFKA-16792:
Agree that even though we could conside
lianetm commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1747085039
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2507,32 +2521,35 @@ public void testCurrentLag(GroupProtocol groupProtocol)
{
lianetm commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1747085039
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2507,32 +2521,35 @@ public void testCurrentLag(GroupProtocol groupProtocol)
{
chia7712 commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1747108990
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Overr
[
https://issues.apache.org/jira/browse/KAFKA-17492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879865#comment-17879865
]
Chia-Ping Tsai commented on KAFKA-17492:
error message (register 3.9 broker to 3
kamalcph commented on code in PR #16602:
URL: https://github.com/apache/kafka/pull/16602#discussion_r1747114987
##
core/src/test/java/kafka/log/remote/RemoteLogOffsetReaderTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
FrankYang0529 commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1747137112
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2507,32 +2521,35 @@ public void testCurrentLag(GroupProtocol groupProtoc
lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747149449
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -753,9 +754,14 @@ public void onResponse(final ClientResponse resp
lianetm commented on PR #17109:
URL: https://github.com/apache/kafka/pull/17109#issuecomment-2334089903
Hey @frankvicky , thanks for the patch! Took a first look (without the
tests), left one comment for consideration about the approach. Thanks!
--
This is an automated message from the Ap
lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747149449
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -753,9 +754,14 @@ public void onResponse(final ClientResponse resp
mumrah commented on PR #17004:
URL: https://github.com/apache/kafka/pull/17004#issuecomment-2334123913
@soarez I may have found a fix. In
https://github.com/apache/kafka/actions/runs/10729396763 I was able to see the
"Timed out waiting for topics to be deleted" failure case. In the logs, it
chia7712 commented on code in PR #17106:
URL: https://github.com/apache/kafka/pull/17106#discussion_r1747126992
##
build.gradle:
##
@@ -499,6 +502,32 @@ subprojects {
maxFailures = userMaxTestRetryFailures
}
}
+
+// As we process results, check if th
bbejeck commented on PR #17104:
URL: https://github.com/apache/kafka/pull/17104#issuecomment-2334158813
Updated to address latest comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
frankvicky commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747223340
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -753,9 +754,14 @@ public void onResponse(final ClientResponse r
Chris Egerton created KAFKA-17493:
-
Summary: Sink connector-related OffsetsApiIntegrationTest suite
test cases failing more frequently with new consumer/group coordinator
Key: KAFKA-17493
URL: https://issues.apach
C0urante commented on PR #16918:
URL: https://github.com/apache/kafka/pull/16918#issuecomment-2334220537
@gharris1727 Can you take a look at this when you have a moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lianetm commented on PR #17075:
URL: https://github.com/apache/kafka/pull/17075#issuecomment-2334236502
Hey @FrankYang0529 , thanks for the patch! Took a full pass, just some minor
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747266859
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1077,6 +1083,10 @@ private void onSuccess(final long currentTimeM
mumrah commented on PR #17106:
URL: https://github.com/apache/kafka/pull/17106#issuecomment-2334284335
Locally, I added a test that will always be flaky (fail, then pass) in the
`:metadata` module. Here are the results with the latest code 111fcf7a895.
Before each run, I emptied the
frankvicky commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747303032
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1077,6 +1083,10 @@ private void onSuccess(final long currentTi
lianetm commented on code in PR #16686:
URL: https://github.com/apache/kafka/pull/16686#discussion_r1747345639
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1302,6 +1304,42 @@ private void releaseAssignmentAndLeaveGroup(fina
lianetm commented on code in PR #16686:
URL: https://github.com/apache/kafka/pull/16686#discussion_r1747345639
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1302,6 +1304,42 @@ private void releaseAssignmentAndLeaveGroup(fina
mumrah opened a new pull request, #17118:
URL: https://github.com/apache/kafka/pull/17118
Use the given epoch in LocalLogManager#prepareAppend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jolshan commented on PR #16898:
URL: https://github.com/apache/kafka/pull/16898#issuecomment-2334395283
will give the +1 when the conflicts are fixed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
mumrah commented on PR #17118:
URL: https://github.com/apache/kafka/pull/17118#issuecomment-2334401889
I could not reproduce this locally, but we do see this test failing
occasionally during CI.
Here's one such failure:
https://ge.apache.org/s/a7oj4c6hibpn4/tests/task/:metadat
jolshan commented on code in PR #16840:
URL: https://github.com/apache/kafka/pull/16840#discussion_r1747400656
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -395,6 +403,8 @@ public synchronized void maybeAddPartition(TopicPar
lucasbru commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1747400688
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java:
##
@@ -90,6 +91,15 @@ public int count() {
return count;
}
+public
lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747405683
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -900,6 +901,37 @@ public void
testOffsetCommitAsyncFailedWith
fred-ro commented on code in PR #17086:
URL: https://github.com/apache/kafka/pull/17086#discussion_r1747432655
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -237,7 +237,7 @@ private void process(final
ConsumerRebalanceListen
[
https://issues.apache.org/jira/browse/KAFKA-17489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17489:
Affects Version/s: 3.8.0
> IllegalStateException if failed task is removed from state upda
lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747437781
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1499,6 +1538,37 @@ public ClientResponse mockOffsetCommitResp
lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747438058
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1499,6 +1538,37 @@ public ClientResponse mockOffsetCommitResp
lianetm commented on code in PR #17109:
URL: https://github.com/apache/kafka/pull/17109#discussion_r1747439518
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1499,6 +1538,37 @@ public ClientResponse mockOffsetCommitResp
[
https://issues.apache.org/jira/browse/KAFKA-16602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur resolved KAFKA-16602.
--
Resolution: Fixed
> Flaky test –
> org.apache.kafka.controller.QuorumControllerTest.testBoots
mumrah opened a new pull request, #17119:
URL: https://github.com/apache/kafka/pull/17119
Cherry-pick of #17094 to 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
lucasbru commented on code in PR #17116:
URL: https://github.com/apache/kafka/pull/17116#discussion_r1747481383
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##
@@ -353,9 +356,11 @@ synchronized boolean lock(final TaskId taskId) {
mumrah opened a new pull request, #17120:
URL: https://github.com/apache/kafka/pull/17120
Cherry-pick of #17094 to 3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
jolshan commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1747537295
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Overri
jolshan commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1747540484
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Overri
CalvinConfluent commented on code in PR #16840:
URL: https://github.com/apache/kafka/pull/16840#discussion_r1747549211
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -980,6 +1002,28 @@ void handleCoordinatorReady() {
CalvinConfluent commented on code in PR #16840:
URL: https://github.com/apache/kafka/pull/16840#discussion_r1747560534
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -368,15 +370,21 @@ public synchronized TransactionalRequestR
jolshan commented on code in PR #16840:
URL: https://github.com/apache/kafka/pull/16840#discussion_r1747560606
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -980,6 +1002,28 @@ void handleCoordinatorReady() {
mumrah merged PR #17106:
URL: https://github.com/apache/kafka/pull/17106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
wernerdv commented on PR #17114:
URL: https://github.com/apache/kafka/pull/17114#issuecomment-2334768121
@chia7712 @mimaison Hello, please take a look at the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cmccabe merged PR #17081:
URL: https://github.com/apache/kafka/pull/17081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mumrah commented on PR #17121:
URL: https://github.com/apache/kafka/pull/17121#issuecomment-2334840543
I have tested the timeout case on mumrah/kafka here
https://github.com/mumrah/kafka/actions/runs/10745303070/job/29804106047?pr=13#step:6:71
This is a perfect example since we do act
jsancio commented on code in PR #17081:
URL: https://github.com/apache/kafka/pull/17081#discussion_r1747455267
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -204,7 +204,8 @@ def __init__(self, context, num_nodes, zk,
security_protocol=SecurityConfig.PLAI
c
bbejeck commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1746160929
##
streams/src/main/java/org/apache/kafka/streams/internals/metrics/StreamsThreadDelegatingMetricsReporter.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Soft
chia7712 commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1745300168
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Overr
chia7712 commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1747882963
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Overr
mjsax commented on PR #17059:
URL: https://github.com/apache/kafka/pull/17059#issuecomment-2335034080
@pegasas -- There is also checkstyle error. Please take a look, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bboyleonp666 commented on PR #16843:
URL: https://github.com/apache/kafka/pull/16843#issuecomment-2335093204
> @bboyleonp666 please rebase code to fix build error. Also, please fix
following usages:
>
>
https://github.com/apache/kafka/blob/28cd7136fb1b5702af82c3736d246c7a1e709140/cor
77 matches
Mail list logo
