DL1231 commented on code in PR #16887:
URL: https://github.com/apache/kafka/pull/16887#discussion_r1730271755
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -256,6 +278,32 @@ public void testDynamicBrokerConfigUpdateUsingKraft()
throws Exception {
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876480#comment-17876480
]
Balaji Rao commented on KAFKA-16567:
[~cadonna] it seems the remaining metrics
*
{
chia7712 commented on PR #16950:
URL: https://github.com/apache/kafka/pull/16950#issuecomment-2308746393
> By restructuring the build.gradle, I meant that the shadowJar block should
be moved above the publishing block. That is not happening in this PR, only
changing the fork is.
@KTK
chia7712 commented on code in PR #16987:
URL: https://github.com/apache/kafka/pull/16987#discussion_r1730294085
##
tools/src/main/java/org/apache/kafka/tools/consumer/DefaultMessageFormatter.java:
##
@@ -130,25 +134,31 @@ public void writeTo(ConsumerRecord
consumerRecord, Print
chia7712 merged PR #16876:
URL: https://github.com/apache/kafka/pull/16876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #16991:
URL: https://github.com/apache/kafka/pull/16991#issuecomment-2308754564
@cmccabe could you please fix build error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
KTKTK-HZ commented on PR #16950:
URL: https://github.com/apache/kafka/pull/16950#issuecomment-2308758996
Hey @gharris1727 @chia7712 , I will modify this PR and refactor build.gradle
to move the shadowJar block before the publishing block.
--
This is an automated message from the Apache Gi
xijiu commented on PR #16980:
URL: https://github.com/apache/kafka/pull/16980#issuecomment-2308792034
> @xijiu could you please fix the build error?
@chia7712 It's my fault, I should add the `@SuppressWarnings("unchecked")`
annotation when I perform forced type conversion, like this
[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-17360:
---
Fix Version/s: 3.7.2
3.8.1
> local log retention ms/bytes "-2" is not tre
chia7712 merged PR #16932:
URL: https://github.com/apache/kafka/pull/16932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
xijiu commented on code in PR #16987:
URL: https://github.com/apache/kafka/pull/16987#discussion_r1730319638
##
tools/src/main/java/org/apache/kafka/tools/consumer/DefaultMessageFormatter.java:
##
@@ -130,25 +134,31 @@ public void writeTo(ConsumerRecord
consumerRecord, PrintStr
[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876497#comment-17876497
]
Chia-Ping Tsai commented on KAFKA-17360:
the patch is merged to trunk
(https://
Chia-Ping Tsai created KAFKA-17418:
--
Summary: Fix the incorrect markdown of junit.py caused by newline
character
Key: KAFKA-17418
URL: https://issues.apache.org/jira/browse/KAFKA-17418
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-17418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876500#comment-17876500
]
kangning.li commented on KAFKA-17418:
-
Hi [~chia7712] , I am interested in this issu
[
https://issues.apache.org/jira/browse/KAFKA-17418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17418:
--
Assignee: kangning.li (was: Chia-Ping Tsai)
> Fix the incorrect markdown of junit.py
[
https://issues.apache.org/jira/browse/KAFKA-17384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876501#comment-17876501
]
Chia-Ping Tsai commented on KAFKA-17384:
[~yangpoan] Could you please add link o
chia7712 commented on code in PR #16992:
URL: https://github.com/apache/kafka/pull/16992#discussion_r1730323750
##
tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java:
##
@@ -107,12 +107,7 @@ private static class GetOffsetShellOptions extends
CommandDefaultOptions {
brandboat opened a new pull request, #16995:
URL: https://github.com/apache/kafka/pull/16995
related to https://issues.apache.org/jira/browse/KAFKA-17360 (3.8 branch)
When the local.retention.ms/bytes is set to -2,
we didn't replace it with the server-side retention.ms/bytes config,
chia7712 commented on code in PR #16958:
URL: https://github.com/apache/kafka/pull/16958#discussion_r1730325275
##
tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java:
##
@@ -131,14 +131,6 @@ private static ArgumentParser argParser() {
.dest("boot
chia7712 commented on code in PR #16990:
URL: https://github.com/apache/kafka/pull/16990#discussion_r1730326689
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/ConfigurationUtils.java:
##
@@ -209,6 +209,19 @@ public String validateString(S
brandboat opened a new pull request, #16996:
URL: https://github.com/apache/kafka/pull/16996
based on 3.7 branch, related to
https://issues.apache.org/jira/browse/KAFKA-17360
When the local.retention.ms/bytes is set to -2,
we didn't replace it with the server-side retention.ms/byte
chia7712 merged PR #16961:
URL: https://github.com/apache/kafka/pull/16961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #16954:
URL: https://github.com/apache/kafka/pull/16954#discussion_r1730329818
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java:
##
@@ -206,29 +206,29 @@ public synchronized Collection
getAllMetadat
xijiu opened a new pull request, #16997:
URL: https://github.com/apache/kafka/pull/16997
1. remove `src/generated/java` from core module
2. add `` to the `suppressions.xml` to suppress all generated
code
### Committer Checklist (excluded from commit message)
- [ ] Verify design
xijiu closed pull request #16997: KAFKA-17416: Add a checkstyle rule to
suppress all generated code
URL: https://github.com/apache/kafka/pull/16997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
xijiu opened a new pull request, #16998:
URL: https://github.com/apache/kafka/pull/16998
1. remove `src/generated/java` from core module
2. add `` to the `suppressions.xml` to suppress all generated
code
### Committer Checklist (excluded from commit message)
- [ ] Verify design
chia7712 commented on code in PR #16998:
URL: https://github.com/apache/kafka/pull/16998#discussion_r1730338891
##
checkstyle/suppressions.xml:
##
@@ -237,6 +237,7 @@
+
Review Comment:
Please remove other generated-related suppression. they are redundan
xijiu commented on code in PR #16998:
URL: https://github.com/apache/kafka/pull/16998#discussion_r1730342466
##
checkstyle/suppressions.xml:
##
@@ -237,6 +237,7 @@
+
Review Comment:
> Please remove other generated-related suppression. they are redundant
chia7712 commented on code in PR #16898:
URL: https://github.com/apache/kafka/pull/16898#discussion_r1730343775
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3225,7 +3228,14 @@ public void replay(
.update
pegasas commented on code in PR #16791:
URL: https://github.com/apache/kafka/pull/16791#discussion_r1730390328
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -820,110 +778,6 @@ public synchronized Topology
addReadOnlyStateStore(final StoreBuilder
pegasas commented on PR #16791:
URL: https://github.com/apache/kafka/pull/16791#issuecomment-2308913465
> @pegasas -- Any updates on this PR?
org.apache.kafka.streams.Topology#addProcessor(java.lang.String,
org.apache.kafka.streams.processor.ProcessorSupplier, java.lang.String...)
pegasas commented on code in PR #16791:
URL: https://github.com/apache/kafka/pull/16791#discussion_r1730392424
##
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java:
##
@@ -292,7 +292,7 @@ Cancellable schedule(final Duration interval,
* (includi
[
https://issues.apache.org/jira/browse/KAFKA-16331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876530#comment-17876530
]
Matthias J. Sax commented on KAFKA-16331:
-
This is a very complicated ticket...
mjsax commented on code in PR #16954:
URL: https://github.com/apache/kafka/pull/16954#discussion_r1730404618
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java:
##
@@ -206,29 +206,29 @@ public synchronized Collection
getAllMetadataFo
mjsax commented on code in PR #16954:
URL: https://github.com/apache/kafka/pull/16954#discussion_r1730404855
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java:
##
@@ -246,7 +246,7 @@ default boolean commitRequested() {
// IQ related methods
[
https://issues.apache.org/jira/browse/KAFKA-17354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876537#comment-17876537
]
Anton Liauchuk commented on KAFKA-17354:
[~aoli-al]
Didn't reproduce the issue
[
https://issues.apache.org/jira/browse/KAFKA-16331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876539#comment-17876539
]
Ismael Juma commented on KAFKA-16331:
-
Seems reasonable. The main thing to call out
[
https://issues.apache.org/jira/browse/KAFKA-16331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876539#comment-17876539
]
Ismael Juma edited comment on KAFKA-16331 at 8/25/24 7:28 PM:
[
https://issues.apache.org/jira/browse/KAFKA-17354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876540#comment-17876540
]
Ao Li commented on KAFKA-17354:
---
[~anton.liauchuk] Yes, I'm able to reproduce the failure.
mjsax commented on PR #16791:
URL: https://github.com/apache/kafka/pull/16791#issuecomment-2308982763
There is two overloads. The old one, using
`org.apache.kafka.streams.processor.ProcessorSupplier`
```
org.apache.kafka.streams.Topology#addProcessor(java.lang.String,
org.apache.kafka
mjsax commented on code in PR #16791:
URL: https://github.com/apache/kafka/pull/16791#discussion_r1730426306
##
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java:
##
@@ -292,8 +292,7 @@ Cancellable schedule(final Duration interval,
* (including
mjsax commented on code in PR #16791:
URL: https://github.com/apache/kafka/pull/16791#discussion_r1730426384
##
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java:
##
@@ -292,8 +292,7 @@ Cancellable schedule(final Duration interval,
* (including
mjsax commented on code in PR #16791:
URL: https://github.com/apache/kafka/pull/16791#discussion_r1730426457
##
streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessingContext.java:
##
@@ -201,8 +201,7 @@ Cancellable schedule(final Duration interval,
* (incl
mjsax commented on PR #16791:
URL: https://github.com/apache/kafka/pull/16791#issuecomment-2308985631
The build has checkstyle errors:
```
> Task :streams:checkstyleMain
--
| 2993 | 09:39:12 AM | [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_
mjsax commented on code in PR #15482:
URL: https://github.com/apache/kafka/pull/15482#discussion_r1730427154
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java:
##
@@ -570,7 +570,7 @@ public Optional> partitions(final String
topic, fi
mjsax commented on code in PR #15482:
URL: https://github.com/apache/kafka/pull/15482#discussion_r1730427271
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##
@@ -1230,7 +1230,7 @@ private KTable
doJoinOnForeignKey(final KTable forei
mjsax commented on code in PR #15482:
URL: https://github.com/apache/kafka/pull/15482#discussion_r1730427271
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##
@@ -1230,7 +1230,7 @@ private KTable
doJoinOnForeignKey(final KTable forei
mjsax commented on PR #15341:
URL: https://github.com/apache/kafka/pull/15341#issuecomment-2308987847
> I have some capacity to pickup this one.
Nice! This is highly appeciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax commented on code in PR #16906:
URL: https://github.com/apache/kafka/pull/16906#discussion_r1730428926
##
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java:
##
@@ -72,14 +71,6 @@ class CachingWindowStore
this.maxObservedTimesta
mjsax commented on PR #16981:
URL: https://github.com/apache/kafka/pull/16981#issuecomment-2308994715
Thank you both!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
mjsax commented on PR #16985:
URL: https://github.com/apache/kafka/pull/16985#issuecomment-2308995761
On build failed with compilation error:
```
> Task :streams:compileJava
--
more_vert | 2701 | 06:13:33 AM |
/home/jenkins/workspace/Kafka_kafka-pr_PR-16985/streams/src/main/java/
mjsax commented on code in PR #16985:
URL: https://github.com/apache/kafka/pull/16985#discussion_r1730431915
##
streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java:
##
@@ -41,10 +34,10 @@ public class TaskId implements Comparable {
/** The ID of the subto
mjsax commented on PR #16985:
URL: https://github.com/apache/kafka/pull/16985#issuecomment-2308996189
This PR should also remove `TaskMetadata#taskId()`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mjsax commented on PR #16985:
URL: https://github.com/apache/kafka/pull/16985#issuecomment-2308998527
Ah. Never mind. `TaskMetadata` was remove by the other PR you did already...
(now I remember why I did leave the commend on the Jira ticket about, both
should be worked on together...) -- i
mjsax commented on PR #16941:
URL: https://github.com/apache/kafka/pull/16941#issuecomment-2309001082
> I'm not entirely sure how this method will be used. From the docs, it
seems that client code can invoke it since it is a public method declared in
the interface.
It's all internal.
[
https://issues.apache.org/jira/browse/KAFKA-17216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-17216.
-
Resolution: Invalid
Cf the reply on GitHub – caused by version miss-match.
> StreamsCon
mjsax merged PR #16914:
URL: https://github.com/apache/kafka/pull/16914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mumrah commented on code in PR #16998:
URL: https://github.com/apache/kafka/pull/16998#discussion_r1730436780
##
checkstyle/suppressions.xml:
##
@@ -221,22 +221,7 @@
files="^(?!.*[\\/]org[\\/]apache[\\/]kafka[\\/]streams[\\/].*$)"/>
-
-
-
-
mjsax commented on PR #16914:
URL: https://github.com/apache/kafka/pull/16914#issuecomment-2309007974
Thanks for the PR @raminqaf -- merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
chia7712 commented on PR #16998:
URL: https://github.com/apache/kafka/pull/16998#issuecomment-2309008426
```
```
```
```
```
```
@xijiu please remove above rules also, thanks!
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/KAFKA-16331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876545#comment-17876545
]
Matthias J. Sax commented on KAFKA-16331:
-
Yes, that's also important. Thanks fo
Chia-Ping Tsai created KAFKA-17419:
--
Summary: Disable SslAdminIntegrationTest#testExpireDelegationToken
for 3.8 and 3.7
Key: KAFKA-17419
URL: https://issues.apache.org/jira/browse/KAFKA-17419
Project
chia7712 commented on PR #16995:
URL: https://github.com/apache/kafka/pull/16995#issuecomment-2309011897
The failed test is caused by my previous backport. I forgot to disable it
... open https://issues.apache.org/jira/browse/KAFKA-17419 to disable it
--
This is an automated message from
mjsax commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1730439203
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -839,7 +839,8 @@ public class StreamsConfig extends AbstractConfig {
Type
chia7712 commented on PR #16950:
URL: https://github.com/apache/kafka/pull/16950#issuecomment-2309013403
> I will modify this PR and refactor build.gradle to move the shadowJar
block before the publishing block.
@KTKTK-HZ Thanks a bunch!
BTW, could you please remove the "[Mino
chia7712 commented on PR #16995:
URL: https://github.com/apache/kafka/pull/16995#issuecomment-2309013599
another failed test pass on my local. will merge it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #16996:
URL: https://github.com/apache/kafka/pull/16996#issuecomment-2309016578
the failed test is traced by
https://issues.apache.org/jira/browse/KAFKA-17419. other failed tests pass on
my local
--
This is an automated message from the Apache Git Service.
To res
chia7712 merged PR #16996:
URL: https://github.com/apache/kafka/pull/16996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #16995:
URL: https://github.com/apache/kafka/pull/16995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876547#comment-17876547
]
Chia-Ping Tsai commented on KAFKA-17360:
3.7:
https://github.com/apache/kafka/c
[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17360.
Resolution: Fixed
> local log retention ms/bytes "-2" is not treated correctly
> -
chia7712 commented on code in PR #16887:
URL: https://github.com/apache/kafka/pull/16887#discussion_r1730446002
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -256,6 +278,32 @@ public void testDynamicBrokerConfigUpdateUsingKraft()
throws Exception {
Chia-Ping Tsai created KAFKA-17420:
--
Summary: Fix flaky StreamThreadTest.tearDown
Key: KAFKA-17420
URL: https://issues.apache.org/jira/browse/KAFKA-17420
Project: Kafka
Issue Type: Test
[
https://issues.apache.org/jira/browse/KAFKA-17419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876549#comment-17876549
]
kangning.li commented on KAFKA-17419:
-
hi [~chia7712] , I am interested in this issu
[
https://issues.apache.org/jira/browse/KAFKA-17419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17419:
--
Assignee: kangning.li (was: Chia-Ping Tsai)
> Disable SslAdminIntegrationTest#testEx
chia7712 commented on PR #16954:
URL: https://github.com/apache/kafka/pull/16954#issuecomment-2309029491
I open https://issues.apache.org/jira/browse/KAFKA-17420 to trace
`StreamThreadTest.tearDown`, and others are known flaky.
--
This is an automated message from the Apache Git Service.
chia7712 merged PR #16954:
URL: https://github.com/apache/kafka/pull/16954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mjsax commented on code in PR #16922:
URL: https://github.com/apache/kafka/pull/16922#discussion_r1730446985
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##
@@ -182,6 +199,120 @@ private boolean lockStateDirectory() {
return
xijiu commented on code in PR #16998:
URL: https://github.com/apache/kafka/pull/16998#discussion_r1730499267
##
checkstyle/suppressions.xml:
##
@@ -221,22 +221,7 @@
files="^(?!.*[\\/]org[\\/]apache[\\/]kafka[\\/]streams[\\/].*$)"/>
-
-
-
-
xijiu commented on PR #16998:
URL: https://github.com/apache/kafka/pull/16998#issuecomment-2309123331
@chia7712 @mumrahI have fixed above issues, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
xijiu commented on code in PR #16998:
URL: https://github.com/apache/kafka/pull/16998#discussion_r1730499267
##
checkstyle/suppressions.xml:
##
@@ -221,22 +221,7 @@
files="^(?!.*[\\/]org[\\/]apache[\\/]kafka[\\/]streams[\\/].*$)"/>
-
-
-
-
chia7712 commented on PR #16980:
URL: https://github.com/apache/kafka/pull/16980#issuecomment-2309141760
@xijiu Could you please rebase code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chia7712 commented on PR #16933:
URL: https://github.com/apache/kafka/pull/16933#issuecomment-2309143513
@FrankYang0529 could you please rebase code to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
FrankYang0529 commented on PR #16933:
URL: https://github.com/apache/kafka/pull/16933#issuecomment-2309151303
> @FrankYang0529 could you please rebase code to trigger QA again?
Rebased it. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the mess
chia7712 commented on code in PR #16905:
URL: https://github.com/apache/kafka/pull/16905#discussion_r1730549155
##
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##
@@ -331,6 +332,54 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegration
gongxuanzhang opened a new pull request, #16999:
URL: https://github.com/apache/kafka/pull/16999
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
chia7712 commented on code in PR #16648:
URL: https://github.com/apache/kafka/pull/16648#discussion_r1730562364
##
clients/src/main/java/org/apache/kafka/clients/admin/ExpireDelegationTokenOptions.java:
##
@@ -25,10 +25,19 @@
* The API of this class is evolving, see {@link Adm
chia7712 commented on PR #16999:
URL: https://github.com/apache/kafka/pull/16999#issuecomment-2309176757
@gongxuanzhang thanks for this patch. the changes are beyond the jira. Could
you please focus on "config_property" file?
--
This is an automated message from the Apache Git Service.
To
DL1231 commented on code in PR #16887:
URL: https://github.com/apache/kafka/pull/16887#discussion_r1730575833
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -256,6 +278,32 @@ public void testDynamicBrokerConfigUpdateUsingKraft()
throws Exception {
gongxuanzhang closed pull request #16999: KAFKA-17382: cleanup out-of-date
configs of config_property
URL: https://github.com/apache/kafka/pull/16999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pegasas commented on PR #16791:
URL: https://github.com/apache/kafka/pull/16791#issuecomment-2309191228
> The build has checkstyle errors:
>
> ```
> > Task :streams:checkstyleMain
> --
> | 2993 | 09:39:12 AM | [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/K
chia7712 commented on code in PR #16921:
URL: https://github.com/apache/kafka/pull/16921#discussion_r1730578171
##
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
chia7712 commented on PR #16879:
URL: https://github.com/apache/kafka/pull/16879#issuecomment-2309201764
@abhi-ksolves could you please remove related scripts and e2e?
https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/mirror_maker.py
https://github.com/apache/kaf
xijiu commented on PR #16980:
URL: https://github.com/apache/kafka/pull/16980#issuecomment-2309230891
> @xijiu Could you please rebase code?
@chia7712
Yeap, I have already rebased the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message,
showuon commented on code in PR #16959:
URL: https://github.com/apache/kafka/pull/16959#discussion_r1730617565
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2530,6 +2635,21 @@ public void
testDeleteLogSegmentDueToRetentionTimeBreach(int segmentCount,
github-actions[bot] commented on PR #15848:
URL: https://github.com/apache/kafka/pull/15848#issuecomment-2309238540
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2309238666
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
gongxuanzhang opened a new pull request, #17000:
URL: https://github.com/apache/kafka/pull/17000
fix https://issues.apache.org/jira/browse/KAFKA-17382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-17397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876576#comment-17876576
]
Arpit Goyal commented on KAFKA-17397:
-
[~kirktrue] Can I pick this up ?
> Ensure C
showuon commented on code in PR #16959:
URL: https://github.com/apache/kafka/pull/16959#discussion_r1730655484
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1254,6 +1255,20 @@ void cleanupExpiredRemoteLogSegments() throws
RemoteStorageException, Execution
1 - 100 of 112 matches
Mail list logo
