frankvicky commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1623166279
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegateTest.java:
##
@@ -140,6 +141,25 @@ public void testEnsureTimerSetOnAdd() {
chiacyu commented on code in PR #15989:
URL: https://github.com/apache/kafka/pull/15989#discussion_r1623166390
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java:
##
@@ -1315,4 +1451,22 @@ private Map structToMap(Struct stru
chiacyu closed pull request #15989: KAFKA-16223: Replace EasyMock/PowerMock
with Mockito for KafkaConfigBackingStoreTest
URL: https://github.com/apache/kafka/pull/15989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
brandboat opened a new pull request, #16165:
URL: https://github.com/apache/kafka/pull/16165
related to https://issues.apache.org/jira/browse/KAFKA-16814
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
TaiJuWu commented on code in PR #15862:
URL: https://github.com/apache/kafka/pull/15862#discussion_r1623180599
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -17,29 +17,64 @@
package kafka.test.junit;
+import kafka.test.ClusterConfig;
impo
TaiJuWu commented on PR #16013:
URL: https://github.com/apache/kafka/pull/16013#issuecomment-2143370139
Pin @chia7712 , Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
soarez commented on code in PR #15834:
URL: https://github.com/apache/kafka/pull/15834#discussion_r1623198189
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1457,6 +1465,18 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
}
farbodahm opened a new pull request, #16166:
URL: https://github.com/apache/kafka/pull/16166
I was using Kafka Connect ([Confluent
Image](https://hub.docker.com/r/confluentinc/cp-kafka-connect)) to run an
Iceberg Sink connector on 2 different AWS environments (running on ECS) and
same Kafk
Chuckame commented on PR #14157:
URL: https://github.com/apache/kafka/pull/14157#issuecomment-2143420186
Hello @mjsax, I'm working on it (or trying to 😄). What do you think about
adding `getRaw` to the `KeyValueStore` interface ? It would generalize an
efficient access from anywhere.
chia7712 commented on code in PR #16164:
URL: https://github.com/apache/kafka/pull/16164#discussion_r1623211768
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java:
##
@@ -1184,6 +1185,148 @@ public void
testRestoreRestartRe
chia7712 commented on code in PR #16013:
URL: https://github.com/apache/kafka/pull/16013#discussion_r1623212627
##
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerIntegrationTestUtils.java:
##
@@ -139,15 +140,19 @@ static void sendBrokerHeartbeatToUnfenceBroke
chiacyu commented on code in PR #16164:
URL: https://github.com/apache/kafka/pull/16164#discussion_r1623216072
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java:
##
@@ -1184,6 +1185,148 @@ public void
testRestoreRestartReq
[
https://issues.apache.org/jira/browse/KAFKA-16871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851287#comment-17851287
]
MOHD KAIF KHAN commented on KAFKA-16871:
Hey [~ableegoldman], I would like to wo
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1623229305
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -223,8 +230,8 @@ class LogCleaner(initialConfig: CleanerConfig,
info(s"Updating logCleanerIoMaxBytesPerS
gongxuanzhang commented on PR #16097:
URL: https://github.com/apache/kafka/pull/16097#issuecomment-2143483983
I update this PR,plz review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
C0urante commented on code in PR #16166:
URL: https://github.com/apache/kafka/pull/16166#discussion_r1623243320
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -190,15 +190,15 @@ private HttpResponse httpRequest(HttpClient
client,
[
https://issues.apache.org/jira/browse/KAFKA-16838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851304#comment-17851304
]
Sergey Ivanov commented on KAFKA-16838:
---
Hi [~ChrisEgerton], thanks for the answer
chia7712 commented on code in PR #16164:
URL: https://github.com/apache/kafka/pull/16164#discussion_r1623248311
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java:
##
@@ -1184,6 +1185,148 @@ public void
testRestoreRestartRe
chia7712 commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1623249229
##
checkstyle/checkstyle.xml:
##
@@ -82,6 +82,10 @@
+
chia7712 merged PR #15862:
URL: https://github.com/apache/kafka/pull/15862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16652.
Fix Version/s: 3.9.0
Resolution: Fixed
> add unit test for ClusterTemplate offering
pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1623251171
##
core/src/test/java/kafka/admin/AclCommandIntegrationTest.java:
##
@@ -0,0 +1,453 @@
+package kafka.admin;
+
+import kafka.test.ClusterInstance;
+import kafka.test.a
chia7712 merged PR #15863:
URL: https://github.com/apache/kafka/pull/15863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16574.
Fix Version/s: 3.9.0
Resolution: Fixed
> The metrics of LogCleaner disappear after
chia7712 merged PR #16155:
URL: https://github.com/apache/kafka/pull/16155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
farbodahm commented on code in PR #16166:
URL: https://github.com/apache/kafka/pull/16166#discussion_r1623260629
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -190,15 +190,15 @@ private HttpResponse httpRequest(HttpClient
client,
[
https://issues.apache.org/jira/browse/KAFKA-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851318#comment-17851318
]
Eric Lu commented on KAFKA-16803:
-
Hi, I've been looking into it for a little while now
[
https://issues.apache.org/jira/browse/KAFKA-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Lu reassigned KAFKA-16803:
---
Assignee: (was: Eric Lu)
> Upgrade to a version of ShadowJavaPlugin which doesn't use Configure
TaiJuWu opened a new pull request, #16167:
URL: https://github.com/apache/kafka/pull/16167
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
EricLuGHub closed pull request #16096: bumping shadowJar 8.1.0->8.1.1
URL: https://github.com/apache/kafka/pull/16096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
[
https://issues.apache.org/jira/browse/KAFKA-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851327#comment-17851327
]
Ganesh Sadanala commented on KAFKA-15156:
-
is this still open issue?Â
> Update
[
https://issues.apache.org/jira/browse/KAFKA-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Sadanala reassigned KAFKA-15156:
---
Assignee: Ganesh Sadanala
> Update cipherInformation correctly in DefaultChannelMet
chia7712 commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2143558213
I noticed that we don't have IT for downgrading to classic group. Maybe we
can add IT in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/KAFKA-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851160#comment-17851160
]
Ganesh Sadanala edited comment on KAFKA-16811 at 6/1/24 7:26 PM:
-
chia7712 commented on PR #16042:
URL: https://github.com/apache/kafka/pull/16042#issuecomment-2143563321
@m1a2st Could you please rebase code again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
C0urante commented on PR #16166:
URL: https://github.com/apache/kafka/pull/16166#issuecomment-2143575258
Thanks @farbodahm! LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
C0urante merged PR #16166:
URL: https://github.com/apache/kafka/pull/16166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851341#comment-17851341
]
Muralidhar Basani commented on KAFKA-16869:
---
Is it ok if I pick up this ?Â
Wi
[
https://issues.apache.org/jira/browse/KAFKA-16874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851342#comment-17851342
]
Muralidhar Basani commented on KAFKA-16874:
---
I see there are a few other imple
muralibasani opened a new pull request, #16168:
URL: https://github.com/apache/kafka/pull/16168
Resolves https://issues.apache.org/jira/browse/KAFKA-16698
My hunch is that adding a timeout to alterClientQuotas, could fix the
timeout issue happening here in next step connectionRateForI
[
https://issues.apache.org/jira/browse/KAFKA-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Muralidhar Basani reassigned KAFKA-16698:
-
Assignee: Muralidhar Basani
> Fix flaky
> kafka.network.DynamicConnectionQuota
[
https://issues.apache.org/jira/browse/KAFKA-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851343#comment-17851343
]
Muralidhar Basani commented on KAFKA-16698:
---
Thanks, I have a PR opened.
> Fi
[
https://issues.apache.org/jira/browse/KAFKA-16698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851343#comment-17851343
]
Muralidhar Basani edited comment on KAFKA-16698 at 6/1/24 9:36 PM:
---
soarez merged PR #15945:
URL: https://github.com/apache/kafka/pull/15945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-16757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez resolved KAFKA-16757.
-
Resolution: Fixed
> Fix broker re-registration issues around MV 3.7-IV2
> --
ganesh-sadanala opened a new pull request, #16169:
URL: https://github.com/apache/kafka/pull/16169
Assing the new value of `cipherInformation` to a member variable if the
assigning variable value is not null. The previous implementation has a bug
preventing it from getting updated with the
[
https://issues.apache.org/jira/browse/KAFKA-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851345#comment-17851345
]
Ganesh Sadanala commented on KAFKA-15156:
-
[GitHub Pull Request #16169|https://g
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1623310676
##
build.gradle:
##
@@ -47,7 +47,8 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// art
gongxuanzhang commented on code in PR #16097:
URL: https://github.com/apache/kafka/pull/16097#discussion_r1623310868
##
checkstyle/checkstyle.xml:
##
@@ -82,6 +82,10 @@
+
frankvicky commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2143675270
Sounds good, I will write an integration test for downgrading to classic
group
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
github-actions[bot] commented on PR #15085:
URL: https://github.com/apache/kafka/pull/15085#issuecomment-2143682945
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #14841:
URL: https://github.com/apache/kafka/pull/14841#issuecomment-2143682954
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Sadanala reassigned KAFKA-16876:
---
Assignee: Ganesh Sadanala
> TaskManager.handleRevocation doesn't handle errors thro
ganesh-sadanala commented on PR #16162:
URL: https://github.com/apache/kafka/pull/16162#issuecomment-2143705807
I have completed the implementation using the SlidingWindow approach with
x=30 seconds for testing. Here are the changes:
https://github.com/apache/kafka/pull/16162
dajac commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2143718116
@dongnuo123 is working in adding integration tests for all this work stream.
We should wait.
@chia7712 We do already have unit tests but we missed one for this
particular case.
--
dajac commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2143718243
@dongnuo123 Could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
56 matches
Mail list logo
