Re: [PR] KAFKA-16821: Member Subscription Spec Interface [kafka]

2024-05-25 Thread via GitHub
dajac commented on code in PR #16068: URL: https://github.com/apache/kafka/pull/16068#discussion_r1614404973 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpec.java: ## @@ -26,9 +26,9 @@ */ public interface GroupSpec { /** - * @r

Re: [PR] KAFKA-16821: Member Subscription Spec Interface [kafka]

2024-05-25 Thread via GitHub
dajac commented on code in PR #16068: URL: https://github.com/apache/kafka/pull/16068#discussion_r1614409077 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpecImpl.java: ## @@ -35,6 +37,11 @@ public class GroupSpecImpl implements GroupSpec {

Re: [PR] KAFKA-15045: (KIP-924 pt. 9) TaskAssignmentUtils implementation of optimizeRackAwareActiveTasks [kafka]

2024-05-25 Thread via GitHub
ableegoldman commented on code in PR #16033: URL: https://github.com/apache/kafka/pull/16033#discussion_r1614410581 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java: ## @@ -58,7 +112,85 @@ public static Map optimizeRackAwareActiveT

Re: [PR] KAFKA-15045: (KIP-924 pt. 9) TaskAssignmentUtils implementation of optimizeRackAwareActiveTasks [kafka]

2024-05-25 Thread via GitHub
ableegoldman commented on code in PR #16033: URL: https://github.com/apache/kafka/pull/16033#discussion_r1614411014 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java: ## @@ -74,20 +198,219 @@ public static Map optimizeRackAwareStand

Re: [PR] KAFKA-16371; fix lingering pending commit when handling OFFSET_METADATA_TOO_LARGE [kafka]

2024-05-25 Thread via GitHub
dajac commented on code in PR #16072: URL: https://github.com/apache/kafka/pull/16072#discussion_r1614441098 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest { assertEquals(0, TestU

[jira] [Commented] (KAFKA-16805) Stop using a ClosureBackedAction to configure Spotbugs reports

2024-05-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849438#comment-17849438 ] 黃竣陽 commented on KAFKA-16805: - I'm interesting in this issue > Stop using a ClosureBackedAc

[PR] KAFKA-16805: Stop using a ClosureBackedAction to configure Spotbugs reports [kafka]

2024-05-25 Thread via GitHub
m1a2st opened a new pull request, #16081: URL: https://github.com/apache/kafka/pull/16081 This issue https://issues.apache.org/jira/browse/KAFKA-16805, I change the `reports` method to `reports.configure` to avoid use the ClosureBackedAction interface -- This is an automated message

Re: [PR] KAFKA-15853: Move general configs out of KafkaConfig [kafka]

2024-05-25 Thread via GitHub
mimaison commented on code in PR #16040: URL: https://github.com/apache/kafka/pull/16040#discussion_r1614511230 ## server/src/main/java/org/apache/kafka/server/config/KafkaServerConfigs.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Comment Edited] (KAFKA-16805) Stop using a ClosureBackedAction to configure Spotbugs reports

2024-05-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849438#comment-17849438 ] 黃竣陽 edited comment on KAFKA-16805 at 5/25/24 1:08 PM: -- I'm interest

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-25 Thread via GitHub
FrankYang0529 commented on PR #15908: URL: https://github.com/apache/kafka/pull/15908#issuecomment-2131274897 > One high-level question: > I found after this change, we increased the test case numbers from 492 -> 660. And the time for this test suite takes form 1h 19m -> 1h 31m. Do we rea

Re: [PR] MINOR: migrate DescribeConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-25 Thread via GitHub
FrankYang0529 commented on code in PR #15908: URL: https://github.com/apache/kafka/pull/15908#discussion_r1614679946 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java: ## @@ -141,699 +162,773 @@ public void testPrintVersion(String quorum

Re: [PR] [Don't merge]KAFKA-16812: The tools-related tests are slow [kafka]

2024-05-25 Thread via GitHub
TaiJuWu commented on PR #16030: URL: https://github.com/apache/kafka/pull/16030#issuecomment-2131288594 We can get test report from tools/build/test-results/test/TEST-org.apache.kafka.tools.TopicCommandIntegrationTest.xml We find this bottleneck is `setup` so we can merge a small test

Re: [PR] KAFKA-15746: KRaft support in ControllerMutationQuotaTest [kafka]

2024-05-25 Thread via GitHub
mimaison commented on PR #15038: URL: https://github.com/apache/kafka/pull/15038#issuecomment-2131300855 @linzihao1999 No worries. It's not really urgent but it would be nice to get it done in the next month or so. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-25 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849461#comment-17849461 ] FTR commented on KAFKA-16687: - Handle personal issue, sorry late to reply. Just found more,

[jira] [Resolved] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-25 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] FTR resolved KAFKA-16687. - Resolution: Invalid > Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0 > ---

Re: [PR] KAFKA-16371; fix lingering pending commit when handling OFFSET_METADATA_TOO_LARGE [kafka]

2024-05-25 Thread via GitHub
jolshan commented on code in PR #16072: URL: https://github.com/apache/kafka/pull/16072#discussion_r1614738949 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest { assertEquals(0, Tes

Re: [PR] [Don't merge]KAFKA-16812: The tools-related tests are slow [kafka]

2024-05-25 Thread via GitHub
chia7712 commented on PR #16030: URL: https://github.com/apache/kafka/pull/16030#issuecomment-2131313203 @TaiJuWu As TopicCommandIntegrationTest is a large test, could you please try to file multiple PRs to move it to TopicCommandTest with new test infra and refactor (you described) ? --

[jira] [Created] (KAFKA-16841) ZKIntegrationTests broken

2024-05-25 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-16841: -- Summary: ZKIntegrationTests broken Key: KAFKA-16841 URL: https://issues.apache.org/jira/browse/KAFKA-16841 Project: Kafka Issue Type: Task Re

[jira] [Updated] (KAFKA-16841) ZKMigratoinIntegrationTests broken

2024-05-25 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-16841: --- Summary: ZKMigratoinIntegrationTests broken (was: ZKIntegrationTests broken) > ZKMigratoin

[jira] [Updated] (KAFKA-16841) ZKMigrationIntegrationTests broken

2024-05-25 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-16841: --- Summary: ZKMigrationIntegrationTests broken (was: ZKMigratoinIntegrationTests broken) > ZK

Re: [PR] KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-25 Thread via GitHub
jolshan commented on PR #16006: URL: https://github.com/apache/kafka/pull/16006#issuecomment-2131315366 Are we sure the failures are not related? It seems there are consistent ZKMigrationIntegrationTest failures on trunk since this change. Reverting the change fixes the issue. -- This i

[jira] [Commented] (KAFKA-16841) ZKMigrationIntegrationTests broken

2024-05-25 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849463#comment-17849463 ] Justine Olshan commented on KAFKA-16841: I am suspicious of https://github.com/a

[jira] [Commented] (KAFKA-16841) ZKMigrationIntegrationTests broken

2024-05-25 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849464#comment-17849464 ] Justine Olshan commented on KAFKA-16841: Reverting that commit seems to fix the

[PR] Revert "KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-25 Thread via GitHub
jolshan opened a new pull request, #16082: URL: https://github.com/apache/kafka/pull/16082 This change seems to have broken several ZKMigrationIntegrationTests. I have filed https://issues.apache.org/jira/browse/KAFKA-16841 but would like to fix our builds for now. ### Committer Chec

Re: [PR] KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-25 Thread via GitHub
jolshan commented on PR #16006: URL: https://github.com/apache/kafka/pull/16006#issuecomment-2131316535 https://github.com/apache/kafka/pull/16082 to revert. If folks can find a fix quickly that also works. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (KAFKA-16841) ZKMigrationIntegrationTests broken

2024-05-25 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849466#comment-17849466 ] Justine Olshan commented on KAFKA-16841: I opened [https://github.com/apache/kaf

Re: [PR] KAFKA-16625: Reverse lookup map from topic partitions to members [kafka]

2024-05-25 Thread via GitHub
dajac merged PR #15974: URL: https://github.com/apache/kafka/pull/15974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-16625) Reverse Lookup Partition to Member in Assignors

2024-05-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16625. - Fix Version/s: 3.8.0 Reviewer: David Jacot Resolution: Fixed > Reverse Lookup Pa

Re: [PR] KAFKA-16371; fix lingering pending commit when handling OFFSET_METADATA_TOO_LARGE [kafka]

2024-05-25 Thread via GitHub
dajac commented on code in PR #16072: URL: https://github.com/apache/kafka/pull/16072#discussion_r1614757426 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest { assertEquals(0, TestU

Re: [PR] KAFKA-16371; fix lingering pending commit when handling OFFSET_METADATA_TOO_LARGE [kafka]

2024-05-25 Thread via GitHub
jolshan commented on code in PR #16072: URL: https://github.com/apache/kafka/pull/16072#discussion_r1614757904 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest { assertEquals(0, Tes

Re: [PR] KAFKA-16371; fix lingering pending commit when handling OFFSET_METADATA_TOO_LARGE [kafka]

2024-05-25 Thread via GitHub
dajac commented on code in PR #16072: URL: https://github.com/apache/kafka/pull/16072#discussion_r1614757426 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -1664,6 +1664,134 @@ class GroupMetadataManagerTest { assertEquals(0, TestU

Re: [PR] [Don't merge]KAFKA-16812: The tools-related tests are slow [kafka]

2024-05-25 Thread via GitHub
TaiJuWu commented on PR #16030: URL: https://github.com/apache/kafka/pull/16030#issuecomment-2131385588 > @TaiJuWu As TopicCommandIntegrationTest is a large test, could you please try to file multiple PRs to move it to TopicCommandTest with new test infra and refactor (you described) ?

Re: [PR] KAFKA-15541: Use LongAdder instead of AtomicInteger [kafka]

2024-05-25 Thread via GitHub
mjsax merged PR #16076: URL: https://github.com/apache/kafka/pull/16076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] Revert "KAFKA-16515: Fix the ZK Metadata cache confusion between brokers and controllers [kafka]

2024-05-25 Thread via GitHub
jolshan commented on PR #16082: URL: https://github.com/apache/kafka/pull/16082#issuecomment-2131668386 No ZkMigrationIntegrationTest failures. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16252; Dynamic KRaft network manager and channel [kafka]

2024-05-25 Thread via GitHub
jsancio commented on code in PR #15986: URL: https://github.com/apache/kafka/pull/15986#discussion_r1610641974 ## core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala: ## @@ -1366,6 +1368,26 @@ class KafkaConfigTest { assertEquals(expectedVoters, addresses) } +

[jira] [Updated] (KAFKA-16824) Utils.getHost and Utils.getPort do not catch a lot of invalid host and ports

2024-05-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16824: --- Description: For example it is not able to detect at least these mal

Re: [PR] KAFKA-16252; Dynamic KRaft network manager and channel [kafka]

2024-05-25 Thread via GitHub
jsancio commented on code in PR #15986: URL: https://github.com/apache/kafka/pull/15986#discussion_r1614958193 ## raft/src/main/java/org/apache/kafka/raft/RequestManager.java: ## @@ -17,108 +17,196 @@ package org.apache.kafka.raft; import java.util.ArrayList; +import java.ut

[jira] [Created] (KAFKA-16842) Make sure to validate controller.quorum.bootstrap.server

2024-05-25 Thread Jira
José Armando García Sancio created KAFKA-16842: -- Summary: Make sure to validate controller.quorum.bootstrap.server Key: KAFKA-16842 URL: https://issues.apache.org/jira/browse/KAFKA-16842 P

[PR] KAFKA-15739: KRaft support in ResetConsumerGroupOffsetTest [kafka]

2024-05-25 Thread via GitHub
linzihao1999 opened a new pull request, #14686: URL: https://github.com/apache/kafka/pull/14686 The tests in ResetConsumerGroupOffsetTest in core/src/test/scala/unit/kafka/admin/ResetConsumerGroupOffsetTest.scala update to support KRaft. ### Committer Checklist (excluded from commit

Re: [PR] MINOR: Disable JDK 11 and 17 tests on PRs [kafka]

2024-05-25 Thread via GitHub
ijuma commented on PR #16051: URL: https://github.com/apache/kafka/pull/16051#issuecomment-2132080935 I'm ok going with something like this to start with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t