chia7712 commented on code in PR #15853:
URL: https://github.com/apache/kafka/pull/15853#discussion_r1589913151
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1703,7 +1704,9 @@ private boolean initWithCommittedOffsetsIfNeeded
florin-akermann commented on code in PR #14107:
URL: https://github.com/apache/kafka/pull/14107#discussion_r1589921037
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java:
##
@@ -109,108 +111,102 @@ public voi
florin-akermann closed pull request #15314: Window not honored? Why is X record
not dropped?
URL: https://github.com/apache/kafka/pull/15314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
florin-akermann commented on code in PR #14107:
URL: https://github.com/apache/kafka/pull/14107#discussion_r1589921037
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java:
##
@@ -109,108 +111,102 @@ public voi
showuon commented on code in PR #15817:
URL: https://github.com/apache/kafka/pull/15817#discussion_r1589925627
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1245,19 +1260,27 @@ public static boolean
isRemoteSegmentWithinLeaderEpochs(RemoteLogSegmentMetada
[
https://issues.apache.org/jira/browse/KAFKA-16174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843403#comment-17843403
]
Johnny Hsu commented on KAFKA-16174:
the exception is from
[https://github.com/apac
[
https://issues.apache.org/jira/browse/KAFKA-16174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843403#comment-17843403
]
Johnny Hsu edited comment on KAFKA-16174 at 5/4/24 8:21 AM:
florin-akermann commented on PR #15689:
URL: https://github.com/apache/kafka/pull/15689#issuecomment-2094077287
Thanks @AyoubOm & @mjsax
> I agree with @AyoubOm that both statements you intend to remove are still
correct?
Indeed, yes.
> It seems https://github.com/apache/k
AyoubOm commented on code in PR #15790:
URL: https://github.com/apache/kafka/pull/15790#discussion_r1589952122
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##
@@ -58,8 +60,14 @@ public void addChild(final ProcessorNode
child) {
publi
johnnychhsu opened a new pull request, #15858:
URL: https://github.com/apache/kafka/pull/15858
## Context
This check is always false, and in `ControllerServer` it cleanup itself if
exception happens. Thus, we don't need this check and cleanup here.
## Solution
Remove this check
AyoubOm commented on code in PR #15790:
URL: https://github.com/apache/kafka/pull/15790#discussion_r1589953917
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -173,21 +172,15 @@ protected Serde prepareValueSerdeForStore(final
S
[
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843421#comment-17843421
]
Johnny Hsu commented on KAFKA-14579:
currently only DumpLogSegments is using Decoder
gaurav-narula commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1589956639
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -389,9 +389,17 @@ class BrokerServer(
authorizer = config.createNewAuthorizer()
author
[
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843421#comment-17843421
]
Johnny Hsu edited comment on KAFKA-14579 at 5/4/24 10:36 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843421#comment-17843421
]
Johnny Hsu edited comment on KAFKA-14579 at 5/4/24 10:36 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843422#comment-17843422
]
Chia-Ping Tsai commented on KAFKA-14579:
{quote}
currently only DumpLogSegments
AndrewJSchofield commented on code in PR #15844:
URL: https://github.com/apache/kafka/pull/15844#discussion_r1589983081
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1145,14 +1141,42 @@ private CompletableFuture> addOffset
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1589995300
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,381 @@
package org.apache.kafka.tools.consumer.group;
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1589996273
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,381 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2094325675
@frankvicky Please avoid "force push". It can eliminate the conversions ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
David Arthur created KAFKA-16667:
Summary: KRaftMigrationDriver gets stuck after successive failovers
Key: KAFKA-16667
URL: https://issues.apache.org/jira/browse/KAFKA-16667
Project: Kafka
Is
[
https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur reassigned KAFKA-16667:
Assignee: David Arthur
> KRaftMigrationDriver gets stuck after successive failovers
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-16667:
-
Description:
This is a continuation of KAFKA-16171.
It turns out that the active KRaftMigration
Chia-Ping Tsai created KAFKA-16668:
--
Summary: Enable to set tags by `ClusterTest`
Key: KAFKA-16668
URL: https://issues.apache.org/jira/browse/KAFKA-16668
Project: Kafka
Issue Type: Improvem
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1590061307
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,381 @@
package org.apache.kafka.tools.consumer.group;
[
https://issues.apache.org/jira/browse/KAFKA-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843481#comment-17843481
]
Chia-Ping Tsai commented on KAFKA-16668:
Personally, introducing a new annotatio
[
https://issues.apache.org/jira/browse/KAFKA-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843482#comment-17843482
]
Johnny Hsu commented on KAFKA-16668:
hi [~chia7712]
may I know if you are working o
[
https://issues.apache.org/jira/browse/KAFKA-16668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16668:
--
Assignee: Johnny Hsu (was: Chia-Ping Tsai)
> Enable to set tags by `ClusterTest`
>
chia7712 commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1590078150
##
core/src/main/scala/kafka/server/FetchSession.scala:
##
@@ -690,6 +702,10 @@ class FetchSessionCache(private val maxEntries: Int,
* 2. B is considered "stale"
jsancio merged PR #15671:
URL: https://github.com/apache/kafka/pull/15671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-16624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez resolved KAFKA-16624.
-
Resolution: Fixed
> Don't generate useless PartitionChangeRecord on older MV
> -
jsancio opened a new pull request, #15859:
URL: https://github.com/apache/kafka/pull/15859
DRAFT
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
jsancio closed pull request #15781: KAFKA-16526; Add quorum state v1
URL: https://github.com/apache/kafka/pull/15781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
Owen-CH-Leung opened a new pull request, #15860:
URL: https://github.com/apache/kafka/pull/15860
As per [KAFKA-16617](https://issues.apache.org/jira/browse/KAFKA-16617),
this PR revised the documentation for `advertised.listeners` to include kraft
handler.
### Committer Checklist (e
[
https://issues.apache.org/jira/browse/KAFKA-16617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen C.H. Leung reassigned KAFKA-16617:
---
Assignee: Owen C.H. Leung
> Add KRaft info for the `advertised.listeners` doc descr
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1590198922
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,374 @@
package org.apache.kafka.tools.consumer.group;
github-actions[bot] commented on PR #14686:
URL: https://github.com/apache/kafka/pull/14686#issuecomment-2094567758
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
chia7712 merged PR #15858:
URL: https://github.com/apache/kafka/pull/15858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #13434:
URL: https://github.com/apache/kafka/pull/13434#discussion_r1590212654
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java:
##
@@ -141,24 +145,13 @@ private static String noClientId() {
prot
chia7712 commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2094642579
https://github.com/apache/kafka/blob/25118cec145b1a70a7b1709ca4a7ac367f066c6c/tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java#L433
@frankvicky
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1590215434
##
core/src/test/java/kafka/test/ClusterInstance.java:
##
@@ -145,4 +152,21 @@ default Admin createAdminClient() {
void startBroker(int brokerId);
void wai
chia7712 commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1590216139
##
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##
@@ -536,7 +537,7 @@ private static ArgumentParser argParser() {
.setDefault(
chia7712 commented on code in PR #15571:
URL: https://github.com/apache/kafka/pull/15571#discussion_r1590217930
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -1558,4 +1561,68 @@ public void testSSLEngineCloseInboundInvokedOnClose()
t
ocadaruma commented on code in PR #15571:
URL: https://github.com/apache/kafka/pull/15571#discussion_r1590220877
##
clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java:
##
@@ -1558,4 +1561,68 @@ public void testSSLEngineCloseInboundInvokedOnClose()
ocadaruma commented on PR #15571:
URL: https://github.com/apache/kafka/pull/15571#issuecomment-2094651947
@chia7712 Thank you for pointing out. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1590222768
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommand.java:
##
@@ -430,7 +430,7 @@ private void printStates(Map states) {
46 matches
Mail list logo
