[
https://issues.apache.org/jira/browse/KAFKA-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Pedersen updated KAFKA-16651:
--
Description:
In the JavaDoc for {{KafkaProducer#send(ProducerRecord, Callback)}}, it claims
t
Mike Pedersen created KAFKA-16651:
-
Summary: KafkaProducer.send does not throw TimeoutException as
documented
Key: KAFKA-16651
URL: https://issues.apache.org/jira/browse/KAFKA-16651
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Pedersen updated KAFKA-16651:
--
Description:
In the JavaDoc for {{{}KafkaProducer#send(ProducerRecord, Callback){}}}, it
clai
[
https://issues.apache.org/jira/browse/KAFKA-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842582#comment-17842582
]
Haruki Okada commented on KAFKA-16651:
--
Might be duplicated: https://issues.apache.
[
https://issues.apache.org/jira/browse/KAFKA-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842584#comment-17842584
]
Mike Pedersen commented on KAFKA-16651:
---
[~ocadaruma] Agreed, that seems like the
[
https://issues.apache.org/jira/browse/KAFKA-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Pedersen resolved KAFKA-16651.
---
Resolution: Duplicate
> KafkaProducer.send does not throw TimeoutException as documented
> -
[
https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842585#comment-17842585
]
Mike Pedersen commented on KAFKA-16372:
---
I just filed created (and closed) a dupe
chia7712 commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1586037686
##
core/src/main/scala/kafka/admin/AclCommand.scala:
##
@@ -115,8 +115,6 @@ object AclCommand extends Logging {
val aclBindings = acls.map(acl => new AclBin
Chia-Ping Tsai created KAFKA-16652:
--
Summary: add unit test for
Key: KAFKA-16652
URL: https://issues.apache.org/jira/browse/KAFKA-16652
Project: Kafka
Issue Type: Improvement
Re
[
https://issues.apache.org/jira/browse/KAFKA-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16652:
---
Summary: add unit test for ClusterTemplate offering zero ClusterConfig
(was: add unit test
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1586041747
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate clu
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1586042610
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -118,16 +118,15 @@ public Stream
provideTestTemplateInvocationContex
return generate
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1586043209
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
chia7712 merged PR #15773:
URL: https://github.com/apache/kafka/pull/15773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16588.
Fix Version/s: 3.8.0
Resolution: Fixed
> broker shutdown hangs when `log.segment.de
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842591#comment-17842591
]
Igor Soarez commented on KAFKA-16606:
-
[~scholzj], [~mimaison] – this isn't super s
clolov commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2088220267
The only comment is that we should update 1) the documentation in
docs/security.html#operations_resources_and_protocols to mention this change 2)
the release notes of 3.8 once they are cre
clolov commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2088220856
Heya @jolshan since you cast a vote on the KIP would you have some time to
review this pull request as well?
--
This is an automated message from the Apache Git Service.
To respond to th
clolov commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2088221738
I looked over the failures in the build, but the test failures appear to be
unrelated to this change
--
This is an automated message from the Apache Git Service.
To respond to the messag
OmniaGM commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586084377
##
core/src/main/scala/kafka/server/FetchSession.scala:
##
@@ -603,14 +619,16 @@ class FetchSessionCache(private val maxEntries: Int,
// A map containing sessions wh
OmniaGM commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586109183
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -389,9 +389,17 @@ class BrokerServer(
authorizer = config.createNewAuthorizer()
authorizer.f
nizhikov commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1586122285
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
sidyag commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2088272313
> The only comment is that we should update 1) the documentation in
docs/security.html#operations_resources_and_protocols to mention this change 2)
the release notes of 3.8 once they are c
OmniaGM commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586116968
##
core/src/main/scala/kafka/server/FetchSession.scala:
##
@@ -430,6 +439,9 @@ class FullFetchContext(private val time: Time,
}
cachedPartitions
}
+
OmniaGM commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586164282
##
core/src/main/scala/kafka/server/FetchSession.scala:
##
@@ -789,7 +807,15 @@ class FetchSessionCache(private val maxEntries: Int,
}
class FetchManager(private va
OmniaGM commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586165271
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -541,9 +541,17 @@ class KafkaServer(
}.toMap
}
-val fetchManager = new Fetc
OmniaGM commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586165970
##
core/src/test/scala/unit/kafka/server/FetchSessionTest.scala:
##
@@ -1932,6 +1932,26 @@ class FetchSessionTest {
}
assertEquals(partitions, partitionsInCon
nizhikov opened a new pull request, #15839:
URL: https://github.com/apache/kafka/pull/15839
This is thirt part of https://github.com/apache/kafka/pull/15417 refactoring.
PR intention - split big PR in parts to simplify review.
PR contains`ConfigCommandTest` rewritten in java
###
chia7712 commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1586258801
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
AyoubOm commented on PR #15607:
URL: https://github.com/apache/kafka/pull/15607#issuecomment-2088456658
> Can we update existing test to not use `Map` but `List` (as I mentioned on
the duplicate ticket https://issues.apache.org/jira/browse/KAFKA-16644) which
should expose the bug?
>
m1a2st opened a new pull request, #15840:
URL: https://github.com/apache/kafka/pull/15840
wip, add new KRAFT test for ConfigCommandIntegrationTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on code in PR #15833:
URL: https://github.com/apache/kafka/pull/15833#discussion_r1586301225
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -95,6 +89,9 @@ public BrokerNode build() {
if (id == -1) {
throw new RuntimeEx
chiacyu commented on PR #15827:
URL: https://github.com/apache/kafka/pull/15827#issuecomment-2088476161
Hi, @mannoopj ,
Thanks for the pr.
There is `clients:checkstyleMain FAILED` in the jenkins pipeline.
You can run `./gradlew clean build -x test` (linux) on your local machine to
d
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1586343459
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
mumrah commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1586349388
##
core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java:
##
@@ -106,6 +106,7 @@ public List getAdditionalExtensions() {
},
(Afte
gaurav-narula commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586362012
##
core/src/main/scala/kafka/server/FetchSession.scala:
##
@@ -603,14 +619,16 @@ class FetchSessionCache(private val maxEntries: Int,
// A map containing sessi
gaurav-narula commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586365674
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -389,9 +389,17 @@ class BrokerServer(
authorizer = config.createNewAuthorizer()
author
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1586367051
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
soarez commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586395026
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -389,9 +389,17 @@ class BrokerServer(
authorizer = config.createNewAuthorizer()
authorizer.fo
OmniaGM commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1586403158
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -389,9 +389,17 @@ class BrokerServer(
authorizer = config.createNewAuthorizer()
authorizer.f
dongnuo123 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1586420616
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void maybeUpdateSubscribedT
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15561:
--
Fix Version/s: 3.8.0
(was: 4.0.0)
> Client support for new SubscriptionPattern
[
https://issues.apache.org/jira/browse/KAFKA-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16272:
--
Priority: Major (was: Blocker)
> Update connect_distributed_test.py to support KIP-848’s group protoc
[
https://issues.apache.org/jira/browse/KAFKA-16272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16272:
--
Fix Version/s: 3.8.0
(was: 4.0.0)
> Update connect_distributed_test.py to suppo
TaiJuWu commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1586484285
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586489784
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -807,4 +809,62 @@ private static void writeSnapshotFooterRecord(
builder.
[
https://issues.apache.org/jira/browse/KAFKA-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TaiJuWu reassigned KAFKA-16652:
---
Assignee: TaiJuWu (was: Chia-Ping Tsai)
> add unit test for ClusterTemplate offering zero ClusterC
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842717#comment-17842717
]
Hector Geraldino commented on KAFKA-16223:
--
Thanks [~chia7712] [~cmukka20] for
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586499310
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software F
aliehsaeedii closed pull request #15731: KAFKA-15309: Add custom error handler
to Producer
URL: https://github.com/apache/kafka/pull/15731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
hgeraldino opened a new pull request, #15841:
URL: https://github.com/apache/kafka/pull/15841
This is the last remaining Kafka Connect test that needs migration from
PowerMock/EasyMock to Mockito.
Previous PR: https://github.com/apache/kafka/pull/15520
As usual, I Iook forward
johnnychhsu opened a new pull request, #15842:
URL: https://github.com/apache/kafka/pull/15842
Jira: https://issues.apache.org/jira/browse/KAFKA-16027
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586524076
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software F
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586526016
##
raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java:
##
@@ -261,7 +260,7 @@ default long truncateToEndOffset(OffsetAndEpoch endOffset) {
* @param snaps
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842724#comment-17842724
]
Chia-Ping Tsai commented on KAFKA-16223:
{quote}
I have another set of tests alr
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586537358
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software F
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586539952
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software F
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586542049
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1853,6 +1824,40 @@ private void subscribeInternal(Collection
topi
Alexander-Aghili commented on PR #15055:
URL: https://github.com/apache/kafka/pull/15055#issuecomment-2088813846
I have the correct file still saved on my new forced update but I can't link
it to this issue. I don't want to revert because I accidently pushed all the
commits from the past fe
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586553978
##
raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java:
##
@@ -0,0 +1,327 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842727#comment-17842727
]
Alexander Aghili commented on KAFKA-16027:
--
Hi [~johnnyhsu], I have added it th
chia7712 commented on PR #15055:
URL: https://github.com/apache/kafka/pull/15055#issuecomment-2088823785
> I have the correct file still saved on my new forced update but I can't
link it to this issue. I don't want to revert because I accidently pushed all
the commits from the past few mont
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586557142
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection
top
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586557142
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection
top
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586559943
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -273,9 +310,18 @@ void cleanup() {
log.error("Unexp
[
https://issues.apache.org/jira/browse/KAFKA-16022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842730#comment-17842730
]
Philip Nee commented on KAFKA-16022:
hi [~phuctran] - I believe this came up during
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1586590857
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -562,8 +709,13 @@ ConfigInfos validateConnectorConfig(
config
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1586591136
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -392,6 +399,146 @@ protected Map
validateSourceConnectorConfig(SourceConn
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1586591574
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -655,27 +811,38 @@ private static ConfigInfos validateClientOverrides(Stri
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586603709
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -273,9 +310,18 @@ void cleanup() {
log.error("Unexp
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586607598
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##
@@ -30,12 +29,7 @@ public abstract class CommitEvent extends
Completa
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586620323
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEvent.java:
##
@@ -16,9 +16,118 @@
*/
package org.apache.kafka.clients.consum
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586620323
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEvent.java:
##
@@ -16,9 +16,118 @@
*/
package org.apache.kafka.clients.consum
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586622390
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1273,6 +1228,22 @@ private void close(Duration timeout, boolean
s
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586626516
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -987,6 +987,7 @@ public void testResetUsingAutoResetPolicy(GroupProtocol
grou
kirktrue commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1586632167
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1169,8 +1129,7 @@ private Map
beginningOrEndOffset(Collection
of
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586731329
##
raft/src/main/java/org/apache/kafka/raft/internals/VoterSet.java:
##
@@ -0,0 +1,327 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842765#comment-17842765
]
Lianet Magrans commented on KAFKA-16514:
Just to answer the question above:
{quo
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586760874
##
raft/src/main/java/org/apache/kafka/snapshot/RecordsSnapshotWriter.java:
##
@@ -216,4 +140,132 @@ private void appendBatches(List>
batches) {
batches.f
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586765460
##
raft/src/test/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachineTest.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the Apache Software Foundation (
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586782977
##
raft/src/test/java/org/apache/kafka/raft/internals/VoterSetHistoryTest.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
kirktrue commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2089079055
> > > Here I have a comment, I could not put at the right location in the
code:
> > > On line 1362, in commitSync() the consumer waits on the commitFuture
with a timer. I think, it sh
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586802072
##
raft/src/main/java/org/apache/kafka/raft/internals/History.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586825107
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -181,20 +181,12 @@ class KafkaRaftManager[T](
private val clientDriver = new KafkaRaftClientDriver[T](clie
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586828276
##
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##
@@ -206,8 +151,16 @@ private static Integer parseVoterId(String idString) {
}
}
-p
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1586591019
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -655,27 +811,38 @@ private static ConfigInfos validateClientOverrides(Stri
junrao commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1586835182
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogOffsetMetadata.java:
##
@@ -28,6 +28,7 @@ public final class LogOffsetMetadata {
//TODO KAFKA-1
junrao commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1586840549
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark wit
[
https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842783#comment-17842783
]
Jun Rao commented on KAFKA-16541:
-
[~ocadaruma] : Will you be able to work on this soon?
cmccabe commented on code in PR #15838:
URL: https://github.com/apache/kafka/pull/15838#discussion_r1586843624
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -303,17 +303,17 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
cmccabe commented on code in PR #15838:
URL: https://github.com/apache/kafka/pull/15838#discussion_r1586844632
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -1541,6 +1541,36 @@ class KRaftClusterTest {
cluster.close()
}
}
+
+ @Test
cmccabe commented on PR #15838:
URL: https://github.com/apache/kafka/pull/15838#issuecomment-2089167707
> Thanks for the patch, @cmccabe. I looked for other usages of this lock and
see we're obtaining the write lock in DynamicBrokerConfig#updateBrokerConfig
which gets called from DynamicCon
junrao commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2089169862
@clolov: Are you able to address the remaining comments? 3.8.0 code freeze
is getting close. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the messag
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586860365
##
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java:
##
@@ -213,20 +213,21 @@ private void completeCurrentBatch() {
*
* @param value
cmccabe commented on PR #15810:
URL: https://github.com/apache/kafka/pull/15810#issuecomment-2089185449
> Should we have a new test for that specific case?
Good point. Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
cmccabe commented on code in PR #15810:
URL: https://github.com/apache/kafka/pull/15810#discussion_r1586861400
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -365,45 +369,62 @@ private void tryElection(PartitionChangeRecord record) {
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586861717
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -159,67 +165,76 @@ public class KafkaRaftClient implements RaftClient {
private final Memor
José Armando García Sancio created KAFKA-16653:
--
Summary: Remove delayed initialization because of static voter set
Key: KAFKA-16653
URL: https://issues.apache.org/jira/browse/KAFKA-16653
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586867970
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -370,8 +363,52 @@ private void maybeFireLeaderChange() {
}
}
-@Override
-
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1586869606
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -370,8 +363,52 @@ private void maybeFireLeaderChange() {
}
}
-@Override
-
1 - 100 of 142 matches
Mail list logo
