[jira] [Assigned] (KAFKA-16582) Feature Request: Introduce max.record.size Configuration Parameter for Producers

2024-04-22 Thread dujian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dujian reassigned KAFKA-16582: -- Assignee: dujian > Feature Request: Introduce max.record.size Configuration Parameter for > Producer

[jira] [Assigned] (KAFKA-16582) Feature Request: Introduce max.record.size Configuration Parameter for Producers

2024-04-22 Thread dujian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dujian reassigned KAFKA-16582: -- Assignee: (was: dujian) > Feature Request: Introduce max.record.size Configuration Parameter for

[jira] [Assigned] (KAFKA-16582) Feature Request: Introduce max.record.size Configuration Parameter for Producers

2024-04-22 Thread dujian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dujian reassigned KAFKA-16582: -- Assignee: dujian > Feature Request: Introduce max.record.size Configuration Parameter for > Producer

[PR] KAFKA-16559 allow defining number of disks per broker in TestKitNodes [kafka]

2024-04-22 Thread via GitHub
gaurav-narula opened a new pull request, #15776: URL: https://github.com/apache/kafka/pull/15776 Reviewers: Igor Soarez , Chia-Ping Tsai Cherry-picks #15730 to 3.7 branch. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

Re: [PR] KAFKA-16559 allow defining number of disks per broker in TestKitNodes [kafka]

2024-04-22 Thread via GitHub
gaurav-narula commented on PR #15776: URL: https://github.com/apache/kafka/pull/15776#issuecomment-2068864485 CC: @soarez @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Kafka 16082 cherry pick [kafka]

2024-04-22 Thread via GitHub
gaurav-narula opened a new pull request, #15777: URL: https://github.com/apache/kafka/pull/15777 Cherry picks #15136 to 3.7 branch. Depends on #15776 being cherry-picked first. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] V

Re: [PR] KAFKA-16082 Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-22 Thread via GitHub
gaurav-narula commented on PR #15777: URL: https://github.com/apache/kafka/pull/15777#issuecomment-2068874029 CC: @soarez @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-16568: JMH Benchmarks for Server Side Rebalances [kafka]

2024-04-22 Thread via GitHub
dajac commented on code in PR #15717: URL: https://github.com/apache/kafka/pull/15717#discussion_r1574417900 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java: ## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Minor: Fix CDS in docker image [kafka]

2024-04-22 Thread via GitHub
omkreddy merged PR #15771: URL: https://github.com/apache/kafka/pull/15771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-10551) Support topic IDs in Produce request

2024-04-22 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-10551: - Assignee: Omnia Ibrahim > Support topic IDs in Produce request > --

[jira] [Assigned] (KAFKA-16582) Feature Request: Introduce max.record.size Configuration Parameter for Producers

2024-04-22 Thread dujian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dujian reassigned KAFKA-16582: -- Assignee: (was: dujian) > Feature Request: Introduce max.record.size Configuration Parameter for

Re: [PR] KAFKA-16298: Ensure rebalance listener exceptions are propagated to the user on consumer poll [kafka]

2024-04-22 Thread via GitHub
cadonna commented on code in PR #15742: URL: https://github.com/apache/kafka/pull/15742#discussion_r1574508879 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1333,32 +1342,41 @@ public void testListenerCallbacksInvoke(Li

[jira] [Commented] (KAFKA-16567) Add New Stream Metrics based on KIP-869

2024-04-22 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839601#comment-17839601 ] Bruno Cadonna commented on KAFKA-16567: --- I think as long as we do not enable the s

[jira] [Updated] (KAFKA-6689) Kafka not release .deleted file.

2024-04-22 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez updated KAFKA-6689: Labels: (was: newbie) > Kafka not release .deleted file. > --

Re: [PR] Add s390x support to CI [kafka]

2024-04-22 Thread via GitHub
Prashant-Jagtap commented on PR #15644: URL: https://github.com/apache/kafka/pull/15644#issuecomment-2069055740 @mimaison Any update on this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-15736) KRaft support in PlaintextConsumerTest

2024-04-22 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839604#comment-17839604 ] Walter Hernandez commented on KAFKA-15736: -- KRaft support seems supported: [ht

[jira] [Resolved] (KAFKA-15736) KRaft support in PlaintextConsumerTest

2024-04-22 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez resolved KAFKA-15736. -- Resolution: Done > KRaft support in PlaintextConsumerTest > --

[jira] [Assigned] (KAFKA-15715) KRaft support in UpdateFeaturesTest

2024-04-22 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-15715: Assignee: Walter Hernandez > KRaft support in UpdateFeaturesTest > --

Re: [PR] KAFKA-16424: remove truncated logs after alter dir [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on code in PR #15616: URL: https://github.com/apache/kafka/pull/15616#discussion_r1574551794 ## core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala: ## @@ -37,6 +40,10 @@ class AlterReplicaLogDirsRequestTest extends BaseRequestTest

[jira] [Commented] (KAFKA-2111) Command Line Standardization - Add Help Arguments & List Required Fields

2024-04-22 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839609#comment-17839609 ] Walter Hernandez commented on KAFKA-2111: - *[mimaison|https://github.com/mimaison

[jira] [Assigned] (KAFKA-15156) Update cipherInformation correctly in DefaultChannelMetadataRegistry

2024-04-22 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-15156: Assignee: Walter Hernandez > Update cipherInformation correctly in DefaultChannel

[jira] [Assigned] (KAFKA-16336) Remove Deprecated metric standby-process-ratio

2024-04-22 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-16336: Assignee: (was: Walter Hernandez) > Remove Deprecated metric standby-process-

[jira] [Commented] (KAFKA-16514) Kafka Streams: stream.close(CloseOptions) does not respect options.leaveGroup flag.

2024-04-22 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839613#comment-17839613 ] Bruno Cadonna commented on KAFKA-16514: --- I might have missed this, but why can we

[jira] [Assigned] (KAFKA-16567) Add New Stream Metrics based on KIP-869

2024-04-22 Thread Walter Hernandez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Hernandez reassigned KAFKA-16567: Assignee: (was: Walter Hernandez) > Add New Stream Metrics based on KIP-869 >

Re: [PR] KAFKA-16298: Ensure rebalance listener exceptions are propagated to the user on consumer poll [kafka]

2024-04-22 Thread via GitHub
lucasbru commented on code in PR #15742: URL: https://github.com/apache/kafka/pull/15742#discussion_r1574580739 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1333,32 +1342,41 @@ public void testListenerCallbacksInvoke(L

Re: [PR] KAFKA-16298: Ensure rebalance listener exceptions are propagated to the user on consumer poll [kafka]

2024-04-22 Thread via GitHub
lucasbru commented on code in PR #15742: URL: https://github.com/apache/kafka/pull/15742#discussion_r1574581701 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -228,13 +228,16 @@ private void process(final ErrorEvent event) {

Re: [PR] Add s390x support to CI [kafka]

2024-04-22 Thread via GitHub
mimaison commented on PR #15644: URL: https://github.com/apache/kafka/pull/15644#issuecomment-2069139226 We're still having issues adding ppc64le (see https://github.com/apache/kafka/pull/13817, https://cwiki.apache.org/confluence/display/KAFKA/KIP-942%3A+Add+Power%28ppc64le%29+support).

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-22 Thread via GitHub
lucasbru merged PR #15613: URL: https://github.com/apache/kafka/pull/15613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-16596) Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()

2024-04-22 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-16596: --- Summary: Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup() Key: KAFKA-16596 URL: https://issues.apache.org/jira/browse/KAFKA-1

Re: [PR] MINOR: example.com moved [kafka]

2024-04-22 Thread via GitHub
viktorsomogyi commented on PR #15758: URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069166189 Ok, a couple of tests failed but none of them is ClientUtilsTest, so I'm merging this. Thank you @akatona84 for your contribution, @brandboat and @chia7712 for the reviews. -- Th

[jira] [Commented] (KAFKA-16504) Flaky test org.apache.kafka.controller.QuorumControllerTest.testConfigurationOperations

2024-04-22 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839620#comment-17839620 ] Igor Soarez commented on KAFKA-16504: - Another failed run, with the same failure ht

[jira] [Created] (KAFKA-16597) Flaky test - org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQuerySpecificStalePartitionStoresMultiStreamThreads()

2024-04-22 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-16597: --- Summary: Flaky test - org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQuerySpecificStalePartitionStoresMultiStreamThreads() Key: KAFKA-16597 URL: https://issues

[jira] [Commented] (KAFKA-16596) Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839623#comment-17839623 ] Chia-Ping Tsai commented on KAFKA-16596: this should be fixed by https://github.

[jira] [Commented] (KAFKA-16596) Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()

2024-04-22 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839624#comment-17839624 ] Viktor Somogyi-Vass commented on KAFKA-16596: - [~soarez] just merged the PR

Re: [PR] MINOR: example.com moved [kafka]

2024-04-22 Thread via GitHub
viktorsomogyi merged PR #15758: URL: https://github.com/apache/kafka/pull/15758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

[jira] [Resolved] (KAFKA-16596) Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()

2024-04-22 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass resolved KAFKA-16596. - Fix Version/s: 3.8.0 Assignee: Andras Katona Resolution: Fixed >

Re: [PR] KAFKA-16466: add details of an internal exception to the failure message [kafka]

2024-04-22 Thread via GitHub
soarez commented on code in PR #15701: URL: https://github.com/apache/kafka/pull/15701#discussion_r1574584174 ## metadata/src/main/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfo.java: ## @@ -191,6 +191,10 @@ public String failureMessage( }

[jira] [Commented] (KAFKA-16596) Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()

2024-04-22 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839632#comment-17839632 ] Igor Soarez commented on KAFKA-16596: - Thanks both! > Flaky test – > org.apache.ka

Re: [PR] MINOR: example.com moved [kafka]

2024-04-22 Thread via GitHub
viktorsomogyi commented on PR #15758: URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069206424 Yea, just had the same thought, will do in a couple of minutes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-22 Thread via GitHub
lianetm opened a new pull request, #15778: URL: https://github.com/apache/kafka/pull/15778 This fixes a consumer system test that was failing for the new protocol. The failure was because the test was expecting the eager behaviour of partitions being revoked on every rebalance, and it was w

[jira] [Updated] (KAFKA-16596) Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()

2024-04-22 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-16596: Fix Version/s: 3.7.1 > Flaky test – > org.apache.kafka.clients.ClientUtilsTest.te

Re: [PR] [DRAFT] KAFKA-16593: wip [kafka]

2024-04-22 Thread via GitHub
frankvicky commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1574626256 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,477 @@ package org.apache.kafka.tools.consumer.group;

[jira] [Commented] (KAFKA-8115) Flaky Test CoordinatorTest#testTaskRequestWithOldStartMsGetsUpdated

2024-04-22 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839621#comment-17839621 ] Igor Soarez commented on KAFKA-8115: Failed again: {code:java} java.util.concurrent.T

[jira] [Commented] (KAFKA-16596) Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()

2024-04-22 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839636#comment-17839636 ] Viktor Somogyi-Vass commented on KAFKA-16596: - Cherry-picked this onto 3.7 a

[jira] [Updated] (KAFKA-16596) Flaky test – org.apache.kafka.clients.ClientUtilsTest.testParseAndValidateAddressesWithReverseLookup()

2024-04-22 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-16596: Fix Version/s: 3.6.3 > Flaky test – > org.apache.kafka.clients.ClientUtilsTest.te

Re: [PR] MINOR: example.com moved [kafka]

2024-04-22 Thread via GitHub
omkreddy commented on PR #15758: URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069192637 Lets also cherry-pick to 3.7 and 3.6 branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-22 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1574660830 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long curren

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-22 Thread via GitHub
lianetm commented on PR #15778: URL: https://github.com/apache/kafka/pull/15778#issuecomment-2069255159 Hey @lucasbru , could you take a look when you have a chance? Similar issue to the one on https://github.com/apache/kafka/pull/15661. With this I get successful runs of the test (s

Re: [PR] KAFKA-15853: Move socket configs into org.apache.kafka.network.SocketServerConfigs [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15772: URL: https://github.com/apache/kafka/pull/15772#discussion_r1574671001 ## server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] MINOR: use assertInstanceOf to replace assertTrue [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15769: URL: https://github.com/apache/kafka/pull/15769#issuecomment-2069289874 @evalaiyc98 thanks for you contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-16549: suppress the warnings from RemoteLogManager [kafka]

2024-04-22 Thread via GitHub
chia7712 merged PR #15767: URL: https://github.com/apache/kafka/pull/15767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16549: suppress the warnings from RemoteLogManager [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15767: URL: https://github.com/apache/kafka/pull/15767#issuecomment-2069300587 @charliecheng630 thanks for ur contribution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] MINOR: use assertInstanceOf to replace assertTrue [kafka]

2024-04-22 Thread via GitHub
chia7712 merged PR #15769: URL: https://github.com/apache/kafka/pull/15769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-16549) suppress the warnings from RemoteLogManager

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16549. Fix Version/s: 3.8.0 Resolution: Fixed > suppress the warnings from RemoteLogManage

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-22 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1574708196 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long curren

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
mimaison commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574685410 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574731972 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574732048 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574733563 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
mimaison commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574744528 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Commented] (KAFKA-15850) Improve KafkaMetrics APIs to expose Value Provider information

2024-04-22 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839657#comment-17839657 ] Apoorv Mittal commented on KAFKA-15850: --- This has been completed as part of KIP-10

Re: [PR] KAFKA-16588: broker shutdown hangs when log.segment.delete.delay.ms is zero [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on PR #15773: URL: https://github.com/apache/kafka/pull/15773#issuecomment-2069404596 > I think the better solution (or a workaround) for it, should be that we set the `nextDeleteDelayMs = Math.max(1, fileDeleteDelayMs)` if if logsToBeDeleted is empty. So, if `fileDe

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574750038 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-16548: Change to use `streamingIterator` [kafka]

2024-04-22 Thread via GitHub
chia7712 merged PR #15765: URL: https://github.com/apache/kafka/pull/15765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16548: Change to use `streamingIterator` [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15765: URL: https://github.com/apache/kafka/pull/15765#issuecomment-2069414872 @m1a2st thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574769505 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] MINOR: Fix io-[wait-]ratio metrics description [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15722: URL: https://github.com/apache/kafka/pull/15722#issuecomment-2069514738 all failed tests pass on my local. merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] MINOR: Fix io-[wait-]ratio metrics description [kafka]

2024-04-22 Thread via GitHub
chia7712 merged PR #15722: URL: https://github.com/apache/kafka/pull/15722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Fix io-[wait-]ratio metrics description [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15722: URL: https://github.com/apache/kafka/pull/15722#issuecomment-2069517654 @emitskevich-blp Thanks for fixing the incorrect docs :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [DRAFT] KAFKA-16593: wip [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1574805564 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,494 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-16483: migrate DeleteOffsetsConsumerGroupCommandIntegrationTest to use ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15679: URL: https://github.com/apache/kafka/pull/15679#discussion_r1574810225 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -42,75 +53,98 @@ import static org.junit.jup

Re: [PR] KAFKA-16559 allow defining number of disks per broker in TestKitNodes [kafka]

2024-04-22 Thread via GitHub
soarez commented on PR #15776: URL: https://github.com/apache/kafka/pull/15776#issuecomment-2069583743 There is a large number of failed tests, but none of them are new -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-16572: allow defining number of disks per broker in ClusterTest [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15745: URL: https://github.com/apache/kafka/pull/15745#issuecomment-2069589870 @FrankYang0529 This PR will enhance our new test infra. However, @brandboat is working at refactoring the infra at the same time. It seems to me this PR should be blocked by #15761 in or

Re: [PR] KAFKA-16565: IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned [kafka]

2024-04-22 Thread via GitHub
kirktrue commented on code in PR #15737: URL: https://github.com/apache/kafka/pull/15737#discussion_r1574860975 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -140,22 +150,32 @@ class IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler): def __init__(

[jira] [Commented] (KAFKA-13459) MM2 should be able to add the source offset to the record header

2024-04-22 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839717#comment-17839717 ] Viktor Somogyi-Vass commented on KAFKA-13459: - [~durban] have you planned to

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-22 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2069725394 Hi @cadonna, thanks for the comments! - the unit test I added initially fails on [this](https://github.com/apache/kafka/blob/d242c444562fe4be41a2bc53d47ab2a6f523b955/clients/src/test/ja

[jira] [Commented] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839724#comment-17839724 ] PoAn Yang commented on KAFKA-16589: --- Hi [~chia7712], is this ticket try to `createAdmi

[jira] [Created] (KAFKA-16598) Mirgrate `ResetConsumerGroupOffsetTest` to new test infra

2024-04-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16598: -- Summary: Mirgrate `ResetConsumerGroupOffsetTest` to new test infra Key: KAFKA-16598 URL: https://issues.apache.org/jira/browse/KAFKA-16598 Project: Kafka

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-22 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1574897141 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -10331,6 +10333,461 @@ public void testClassicGroupOnUnlo

Re: [PR] KAFKA-16483: migrate DeleteOffsetsConsumerGroupCommandIntegrationTest to use ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
FrankYang0529 commented on PR #15679: URL: https://github.com/apache/kafka/pull/15679#issuecomment-2069788585 > @FrankYang0529 thanks for updated PR. two minor comments left. PTAL Hi @chia7712, I addressed last comments. Thanks for the review. -- This is an automated message from th

[jira] [Comment Edited] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839724#comment-17839724 ] PoAn Yang edited comment on KAFKA-16589 at 4/22/24 2:56 PM:

Re: [PR] MINOR: Add junit properties to display parameterized test names [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #14983: URL: https://github.com/apache/kafka/pull/14983#issuecomment-2069776278 When testing 3.7 branch for #15776, I encountered following error: ``` java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.InvalidTopicException: Topic n

[jira] [Commented] (KAFKA-16598) Mirgrate `ResetConsumerGroupOffsetTest` to new test infra

2024-04-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839730#comment-17839730 ] 黃竣陽 commented on KAFKA-16598: - I am able to handle this issue. > Mirgrate `ResetConsumerGro

[jira] [Commented] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839731#comment-17839731 ] Chia-Ping Tsai commented on KAFKA-16589: {quote}  is this ticket about removing

[jira] [Commented] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839733#comment-17839733 ] PoAn Yang commented on KAFKA-16589: --- Got it. I'm interested in the issue. May I take i

[jira] [Assigned] (KAFKA-16598) Mirgrate `ResetConsumerGroupOffsetTest` to new test infra

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16598: -- Assignee: 黃竣陽 (was: Chia-Ping Tsai) > Mirgrate `ResetConsumerGroupOffsetTest` to new

[jira] [Assigned] (KAFKA-16589) Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close

2024-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16589: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > Consider removing `ClusterInstance#creat

Re: [PR] KAFKA-15853: Move quota configs into server-common package [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15774: URL: https://github.com/apache/kafka/pull/15774#discussion_r1574929931 ## server-common/src/main/java/org/apache/kafka/server/config/ServerQuotaConfigs.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-04-22 Thread via GitHub
m1a2st opened a new pull request, #15779: URL: https://github.com/apache/kafka/pull/15779 change the ResetConsumerGroupOffsetTest first to new test framework -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-04-22 Thread via GitHub
m1a2st commented on PR #15779: URL: https://github.com/apache/kafka/pull/15779#issuecomment-2069841257 @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] KAFKA-16559 allow defining number of disks per broker in TestKitNodes [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on PR #15776: URL: https://github.com/apache/kafka/pull/15776#issuecomment-2069843217 @soarez Any concerns? The failed streams tests can get fixed by backporting #14983. Hence, I'd like to merge it :) -- This is an automated message from the Apache Git Service. To respo

[PR] MINOR: Reduce the time taken to execute the TieredStorage tests. [kafka]

2024-04-22 Thread via GitHub
kamalcph opened a new pull request, #15780: URL: https://github.com/apache/kafka/pull/15780 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[jira] [Commented] (KAFKA-15089) Consolidate all the group coordinator configs

2024-04-22 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839744#comment-17839744 ] Omnia Ibrahim commented on KAFKA-15089: --- I can have a look once I finish KAFKA-158

Re: [PR] KAFKA-15853: Move socket configs into org.apache.kafka.network.SocketServerConfigs [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15772: URL: https://github.com/apache/kafka/pull/15772#discussion_r1574952989 ## server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-15853: Move socket configs into org.apache.kafka.network.SocketServerConfigs [kafka]

2024-04-22 Thread via GitHub
OmniaGM commented on code in PR #15772: URL: https://github.com/apache/kafka/pull/15772#discussion_r1574953974 ## server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-16560: Refactor/cleanup BrokerNode/ControllerNode/ClusterConfig [kafka]

2024-04-22 Thread via GitHub
brandboat commented on code in PR #15761: URL: https://github.com/apache/kafka/pull/15761#discussion_r1574974316 ## core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala: ## @@ -18,41 +18,58 @@ package kafka.server import java.net.Socket import java.util.Col

Re: [PR] MINOR: Reduce the time taken to execute the TieredStorage tests. [kafka]

2024-04-22 Thread via GitHub
kamalcph commented on PR #15780: URL: https://github.com/apache/kafka/pull/15780#issuecomment-2069948134 This PR is a follow-up of #15719. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-16463 System test for reverting migration to ZK [kafka]

2024-04-22 Thread via GitHub
soarez commented on code in PR #15754: URL: https://github.com/apache/kafka/pull/15754#discussion_r1574994375 ## tests/kafkatest/tests/core/zookeeper_migration_test.py: ## @@ -86,10 +87,35 @@ def do_migration(self, roll_controller = False, downgrade_to_zk = False):

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-22 Thread via GitHub
chia7712 commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1575000110 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,448 @@ package org.apache.kafka.tools.consumer.group;

[jira] [Created] (KAFKA-16599) Always await async commit callbacks in commitSync and close

2024-04-22 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-16599: -- Summary: Always await async commit callbacks in commitSync and close Key: KAFKA-16599 URL: https://issues.apache.org/jira/browse/KAFKA-16599 Project: Kafka

  1   2   >