chiacyu commented on PR #15678:
URL: https://github.com/apache/kafka/pull/15678#issuecomment-2055793708
Thanks for the comments. Just applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1565280518
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ClientSideAssignorBenchmark.java:
##
@@ -0,0 +1,198 @@
+package org.apache.kafka.jmh.group_coordina
lucasbru commented on PR #15408:
URL: https://github.com/apache/kafka/pull/15408#issuecomment-2056028533
@cadonna could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 merged PR #15708:
URL: https://github.com/apache/kafka/pull/15708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #15613:
URL: https://github.com/apache/kafka/pull/15613#issuecomment-2056076747
@cadonna Could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lucasbru commented on PR #15613:
URL: https://github.com/apache/kafka/pull/15613#issuecomment-2056077615
@lianetm thanks for the comments, addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
chia7712 commented on PR #15708:
URL: https://github.com/apache/kafka/pull/15708#issuecomment-2056075855
> No need to rebase, you can just log into Jenkins with your Apache
credentials and rekick the build. I went to
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15708/2/ and cl
[
https://issues.apache.org/jira/browse/KAFKA-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16549:
---
Description:
{quote}
/home/chia7712/project/kafka/core/src/main/java/kafka/log/remote/Remote
Chia-Ping Tsai created KAFKA-16549:
--
Summary: suppress the warnings from RemoteLogManager
Key: KAFKA-16549
URL: https://issues.apache.org/jira/browse/KAFKA-16549
Project: Kafka
Issue Type: I
chia7712 merged PR #15716:
URL: https://github.com/apache/kafka/pull/15716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16490.
Fix Version/s: 3.8.0
Resolution: Fixed
> Upgrade gradle from 8.6 to 8.7
> -
[
https://issues.apache.org/jira/browse/KAFKA-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837123#comment-17837123
]
Chia Chuan Yu commented on KAFKA-16546:
---
Hi, [~chia7712]
Can I have this one? Pl
[
https://issues.apache.org/jira/browse/KAFKA-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16546:
--
Assignee: Chia Chuan Yu (was: Chia-Ping Tsai)
> add docs to explain how to update cl
Chia-Ping Tsai created KAFKA-16550:
--
Summary: add integration test for LogDirsCommand
Key: KAFKA-16550
URL: https://issues.apache.org/jira/browse/KAFKA-16550
Project: Kafka
Issue Type: Test
Chia-Ping Tsai created KAFKA-16551:
--
Summary: add integration test for ClusterTool
Key: KAFKA-16551
URL: https://issues.apache.org/jira/browse/KAFKA-16551
Project: Kafka
Issue Type: Test
chia7712 commented on code in PR #15714:
URL: https://github.com/apache/kafka/pull/15714#discussion_r1565426868
##
storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foun
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1565539750
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
Luke Chen created KAFKA-16552:
-
Summary: Create an internal config to control InitialTaskDelayMs
in LogManager to speed up tests
Key: KAFKA-16552
URL: https://issues.apache.org/jira/browse/KAFKA-16552
Pro
[
https://issues.apache.org/jira/browse/KAFKA-16552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837163#comment-17837163
]
Kuan Po Tseng commented on KAFKA-16552:
---
+1 on this !
> Create an internal config
[
https://issues.apache.org/jira/browse/KAFKA-16552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16552:
-
Assignee: Kuan Po Tseng (was: Luke Chen)
> Create an internal config to control InitialTaskDel
[
https://issues.apache.org/jira/browse/KAFKA-16552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837164#comment-17837164
]
Luke Chen commented on KAFKA-16552:
---
Thanks [~brandboat] !
> Create an internal confi
mimaison commented on PR #15711:
URL: https://github.com/apache/kafka/pull/15711#issuecomment-2056497697
None of the test failures are related, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1565569471
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File],
}
}
+ def recoverAbandonedFutureLogs(broke
chia7712 commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1565571409
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -81,8 +82,7 @@ public BrokerNode build(
logDataDirectories = Collections.
chia7712 commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1565572433
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File],
}
}
+ def recoverAbandonedFutureLogs(broke
[
https://issues.apache.org/jira/browse/KAFKA-15369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-15369.
Fix Version/s: 3.7.0
Assignee: Colin McCabe
Resolution: Fixed
> Allow Admi
[
https://issues.apache.org/jira/browse/KAFKA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reopened KAFKA-15230:
reopen to make it as duplicate
> ApiVersions data between controllers is not reliable
> -
[
https://issues.apache.org/jira/browse/KAFKA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-15230.
Fix Version/s: (was: 3.7.0)
Resolution: Duplicate
this is fixed by https://issu
mimaison merged PR #15711:
URL: https://github.com/apache/kafka/pull/15711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1565635052
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -40,7 +92,72 @@ public interface TierStateMachine {
*/
PartitionFetchState start(TopicPartiti
gaurav-narula commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1565638692
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File],
}
}
+ def recoverAbandonedFutureLogs(
dajac commented on code in PR #15536:
URL: https://github.com/apache/kafka/pull/15536#discussion_r1565639650
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##
@@ -1661,6 +1661,65 @@ class GroupMetadataManagerTest {
assertEquals(0, TestUt
Chia-Ping Tsai created KAFKA-16553:
--
Summary: log controller configs when startup
Key: KAFKA-16553
URL: https://issues.apache.org/jira/browse/KAFKA-16553
Project: Kafka
Issue Type: Improveme
mimaison commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1565718889
##
clients/src/main/java/org/apache/kafka/common/network/SslChannelBuilder.java:
##
@@ -60,7 +58,6 @@ public SslChannelBuilder(Mode mode,
this.mode = mode;
mimaison commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1565719621
##
clients/src/main/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPool.java:
##
@@ -37,13 +37,13 @@ public class GarbageCollectedMemoryPool extends
Simple
mimaison commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1565721043
##
clients/src/main/java/org/apache/kafka/common/utils/BufferSupplier.java:
##
@@ -79,12 +79,8 @@ public ByteBuffer get(int size) {
@Override
public
mimaison commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1565764251
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorStrategy.java:
##
@@ -136,8 +136,8 @@ private CoordinatorKey
requireSingletonAndType(Set
lianetm commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1565783934
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest
m
lianetm commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1565815246
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -482,6 +484,14 @@ public long nextHeartbeatMs(final long curren
lianetm commented on PR #15698:
URL: https://github.com/apache/kafka/pull/15698#issuecomment-2056883089
Hey @cadonna, thanks a lot for your feedback! All comments addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
soarez opened a new pull request, #15718:
URL: https://github.com/apache/kafka/pull/15718
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
lianetm commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1565783934
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest
m
soarez commented on code in PR #15718:
URL: https://github.com/apache/kafka/pull/15718#discussion_r1565822707
##
docs/ops.html:
##
@@ -2126,7 +2142,7 @@ https://github.com/apache/kafka/blob/3617dda9a5415ee1597967f754985fb73a5350c6/core/src/main/scala/kafka/controller/KafkaContro
mimaison commented on code in PR #15710:
URL: https://github.com/apache/kafka/pull/15710#discussion_r1565856071
##
server/src/main/java/org/apache/kafka/server/AssignmentsManager.java:
##
@@ -321,7 +321,7 @@ public void run() throws Exception {
AssignReplicasToD
dajac commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1565866968
##
group-coordinator/src/main/resources/common/message/ConsumerGroupMemberMetadataValue.json:
##
@@ -35,6 +35,20 @@
{ "name": "RebalanceTimeoutMs", "type": "int32",
johnnychhsu commented on PR #15713:
URL: https://github.com/apache/kafka/pull/15713#issuecomment-2056975870
thanks for the pr!
this looks good to me, leave a simple comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
C0urante commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-2056973237
Thanks Sagar, great catch! I suspected this would be a gnarly one to tackle
but it's turning out to be even harder than I thought.
I think there's still an issue with the current s
johnnychhsu commented on code in PR #15713:
URL: https://github.com/apache/kafka/pull/15713#discussion_r1565877195
##
streams/src/main/java/org/apache/kafka/streams/kstream/NamedOperation.java:
##
@@ -17,7 +17,7 @@
package org.apache.kafka.streams.kstream;
/**
- * Default in
soarez commented on code in PR #15704:
URL: https://github.com/apache/kafka/pull/15704#discussion_r1565856796
##
docker/generate_kafka_pr_template.sh:
##
@@ -0,0 +1,76 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
mimaison commented on code in PR #15710:
URL: https://github.com/apache/kafka/pull/15710#discussion_r1565897312
##
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java:
##
@@ -116,8 +116,7 @@ public synchronized boolean
maybeUpdatePushRequestTimestamp
johnnychhsu commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1565898495
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri
johnnychhsu commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2057103180
thanks for the PR!
just curious, what is the problem without the newly added state? does it
cause any issues?
--
This is an automated message from the Apache Git Service.
To res
johnnychhsu commented on PR #15643:
URL: https://github.com/apache/kafka/pull/15643#issuecomment-2057106113
thanks for the PR. this looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mimaison commented on code in PR #15697:
URL: https://github.com/apache/kafka/pull/15697#discussion_r1565973156
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -870,6 +875,7 @@ object KafkaConfig {
.define(CreateTopicPolicyClassNameProp, CLASS, null, LOW,
Cr
johnnychhsu commented on code in PR #15595:
URL: https://github.com/apache/kafka/pull/15595#discussion_r1565975540
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##
@@ -436,6 +436,7 @@ private void initialize
mimaison commented on PR #15709:
URL: https://github.com/apache/kafka/pull/15709#issuecomment-2057128107
None of the failures seem related, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
mimaison merged PR #15709:
URL: https://github.com/apache/kafka/pull/15709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
dajac commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1566001316
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -1046,4 +1051,101 @@ public void testIsInStatesCaseInsensitiv
[
https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-16474:
---
Attachment: failing_results.zip
> AsyncKafkaConsumer might send out heartbeat request without waitin
[
https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837342#comment-17837342
]
Philip Nee commented on KAFKA-16474:
The log was attached:
See line 7481 and 7492 i
brandboat opened a new pull request, #15719:
URL: https://github.com/apache/kafka/pull/15719
related to KAFKA-16552,
Introduce a new internal config `log.initial.task.delay.ms` to control
InitialTaskDelayMs in LogManager to speed up tests
### Committer Checklist (excluded from
chia7712 commented on code in PR #15575:
URL: https://github.com/apache/kafka/pull/15575#discussion_r1566098229
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1458,40 +1395,40 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
AyoubOm commented on code in PR #15619:
URL: https://github.com/apache/kafka/pull/15619#discussion_r1566096443
##
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##
@@ -613,6 +616,74 @@ public synchronized StreamsBuilder
addGlobalStore(final StoreBuilder<
OmniaGM commented on code in PR #15575:
URL: https://github.com/apache/kafka/pull/15575#discussion_r1566111409
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1458,40 +1395,40 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
d
OmniaGM commented on code in PR #15575:
URL: https://github.com/apache/kafka/pull/15575#discussion_r1566114227
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1458,40 +1395,40 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
d
chia7712 commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1566129710
##
server/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
johnnychhsu opened a new pull request, #15720:
URL: https://github.com/apache/kafka/pull/15720
## Context
Add unit test for TopicImageNodeTest
Jira ticket: https://issues.apache.org/jira/browse/KAFKA-16475
## Test
### Committer Checklist (excluded from commit message)
-
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1566156280
##
server/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1566156280
##
server/src/main/java/org/apache/kafka/server/config/KafkaLogConfigs.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837366#comment-17837366
]
Johnny Hsu commented on KAFKA-13105:
hi [~cmccabe] I would like to work on this if n
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-2057408474
Hi @gharris1727 sorry for the delay. I've resolved the merge conflicts; let
me know what you think if you have a moment.
--
This is an automated message from the Apache Git Service.
To
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566199529
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java:
##
@@ -0,0 +1,153 @@
+package org.apache.kafka.jmh.group_c
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566200808
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java:
##
@@ -0,0 +1,153 @@
+package org.apache.kafka.jmh.group_c
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566203863
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package org.apache.kafka.jmh.group_coor
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2057454239
> thanks for the PR! just curious, what is the problem without the newly
added state? does it cause any issues?
@johnnychhsu
When a kafka consumer encounters a FENCED_LEADER_
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566204495
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package org.apache.kafka.jmh.group_coor
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566211207
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ClientSideAssignorBenchmark.java:
##
@@ -0,0 +1,198 @@
+package org.apache.kafka.jmh.group_coor
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566211483
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ClientSideAssignorBenchmark.java:
##
@@ -0,0 +1,198 @@
+package org.apache.kafka.jmh.group_coor
Dongnuo Lyu created KAFKA-16554:
---
Summary: Online downgrade triggering and group type conversion
Key: KAFKA-16554
URL: https://issues.apache.org/jira/browse/KAFKA-16554
Project: Kafka
Issue Typ
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566219575
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package org.apache.kafka.jmh.group_coor
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566224264
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java:
##
@@ -0,0 +1,153 @@
+package org.apache.kafka.jmh.group_c
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566233067
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package org.apache.kafka.jmh.group_coor
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566234265
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package org.apache.kafka.jmh.group_coor
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566237268
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package org.apache.kafka.jmh.group_coor
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1566238375
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/TargetAssignmentBuilderBenchmark.java:
##
@@ -0,0 +1,259 @@
+package org.apache.kafka.jmh.group
CalvinConfluent commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {
dongnuo123 opened a new pull request, #15721:
URL: https://github.com/apache/kafka/pull/15721
Online downgrade from a consumer group to a classic group is triggered when
the last consumer that uses the consumer protocol leaves the group. A rebalance
is manually triggered after the group con
Kirk True created KAFKA-16555:
-
Summary: Consumer's RequestState has incorrect logic to determine
if inflight
Key: KAFKA-16555
URL: https://issues.apache.org/jira/browse/KAFKA-16555
Project: Kafka
Kirk True created KAFKA-16556:
-
Summary: Race condition between ConsumerRebalanceListener and
SubscriptionState
Key: KAFKA-16556
URL: https://issues.apache.org/jira/browse/KAFKA-16556
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16556:
-
Assignee: Kirk True
> Race condition between ConsumerRebalanceListener and SubscriptionState
>
[
https://issues.apache.org/jira/browse/KAFKA-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16556:
--
Description:
There appears to be a race condition between invoking the
{{ConsumerRebalanceListener}}
CalvinConfluent commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1566242343
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {
Kirk True created KAFKA-16557:
-
Summary: Fix CommitRequestManager’s
OffsetFetchRequestState.toString()
Key: KAFKA-16557
URL: https://issues.apache.org/jira/browse/KAFKA-16557
Project: Kafka
Issu
[
https://issues.apache.org/jira/browse/KAFKA-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16557:
--
Summary: Fix OffsetFetchRequestState.toString() (was: Fix
CommitRequestManager’s OffsetFetchRequestSt
[
https://issues.apache.org/jira/browse/KAFKA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16558:
--
Description: The inner class {{HeartbeatRequestState}} does not override
the {{toStringBase()}} method
Kirk True created KAFKA-16558:
-
Summary: Implement HeartbeatRequestState.toStringBase()
Key: KAFKA-16558
URL: https://issues.apache.org/jira/browse/KAFKA-16558
Project: Kafka
Issue Type: Bug
emitskevich-blp opened a new pull request, #15722:
URL: https://github.com/apache/kafka/pull/15722
[Implementation of KIP-773](https://github.com/apache/kafka/pull/11302)
deprecated `iotime-total` and `io-waittime-total` metrics. It wasn't expected
to mark `io-ratio` and `io-wait-ratio` de
AyoubOm commented on code in PR #15713:
URL: https://github.com/apache/kafka/pull/15713#discussion_r1566436979
##
streams/src/main/java/org/apache/kafka/streams/kstream/NamedOperation.java:
##
@@ -17,7 +17,7 @@
package org.apache.kafka.streams.kstream;
/**
- * Default interf
[
https://issues.apache.org/jira/browse/KAFKA-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16556:
--
Summary: Race condition between ConsumerRebalanceListener and
SubscriptionState causes commit offsets
CalvinConfluent commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1566455070
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {
1 - 100 of 125 matches
Mail list logo
