KrishVora01 closed pull request #15703: KAFKA-16373: Adding Apache Kafka Docker
Official Images Directory
URL: https://github.com/apache/kafka/pull/15703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
KrishVora01 opened a new pull request, #15704:
URL: https://github.com/apache/kafka/pull/15704
This PR adds code to support Apache Kafka Docker Official Images.
The files added include:
1. .github/workflows/prepare_docker_official_image_source.yml This adds
github actions workflow to c
[
https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836444#comment-17836444
]
Kamal Chandraprakash commented on KAFKA-16511:
--
The segment deletion might
[
https://issues.apache.org/jira/browse/KAFKA-13636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836455#comment-17836455
]
zhangzhisheng commented on KAFKA-13636:
---
Kafka broker version is 2.7.2
Client vers
[
https://issues.apache.org/jira/browse/KAFKA-16522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Quoc Phong Dang reassigned KAFKA-16522:
---
Assignee: Quoc Phong Dang
> Admin client changes for adding and removing voters
> -
showuon commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1562184559
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri
[
https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836472#comment-17836472
]
Francois Visconte commented on KAFKA-16511:
---
I ran kafka-delete-records.sh and
[
https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836472#comment-17836472
]
Francois Visconte edited comment on KAFKA-16511 at 4/12/24 8:24 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836501#comment-17836501
]
Luke Chen commented on KAFKA-16510:
---
[~hiroa] , I'd like to confirm that only `kafka-m
[
https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836503#comment-17836503
]
Walter Hernandez commented on KAFKA-2499:
-
This indeed duplicates the referenced
[ https://issues.apache.org/jira/browse/KAFKA-2499 ]
Walter Hernandez deleted comment on KAFKA-2499:
-
was (Author: JIRAUSER305029):
This indeed duplicates the referenced earlier ticket, where there is a patch
available.
However, this patch
[
https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez updated KAFKA-2499:
Issue Type: Improvement (was: Bug)
> kafka-producer-perf-test should use something more re
[
https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-2499:
---
Assignee: Walter Hernandez
> kafka-producer-perf-test should use something more real
[
https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836506#comment-17836506
]
Walter Hernandez commented on KAFKA-2499:
-
This is indeed duplicated by the refer
[
https://issues.apache.org/jira/browse/KAFKA-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836506#comment-17836506
]
Walter Hernandez edited comment on KAFKA-2499 at 4/12/24 8:45 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hiro updated KAFKA-16510:
-
Affects Version/s: 3.7.0
(was: 3.4.1)
> java.lang.OutOfMemoryError in kafka-metadata-
[
https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836517#comment-17836517
]
Hiro commented on KAFKA-16510:
--
[~showuon]
No, the problem occurred with all scripts.
When
showuon commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1562284319
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1176,6 +1176,42 @@ class LogManager(logDirs: Seq[File],
}
}
+ def recoverAbandonedFutureLogs(broker
VedarthConfluent commented on code in PR #15704:
URL: https://github.com/apache/kafka/pull/15704#discussion_r1562289692
##
docker/generate_kafka_pr_template.sh:
##
@@ -0,0 +1,61 @@
+#!/usr/bin/env bash
Review Comment:
Add license string at the beginning of all new files
-
showuon commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1562307197
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1173,6 +1173,35 @@ class LogManager(logDirs: Seq[File],
}
}
+ def recoverAbandonedFutureLogs(broker
[
https://issues.apache.org/jira/browse/KAFKA-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836529#comment-17836529
]
Luke Chen commented on KAFKA-16510:
---
OK, I see. If it's the issue of incorrectly SASL_
showuon commented on PR #14778:
URL: https://github.com/apache/kafka/pull/14778#issuecomment-2051465918
Correction: For this:
> some users might feel surprised when their fetch doesn't respond in
fetch.max.wait.ms time.
This is wrong. Even if the remote reading is not completed, ye
mimaison opened a new pull request, #15705:
URL: https://github.com/apache/kafka/pull/15705
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
cadonna commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1562500382
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -269,6 +269,9 @@ private NetworkClientDelegate.UnsentRequest
m
chiacyu commented on code in PR #15678:
URL: https://github.com/apache/kafka/pull/15678#discussion_r1562574967
##
server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:
##
@@ -172,10 +172,11 @@ public void testAssignmentAggregation() throws
InterruptedExcepti
hudeqi created KAFKA-16543:
--
Summary: There may be ambiguous deletions in the
`cleanupGroupMetadata` when the generation of the group is less than or equal
to 0
Key: KAFKA-16543
URL: https://issues.apache.org/jira/brows
[
https://issues.apache.org/jira/browse/KAFKA-16543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hudeqi updated KAFKA-16543:
---
Description:
In the `cleanupGroupMetadata` method, tombstone messages is written to delete
the group's Meta
hudeqi opened a new pull request, #15706:
URL: https://github.com/apache/kafka/pull/15706
In the `cleanupGroupMetadata` method, tombstone messages is written to
delete the group's MetadataKey only when the group is in the Dead state and the
generation is greater than 0. The comment indicate
dajac commented on PR #15706:
URL: https://github.com/apache/kafka/pull/15706#issuecomment-2051869550
Hi @hudeqi. Thanks for the patch. I would like to better understand it. My
first question is how would Flink commit Flink with a generationId equal to -1?
The generation of the group is onl
alok123t opened a new pull request, #15707:
URL: https://github.com/apache/kafka/pull/15707
Previously, we were comparing uuid by reference, which could be incorrect.
This PR replaces to do the comparison by value instead
### Committer Checklist (excluded from commit message)
- [ ]
dajac commented on PR #15536:
URL: https://github.com/apache/kafka/pull/15536#issuecomment-2051891235
Sorry for the delay on this one. I will review it next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
soarez commented on code in PR #15697:
URL: https://github.com/apache/kafka/pull/15697#discussion_r1562612304
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -507,6 +522,7 @@ class BrokerLifecycleManager(
if (errorCode == Errors.NONE) {
[
https://issues.apache.org/jira/browse/KAFKA-15359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reassigned KAFKA-15359:
---
Assignee: (was: Igor Soarez)
> Support log.dir.failure.timeout.ms configuration for JBO
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836644#comment-17836644
]
Sal Sorrentino commented on KAFKA-16514:
Digging further into this, it seems the
mimaison opened a new pull request, #15708:
URL: https://github.com/apache/kafka/pull/15708
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
mimaison opened a new pull request, #15709:
URL: https://github.com/apache/kafka/pull/15709
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
mimaison opened a new pull request, #15710:
URL: https://github.com/apache/kafka/pull/15710
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
mimaison opened a new pull request, #15711:
URL: https://github.com/apache/kafka/pull/15711
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
CalvinConfluent commented on PR #15702:
URL: https://github.com/apache/kafka/pull/15702#issuecomment-2052041676
@mumrah Can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mimaison opened a new pull request, #15712:
URL: https://github.com/apache/kafka/pull/15712
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836671#comment-17836671
]
Matthias J. Sax commented on KAFKA-16514:
-
CloseOption was introduced via
[http
chia7712 merged PR #15670:
URL: https://github.com/apache/kafka/pull/15670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AyoubOm opened a new pull request, #15713:
URL: https://github.com/apache/kafka/pull/15713
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
kirktrue commented on PR #15408:
URL: https://github.com/apache/kafka/pull/15408#issuecomment-2052100630
@lucasbru—I think it's worth adding the tests, even if we already know there
are more to be added in the future.
--
This is an automated message from the Apache Git Service.
To respond
chia7712 commented on code in PR #15710:
URL: https://github.com/apache/kafka/pull/15710#discussion_r1562828732
##
server-common/src/test/java/org/apache/kafka/timeline/SnapshotRegistryTest.java:
##
@@ -41,9 +42,7 @@ public void testEmptyRegistry() {
private static void ass
cmccabe merged PR #15648:
URL: https://github.com/apache/kafka/pull/15648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
chia7712 commented on PR #15707:
URL: https://github.com/apache/kafka/pull/15707#issuecomment-2052183089
the following links have similar issue. Should we fix them in this PR or I
file a follow-up to fix them?
https://github.com/apache/kafka/blob/61baa7ac6bb871797197d9289a848a0d4f587
junrao commented on code in PR #14242:
URL: https://github.com/apache/kafka/pull/14242#discussion_r1562928115
##
server-common/src/main/java/org/apache/kafka/server/common/CheckpointFile.java:
##
@@ -72,18 +72,20 @@ public CheckpointFile(File file,
tempPath = Paths.get(
[
https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-16541:
Affects Version/s: 3.7.0
> Potential leader epoch checkpoint file corruption on OS crash
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836717#comment-17836717
]
Jun Rao commented on KAFKA-16541:
-
Thanks for filing the jira, [~ocadaruma] ! Since thi
[
https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836717#comment-17836717
]
Jun Rao edited comment on KAFKA-16541 at 4/12/24 5:43 PM:
--
Than
junrao commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2052208460
@kamalcph : Thanks for the update. JDK 11 and Scala 2.13 didn't complete in
the last test run. Could you trigger another run of the tests?
--
This is an automated message from the Apache
chia7712 commented on code in PR #15705:
URL: https://github.com/apache/kafka/pull/15705#discussion_r1562938471
##
clients/src/main/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPool.java:
##
@@ -37,13 +37,13 @@ public class GarbageCollectedMemoryPool extends
Simple
Chia-Ping Tsai created KAFKA-16544:
--
Summary: DescribeTopicsResult#allTopicIds and
DescribeTopicsResult#allTopicNames should return null instead of throwing NPE
Key: KAFKA-16544
URL: https://issues.apache.org/jir
[
https://issues.apache.org/jira/browse/KAFKA-16544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16544:
--
Assignee: Chia-Ping Tsai
> DescribeTopicsResult#allTopicIds and DescribeTopicsResult#
Chia-Ping Tsai created KAFKA-16545:
--
Summary: Auto adjust the replica factor according to number of
broker when using ClusterTestExtensions
Key: KAFKA-16545
URL: https://issues.apache.org/jira/browse/KAFKA-16545
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836736#comment-17836736
]
A. Sophie Blee-Goldman commented on KAFKA-16514:
I haven't gone back and
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1563193794
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {
l
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1563195256
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -423,6 +441,17 @@ public void replay(ConfigRecord record) {
l
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1563199330
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {
void ha
junrao commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1562991673
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark wit
alok123t commented on PR #15707:
URL: https://github.com/apache/kafka/pull/15707#issuecomment-2052600875
@jolshan @chia7712 randomly looking at the code base, i think this is
prevalent in multiple places. Shall I update them all in this PR and also
create a ticket?
--
This is an automate
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836750#comment-17836750
]
Sal Sorrentino commented on KAFKA-16514:
The KIP mentions nothing about static m
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836750#comment-17836750
]
Sal Sorrentino edited comment on KAFKA-16514 at 4/12/24 10:03 PM:
alok123t commented on PR #15707:
URL: https://github.com/apache/kafka/pull/15707#issuecomment-2052621773
i did smth similar to https://stackoverflow.com/a/73535824 to find all
usages in the codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836750#comment-17836750
]
Sal Sorrentino edited comment on KAFKA-16514 at 4/12/24 10:06 PM:
chia7712 commented on code in PR #15707:
URL: https://github.com/apache/kafka/pull/15707#discussion_r1563600417
##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -270,7 +270,7 @@ class DefaultAlterPartitionManager(
inflightAlterPartitionItems.groupBy(
chia7712 commented on code in PR #15489:
URL: https://github.com/apache/kafka/pull/15489#discussion_r1562683822
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -391,4 +428,30 @@ private String[] addBootstrapServer(String... args) {
return
chia7712 commented on PR #15654:
URL: https://github.com/apache/kafka/pull/15654#issuecomment-2053016969
close as we do see the root cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
chia7712 closed pull request #15654: debug for #15489
URL: https://github.com/apache/kafka/pull/15654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: ji
[
https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836762#comment-17836762
]
Kamal Chandraprakash commented on KAFKA-16511:
--
[~fvisconte]
The issue mig
[
https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash updated KAFKA-16511:
-
Description:
I have some topics there were not written since a few days (having
alok123t commented on code in PR #15707:
URL: https://github.com/apache/kafka/pull/15707#discussion_r1563676834
##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -270,7 +270,7 @@ class DefaultAlterPartitionManager(
inflightAlterPartitionItems.groupBy(
73 matches
Mail list logo
