Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

2024-01-19 Thread via GitHub
dajac commented on code in PR #15221: URL: https://github.com/apache/kafka/pull/15221#discussion_r1458553635 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -856,7 +899,8 @@ public boolean cleanupExpiredOffsets(String group

Re: [PR] KAFKA-14505; [8/8] Update offset delete paths [kafka]

2024-01-19 Thread via GitHub
dajac commented on PR #15221: URL: https://github.com/apache/kafka/pull/15221#issuecomment-1899953142 @jeffkbkim @dongnuo123 Thanks for your comments. I addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-19 Thread via GitHub
dajac commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1458564906 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1098,30 +1054,36 @@ private static boolean isGroupIdNotEmpty(St

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-19 Thread via GitHub
dajac commented on PR #15196: URL: https://github.com/apache/kafka/pull/15196#issuecomment-1899964532 @jeffkbkim @dongnuo123 Thanks for your comments. I have addressed all of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-19 Thread via GitHub
dajac commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1458570521 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] MINOR: populate TopicName in ConsumerGroupDescribe [kafka]

2024-01-19 Thread via GitHub
dajac commented on code in PR #15205: URL: https://github.com/apache/kafka/pull/15205#discussion_r1458581509 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -571,15 +577,29 @@ public ConsumerGroupDescribeResponseData

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-01-19 Thread via GitHub
kamalcph commented on code in PR #15213: URL: https://github.com/apache/kafka/pull/15213#discussion_r1458560112 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp ==

[jira] [Updated] (KAFKA-16144) Controller leader checkQuorum timer should skip only 1 controller case

2024-01-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-16144: --- Fix Version/s: 3.7.0 > Controller leader checkQuorum timer should skip only 1 controller cas

Re: [PR] KAFKA-14277: Add event queue size method [kafka]

2024-01-19 Thread via GitHub
danielgospodinow closed pull request #12712: KAFKA-14277: Add event queue size method URL: https://github.com/apache/kafka/pull/12712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Updated] (KAFKA-16144) Controller leader checkQuorum timer should skip only 1 controller case

2024-01-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-16144: --- Priority: Blocker (was: Major) > Controller leader checkQuorum timer should skip only 1 con

[jira] [Commented] (KAFKA-16144) Controller leader checkQuorum timer should skip only 1 controller case

2024-01-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808548#comment-17808548 ] Mickael Maison commented on KAFKA-16144: Marking this as a blocker as it's a reg

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-01-19 Thread via GitHub
kamalcph commented on code in PR #15213: URL: https://github.com/apache/kafka/pull/15213#discussion_r1458606590 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1300,18 +1303,27 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp ==

[jira] [Comment Edited] (KAFKA-16144) Controller leader checkQuorum timer should skip only 1 controller case

2024-01-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808548#comment-17808548 ] Mickael Maison edited comment on KAFKA-16144 at 1/19/24 9:11 AM: -

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
ppatierno commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1458520337 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the c

Re: [PR] KAFKA-16104: Enable additional PlaintextConsumerTest tests for new consumer [kafka]

2024-01-19 Thread via GitHub
lucasbru merged PR #15206: URL: https://github.com/apache/kafka/pull/15206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-19 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1458663082 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -452,21 +453,39 @@ public Group group(String groupId, long committe

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
dajac commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1458665622 ## clients/src/main/java/org/apache/kafka/clients/admin/ConsumerGroupListing.java: ## @@ -21,95 +21,111 @@ import java.util.Optional; Review Comment: We would need t

[jira] [Commented] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-01-19 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808578#comment-17808578 ] Luke Chen commented on KAFKA-16162: --- Thanks [~pprovenzano], I agree we also need to ha

[jira] [Created] (KAFKA-16168) Implement GroupCoordinator.onPartitionsDeleted

2024-01-19 Thread David Jacot (Jira)
David Jacot created KAFKA-16168: --- Summary: Implement GroupCoordinator.onPartitionsDeleted Key: KAFKA-16168 URL: https://issues.apache.org/jira/browse/KAFKA-16168 Project: Kafka Issue Type: Sub-

[jira] [Assigned] (KAFKA-16111) Implement tests for tricky rebalance callback scenarios

2024-01-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-16111: -- Assignee: (was: Lucas Brutschy) > Implement tests for tricky rebalance callback s

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
mimaison commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1458684850 ## checkstyle/import-control-core.xml: ## @@ -82,6 +82,7 @@ + Review Comment: Do we really need this change? core seems to build fine without

Re: [PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-19 Thread via GitHub
stanislavkozlovski commented on code in PR #15186: URL: https://github.com/apache/kafka/pull/15186#discussion_r1458752762 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -376,25 +376,21 @@ protected Map prepareCloseFetchSessi

Re: [PR] KAFKA-15610: Fix `CoreUtils.swallow()` test gaps [kafka]

2024-01-19 Thread via GitHub
divijvaidya commented on PR #14583: URL: https://github.com/apache/kafka/pull/14583#issuecomment-1900157802 @atu-sharm would you like to continue on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Assigned] (KAFKA-16148) Implement GroupMetadataManager#onUnloaded

2024-01-19 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-16148: --- Assignee: Jeff Kim > Implement GroupMetadataManager#onUnloaded > --

Re: [PR] KAFKA-15942: Implement ConsumerInterceptor [kafka]

2024-01-19 Thread via GitHub
Joker-5 commented on PR #14963: URL: https://github.com/apache/kafka/pull/14963#issuecomment-1900231164 > @Joker-5 I can add it in the PR description so that I don't forget. But the tag needs to added to the final commit, once we merge it, so we cannot really add it yet Got it, many

Re: [PR] KAFKA-16085: Add metric value consolidated for topics on a broker for tiered storage. [kafka]

2024-01-19 Thread via GitHub
divijvaidya commented on code in PR #15133: URL: https://github.com/apache/kafka/pull/15133#discussion_r1458819718 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -529,20 +564,33 @@ class BrokerTopicMetrics(name: Option[String], configOpt: java.util.Optiona

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-19 Thread via GitHub
cadonna commented on code in PR #15000: URL: https://github.com/apache/kafka/pull/15000#discussion_r1458727101 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetCommitCallbackInvoker.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] KAFKA-16113: Add committed and commit sensor to record metrics [kafka]

2024-01-19 Thread via GitHub
lucasbru merged PR #15210: URL: https://github.com/apache/kafka/pull/15210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16085: Add metric value consolidated for topics on a broker for tiered storage. [kafka]

2024-01-19 Thread via GitHub
showuon commented on PR #15133: URL: https://github.com/apache/kafka/pull/15133#issuecomment-1900326555 > Most are optional comments but the blocking comments before we merge are the once related to removal of metrics when topic is deleted. I would assume that removal needs to occur from ne

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-01-19 Thread via GitHub
VictorvandenHoven commented on PR #14426: URL: https://github.com/apache/kafka/pull/14426#issuecomment-1900331266 > @mjsax , @guozhangwang , can we merge this? How long does it normally take to get a reaction? -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] KAFKA-16107: Stop fetching while onPartitionsAssign completes [kafka]

2024-01-19 Thread via GitHub
dajac commented on code in PR #15215: URL: https://github.com/apache/kafka/pull/15215#discussion_r1458965028 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1134,9 +1134,22 @@ private CompletableFuture assignPartitions(

[jira] [Commented] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-01-19 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808653#comment-17808653 ] Francois Visconte commented on KAFKA-15776: --- [~ckamal] Any idea on how to move

Re: [PR] KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on PR #15228: URL: https://github.com/apache/kafka/pull/15228#issuecomment-1900431524 > Thanks @apoorvmittal10! > > Merged to `trunk` and cherry-picked to `3.7` branch. Thanks @mjsax -- This is an automated message from the Apache Git Service. To res

[jira] [Commented] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-01-19 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808658#comment-17808658 ] Proven Provenzano commented on KAFKA-16162: ---   Hi [~showuon]  I think my pat

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
AndrewJSchofield commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459018939 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -433,4 +459,26 @@ public Map matchPattern() { return matchPattern

Re: [PR] KAFKA-16107: Stop fetching while onPartitionsAssign completes [kafka]

2024-01-19 Thread via GitHub
AndrewJSchofield commented on code in PR #15215: URL: https://github.com/apache/kafka/pull/15215#discussion_r1459040148 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1134,9 +1134,22 @@ private CompletableFuture assignPart

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-01-19 Thread via GitHub
AndrewJSchofield commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1459047606 ## clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupsOptions.java: ## @@ -34,13 +35,24 @@ public class ListConsumerGroupsOptions extends

[jira] [Created] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-01-19 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-16169: -- Summary: FencedException in commitAsync not propagated without callback Key: KAFKA-16169 URL: https://issues.apache.org/jira/browse/KAFKA-16169 Project: Kafka

[jira] [Created] (KAFKA-16170) Infinite logs observed when running single node kafka in kraft mode with default KRaft properties in 3.7.0 RC2

2024-01-19 Thread Vedarth Sharma (Jira)
Vedarth Sharma created KAFKA-16170: -- Summary: Infinite logs observed when running single node kafka in kraft mode with default KRaft properties in 3.7.0 RC2 Key: KAFKA-16170 URL: https://issues.apache.org/jira/br

[jira] [Updated] (KAFKA-15832) Trigger client reconciliation based on manager poll

2024-01-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15832: --- Description: Currently the reconciliation logic on the client is triggered when a new target

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-19 Thread via GitHub
lucasbru commented on code in PR #15000: URL: https://github.com/apache/kafka/pull/15000#discussion_r1459046282 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetCommitCallbackInvoker.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Updated] (KAFKA-15832) Trigger client reconciliation based on manager poll

2024-01-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15832: --- Description: Currently the reconciliation logic on the client is triggered when a new target

[jira] [Updated] (KAFKA-16170) Continuous never ending logs observed when running single node kafka in kraft mode with default KRaft properties in 3.7.0 RC2

2024-01-19 Thread Vedarth Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vedarth Sharma updated KAFKA-16170: --- Summary: Continuous never ending logs observed when running single node kafka in kraft mode

[jira] [Updated] (KAFKA-15832) Trigger client reconciliation based on manager poll

2024-01-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15832: --- Description: Currently the reconciliation logic on the client is triggered when a new target

[jira] [Resolved] (KAFKA-16170) Continuous never ending logs observed when running single node kafka in kraft mode with default KRaft properties in 3.7.0 RC2

2024-01-19 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-16170. Resolution: Duplicate Duplicate of https://issues.apache.org/jira/browse/KAFKA-16144 > Co

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459158610 ## core/src/test/scala/unit/kafka/utils/PasswordEncoderTest.scala: ## @@ -19,10 +19,9 @@ package kafka.utils import javax.crypto.SecretKeyFactory - -import kafka.s

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459167324 ## server/src/main/java/org/apache/kafka/server/config/Defaults.java: ## @@ -0,0 +1,278 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459167766 ## server/src/main/java/org/apache/kafka/server/config/Defaults.java: ## @@ -0,0 +1,278 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459168180 ## core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala: ## @@ -53,7 +53,7 @@ class LogCleanerManagerTest extends Logging { val logConfig: LogConfig = new

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
OmniaGM commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459169205 ## checkstyle/import-control-core.xml: ## @@ -82,6 +82,7 @@ + Review Comment: nope, I think this was left over from the main pr -- This is

Re: [PR] [Kafka-14404] fix overlap of streams-config sections & describe additional parameters [kafka]

2024-01-19 Thread via GitHub
AyoubOm commented on PR #15162: URL: https://github.com/apache/kafka/pull/15162#issuecomment-1900594772 @ableegoldman @mjsax I added a section for `client.id`, the result looks like this: https://github.com/apache/kafka/assets/23745892/9934893b-967d-44a6-842b-51b8b3cd43a8";> Pl

[PR] Note that Java 11 support for broker and tools is deprecated for removal in 4.0 [kafka]

2024-01-19 Thread via GitHub
ijuma opened a new pull request, #15236: URL: https://github.com/apache/kafka/pull/15236 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

Re: [PR] KAFKA-15853: Move KafkaConfig.Defaults to server module [kafka]

2024-01-19 Thread via GitHub
mimaison commented on code in PR #15158: URL: https://github.com/apache/kafka/pull/15158#discussion_r1459178820 ## core/src/test/scala/unit/kafka/utils/PasswordEncoderTest.scala: ## @@ -19,10 +19,9 @@ package kafka.utils import javax.crypto.SecretKeyFactory - -import kafka.

[jira] [Commented] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-01-19 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808701#comment-17808701 ] Lianet Magrans commented on KAFKA-16169: Hey [~lbrutschy], I'm currently working

Re: [PR] KAFKA-16107: Stop fetching while onPartitionsAssign completes [kafka]

2024-01-19 Thread via GitHub
lianetm commented on code in PR #15215: URL: https://github.com/apache/kafka/pull/15215#discussion_r1459204272 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1134,9 +1134,22 @@ private CompletableFuture assignPartitions(

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-19 Thread via GitHub
stanislavkozlovski commented on PR #15235: URL: https://github.com/apache/kafka/pull/15235#issuecomment-1900646211 I guess this is a regression from https://issues.apache.org/jira/browse/KAFKA-15489 ? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-19 Thread via GitHub
mimaison commented on PR #15235: URL: https://github.com/apache/kafka/pull/15235#issuecomment-1900657870 Yes, this issue was introduced in https://github.com/apache/kafka/commit/37416e1aebae33d01d5059ba906ec8e0e1107284 -- This is an automated message from the Apache Git Service. To respon

[jira] [Created] (KAFKA-16171) Controller failover during ZK migration can lead to controller unavailability for ZK brokers

2024-01-19 Thread David Arthur (Jira)
David Arthur created KAFKA-16171: Summary: Controller failover during ZK migration can lead to controller unavailability for ZK brokers Key: KAFKA-16171 URL: https://issues.apache.org/jira/browse/KAFKA-16171

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can lead to controller unavailability for ZK brokers

2024-01-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Component/s: controller kraft > Controller failover during ZK migration can lea

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can prevent metadata updates to ZK brokers

2024-01-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Summary: Controller failover during ZK migration can prevent metadata updates to ZK brokers (wa

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can lead to controller unavailability for ZK brokers

2024-01-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Affects Version/s: 3.6.1 3.6.0 3.7.0 > Controller

[jira] [Updated] (KAFKA-16171) Controller failover during ZK migration can prevent metadata updates to ZK brokers

2024-01-19 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16171: - Description: h2. Description During the ZK migration, after KRaft becomes the active controller

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-19 Thread via GitHub
cadonna commented on code in PR #15000: URL: https://github.com/apache/kafka/pull/15000#discussion_r1459255586 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -271,6 +283,7 @@ public CompletableFuture maybeAutoCommitAllConsu

Re: [PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-19 Thread via GitHub
kirktrue commented on code in PR #15186: URL: https://github.com/apache/kafka/pull/15186#discussion_r1459258946 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -376,25 +376,21 @@ protected Map prepareCloseFetchSessi final

[jira] [Resolved] (KAFKA-16113) AsyncKafkaConsumer: Add missing offset commit metrics

2024-01-19 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-16113. Resolution: Fixed > AsyncKafkaConsumer: Add missing offset commit metrics > --

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-19 Thread via GitHub
lucasbru commented on code in PR #15000: URL: https://github.com/apache/kafka/pull/15000#discussion_r1459285186 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -271,6 +283,7 @@ public CompletableFuture maybeAutoCommitAllCons

[PR] KAFKA-16168; Implement GroupCoordinator.onPartitionsDeleted [kafka]

2024-01-19 Thread via GitHub
dajac opened a new pull request, #15237: URL: https://github.com/apache/kafka/pull/15237 WIP - Built on top of https://github.com/apache/kafka/pull/15221. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

Re: [PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-19 Thread via GitHub
kirktrue commented on code in PR #15186: URL: https://github.com/apache/kafka/pull/15186#discussion_r1459293494 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -376,25 +376,21 @@ protected Map prepareCloseFetchSessi final

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-19 Thread via GitHub
jolshan commented on code in PR #15183: URL: https://github.com/apache/kafka/pull/15183#discussion_r1459300270 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -92,30 +117,34 @@ public boolean equals(Object o) { Offse

[jira] [Commented] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-01-19 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808735#comment-17808735 ] Lucas Brutschy commented on KAFKA-16169: Sound good! I'd suggest doing it after

Re: [PR] KAFKA-14505; [7/N] Always materialize the most recent committed offset [kafka]

2024-01-19 Thread via GitHub
jolshan commented on PR #15183: URL: https://github.com/apache/kafka/pull/15183#issuecomment-1900735439 > we could delete all the pending transactional offsets when a new offset record is replayed. Hmmm does this work for LSO correctly? I know that the consumer offset topic has sligh

Re: [PR] KAFKA-16144: skip checkQuorum for only 1 voter case [kafka]

2024-01-19 Thread via GitHub
jsancio commented on code in PR #15235: URL: https://github.com/apache/kafka/pull/15235#discussion_r1459322086 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -101,6 +101,10 @@ protected LeaderState( * @return the remainingMs before the checkQuorumTimer

[jira] [Created] (KAFKA-16172) Flaky test: testProducerConsumerOverrideLowerQuota – kafka.api.UserQuotaTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16172: - Summary: Flaky test: testProducerConsumerOverrideLowerQuota – kafka.api.UserQuotaTest Key: KAFKA-16172 URL: https://issues.apache.org/jira/browse/KAFKA-16172 Projec

[jira] [Created] (KAFKA-16173) Flaky test: testTimeoutMetrics – org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16173: - Summary: Flaky test: testTimeoutMetrics – org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest Key: KAFKA-16173 URL: https://issues.apache.org/jira/browse/KAFKA-16

[jira] [Created] (KAFKA-16174) Flaky test: testDescribeQuorumStatusSuccessful – org.apache.kafka.tools.MetadataQuorumCommandTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16174: - Summary: Flaky test: testDescribeQuorumStatusSuccessful – org.apache.kafka.tools.MetadataQuorumCommandTest Key: KAFKA-16174 URL: https://issues.apache.org/jira/browse/KAFKA-1617

[jira] [Created] (KAFKA-16175) Flaky test: testAsynchronousAuthorizerAclUpdatesDontBlockRequestThreads – kafka.api.SslAdminIntegrationTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16175: - Summary: Flaky test: testAsynchronousAuthorizerAclUpdatesDontBlockRequestThreads – kafka.api.SslAdminIntegrationTest Key: KAFKA-16175 URL: https://issues.apache.org/jira/browse

[jira] [Comment Edited] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-01-19 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808653#comment-17808653 ] Francois Visconte edited comment on KAFKA-15776 at 1/19/24 4:52 PM: --

[jira] [Created] (KAFKA-16177) Flaky test: testBatchSizeZeroNoPartitionNoRecordKey – kafka.api.PlaintextProducerSendTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16177: - Summary: Flaky test: testBatchSizeZeroNoPartitionNoRecordKey – kafka.api.PlaintextProducerSendTest Key: KAFKA-16177 URL: https://issues.apache.org/jira/browse/KAFKA-16177

[jira] [Created] (KAFKA-16176) Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest

2024-01-19 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-16176: - Summary: Flaky test: testSendToPartitionWithFollowerShutdownShouldNotTimeout – kafka.api.PlaintextProducerSendTest Key: KAFKA-16176 URL: https://issues.apache.org/jira/browse/K

[jira] [Comment Edited] (KAFKA-15776) Update delay timeout for DelayedRemoteFetch request

2024-01-19 Thread Francois Visconte (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808653#comment-17808653 ] Francois Visconte edited comment on KAFKA-15776 at 1/19/24 4:52 PM: --

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on PR #15190: URL: https://github.com/apache/kafka/pull/15190#issuecomment-1900762271 > @apoorvmittal10 : Thanks for the updated PR. LGTM. Are the test failures related? Are they all being tracked? @junrao The tests failures are unrelated and below are the det

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459350997 ## server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java: ## @@ -919,4 +922,101 @@ public void testPushTelemetryConcurrentRequestAfterSubsc

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459368565 ## server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java: ## @@ -919,4 +922,101 @@ public void testPushTelemetryConcurrentRequestAfterSubsc

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
apoorvmittal10 commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459376549 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -433,4 +459,26 @@ public Map matchPattern() { return matchPattern;

Re: [PR] KAFKA-15813: Evict client instances from cache (KIP-714) [kafka]

2024-01-19 Thread via GitHub
AndrewJSchofield commented on code in PR #15234: URL: https://github.com/apache/kafka/pull/15234#discussion_r1459379766 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -433,4 +459,26 @@ public Map matchPattern() { return matchPattern

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-19 Thread via GitHub
mjsax merged PR #15217: URL: https://github.com/apache/kafka/pull/15217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-19 Thread via GitHub
mjsax commented on PR #15217: URL: https://github.com/apache/kafka/pull/15217#issuecomment-1900804744 Merged to `trunk` and cherry-picked to `3.7` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459430540 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the clu

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459434002 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the clu

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459466608 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the clu

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459430540 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the clu

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459483045 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the clu

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459484260 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the clu

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459484761 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the clu

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-19 Thread via GitHub
cmccabe commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1459486416 ## docs/ops.html: ## @@ -3992,6 +3979,75 @@ Finalizing the migration # Other configs ... + Reverting to ZooKeeper mode During the Migration + +While the clu

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-19 Thread via GitHub
jolshan commented on code in PR #15212: URL: https://github.com/apache/kafka/pull/15212#discussion_r1459490703 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -875,30 +875,43 @@ private void maybeRemovePartitionEpoch(

Re: [PR] KAFKA-16095: Update list group state type filter to include the states for the new consumer group type [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15211: URL: https://github.com/apache/kafka/pull/15211#discussion_r1459497325 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupState.java: ## @@ -31,7 +31,15 @@ public enum ConsumerGroupState { COMPLETING_REBALANCE("Completing

Re: [PR] KAFKA-16095: Update list group state type filter to include the states for the new consumer group type [kafka]

2024-01-19 Thread via GitHub
rreddy-22 commented on code in PR #15211: URL: https://github.com/apache/kafka/pull/15211#discussion_r1459497325 ## clients/src/main/java/org/apache/kafka/common/ConsumerGroupState.java: ## @@ -31,7 +31,15 @@ public enum ConsumerGroupState { COMPLETING_REBALANCE("Completing

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-19 Thread via GitHub
junrao commented on PR #15190: URL: https://github.com/apache/kafka/pull/15190#issuecomment-1900901612 Thanks for triaging the test failures, @apoorvmittal10. Merging the PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-15811: Enhance request context with client socket port information (KIP-714) [kafka]

2024-01-19 Thread via GitHub
junrao merged PR #15190: URL: https://github.com/apache/kafka/pull/15190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

  1   2   >