showuon merged PR #14927:
URL: https://github.com/apache/kafka/pull/14927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
omkreddy commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1422015243
##
docker/examples/jvm/cluster/combined/ssl/docker-compose.yml:
##
@@ -0,0 +1,113 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contribut
lucasbru merged PR #14975:
URL: https://github.com/apache/kafka/pull/14975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
dajac commented on PR #14954:
URL: https://github.com/apache/kafka/pull/14954#issuecomment-1849511808
@soarez `testAlterReplicaLogDirs(String).quorum=kraft –
kafka.api.PlaintextAdminIntegrationTest` still fails in
[trunk](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka
cadonna opened a new pull request, #14980:
URL: https://github.com/apache/kafka/pull/14980
If multiple addresses are available. This change is a follow-up to #9902.
When re-resolving DNS after disconnecting, it is possible (likely, even) that
we will resolve the same set of addresses in the
mjsax merged PR #14948:
URL: https://github.com/apache/kafka/pull/14948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cadonna commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1422075316
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -201,13 +224,35 @@ public long maximumTimeToWait(long currentTi
dajac commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1849536819
Merged trunk to address conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
cadonna commented on PR #14873:
URL: https://github.com/apache/kafka/pull/14873#issuecomment-1849541992
> @lianetm / @cadonna any more comments on this?
@lucasbru I did not get any answer to the following comment:
https://github.com/apache/kafka/pull/14873#discussion_r1418729793
vamossagar12 opened a new pull request, #14981:
URL: https://github.com/apache/kafka/pull/14981
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/KAFKA-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-13922:
Labels: cloudera (was: )
> Unable to generate coverage reports for the whole proj
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422131602
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -113,16 +113,15 @@ public void process(ApplicationEvent
Viktor Somogyi-Vass created KAFKA-15992:
---
Summary: Make MM2 heartbeats topic name configurable
Key: KAFKA-15992
URL: https://issues.apache.org/jira/browse/KAFKA-15992
Project: Kafka
Iss
[
https://issues.apache.org/jira/browse/KAFKA-15992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-15992:
Component/s: mirrormaker
> Make MM2 heartbeats topic name configurable
> -
OmniaGM commented on PR #14954:
URL: https://github.com/apache/kafka/pull/14954#issuecomment-1849633538
> @soarez `testAlterReplicaLogDirs(String).quorum=kraft –
kafka.api.PlaintextAdminIntegrationTest` still fails in
[trunk](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fk
dajac commented on PR #14954:
URL: https://github.com/apache/kafka/pull/14954#issuecomment-1849637350
Thanks @OmniaGM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
mjsax merged PR #14965:
URL: https://github.com/apache/kafka/pull/14965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax merged PR #14958:
URL: https://github.com/apache/kafka/pull/14958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422136734
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1499,6 +1575,149 @@ private void subscribeInternal(Collection
topics
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422269556
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -177,34 +202,37 @@ public void process(final BackgroundEvent event) {
dajac commented on PR #14640:
URL: https://github.com/apache/kafka/pull/14640#issuecomment-1849773951
@kirktrue I just replied to the open comments and left more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
viktorsomogyi commented on PR #13975:
URL: https://github.com/apache/kafka/pull/13975#issuecomment-1849789158
@mimaison do you think you can review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
soarez opened a new pull request, #14982:
URL: https://github.com/apache/kafka/pull/14982
AssignmentEvents are deduped in AssignmentsManager, but it is important to
consider any involved completion handlers and ensure they are eventually called.
This addresses a failing test:
testA
soarez commented on PR #14982:
URL: https://github.com/apache/kafka/pull/14982#issuecomment-1849817907
@dajac @OmniaGM PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dajac commented on code in PR #14848:
URL: https://github.com/apache/kafka/pull/14848#discussion_r1422297921
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##
@@ -29,44 +28,75 @@
import java.util.Arrays;
import jav
OmniaGM commented on PR #14982:
URL: https://github.com/apache/kafka/pull/14982#issuecomment-1849861443
LGTM, this is a straightforward change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/KAFKA-15992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertalan Kondrat reassigned KAFKA-15992:
Assignee: Bertalan Kondrat (was: Viktor Somogyi-Vass)
> Make MM2 heartbeats topi
[
https://issues.apache.org/jira/browse/KAFKA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertalan Kondrat reassigned KAFKA-15497:
Assignee: Bertalan Kondrat
> Refactor build.gradle and split each module configur
showuon commented on PR #14832:
URL: https://github.com/apache/kafka/pull/14832#issuecomment-1849962133
@clolov , could you address @kamalcph 's comments? I hope this KIP can be
included into v3.7.0.
--
This is an automated message from the Apache Git Service.
To respond to the messag
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1422418778
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -595,22 +609,25 @@ class CoordinatorWriteEvent implements
Co
cadonna opened a new pull request, #14983:
URL: https://github.com/apache/kafka/pull/14983
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
dajac commented on PR #14981:
URL: https://github.com/apache/kafka/pull/14981#issuecomment-1850048978
@vamossagar12 I updated the title to match the one of the Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lucasbru commented on code in PR #14930:
URL: https://github.com/apache/kafka/pull/14930#discussion_r1422459407
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -482,6 +497,47 @@ private void process(final GroupMetadataUpdateEve
mjsax commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1422442823
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java:
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Soft
aliehsaeedii commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1422488101
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java:
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apac
lucasbru commented on code in PR #14962:
URL: https://github.com/apache/kafka/pull/14962#discussion_r1422495787
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java:
##
@@ -55,16 +56,13 @@
*
* The manager checks the state of
OmniaGM commented on code in PR #14881:
URL: https://github.com/apache/kafka/pull/14881#discussion_r1422522894
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -867,6 +869,25 @@ class Partition(val topicPartition: TopicPartition,
}
}
+ private def createLog
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1422550544
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -386,7 +431,26 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
rondagostino merged PR #14881:
URL: https://github.com/apache/kafka/pull/14881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
rondagostino commented on code in PR #14942:
URL: https://github.com/apache/kafka/pull/14942#discussion_r1422561158
##
server/src/main/java/org/apache/kafka/server/AssignmentsManager.java:
##
@@ -240,31 +269,53 @@ public void run() throws Exception {
}
}
+pri
mimaison commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1850229092
@divijvaidya Do you have any further comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
rondagostino commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1850245547
`51 tests have failed. There are 49 new tests failing, 2 existing failing`
This seems like a lot more failures than we are used to recently. @OmniaGM
Can you rebase this onto
rondagostino merged PR #14982:
URL: https://github.com/apache/kafka/pull/14982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
VedarthConfluent commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1422629371
##
docs/quickstart.html:
##
@@ -94,6 +98,12 @@
$
bin/kafka-server-start.sh config/kraft/server.properties
+Using docker image
+
+
VedarthConfluent commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1422629627
##
docker/examples/jvm/cluster/combined/ssl/docker-compose.yml:
##
@@ -0,0 +1,113 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# c
[
https://issues.apache.org/jira/browse/KAFKA-15922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano reassigned KAFKA-15922:
-
Assignee: Proven Provenzano
> Add MetadataVersion for JBOD
> --
VedarthConfluent commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1422629371
##
docs/quickstart.html:
##
@@ -94,6 +98,12 @@
$
bin/kafka-server-start.sh config/kraft/server.properties
+Using docker image
+
+
VedarthConfluent commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1422647778
##
docs/quickstart.html:
##
@@ -94,6 +98,12 @@
$
bin/kafka-server-start.sh config/kraft/server.properties
+Using docker image
+
+
nikramakrishnan commented on PR #14649:
URL: https://github.com/apache/kafka/pull/14649#issuecomment-1850310706
@satishd apologies for the late response, I was on vacation. I have updated
the PR to remove the integration test for now, and it should be ready to merge
(given the unit test pas
Joker-5 commented on PR #14963:
URL: https://github.com/apache/kafka/pull/14963#issuecomment-1850317127
@vamossagar12 Thanks for reviewing the PR!
At the beginning I misunderstood this ticket, now I understood and the code
has already updated.
When commit request returns successfu
pprovenzano opened a new pull request, #14984:
URL: https://github.com/apache/kafka/pull/14984
The changes needed to make JBOD work in KRaft mode and to enable migration
JBOD systems from ZK to KRaft are in.
--
This is an automated message from the Apache Git Service.
To respond to the me
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1422676113
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -404,6 +468,7 @@ object BrokerTopicStats {
val ProduceMessageConversionsPerSec = "ProduceMessageC
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1422675847
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -386,7 +431,26 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422677966
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
testOnSubscriptionUpdatedTran
rondagostino commented on PR #14400:
URL: https://github.com/apache/kafka/pull/14400#issuecomment-1850346431
Thanks for the PR! Given that we have no automated test, please add
comments documenting the output of appropriate manual tests of this feature.
--
This is an automated message fr
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1422704717
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
testOnSubscriptionUpdatedTransi
Joker-5 commented on PR #14799:
URL: https://github.com/apache/kafka/pull/14799#issuecomment-1850377238
Hi @dajac, the code has already updated.
Would you have time to take a look at this PR?
Thanks so much.
--
This is an automated message from the Apache Git Service.
To respond
OmniaGM commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1850387349
> `51 tests have failed. There are 49 new tests failing, 2 existing failing`
>
> This seems like a lot more failures than we are used to recently. @OmniaGM
Can you rebase this onto
[
https://issues.apache.org/jira/browse/KAFKA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano reassigned KAFKA-15893:
-
Assignee: Proven Provenzano
> Bump MetadataVersion for directory assignments
>
rwunderer closed pull request #6166: KAFKA-7839 Add quotes to CLASSPATH on Java
start
URL: https://github.com/apache/kafka/pull/6166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
cadonna commented on code in PR #14930:
URL: https://github.com/apache/kafka/pull/14930#discussion_r1422458903
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -16,8 +16,43 @@
*/
package org.apache.kafka.clients.consumer.
rondagostino commented on PR #14942:
URL: https://github.com/apache/kafka/pull/14942#issuecomment-1850488367
Can we get the conflicts resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lucasbru commented on code in PR #14930:
URL: https://github.com/apache/kafka/pull/14930#discussion_r1422818505
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -482,6 +497,47 @@ private void process(final GroupMetadataUpdateEve
clolov commented on PR #14832:
URL: https://github.com/apache/kafka/pull/14832#issuecomment-1850504833
Heya, sorry, I will try to provide an updated version tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lucasbru commented on code in PR #14930:
URL: https://github.com/apache/kafka/pull/14930#discussion_r1422826824
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -16,8 +16,43 @@
*/
package org.apache.kafka.clients.consumer
lucasbru commented on code in PR #14930:
URL: https://github.com/apache/kafka/pull/14930#discussion_r1422828083
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -42,192 +77,142 @@
import
org.apache.kafka.clients.consumer.i
lucasbru commented on code in PR #14930:
URL: https://github.com/apache/kafka/pull/14930#discussion_r1422830104
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -42,192 +77,142 @@
import
org.apache.kafka.clients.consumer.i
[
https://issues.apache.org/jira/browse/KAFKA-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-15950:
Summary: Serialize broker heartbeat requests (was: CommunicationEvent
should be scheduled with EarliestDe
[
https://issues.apache.org/jira/browse/KAFKA-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-15950:
Description:
{{KafkaEventQueue}} does de-duping and only allows one outstanding
{{CommunicationEvent}} in
[
https://issues.apache.org/jira/browse/KAFKA-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-15950:
Description:
{{KafkaEventQueue}} does de-duping and only allows one outstanding
{{CommunicationEvent}} in
[
https://issues.apache.org/jira/browse/KAFKA-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-15950:
Description:
This is a follow up issue from the discussion in
https://github.com/apache/kafka/pull/14836#
[
https://issues.apache.org/jira/browse/KAFKA-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-15950:
Description:
This is a followup issue from the discussion in
[https://github.com/apache/kafka/pull/14836#
cadonna commented on code in PR #14930:
URL: https://github.com/apache/kafka/pull/14930#discussion_r1422846003
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -16,8 +16,43 @@
*/
package org.apache.kafka.clients.consumer.
cadonna commented on PR #14983:
URL: https://github.com/apache/kafka/pull/14983#issuecomment-1850549930
There was not a single streams failure in the builds:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14983/1/#showFailuresLink
--
This is an automated message from the Apach
cadonna commented on PR #14944:
URL: https://github.com/apache/kafka/pull/14944#issuecomment-1850574652
@lucasbru This PR is ready to merge. Should I wait for
https://github.com/apache/kafka/pull/14930 and close this since this is also
solved that? Or should we just merge this as a temporar
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1422903137
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -368,6 +403,16 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1422910744
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -386,7 +431,26 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
clolov commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1422910744
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -386,7 +431,26 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
java.util.Optional[Kaf
cadonna commented on PR #14961:
URL: https://github.com/apache/kafka/pull/14961#issuecomment-1850662683
@alok123t I just read your comment. FYI, I worked on fixing this PR today.
The [resulting PR](https://github.com/apache/kafka/pull/14983) is ready to
merge. I just need an approval.
--
lihaosky commented on PR #14426:
URL: https://github.com/apache/kafka/pull/14426#issuecomment-1850672002
@mjsax , @guozhangwang , can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
philipnee commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1422983344
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -201,13 +224,35 @@ public long maximumTimeToWait(long current
philipnee commented on PR #14873:
URL: https://github.com/apache/kafka/pull/14873#issuecomment-1850676664
hi @cadonna - Sorry about unintentionally ignoring your question. I've just
responded to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
lihaosky commented on code in PR #14605:
URL: https://github.com/apache/kafka/pull/14605#discussion_r1422983101
##
streams/test-utils/src/test/java/org/apache/kafka/streams/test/MockFixedKeyProcessorContextTest.java:
##
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software F
lucasbru commented on code in PR #14930:
URL: https://github.com/apache/kafka/pull/14930#discussion_r1423004412
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1535,6 +1591,11 @@ int callbacks() {
return invoker.callb
dajac commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1850707387
I looked at all the failed tests and none of them are related to this PR.
The "existing failure" are related to JBDO changes. Merging to trunk.
--
This is an automated message from the Ap
dajac merged PR #14857:
URL: https://github.com/apache/kafka/pull/14857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
philipnee commented on PR #14873:
URL: https://github.com/apache/kafka/pull/14873#issuecomment-1850712115
Hi @lianetm and @lucasbru - Per your request, I've just ran the tests using
```
Arguments.of("kraft+kip848", "consumer"))
```
All tests passed except `testRemoteAssig
[
https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15574.
-
Fix Version/s: 3.7.0
Resolution: Fixed
> Update states and transitions for membership man
lucasbru commented on PR #14873:
URL: https://github.com/apache/kafka/pull/14873#issuecomment-1850740142
@philipnee thanks for the updates.
@cadonna I'll wait for you green light this by approving.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dajac opened a new pull request, #14985:
URL: https://github.com/apache/kafka/pull/14985
This patch wires the handling of makers written by the transaction
coordinator via the WriteTxnMarkers API. In the old group coordinator, the
markers are written to the logs and the group coordinator is
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1423029434
##
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##
@@ -135,7 +136,22 @@ class CoordinatorLoaderImpl[T](
memoryRecords.batches.f
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1423029751
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -190,4 +170,56 @@ class CoordinatorPartitionWriter[T](
throw Errors.NOT_LE
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1423030220
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2361,25 +2361,27 @@ class KafkaApis(val requestChannel: RequestChannel,
* request, so there could be mu
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1423030686
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2416,14 +2418,49 @@ class KafkaApis(val requestChannel: RequestChannel,
numAppends.decrementAndGet()
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1423031807
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -881,6 +882,120 @@ public String toString() {
}
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1423031514
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -892,6 +893,43 @@ public void replay(
}
}
+/**
lucasbru commented on PR #14944:
URL: https://github.com/apache/kafka/pull/14944#issuecomment-1850757955
@cadonna If you have more comments on #14930, please feel free to merge
this, I will anyways have conflicts with every single CTR/KIP-848 PR.
Instead, if #14930 is good to go, let
lianetm commented on PR #14873:
URL: https://github.com/apache/kafka/pull/14873#issuecomment-1850787095
@philipnee thanks for the updates! One last comment. Important follow-up to
this PR is to enable the specific max poll related integration tests (like
`testMaxPollIntervalMs`), that are c
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423062667
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
testOnSubscriptionUpdatedTra
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1423064727
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1499,6 +1575,149 @@ private void subscribeInternal(Collection
top
1 - 100 of 178 matches
Mail list logo
