appchemist opened a new pull request, #14765:
URL: https://github.com/apache/kafka/pull/14765
When a request is timed out, a old inFlightCorrelationId value is remaining
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cadonna commented on PR #14746:
URL: https://github.com/apache/kafka/pull/14746#issuecomment-1812010386
@philipnee @kirktrue Thanks for your comments and explanation! I totally
missed that if the future is completed exceptionally it throws an
`ExecutionException`. The javadocs of `completeE
msn-tldr commented on PR #14757:
URL: https://github.com/apache/kafka/pull/14757#issuecomment-1812141051
@wcarlson5 thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Goyal updated KAFKA-15388:
Attachment: Screenshot 2023-11-15 at 3.47.54 PM.png
> Handle topics that were having compaction as
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Goyal updated KAFKA-15388:
Attachment: Screenshot 2023-11-15 at 3.53.43 PM.png
> Handle topics that were having compaction as
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Goyal updated KAFKA-15388:
Attachment: (was: Screenshot 2023-11-15 at 3.53.43 PM.png)
> Handle topics that were having co
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Goyal updated KAFKA-15388:
Attachment: tieredtopicloglist.png
> Handle topics that were having compaction as retention earlie
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786299#comment-17786299
]
Arpit Goyal commented on KAFKA-15388:
-
Hey [~divijvaidya] I am successfully able to
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786299#comment-17786299
]
Arpit Goyal edited comment on KAFKA-15388 at 11/15/23 10:37 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786299#comment-17786299
]
Arpit Goyal edited comment on KAFKA-15388 at 11/15/23 10:38 AM:
--
dajac commented on PR #14635:
URL: https://github.com/apache/kafka/pull/14635#issuecomment-1812239280
I cannot get a clean build for this one. @wolfchimneyrock Could you please
merge trunk to your branch?
--
This is an automated message from the Apache Git Service.
To respond to the messa
dajac commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394032677
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbeat
dajac commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394042794
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbeat
dajac commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394053638
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbeat
[
https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786317#comment-17786317
]
Daniele Carminati commented on KAFKA-15513:
---
Hi there
I made an error reportin
lucasbru commented on PR #14680:
URL: https://github.com/apache/kafka/pull/14680#issuecomment-1812360189
Okay. Sounds like using the background events queue wouldn't strictly have
downsides, but also not have so many upsides. I agree that picking things from
a queue sounds awkward, so let's
Apoorv Mittal created KAFKA-15830:
-
Summary: Add request/response handling in KafkaApis and update
metrics plugin
Key: KAFKA-15830
URL: https://issues.apache.org/jira/browse/KAFKA-15830
Project: Kafka
lucasbru commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1394089557
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -147,6 +151,10 @@ public class PrototypeAsyncConsumer implement
[
https://issues.apache.org/jira/browse/KAFKA-15809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phuc Hong Tran updated KAFKA-15809:
---
Summary: Updating broker's metadata schema to include TS enable status
(was: Adding TS to b
divijvaidya commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1812459578
We have an unusually large number of failures. @alok123t can you please
check the failures to see if they might be related to this change?
--
This is an automated message from the A
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-15653.
Fix Version/s: 3.7.0
3.6.1
Resolution: Fixed
> NPE in ChunkedByt
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786338#comment-17786338
]
Justine Olshan commented on KAFKA-15653:
Yes. [~h...@pinterest.com] this is reso
alok123t commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1812467554
@divijvaidya looks unrelated. Most failed tests are related to
`RestoreIntegrationTest` - likely some regression when I merged in latest
changes from trunk to trigger a new build
--
T
dajac commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1812491676
Hey @alok123t. Thanks for working on this. In the last build, I just noticed
that parameterized still are still reported as:
```
Build / JDK 21 and Scala 2.13 / [5] Type=ZK, MetadataVe
dajac commented on PR #14670:
URL: https://github.com/apache/kafka/pull/14670#issuecomment-1812496898
I had a look at all the failed tests from the last build and they look all
unrelated to me. Therefore, I am going to merge this PR to trunk. Thanks
@kirktrue for the patch!
--
This is an
dajac merged PR #14670:
URL: https://github.com/apache/kafka/pull/14670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
kamalcph commented on PR #14755:
URL: https://github.com/apache/kafka/pull/14755#issuecomment-1812555386
The test failures are unrelated to this PR:
```
Build / JDK 17 and Scala 2.13 / testFailureToFenceEpoch(String).quorum=kraft
– kafka.api.TransactionsTest
38s
Build / JDK 1
Andrew Schofield created KAFKA-15831:
Summary: List Client Metrics Configuration Resources
Key: KAFKA-15831
URL: https://issues.apache.org/jira/browse/KAFKA-15831
Project: Kafka
Issue Typ
[
https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786367#comment-17786367
]
Proven Provenzano commented on KAFKA-15513:
---
You can set up the controller and
[
https://issues.apache.org/jira/browse/KAFKA-15824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayank Shekhar Narula resolved KAFKA-15824.
---
Resolution: Fixed
> SubscriptionState's maybeValidatePositionForCurrentLeade
eduwercamacaro commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1394297063
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -701,7 +706,15 @@ private StandbyTask convertActiveToStandby(final
eduwercamacaro commented on code in PR #14735:
URL: https://github.com/apache/kafka/pull/14735#discussion_r1394297063
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -701,7 +706,15 @@ private StandbyTask convertActiveToStandby(final
Lianet Magrans created KAFKA-15832:
--
Summary: Trigger reconciliation based on manager poll
Key: KAFKA-15832
URL: https://issues.apache.org/jira/browse/KAFKA-15832
Project: Kafka
Issue Type:
Lucas Brutschy created KAFKA-15833:
--
Summary: Restrict Consumer API to be used from one thread
Key: KAFKA-15833
URL: https://issues.apache.org/jira/browse/KAFKA-15833
Project: Kafka
Issue Ty
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394322340
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -260,42 +924,52 @@ public Optional serverAssignor() {
* {@i
[
https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-15832:
--
Assignee: Lianet Magrans
> Trigger client reconciliation based on manager poll
>
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394344222
##
clients/src/main/java/org/apache/kafka/clients/MetadataCache.java:
##
@@ -102,6 +107,10 @@ Map topicIds() {
return topicIds;
}
+Map topicNames()
[
https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15832:
---
Summary: Trigger client reconciliation based on manager poll (was: Trigger
reconciliation b
lucasbru commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1394385232
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -415,6 +439,27 @@ public ConsumerRecords poll(final Duration timeou
lucasbru commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1394418301
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -415,6 +439,27 @@ public ConsumerRecords poll(final Duration timeou
hachikuji commented on code in PR #14612:
URL: https://github.com/apache/kafka/pull/14612#discussion_r1394487516
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1355,6 +1402,60 @@ class KafkaApis(val requestChannel: RequestChannel,
))
}
+ def handleDescr
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394493344
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
philipnee commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1394496768
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -415,6 +439,27 @@ public ConsumerRecords poll(final Duration timeo
mimaison commented on code in PR #14756:
URL: https://github.com/apache/kafka/pull/14756#discussion_r1394485129
##
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java:
##
@@ -185,6 +188,18 @@ private SslEngineFactory
createNewSslEngineFactory(Map newConfi
mimaison commented on PR #14756:
URL: https://github.com/apache/kafka/pull/14756#issuecomment-1812934459
@viktorsomogyi @omkreddy You also voted on the KIP. Do you want to take a
look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kamalcph opened a new pull request, #14766:
URL: https://github.com/apache/kafka/pull/14766
Pending: To cover with unit and integration tests
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build sta
gharris1727 commented on PR #14762:
URL: https://github.com/apache/kafka/pull/14762#issuecomment-1812953889
@yashmayya I noticed those failures and wasn't sure they're affected, thanks
for explaining exactly what is going on!
Since other workers in the cluster may not have this fix ap
chb2ab commented on PR #14747:
URL: https://github.com/apache/kafka/pull/14747#issuecomment-1812956129
I've run all the failing tests locally and they passed
(kafka.api.ConsumerBounceTest.testConsumptionWithBrokerFailures after a retry)
> Build / JDK 8 and Scala 2.12 /
testRackAwareR
dajac commented on PR #14635:
URL: https://github.com/apache/kafka/pull/14635#issuecomment-1812962335
@wolfchimneyrock I just did it. Let's see how the next build goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
jolshan commented on PR #14747:
URL: https://github.com/apache/kafka/pull/14747#issuecomment-1812965942
@chb2ab was the re-revert clean? Any conflicts that needed resolving?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786449#comment-17786449
]
Divij Vaidya commented on KAFKA-15481:
--
update: I am currently on it. Will take ano
apoorvmittal10 opened a new pull request, #14767:
URL: https://github.com/apache/kafka/pull/14767
The PR adds handling of telemetry APIs in KafkaAPIs.scala which calls the
respective manager to handle the API calls. Also the telemetry plugin which if
registered in configs get registered for
apoorvmittal10 commented on code in PR #14767:
URL: https://github.com/apache/kafka/pull/14767#discussion_r1394557331
##
core/src/main/java/kafka/metrics/ClientMetricsReceiverPlugin.java:
##
@@ -0,0 +1,67 @@
+/*
Review Comment:
This class is major overlap with the other open
apoorvmittal10 commented on code in PR #14767:
URL: https://github.com/apache/kafka/pull/14767#discussion_r1394561710
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3697,16 +3698,60 @@ class KafkaApis(val requestChannel: RequestChannel,
CompletableFuture.comple
cadonna commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1394568452
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -168,6 +178,44 @@ public void testCommitted_ExceptionThrown() {
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394570775
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -17,25 +17,86 @@
package org.apache.kafka.clients.consumer.int
cadonna commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1394571238
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -415,6 +439,27 @@ public ConsumerRecords poll(final Duration timeout
cadonna commented on code in PR #14746:
URL: https://github.com/apache/kafka/pull/14746#discussion_r1394572019
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -415,6 +439,27 @@ public ConsumerRecords poll(final Duration timeout
philipnee commented on PR #14680:
URL: https://github.com/apache/kafka/pull/14680#issuecomment-1813009735
Hi @lucasbru - Addressed your comment about the volatile. I also modify the
invoker.submit to catch some java exception. Please review. Terrible sorry
but I needed to rebase to the c
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786456#comment-17786456
]
Divij Vaidya commented on KAFKA-15388:
--
Nice work on having a reproducer Arpit! (y)
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786456#comment-17786456
]
Divij Vaidya edited comment on KAFKA-15388 at 11/15/23 6:04 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786458#comment-17786458
]
Divij Vaidya commented on KAFKA-15341:
--
Hey [~phuctran] , I won't have time in next
apoorvmittal10 commented on PR #14620:
URL: https://github.com/apache/kafka/pull/14620#issuecomment-1813016172
Thanks @AndrewJSchofield for approving the PR. @mjsax @xvrl @philipnee
please if you can review again as well.
--
This is an automated message from the Apache Git Service.
To res
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394581206
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -77,32 +138,111 @@ public class MembershipManagerImpl implements
chb2ab commented on PR #14747:
URL: https://github.com/apache/kafka/pull/14747#issuecomment-1813016931
@jolshan yes it was a clean revert, no conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394585362
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -77,32 +138,111 @@ public class MembershipManagerImpl implements
apoorvmittal10 commented on PR #14632:
URL: https://github.com/apache/kafka/pull/14632#issuecomment-1813025066
> @apoorvmittal10 : Thanks for looking into the test failures. There is an
ongoing discussion on requiring a green build before merging the PR. I will
need to wait for the result o
cadonna commented on PR #14746:
URL: https://github.com/apache/kafka/pull/14746#issuecomment-1813027684
I am still not sure what the conclusion is regarding:
https://github.com/apache/kafka/pull/14746#issuecomment-1809158196
--
This is an automated message from the Apache Git Service.
To
apoorvmittal10 commented on PR #14767:
URL: https://github.com/apache/kafka/pull/14767#issuecomment-1813029427
Build depends on PR: https://github.com/apache/kafka/pull/14699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-15833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-15833:
--
Assignee: Lucas Brutschy
> Restrict Consumer API to be used from one thread
> ---
philipnee commented on PR #14746:
URL: https://github.com/apache/kafka/pull/14746#issuecomment-1813035808
hi @cadonna - I think we probably don't have to worry about it here. I have
one comment: Is it possible to test poll would return normally after the
consumer is woken up and invoke pol
philipnee commented on PR #14620:
URL: https://github.com/apache/kafka/pull/14620#issuecomment-1813036647
Hi @apoorvmittal10 - Thanks for addressing the comments, I have no more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394619681
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394629300
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394646561
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
dongnuo123 commented on code in PR #14656:
URL: https://github.com/apache/kafka/pull/14656#discussion_r1394662269
##
core/src/test/scala/unit/kafka/server/LeaveGroupRequestTest.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
Greg Harris created KAFKA-15834:
---
Summary: Subscribing to non-existent topic blocks StreamThread
from stopping
Key: KAFKA-15834
URL: https://issues.apache.org/jira/browse/KAFKA-15834
Project: Kafka
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394733589
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394742401
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
[
https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-14438:
-
Assignee: Kirk True
> Stop supporting empty consumer groupId
>
AndrewJSchofield commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1394744738
##
core/src/main/java/kafka/metrics/ClientMetricsConfigs.java:
##
@@ -80,6 +82,11 @@ public class ClientMetricsConfigs {
public static final String CLIENT
[
https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14438:
--
Summary: Stop supporting empty consumer group.id (was: Stop supporting
empty consumer groupId)
> Sto
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394746271
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
[
https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14438:
--
Description:
Currently, a warning message is logged upon using an empty consumer groupId. In
the next
[
https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14438:
--
Labels: kip-848-client-support kip-848-e2e kip-848-preview (was: )
> Stop supporting empty consumer g
[
https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14438:
--
Summary: Throw InvalidGroupIdException when consumer configured with
empty/whitespace-only group.id (
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394753399
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -77,32 +138,111 @@ public class MembershipManagerImpl implements
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394759427
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -168,10 +308,37 @@ public void
updateState(ConsumerGroupHeartbea
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394774045
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
Lianet Magrans created KAFKA-15835:
--
Summary: Group commit/callbacks triggering logic
Key: KAFKA-15835
URL: https://issues.apache.org/jira/browse/KAFKA-15835
Project: Kafka
Issue Type: Sub-t
[
https://issues.apache.org/jira/browse/KAFKA-15835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-15835:
--
Assignee: Lianet Magrans
> Group commit/callbacks triggering logic
>
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394786770
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394789418
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -181,63 +348,560 @@ public void
updateState(ConsumerGroupHeartbe
[
https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14438:
--
Summary: Throw error when consumer configured with empty/whitespace-only
group.id (was: Throw Invalid
kirktrue opened a new pull request, #14768:
URL: https://github.com/apache/kafka/pull/14768
Per [KIP-289 (Improve the default group id behavior in
`KafkaConsumer`)](https://cwiki.apache.org/confluence/display/KAFKA/KIP-289%3A+Improve+the+default+group+id+behavior+in+KafkaConsumer),
the `gro
kirktrue commented on PR #14768:
URL: https://github.com/apache/kafka/pull/14768#issuecomment-1813279513
@philipnee—can you add the `ctr` and `KIP-848` labels? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cmccabe commented on code in PR #14719:
URL: https://github.com/apache/kafka/pull/14719#discussion_r1394818560
##
core/src/main/scala/kafka/controller/ControllerChannelManager.scala:
##
@@ -567,7 +567,6 @@ abstract class AbstractControllerBrokerRequestBatch(config:
KafkaConfig,
cmccabe commented on code in PR #14719:
URL: https://github.com/apache/kafka/pull/14719#discussion_r1394820962
##
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##
@@ -55,6 +56,64 @@ trait ZkFinalizedFeatureCache {
def getFeatureOption: Option[Features]
}
AndrewJSchofield commented on code in PR #14768:
URL: https://github.com/apache/kafka/pull/14768#discussion_r1394821601
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java:
##
@@ -150,11 +150,9 @@ public class LegacyKafkaConsumer impleme
cmccabe commented on code in PR #14719:
URL: https://github.com/apache/kafka/pull/14719#discussion_r1394827643
##
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##
@@ -55,6 +56,64 @@ trait ZkFinalizedFeatureCache {
def getFeatureOption: Option[Features]
}
1 - 100 of 178 matches
Mail list logo
