Re: [PR] KAFKA-15038: Add metadatacache into RemoteLogManager, and refactor all relevant codes [kafka]

2023-11-04 Thread via GitHub
Owen-CH-Leung commented on PR #14136: URL: https://github.com/apache/kafka/pull/14136#issuecomment-1793384128 Hi all - I've rebased trunk. Can I ask for some feedback again ? Thanks @clolov @showuon @satishd @kamalcph -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-15513) KRaft cluster fails with SCRAM authentication enabled for control-plane

2023-11-04 Thread Christian Lefebvre (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782843#comment-17782843 ] Christian Lefebvre commented on KAFKA-15513: I noticed `kafka-storage` comma

[jira] [Comment Edited] (KAFKA-15513) KRaft cluster fails with SCRAM authentication enabled for control-plane

2023-11-04 Thread Christian Lefebvre (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782843#comment-17782843 ] Christian Lefebvre edited comment on KAFKA-15513 at 11/4/23 8:40 AM: -

[jira] [Commented] (KAFKA-15371) MetadataShell is stuck when bootstrapping

2023-11-04 Thread Christian Lefebvre (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782846#comment-17782846 ] Christian Lefebvre commented on KAFKA-15371: Weirdly, I had the same case th

[jira] [Comment Edited] (KAFKA-15371) MetadataShell is stuck when bootstrapping

2023-11-04 Thread Christian Lefebvre (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782846#comment-17782846 ] Christian Lefebvre edited comment on KAFKA-15371 at 11/4/23 9:48 AM: -

[jira] [Commented] (KAFKA-15341) Enabling TS for a topic during rolling restart causes problems

2023-11-04 Thread jinlong wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782850#comment-17782850 ] jinlong wang commented on KAFKA-15341: -- maybe i can help, please assign to me. > E

[jira] [Commented] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-11-04 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782860#comment-17782860 ] Arpit Goyal commented on KAFKA-15388: - [~divijvaidya] [~satish.duggana] [~christo_lo

[jira] [Comment Edited] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-11-04 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782860#comment-17782860 ] Arpit Goyal edited comment on KAFKA-15388 at 11/4/23 11:45 AM: ---

[jira] [Comment Edited] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-11-04 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782860#comment-17782860 ] Arpit Goyal edited comment on KAFKA-15388 at 11/4/23 11:45 AM: ---

[jira] [Commented] (KAFKA-15313) Delete remote log segments partition asynchronously when a partition is deleted.

2023-11-04 Thread jinlong wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782877#comment-17782877 ] jinlong wang commented on KAFKA-15313: -- I can help on this, please assign to me tha

[jira] [Commented] (KAFKA-15341) Enabling TS for a topic during rolling restart causes problems

2023-11-04 Thread jinlong wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782881#comment-17782881 ] jinlong wang commented on KAFKA-15341: -- After check the logic. It seems that the `

[jira] [Commented] (KAFKA-15371) MetadataShell is stuck when bootstrapping

2023-11-04 Thread Christian Lefebvre (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782882#comment-17782882 ] Christian Lefebvre commented on KAFKA-15371: It becomes more and more weird

[jira] [Comment Edited] (KAFKA-15371) MetadataShell is stuck when bootstrapping

2023-11-04 Thread Christian Lefebvre (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782882#comment-17782882 ] Christian Lefebvre edited comment on KAFKA-15371 at 11/4/23 2:10 PM: -

[PR] MINOR: add clarification about log compaction [kafka]

2023-11-04 Thread via GitHub
AyoubOm opened a new pull request, #14701: URL: https://github.com/apache/kafka/pull/14701 *Add a note about log compaction behavior. The term "old data" used may be misunderstood as old data with respect of time, instead of old data associated with a given key* ### Committer Che

[jira] [Commented] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-11-04 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782907#comment-17782907 ] Arpit Goyal commented on KAFKA-15388: - I just found the answer for the above query

[PR] DRAFT: KAFKA-15764: Missing Tests for Transactions [kafka]

2023-11-04 Thread via GitHub
jolshan opened a new pull request, #14702: URL: https://github.com/apache/kafka/pull/14702 I tried adding compression to the producer to see if it triggered the failure found in KAFKA-15653. My first attempt did not seem to yield any failures yet. -- This is an automated message from

[jira] [Commented] (KAFKA-15764) Missing tests for transactions

2023-11-04 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782908#comment-17782908 ] Justine Olshan commented on KAFKA-15764: I created an example of what I was sayi

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-04 Thread via GitHub
AndrewJSchofield commented on PR #14690: URL: https://github.com/apache/kafka/pull/14690#issuecomment-1793496177 Hi @philipnee, thanks for you comment. It does raise an interesting point. My view is that CompletableFuture provides a really nice abstraction for asynchronous processing.

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-04 Thread via GitHub
philipnee commented on PR #14690: URL: https://github.com/apache/kafka/pull/14690#issuecomment-1793538245 Hi @AndrewJSchofield - Thank you for your inputs here, your point is absolutely valid in terms of the abstraction it provides. My main concern is the rebalance callback invocation. Ma

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-04 Thread via GitHub
philipnee commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1382450219 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -181,33 +262,465 @@ public void updateState(ConsumerGroupHeart

[jira] [Resolved] (KAFKA-15783) Unable to set batchSize in log4j2 Kafka appender

2023-11-04 Thread Diego Pettisani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Pettisani resolved KAFKA-15783. - Resolution: Not A Problem > Unable to set batchSize in log4j2 Kafka appender > -

[jira] [Comment Edited] (KAFKA-15783) Unable to set batchSize in log4j2 Kafka appender

2023-11-04 Thread Diego Pettisani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782928#comment-17782928 ] Diego Pettisani edited comment on KAFKA-15783 at 11/4/23 9:32 PM:

[jira] [Commented] (KAFKA-15783) Unable to set batchSize in log4j2 Kafka appender

2023-11-04 Thread Diego Pettisani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782928#comment-17782928 ] Diego Pettisani commented on KAFKA-15783: - Sorry, only now I verified that we ca

[jira] [Comment Edited] (KAFKA-15783) Unable to set batchSize in log4j2 Kafka appender

2023-11-04 Thread Diego Pettisani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782928#comment-17782928 ] Diego Pettisani edited comment on KAFKA-15783 at 11/4/23 9:33 PM:

[jira] [Comment Edited] (KAFKA-15783) Unable to set batchSize in log4j2 Kafka appender

2023-11-04 Thread Diego Pettisani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782928#comment-17782928 ] Diego Pettisani edited comment on KAFKA-15783 at 11/4/23 9:33 PM: