Re: [PR] KAFKA-15562: ensure commit request manager handles errors correctly [kafka]

2023-10-26 Thread via GitHub
scyber commented on code in PR #14639: URL: https://github.com/apache/kafka/pull/14639#discussion_r1372704905 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -215,16 +227,113 @@ public NetworkClientDelegate.UnsentRequest toU

[jira] [Commented] (KAFKA-12822) Remove Deprecated APIs of Kafka Streams in 4.0

2023-10-26 Thread Grigorii Piskunov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779782#comment-17779782 ] Grigorii Piskunov commented on KAFKA-12822: --- Hi Guys, Would be possible to pa

Re: [PR] MINOR: avoid blocking for randomness in DefaultRecordBatchTest [kafka]

2023-10-26 Thread via GitHub
divijvaidya commented on PR #14625: URL: https://github.com/apache/kafka/pull/14625#issuecomment-1780575442 There are flaky test failures but DefaultRecordBatchTest is not amongst failing tests. Merging this in. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] MINOR: avoid blocking for randomness in DefaultRecordBatchTest [kafka]

2023-10-26 Thread via GitHub
divijvaidya merged PR #14625: URL: https://github.com/apache/kafka/pull/14625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] Add pre-requisite check in release.py [kafka]

2023-10-26 Thread via GitHub
Owen-CH-Leung commented on code in PR #14636: URL: https://github.com/apache/kafka/pull/14636#discussion_r1372728989 ## release.py: ## @@ -491,6 +491,25 @@ def command_release_announcement_email(): Do you have all of of these setup? (y/n): """ % (PREFS_FILE, json.dumps(prefs,

[jira] [Commented] (KAFKA-12822) Remove Deprecated APIs of Kafka Streams in 4.0

2023-10-26 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779788#comment-17779788 ] Josep Prat commented on KAFKA-12822: Hi Grigorii, Yes everyone is welcomed to parti

Re: [PR] MINOR: Minor update patch versions [kafka]

2023-10-26 Thread via GitHub
satishd commented on PR #14641: URL: https://github.com/apache/kafka/pull/14641#issuecomment-1780604057 @jolshan: @showuon helped in running the system tests for 3.6.0 release. I do not think there were any issues reported during those runs related to these versions. -- This is an auto

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-26 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1780627595 @jolshan Looks like we good to go. Are you ready to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] MINOR: Fix misleading log in streams restoration [kafka]

2023-10-26 Thread via GitHub
lucasbru opened a new pull request, #14643: URL: https://github.com/apache/kafka/pull/14643 This line seems to indicate that stand-by tasks have caught up to the end of the changelog, as they are logged as part of `allTasks`. But in fact, only active tasks have caught up to the end of the

[PR] [MINOR] Remove dead code from ConsumerGroupCommand [kafka]

2023-10-26 Thread via GitHub
nizhikov opened a new pull request, #14644: URL: https://github.com/apache/kafka/pull/14644 This PR simply removes unused code from `ConsumerGroupCommand`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage an

[jira] [Assigned] (KAFKA-15200) verify pre-requisite at start of release.py

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-15200: Assignee: Owen C.H. Leung (was: Abhinav Tripathi) > verify pre-requisite at start of rel

Re: [PR] Add pre-requisite check in release.py [kafka]

2023-10-26 Thread via GitHub
divijvaidya merged PR #14636: URL: https://github.com/apache/kafka/pull/14636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] Kafka 15680 [kafka]

2023-10-26 Thread via GitHub
kumarpritam863 commented on PR #14630: URL: https://github.com/apache/kafka/pull/14630#issuecomment-1780668877 > @kumarpritam863 is this the same as #12622 and https://issues.apache.org/jira/browse/KAFKA-14220? And if so, can you shed some light on why that PR and ticket were wiped and clos

[jira] [Updated] (KAFKA-15200) verify pre-requisite at start of release.py

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15200: - Fix Version/s: 3.7.0 > verify pre-requisite at start of release.py > ---

[jira] [Assigned] (KAFKA-15198) Improve version release scripts

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-15198: Assignee: (was: Abhinav Tripathi) > Improve version release scripts > ---

[jira] [Resolved] (KAFKA-15200) verify pre-requisite at start of release.py

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15200. -- Resolution: Fixed > verify pre-requisite at start of release.py >

Re: [PR] KAFKA-14484: [1/N] Move PartitionMetadataFile to storage module [kafka]

2023-10-26 Thread via GitHub
alok123t commented on code in PR #14607: URL: https://github.com/apache/kafka/pull/14607#discussion_r1372811735 ## storage/src/main/java/org/apache/kafka/storage/internals/log/PartitionMetadataReadBuffer.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-14133: Replace Easymock with Mockito in StreamsProducerTest, TopologyMetadataTest & GlobalStateStoreProviderTest [kafka]

2023-10-26 Thread via GitHub
bachmanity1 commented on code in PR #14410: URL: https://github.com/apache/kafka/pull/14410#discussion_r1372812958 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java: ## @@ -1173,17 +1126,13 @@ public void shouldResetTransactionInitia

Re: [PR] KAFKA-14133: Replace Easymock with Mockito in StreamsProducerTest, TopologyMetadataTest & GlobalStateStoreProviderTest [kafka]

2023-10-26 Thread via GitHub
bachmanity1 commented on PR #14410: URL: https://github.com/apache/kafka/pull/14410#issuecomment-1780697176 > Looks good to me! @clolov do you have any other comments on this PR? @divijvaidya Can you not merge for now? Looks like some tests are failing. -- This is an automa

Re: [PR] Add explicit exit call to each shell command [kafka]

2023-10-26 Thread via GitHub
tkornai commented on PR #14633: URL: https://github.com/apache/kafka/pull/14633#issuecomment-1780699120 Hi @gharris1727, thanks for your prompt reply. The provider in question is [java-spiffe](https://github.com/spiffe/java-spiffe). I agree that tackling the problem from that side ma

Re: [PR] Add explicit exit call to each shell command [kafka]

2023-10-26 Thread via GitHub
tkornai closed pull request #14633: Add explicit exit call to each shell command URL: https://github.com/apache/kafka/pull/14633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] MINOR: added compatibility for MinGW [kafka]

2023-10-26 Thread via GitHub
maniekes commented on code in PR #13321: URL: https://github.com/apache/kafka/pull/13321#discussion_r1372826306 ## bin/kafka-run-class.sh: ## @@ -229,7 +230,7 @@ if [ -z "$KAFKA_LOG4J_OPTS" ]; then # Log to console. This is a tool. LOG4J_DIR="$base_dir/config/tools-log4j.p

Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]

2023-10-26 Thread via GitHub
clolov commented on PR #14623: URL: https://github.com/apache/kafka/pull/14623#issuecomment-1780706599 I am able to reproduce the failing tests locally and I am trying to understand why the behaviour is not as expected. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]

2023-10-26 Thread via GitHub
clolov commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1372832772 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java: ## @@ -146,69 +135,26 @@ public class StreamsMetricsImplTest {

Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]

2023-10-26 Thread via GitHub
clolov commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1372833090 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java: ## @@ -1293,43 +1204,33 @@ private void verifyMetric(final Str

Re: [PR] KAFKA-15158: Add metrics for RemoteRequestsPerSec [kafka]

2023-10-26 Thread via GitHub
clolov commented on PR #14375: URL: https://github.com/apache/kafka/pull/14375#issuecomment-1780714845 I have republished KIP-963 (https://lists.apache.org/thread/40vsyc240hyody37mf2f0pn90shkzb45). Would people manage to find some time to comment on it (@tinaselenge @nikramakrishnan @showu

Re: [PR] KAFKA-14133: Replace Easymock with Mockito in StreamsProducerTest, TopologyMetadataTest & GlobalStateStoreProviderTest [kafka]

2023-10-26 Thread via GitHub
bachmanity1 commented on code in PR #14410: URL: https://github.com/apache/kafka/pull/14410#discussion_r1372841385 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsProducerTest.java: ## @@ -1098,20 +1055,16 @@ public void shouldSwallowExceptionOnEosA

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

2023-10-26 Thread via GitHub
divijvaidya commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372844362 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: Thi

Re: [PR] KAFKA-15653: Pass requestLocal as argument to callback so we use the correct one for the thread [kafka]

2023-10-26 Thread via GitHub
divijvaidya commented on code in PR #14629: URL: https://github.com/apache/kafka/pull/14629#discussion_r1372844362 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig, } } + /* + * Note: Thi

Re: [PR] MINOR: added compatibility for MinGW [kafka]

2023-10-26 Thread via GitHub
divijvaidya commented on code in PR #13321: URL: https://github.com/apache/kafka/pull/13321#discussion_r1372856100 ## bin/kafka-run-class.sh: ## @@ -229,7 +230,7 @@ if [ -z "$KAFKA_LOG4J_OPTS" ]; then # Log to console. This is a tool. LOG4J_DIR="$base_dir/config/tools-log4

[jira] [Created] (KAFKA-15685) Missing compatibility for MinGW (windows)

2023-10-26 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-15685: Summary: Missing compatibility for MinGW (windows) Key: KAFKA-15685 URL: https://issues.apache.org/jira/browse/KAFKA-15685 Project: Kafka Issue Type: Improve

[jira] [Created] (KAFKA-15686) Consumer should be able to detect network problem

2023-10-26 Thread Jiahongchao (Jira)
Jiahongchao created KAFKA-15686: --- Summary: Consumer should be able to detect network problem Key: KAFKA-15686 URL: https://issues.apache.org/jira/browse/KAFKA-15686 Project: Kafka Issue Type: N

Re: [PR] KAFKA-15685: added compatibility for MinGW [kafka]

2023-10-26 Thread via GitHub
divijvaidya merged PR #13321: URL: https://github.com/apache/kafka/pull/13321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[jira] [Resolved] (KAFKA-15685) Missing compatibility for MinGW (windows)

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15685. -- Resolution: Fixed > Missing compatibility for MinGW (windows) > --

[jira] [Commented] (KAFKA-15685) Missing compatibility for MinGW (windows)

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779814#comment-17779814 ] Divij Vaidya commented on KAFKA-15685: -- Associated PR [https://github.com/apache/ka

[jira] [Updated] (KAFKA-15685) Missing compatibility for MinGW and MSYS2 (windows)

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15685: - Summary: Missing compatibility for MinGW and MSYS2 (windows) (was: Missing compatibility for Mi

[jira] [Updated] (KAFKA-15685) Add missing compatibility for MinGW and MSYS2 (windows)

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15685: - Summary: Add missing compatibility for MinGW and MSYS2 (windows) (was: Missing compatibility fo

Re: [PR] [MINOR] Remove dead code from ConsumerGroupCommand [kafka]

2023-10-26 Thread via GitHub
nizhikov closed pull request #14644: [MINOR] Remove dead code from ConsumerGroupCommand URL: https://github.com/apache/kafka/pull/14644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-15685: added compatibility for MinGW [kafka]

2023-10-26 Thread via GitHub
divijvaidya commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1780757972 Hey @maniekes I added a JIRA for this PR https://issues.apache.org/jira/browse/KAFKA-15685 since it is relevant to call this one out in release notes. Please feel free to assign i

Re: [PR] KAFKA-15685: added compatibility for MinGW [kafka]

2023-10-26 Thread via GitHub
maniekes commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1780816193 thank you @divijvaidya for help and support. i created jira account in Jira but cannot assign ticket to me, can you try to assign now? -- This is an automated message from the Apache G

Re: [PR] KAFKA-15614: Define interfaces and classes for client telemetry [kafka]

2023-10-26 Thread via GitHub
apoorvmittal10 commented on PR #14575: URL: https://github.com/apache/kafka/pull/14575#issuecomment-1780830968 Is there anything that I should address or we can merge the PR? There are some unrelated tests failed: ``` 14 tests have failed There are 14 new tests failing, 0 existi

Re: [PR] KAFKA-15673: Adding client metrics resource types (KIP-714) [kafka]

2023-10-26 Thread via GitHub
apoorvmittal10 commented on code in PR #14621: URL: https://github.com/apache/kafka/pull/14621#discussion_r1372939620 ## core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala: ## @@ -0,0 +1,119 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] KAFKA-15673: Adding client metrics resource types (KIP-714) [kafka]

2023-10-26 Thread via GitHub
apoorvmittal10 commented on code in PR #14621: URL: https://github.com/apache/kafka/pull/14621#discussion_r1372943465 ## core/src/main/scala/kafka/server/ClientMetricsManager.scala: ## @@ -0,0 +1,38 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15673: Adding client metrics resource types (KIP-714) [kafka]

2023-10-26 Thread via GitHub
apoorvmittal10 commented on code in PR #14621: URL: https://github.com/apache/kafka/pull/14621#discussion_r1372948398 ## core/src/test/scala/kafka/metrics/ClientMetricsTestUtils.scala: ## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] KAFKA-15673: Adding client metrics resource types (KIP-714) [kafka]

2023-10-26 Thread via GitHub
apoorvmittal10 commented on code in PR #14621: URL: https://github.com/apache/kafka/pull/14621#discussion_r1372949389 ## core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala: ## @@ -0,0 +1,119 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] KAFKA-15673: Adding client metrics resource types (KIP-714) [kafka]

2023-10-26 Thread via GitHub
apoorvmittal10 commented on code in PR #14621: URL: https://github.com/apache/kafka/pull/14621#discussion_r1372950150 ## core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala: ## @@ -0,0 +1,119 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] KAFKA-15673: Adding client metrics resource types (KIP-714) [kafka]

2023-10-26 Thread via GitHub
apoorvmittal10 commented on PR #14621: URL: https://github.com/apache/kafka/pull/14621#issuecomment-1780865857 > Hi @apoorvmittal10 Thanks for taking my suggestions. I left a few more, mostly about the aesthetic aspect as scala is a pretty idiomatic language... > > Terribly sorry that

[jira] [Updated] (KAFKA-15687) Update host address for the GoupMetadata when replace static members

2023-10-26 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-15687: Summary: Update host address for the GoupMetadata when replace static members (was: Update host address f

[jira] [Created] (KAFKA-15687) Update host address for the GoupMetadata of static members

2023-10-26 Thread Yu Wang (Jira)
Yu Wang created KAFKA-15687: --- Summary: Update host address for the GoupMetadata of static members Key: KAFKA-15687 URL: https://issues.apache.org/jira/browse/KAFKA-15687 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-15687) Update host address for the GoupMetadata when replace static members

2023-10-26 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang updated KAFKA-15687: Description: We are trying to use static membership protocol for our consumers in Kubernetes. When our po

Re: [PR] KAFKA-14517:Implement regex subscriptions [kafka]

2023-10-26 Thread via GitHub
vamossagar12 commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-1780885517 @JimmyWang6 , I think for this part > What if a new topic gets created which matches the regex subscription of some member. we need to use the metadata update mechanism def

Re: [PR] KAFKA-14517:Implement regex subscriptions [kafka]

2023-10-26 Thread via GitHub
vamossagar12 closed pull request #14327: KAFKA-14517:Implement regex subscriptions URL: https://github.com/apache/kafka/pull/14327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] KAFKA-14517:Implement regex subscriptions [kafka]

2023-10-26 Thread via GitHub
JimmyWang6 opened a new pull request, #14327: URL: https://github.com/apache/kafka/pull/14327 This pull request implements the server-side functionality for regex subscriptions in the next generation of the consumer rebalance protocol. For the ConsumerGroupHeartbeat API, the server no

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" & "cache.max.bytes.buffering" with "{statestore.cache}/{input.buffer}.max.bytes"

2023-10-26 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779839#comment-17779839 ] Sagar Rao commented on KAFKA-13152: --- Thanks [~ableegoldman], there are merge conflicts

[jira] [Commented] (KAFKA-15687) Update host address for the GoupMetadata when replace static members

2023-10-26 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779863#comment-17779863 ] Sagar Rao commented on KAFKA-15687: --- Thanks for filing this bug [~LucentWong]. You hav

Re: [PR] KAFKA-15685: added compatibility for MinGW [kafka]

2023-10-26 Thread via GitHub
divijvaidya commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1780956839 What is your Jira ID / Full name? Also to double check, you created an account in Apache Jira, right? The instructions are at https://selfserve.apache.org/jira-account.html -- This

Re: [PR] KAFKA-15661: KIP-951: Server side and protocol changes [kafka]

2023-10-26 Thread via GitHub
msn-tldr commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1373029404 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java: ## @@ -67,20 +69,31 @@ public ProduceResponse(ProduceResponseData produceResponseData)

Re: [PR] KIP-951: protocol changes [kafka]

2023-10-26 Thread via GitHub
msn-tldr commented on PR #14627: URL: https://github.com/apache/kafka/pull/14627#issuecomment-1780966602 @chb2ab CMIIW, but @jolshan i think scope of the PR is just protocol changes, not server-side changes. Intention is to merge the protocol-changes soon, so client-side changes can also be

[jira] [Commented] (KAFKA-15685) Add missing compatibility for MinGW and MSYS2 (windows)

2023-10-26 Thread Rafal Klimonda (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779864#comment-17779864 ] Rafal Klimonda commented on KAFKA-15685: as discussed, please assign this issue

Re: [PR] KAFKA-15685: added compatibility for MinGW [kafka]

2023-10-26 Thread via GitHub
maniekes commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1780967748 yes, i created one. maniekes / Rafal Klimonda. i left comment under this issue so you can easly idenfity me -- This is an automated message from the Apache Git Service. To respond to t

[jira] [Assigned] (KAFKA-15685) Add missing compatibility for MinGW and MSYS2 (windows)

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-15685: Assignee: Rafal Klimonda > Add missing compatibility for MinGW and MSYS2 (windows) >

[jira] [Updated] (KAFKA-15685) Add missing compatibility for MinGW and MSYS2 (windows)

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15685: - Reporter: Rafal Klimonda (was: Divij Vaidya) > Add missing compatibility for MinGW and MSYS2 (w

[jira] [Commented] (KAFKA-15685) Add missing compatibility for MinGW and MSYS2 (windows)

2023-10-26 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779865#comment-17779865 ] Divij Vaidya commented on KAFKA-15685: -- I assigned this to you and in future you sh

Re: [PR] KAFKA-15583: Enforce HWM advance only if partition is not under-min-ISR [kafka]

2023-10-26 Thread via GitHub
mumrah commented on code in PR #14594: URL: https://github.com/apache/kafka/pull/14594#discussion_r1373061403 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1106,6 +1115,12 @@ class Partition(val topicPartition: TopicPartition, * @return true if the HW was incr

Re: [PR] KAFKA-14133: Move StreamsMetricsImplTest to Mockito [kafka]

2023-10-26 Thread via GitHub
clolov commented on code in PR #14623: URL: https://github.com/apache/kafka/pull/14623#discussion_r1373087790 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java: ## @@ -1293,43 +1204,33 @@ private void verifyMetric(final Str

[jira] [Created] (KAFKA-15688) Partition leader election not running when disk IO hangs

2023-10-26 Thread Peter Sinoros-Szabo (Jira)
Peter Sinoros-Szabo created KAFKA-15688: --- Summary: Partition leader election not running when disk IO hangs Key: KAFKA-15688 URL: https://issues.apache.org/jira/browse/KAFKA-15688 Project: Kafka

Re: [PR] KAFKA-15562: ensure commit request manager handles errors correctly [kafka]

2023-10-26 Thread via GitHub
lucasbru commented on code in PR #14639: URL: https://github.com/apache/kafka/pull/14639#discussion_r1373051849 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -148,28 +167,35 @@ Queue unsentOffsetCommitRequests() {

Re: [PR] KAFKA-15562: ensure commit request manager handles errors correctly [kafka]

2023-10-26 Thread via GitHub
lucasbru commented on PR #14639: URL: https://github.com/apache/kafka/pull/14639#issuecomment-1781118953 Thanks @philipnee, I left some comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-26 Thread via GitHub
dajac commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1373214870 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -277,6 +279,22 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PLAI self.isolat

Re: [PR] KIP-951: protocol changes [kafka]

2023-10-26 Thread via GitHub
chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373238109 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -360,7 +360,9 @@ public short partitionRecordVersion() { } public s

Re: [PR] KIP-951: protocol changes [kafka]

2023-10-26 Thread via GitHub
chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373245183 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -102,6 +104,15 @@ "about": "The preferred read replica for the consumer to use on its

Re: [PR] KIP-951: protocol changes [kafka]

2023-10-26 Thread via GitHub
chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373258152 ## clients/src/main/resources/common/message/FetchResponse.json: ## @@ -45,7 +45,9 @@ // Version 14 is the same as version 13 but it also receives a new error called

Re: [PR] KIP-951: protocol changes [kafka]

2023-10-26 Thread via GitHub
chb2ab commented on code in PR #14627: URL: https://github.com/apache/kafka/pull/14627#discussion_r1373265206 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -53,7 +53,9 @@ // // Version 15 adds the ReplicaState which includes new field ReplicaEpoch

Re: [PR] KAFKA-15661: KIP-951: protocol changes [kafka]

2023-10-26 Thread via GitHub
chb2ab commented on PR #14627: URL: https://github.com/apache/kafka/pull/14627#issuecomment-1781250666 I updated the title, this would be a partial implementation of KAFKA-15661. I replied to the other comments as well and incorporated them into https://github.com/apache/kafka/pull/14

Re: [PR] MINOR: Remove ambiguous constructor [kafka]

2023-10-26 Thread via GitHub
kirktrue commented on PR #14598: URL: https://github.com/apache/kafka/pull/14598#issuecomment-1781257814 I would -0.5 this approach. But I won't complain if it gets merged 😄 IMO it's ideal for the internal state of an object to be as completely fleshed out upon constructor completion

[PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

2023-10-26 Thread via GitHub
Owen-CH-Leung opened a new pull request, #14645: URL: https://github.com/apache/kafka/pull/14645 As described in the ticket [KAFKA-15201](https://issues.apache.org/jira/browse/KAFKA-15201), this PR allows the `git push` action to fail gracefully in case of error. ### Committer Checkl

[jira] [Commented] (KAFKA-15201) When git fails, script goes into a loop

2023-10-26 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779931#comment-17779931 ] Owen C.H. Leung commented on KAFKA-15201: - Hi [~divijvaidya] , I've created a PR

[jira] [Created] (KAFKA-15689) KRaftMigrationDriver not logging the skipped event when expected state is wrong

2023-10-26 Thread Paolo Patierno (Jira)
Paolo Patierno created KAFKA-15689: -- Summary: KRaftMigrationDriver not logging the skipped event when expected state is wrong Key: KAFKA-15689 URL: https://issues.apache.org/jira/browse/KAFKA-15689 P

Re: [PR] KAFKA-15689: Logging skipped event when expected migration state is wrong [kafka]

2023-10-26 Thread via GitHub
ppatierno commented on PR #14646: URL: https://github.com/apache/kafka/pull/14646#issuecomment-1781329671 @showuon maybe you can take a look at this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-15689) KRaftMigrationDriver not logging the skipped event when expected state is wrong

2023-10-26 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paolo Patierno updated KAFKA-15689: --- Description: The KRaftMigrationDriver.checkDriverState is used in multiple implementations

Re: [PR] KAFKA-15647: Fix the different behavior in error handling between the old and new group coordinator [kafka]

2023-10-26 Thread via GitHub
dajac commented on code in PR #14589: URL: https://github.com/apache/kafka/pull/14589#discussion_r1373349480 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -4385,15 +4451,39 @@ class KafkaApisTest { .setGroupId("group-3") .setErrorCode(Erro

Re: [PR] MINOR: LeaveGroupResponse v0 - v2 loses its member under certain error conditions [kafka]

2023-10-26 Thread via GitHub
dajac commented on PR #14635: URL: https://github.com/apache/kafka/pull/14635#issuecomment-1781346471 Thanks @wolfchimneyrock. We will take a look into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-15688) Partition leader election not running when disk IO hangs

2023-10-26 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779956#comment-17779956 ] Haruki Okada commented on KAFKA-15688: -- > Is it possible to add such a feature to K

Re: [PR] MINOR: Fix misleading log in streams restoration [kafka]

2023-10-26 Thread via GitHub
mjsax merged PR #14643: URL: https://github.com/apache/kafka/pull/14643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15584: Leader election with ELR [kafka]

2023-10-26 Thread via GitHub
CalvinConfluent commented on PR #14593: URL: https://github.com/apache/kafka/pull/14593#issuecomment-1781378832 @mumrah The failed tests are irrelevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (KAFKA-15690) Flaky integration tests

2023-10-26 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15690: -- Summary: Flaky integration tests Key: KAFKA-15690 URL: https://issues.apache.org/jira/browse/KAFKA-15690 Project: Kafka Issue Type: Bug Reporter: Cal

Re: [PR] KAFKA-15582: Move the clean shutdown file to the storage package [kafka]

2023-10-26 Thread via GitHub
CalvinConfluent commented on PR #14603: URL: https://github.com/apache/kafka/pull/14603#issuecomment-1781399982 @junrao The failed tests are irrelevant. Found some flaky integration tests(they can pass locally but take a long time) https://issues.apache.org/jira/browse/KAFKA-15690 --

Re: [PR] MINOR: Fix misleading log in streams restoration [kafka]

2023-10-26 Thread via GitHub
mjsax commented on PR #14643: URL: https://github.com/apache/kafka/pull/14643#issuecomment-1781402883 Thanks for the fix! Merged to `trunk` and cherry-picked to `3.6` and `3.5` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Created] (KAFKA-15691) Upgrade existing and add new system tests to use new coordinator

2023-10-26 Thread Kirk True (Jira)
Kirk True created KAFKA-15691: - Summary: Upgrade existing and add new system tests to use new coordinator Key: KAFKA-15691 URL: https://issues.apache.org/jira/browse/KAFKA-15691 Project: Kafka I

[jira] [Created] (KAFKA-15692) New integration tests to have full coverage

2023-10-26 Thread Kirk True (Jira)
Kirk True created KAFKA-15692: - Summary: New integration tests to have full coverage Key: KAFKA-15692 URL: https://issues.apache.org/jira/browse/KAFKA-15692 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-15691) Upgrade existing and add new system tests to use new coordinator

2023-10-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15691: -- Labels: kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was: ) > Upgrade existing and add

[jira] [Updated] (KAFKA-15692) New integration tests to have full coverage

2023-10-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15692: -- Description: These are to fix bugs discovered during PR reviews but not tests. > New integration test

[jira] [Updated] (KAFKA-15691) Upgrade existing and add new system tests to use new coordinator

2023-10-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15691: -- Priority: Minor (was: Major) > Upgrade existing and add new system tests to use new coordinator > ---

[jira] [Updated] (KAFKA-15692) New integration tests to have full coverage

2023-10-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15692: -- Priority: Minor (was: Major) > New integration tests to have full coverage >

[jira] [Created] (KAFKA-15693) Disabling scheduled rebalance delay in Connect can lead to indefinitely unassigned connectors and tasks

2023-10-26 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15693: - Summary: Disabling scheduled rebalance delay in Connect can lead to indefinitely unassigned connectors and tasks Key: KAFKA-15693 URL: https://issues.apache.org/jira/browse/KAFK

[jira] [Updated] (KAFKA-15692) New integration tests to have full coverage for end-to-end testing

2023-10-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15692: -- Summary: New integration tests to have full coverage for end-to-end testing (was: New integration tes

[jira] [Created] (KAFKA-15694) New integration tests to have full coverage for preview

2023-10-26 Thread Kirk True (Jira)
Kirk True created KAFKA-15694: - Summary: New integration tests to have full coverage for preview Key: KAFKA-15694 URL: https://issues.apache.org/jira/browse/KAFKA-15694 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-15694) New integration tests to have full coverage for preview

2023-10-26 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15694: -- Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848 kip-848-client-support kip-848-e

[PR] KAFKA-15693: Immediately reassign lost connectors and tasks when scheduled rebalance delay is disabled [kafka]

2023-10-26 Thread via GitHub
C0urante opened a new pull request, #14647: URL: https://github.com/apache/kafka/pull/14647 [Jira](https://issues.apache.org/jira/browse/KAFKA-15693) This change is fairly lightweight: when `scheduled.rebalance.max.delay.ms` is set to `0`, instead of sending out an intentionally-incom

[jira] [Commented] (KAFKA-15693) Disabling scheduled rebalance delay in Connect can lead to indefinitely unassigned connectors and tasks

2023-10-26 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779977#comment-17779977 ] Chris Egerton commented on KAFKA-15693: --- For all affected versions, the most grace

  1   2   3   >