[GitHub] [kafka] rreddy-22 opened a new pull request, #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
rreddy-22 opened a new pull request, #14182: URL: https://github.com/apache/kafka/pull/14182 This module contains code for the implementation of the Optimized Uniform Rack Aware Assignor. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] fvaleri commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

2023-08-10 Thread via GitHub
fvaleri commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1289694241 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Assigned] (KAFKA-15210) Mention vote should be open for at atleast 72 hours

2023-08-10 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-15210: - Assignee: Gantigmaa Selenge > Mention vote should be open for at atleast 72 hou

[jira] [Assigned] (KAFKA-15201) When git fails, script goes into a loop

2023-08-10 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-15201: - Assignee: Gantigmaa Selenge > When git fails, script goes into a loop > ---

[GitHub] [kafka] tinaselenge opened a new pull request, #14183: KAFKA-15210: Mention vote should be open for at atleast 72 hours in the release script

2023-08-10 Thread via GitHub
tinaselenge opened a new pull request, #14183: URL: https://github.com/apache/kafka/pull/14183 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] tinaselenge opened a new pull request, #14184: KAFKA-15201: When git fails, the script goes into a loop

2023-08-10 Thread via GitHub
tinaselenge opened a new pull request, #14184: URL: https://github.com/apache/kafka/pull/14184 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] satishd commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
satishd commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1289750794 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** * Dele

[jira] [Resolved] (KAFKA-14421) OffsetFetchRequest throws NPE Exception

2023-08-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14421. --- Resolution: Resolved Resolved in the later release. > OffsetFetchRequest throws NPE Exception > ---

[GitHub] [kafka] divijvaidya commented on pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-10 Thread via GitHub
divijvaidya commented on PR #14078: URL: https://github.com/apache/kafka/pull/14078#issuecomment-1672790058 Unrelated failures: ``` [Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest.testSyncTopicConfigs()](https://ci-builds.

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-10 Thread via GitHub
divijvaidya commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1289780489 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends BaseProducerSendTest

[GitHub] [kafka] AndrewJSchofield commented on a diff in pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

2023-08-10 Thread via GitHub
AndrewJSchofield commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1288667079 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -119,20 +130,24 @@ public synchronized Cluster fetch() { * @return remaining time

[jira] [Created] (KAFKA-15328) Inter broker partition reassignment triggers offline log dirs randomly

2023-08-10 Thread dgiri (Jira)
dgiri created KAFKA-15328: - Summary: Inter broker partition reassignment triggers offline log dirs randomly Key: KAFKA-15328 URL: https://issues.apache.org/jira/browse/KAFKA-15328 Project: Kafka Iss

[GitHub] [kafka] divijvaidya commented on pull request #14184: KAFKA-15201: When git fails, the script goes into a loop

2023-08-10 Thread via GitHub
divijvaidya commented on PR #14184: URL: https://github.com/apache/kafka/pull/14184#issuecomment-1672871528 Thank you for picking this up @tinaselenge. Can you please help me understand in the description why the script was going in a loop and how does this PR fix it? It would also be nice

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14183: KAFKA-15210: Mention vote should be open for at atleast 72 hours in the release script

2023-08-10 Thread via GitHub
divijvaidya commented on code in PR #14183: URL: https://github.com/apache/kafka/pull/14183#discussion_r1289835715 ## release.py: ## @@ -721,7 +721,7 @@ def select_gpg_key(): Release notes for the %(release_version)s release: https://home.apache.org/~%(apache_id)s/kafka-%(rc_t

[jira] [Commented] (KAFKA-14049) Relax Non Null Requirement for KStreamGlobalKTable Left Join

2023-08-10 Thread Florin Akermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752738#comment-17752738 ] Florin Akermann commented on KAFKA-14049: - Same for me. I simply assigned it to

[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

2023-08-10 Thread via GitHub
divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1672922357 Regarding my previous comment: > where does kraft create topic and alter topic config invoke the validation because we seem to only be changing the controller config validation.

[GitHub] [kafka] kamalcph commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

2023-08-10 Thread via GitHub
kamalcph commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1672925848 > Regarding my previous comment: > > > where does kraft create topic and alter topic config invoke the validation because we seem to only be changing the controller config validati

[GitHub] [kafka] kamalcph commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1289921354 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -231,7 +231,7 @@ class ControllerServer( setMetrics(quorumControllerMetrics). s

[jira] [Created] (KAFKA-15329) Make default `remote.log.metadata.manager.class.name` as topic based RLMM

2023-08-10 Thread Luke Chen (Jira)
Luke Chen created KAFKA-15329: - Summary: Make default `remote.log.metadata.manager.class.name` as topic based RLMM Key: KAFKA-15329 URL: https://issues.apache.org/jira/browse/KAFKA-15329 Project: Kafka

[GitHub] [kafka] satishd commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-10 Thread via GitHub
satishd commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1289928040 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC to

[jira] [Created] (KAFKA-15330) Migration from ZK to KRaft works with 3.4 but fails from 3.5 upwards

2023-08-10 Thread Roland Sommer (Jira)
Roland Sommer created KAFKA-15330: - Summary: Migration from ZK to KRaft works with 3.4 but fails from 3.5 upwards Key: KAFKA-15330 URL: https://issues.apache.org/jira/browse/KAFKA-15330 Project: Kafka

[GitHub] [kafka] kamalcph commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

2023-08-10 Thread via GitHub
kamalcph commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1672992922 @divijvaidya @showuon Added the unit and integration test. Please take another look. Thanks! -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] kamalcph commented on a diff in pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #14176: URL: https://github.com/apache/kafka/pull/14176#discussion_r1289921354 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -231,7 +231,7 @@ class ControllerServer( setMetrics(quorumControllerMetrics). s

[GitHub] [kafka] showuon commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-10 Thread via GitHub
showuon commented on code in PR #14151: URL: https://github.com/apache/kafka/pull/14151#discussion_r1289944769 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {

[GitHub] [kafka] showuon commented on a diff in pull request #14151: KAFKA-15083: add config with "remote.log.metadata" prefix

2023-08-10 Thread via GitHub
showuon commented on code in PR #14151: URL: https://github.com/apache/kafka/pull/14151#discussion_r1289945895 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -913,6 +969,12 @@ private RemoteLogManagerConfig createRLMConfig(Properties props) {

[jira] [Commented] (KAFKA-15330) Migration from ZK to KRaft works with 3.4 but fails from 3.5 upwards

2023-08-10 Thread Roland Sommer (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752771#comment-17752771 ] Roland Sommer commented on KAFKA-15330: --- In addition I did the same tests using 3.

[GitHub] [kafka] tinaselenge commented on pull request #14184: KAFKA-15201: When git fails, the script goes into a loop

2023-08-10 Thread via GitHub
tinaselenge commented on PR #14184: URL: https://github.com/apache/kafka/pull/14184#issuecomment-1673077828 @divijvaidya I'm sorry, I realise this doesn't fix the issue. `cmd` function that executes git push takes optional parameters such as `num_retries` and `allow_failure`. When these are

[jira] [Updated] (KAFKA-15328) Inter broker partition reassignment triggers offline log dirs randomly

2023-08-10 Thread dgiri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dgiri updated KAFKA-15328: -- Description: When running the intra-broker partition reassignments from one disk to another, kafka triggers o

[jira] [Closed] (KAFKA-14707) Possible read error in the Array type caused by insufficient remaining bytes

2023-08-10 Thread Nelson Bighetti (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nelson Bighetti closed KAFKA-14707. --- > Possible read error in the Array type caused by insufficient remaining bytes > ---

[GitHub] [kafka] bachmanity1 commented on pull request #14142: KAFKA-7438: Replace EasyMock with Mockito & remove misleading tests in SessionSto…

2023-08-10 Thread via GitHub
bachmanity1 commented on PR #14142: URL: https://github.com/apache/kafka/pull/14142#issuecomment-1673143048 It looks like test failures are not related to this PR. ``` Build / JDK 11 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() – org.apache.kafka.connect.mirror.integr

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-10 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290107019 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-10 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290120601 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-10 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290124230 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14183: KAFKA-15210: Mention vote should be open for at atleast 72 hours in the release script

2023-08-10 Thread via GitHub
tinaselenge commented on code in PR #14183: URL: https://github.com/apache/kafka/pull/14183#discussion_r1290156210 ## release.py: ## @@ -721,7 +721,7 @@ def select_gpg_key(): Release notes for the %(release_version)s release: https://home.apache.org/~%(apache_id)s/kafka-%(rc_t

[GitHub] [kafka] vveicc opened a new pull request, #14185: KAFKA-15287: Change NodeApiVersions.create() to support kraft

2023-08-10 Thread via GitHub
vveicc opened a new pull request, #14185: URL: https://github.com/apache/kafka/pull/14185 - Change NodeApiVersions.create() to support kraft - Change ApiKeysTest to support kraft - Change ApiVersionsResponseTest to support kraft ### Committer Checklist (excluded from commit messa

[GitHub] [kafka] kamalcph commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

2023-08-10 Thread via GitHub
kamalcph commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1673418121 We have added sufficient validations while creating/updating the topic. If the user didn't override the `local.retention.bytes`, `retention.bytes`, `retention.ms` or `local.retention.ms`

[jira] [Updated] (KAFKA-15327) Async consumer should commit offsets on close

2023-08-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15327: --- Description: In the current implementation of the KafkaConsumer, the ConsumerCoordinator co

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290329358 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** * Del

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290329055 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -558,17 +574,38 @@ class ReplicaManager(val config: KafkaConfig, } partitionsToDelete

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290338684 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -558,17 +574,38 @@ class ReplicaManager(val config: KafkaConfig, } partitionsToDelete

[jira] [Created] (KAFKA-15331) Handle remote log enabled topic deletion when leader is not available

2023-08-10 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-15331: Summary: Handle remote log enabled topic deletion when leader is not available Key: KAFKA-15331 URL: https://issues.apache.org/jira/browse/KAFKA-15331

[jira] [Updated] (KAFKA-15331) Handle remote log enabled topic deletion when leader is not available

2023-08-10 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15331: - Parent: KAFKA-7739 Issue Type: Sub-task (was: Task) > Handle remote log

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290341929 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -478,7 +481,8 @@ class ReplicaManager(val config: KafkaConfig, if (requestLeaderEpoch ==

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290366372 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -558,17 +574,38 @@ class ReplicaManager(val config: KafkaConfig, } partitionsToDelete

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290369199 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** * Del

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290376710 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** * Del

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-10 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1290377829 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -343,21 +345,78 @@ public void onLeadershipChange(Set partitionsBecomeLeader, /** * Del

[GitHub] [kafka] mimaison commented on a diff in pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

2023-08-10 Thread via GitHub
mimaison commented on code in PR #13204: URL: https://github.com/apache/kafka/pull/13204#discussion_r1290277580 ## tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] gharris1727 commented on pull request #14159: Kafka 15291 connect plugins implement versioned

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14159: URL: https://github.com/apache/kafka/pull/14159#issuecomment-1673635408 Flaky test failures appear unrelated, and tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (KAFKA-15291) Implement Versioned interfaces in common Connect plugins

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15291. - Resolution: Fixed > Implement Versioned interfaces in common Connect plugins > -

[GitHub] [kafka] gharris1727 merged pull request #14159: Kafka 15291 connect plugins implement versioned

2023-08-10 Thread via GitHub
gharris1727 merged PR #14159: URL: https://github.com/apache/kafka/pull/14159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290486200 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290445388 ## docs/streams/architecture.html: ## @@ -167,6 +167,14 @@ Kafka Streams Developer Guide section. + +There is also a client side config client.rack whi

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290489338 ## docs/streams/developer-guide/config-streams.html: ## @@ -718,6 +760,24 @@ rack.aware.assignment.tags +rack.aware.assignment.traffic_cost + +

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290445751 ## docs/streams/architecture.html: ## @@ -167,6 +167,14 @@ Kafka Streams Developer Guide section. + +There is also a client side config client.rack whi

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290483313 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290489521 ## docs/streams/developer-guide/config-streams.html: ## @@ -718,6 +760,24 @@ rack.aware.assignment.tags +rack.aware.assignment.traffic_cost + +

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290485321 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[jira] [Created] (KAFKA-15332) Eligible Leader Replicas

2023-08-10 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15332: -- Summary: Eligible Leader Replicas Key: KAFKA-15332 URL: https://issues.apache.org/jira/browse/KAFKA-15332 Project: Kafka Issue Type: New Feature Repo

[GitHub] [kafka] C0urante opened a new pull request, #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante opened a new pull request, #14186: URL: https://github.com/apache/kafka/pull/14186 [Jira](https://issues.apache.org/jira/browse/KAFKA-14682) Our Jenkinsfile is currently configured to do testing with the `unitTest` and `integrationTest` tasks, instead of the `test` task. Thes

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290482358 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] cmccabe merged pull request #14050: KAFKA-15220: Do not returned fenced brokers from getAliveBrokerNode

2023-08-10 Thread via GitHub
cmccabe merged PR #14050: URL: https://github.com/apache/kafka/pull/14050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] mjsax commented on a diff in pull request #14181: KAFKA-15022: [10/N] docs for rack aware assignor

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14181: URL: https://github.com/apache/kafka/pull/14181#discussion_r1290483692 ## docs/streams/developer-guide/config-streams.html: ## @@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and serializ

[GitHub] [kafka] C0urante commented on pull request #14186: KAFKA-14682: Report Mockito unused stubbings during Jenkins build

2023-08-10 Thread via GitHub
C0urante commented on PR #14186: URL: https://github.com/apache/kafka/pull/14186#issuecomment-1673671924 I've opened this as a draft request to demonstrate that unused stubbings will be successfully reported with the proposed change to the Jenkinsfile. Once the build fails successfully (🙃),

[GitHub] [kafka] jolshan commented on a diff in pull request #14138: Fix a race when query isUnderMinIsr

2023-08-10 Thread via GitHub
jolshan commented on code in PR #14138: URL: https://github.com/apache/kafka/pull/14138#discussion_r1290546194 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -798,6 +803,12 @@ class Partition(val topicPartition: TopicPartition, // to maintain the decision mak

[jira] [Created] (KAFKA-15333) Flaky build failure throwing Connect Exception: Could not connect to server....

2023-08-10 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15333: -- Summary: Flaky build failure throwing Connect Exception: Could not connect to server Key: KAFKA-15333 URL: https://issues.apache.org/jira/browse/KAFKA-15333 Project:

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] C0urante commented on a diff in pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14064: URL: https://github.com/apache/kafka/pull/14064#discussion_r1290570863 ## tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java: ## @@ -0,0 +1,559 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] gharris1727 commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1673813076 System test failures appear to be due to reasons other than classloading/dependency issues. The producer performance tests appear to work normally. ``` tests/kafkatest/tests/co

[GitHub] [kafka] kirktrue commented on pull request #13908: KAFKA-15052 Fix the flaky testBalancePartitionLeaders - part II

2023-08-10 Thread via GitHub
kirktrue commented on PR #13908: URL: https://github.com/apache/kafka/pull/13908#issuecomment-1673815636 @divijvaidya Can you review this with an eye to merging it? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] kirktrue commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-10 Thread via GitHub
kirktrue commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673817790 @gharris1727 Thanks for your work on this! Hopefully it will help KAFKA-15197 too! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax commented on a diff in pull request #14103: HOTIFX: fix Kafka Streams upgrade path from 3.4 to 3.5

2023-08-10 Thread via GitHub
mjsax commented on code in PR #14103: URL: https://github.com/apache/kafka/pull/14103#discussion_r1290589930 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -947,9 +947,15 @@ public String toString() { } public static class ValidString i

[GitHub] [kafka] C0urante commented on a diff in pull request #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14068: URL: https://github.com/apache/kafka/pull/14068#discussion_r1290620328 ## docs/connect.html: ## @@ -543,6 +543,67 @@ ACL requirements +Plugin Discovery + +Plugin discovery is the name for the strategy which the

[GitHub] [kafka] florin-akermann opened a new pull request, #14187: KAFKA-13197: fix GlobalKTable join/left-join semantics documentation.

2023-08-10 Thread via GitHub
florin-akermann opened a new pull request, #14187: URL: https://github.com/apache/kafka/pull/14187 The documentation for join/left-join Kstream-GlobalKtable is out dated: The left hand side key may be null. Note that the second statement mentioned in the Jira https://issues.apache.or

[GitHub] [kafka] gharris1727 commented on pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14064: URL: https://github.com/apache/kafka/pull/14064#issuecomment-1673833354 > We may choose to report broken plugin locations (i.e., any that has one or more unloadable plugins), but IMO it's better to leave this info out entirely. We have room to maneuver in

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-08-10 Thread via GitHub
gharris1727 commented on code in PR #14064: URL: https://github.com/apache/kafka/pull/14064#discussion_r1290624348 ## tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java: ## @@ -0,0 +1,559 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] C0urante commented on a diff in pull request #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14068: URL: https://github.com/apache/kafka/pull/14068#discussion_r1290624547 ## docs/connect.html: ## @@ -543,6 +543,67 @@ ACL requirements +Plugin Discovery + +Plugin discovery is the name for the strategy which the

[GitHub] [kafka] C0urante commented on a diff in pull request #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14068: URL: https://github.com/apache/kafka/pull/14068#discussion_r1290627899 ## docs/connect.html: ## @@ -543,6 +543,67 @@ ACL requirements +Plugin Discovery + +Plugin discovery is the name for the strategy which the

[GitHub] [kafka] C0urante commented on a diff in pull request #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14068: URL: https://github.com/apache/kafka/pull/14068#discussion_r1290629836 ## docs/connect.html: ## @@ -543,6 +543,67 @@ ACL requirements +Plugin Discovery + +Plugin discovery is the name for the strategy which the

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-10 Thread via GitHub
jeffkbkim commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1290585581 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java: ## @@ -0,0 +1,396 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] gharris1727 commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673859231 I saw one of the CI builds with testOffsetTranslationBehindReplicationFlow failing, so I think there is still another source of flakiness somewhere. I'll close the fix JIRA but leave

[GitHub] [kafka] C0urante commented on a diff in pull request #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14082: URL: https://github.com/apache/kafka/pull/14082#discussion_r1290641476 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java: ## @@ -43,6 +47,11 @@ public void configure(Map props) {

[GitHub] [kafka] gharris1727 commented on pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-10 Thread via GitHub
gharris1727 commented on PR #14156: URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673861990 The latest CI run has some unrelated flakiness, and tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] gharris1727 merged pull request #14156: KAFKA-15202: Fix MM2 offset translation when syncs are variably spaced

2023-08-10 Thread via GitHub
gharris1727 merged PR #14156: URL: https://github.com/apache/kafka/pull/14156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] rittikaadhikari commented on pull request #13503: MINOR: Refactor TierStateMachine related tests into a separate test file

2023-08-10 Thread via GitHub
rittikaadhikari commented on PR #13503: URL: https://github.com/apache/kafka/pull/13503#issuecomment-1673867152 @junrao Thanks for the review! I have addressed the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] C0urante commented on a diff in pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14102: URL: https://github.com/apache/kafka/pull/14102#discussion_r1290659476 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3929,543 +3008,636 @@ public void testPollDurationOnS

[GitHub] [kafka] C0urante commented on a diff in pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

2023-08-10 Thread via GitHub
C0urante commented on code in PR #14102: URL: https://github.com/apache/kafka/pull/14102#discussion_r1290658873 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3872,7 +2952,7 @@ public void testVerifyTaskGeneration

[GitHub] [kafka] C0urante commented on pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

2023-08-10 Thread via GitHub
C0urante commented on PR #14102: URL: https://github.com/apache/kafka/pull/14102#issuecomment-1673896029 I should note that because this test makes heavy use of Mockito's strict stubbing feature, I've opened https://github.com/apache/kafka/pull/14186 to enable reporting of unused stubbings

[GitHub] [kafka] C0urante merged pull request #14102: KAFKA-13187: Replace EasyMock / PowerMock with Mockito in DistributedHerderTest

2023-08-10 Thread via GitHub
C0urante merged PR #14102: URL: https://github.com/apache/kafka/pull/14102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-13187) Replace EasyMock and PowerMock with Mockito for DistributedHerderTest

2023-08-10 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13187. --- Fix Version/s: 3.6.0 Resolution: Done > Replace EasyMock and PowerMock with Mockito f

[jira] [Updated] (KAFKA-15202) MM2 OffsetSyncStore clears too many syncs when sync spacing is variable

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15202: Fix Version/s: 3.3.3 3.4.2 3.5.2 > MM2 OffsetSyncStore clear

[jira] [Updated] (KAFKA-15202) MM2 OffsetSyncStore clears too many syncs when sync spacing is variable

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15202: Affects Version/s: 3.5.1 (was: 3.3.3) > MM2 OffsetSyncStore clears too

[GitHub] [kafka] gharris1727 merged pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-10 Thread via GitHub
gharris1727 merged PR #14092: URL: https://github.com/apache/kafka/pull/14092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[jira] [Resolved] (KAFKA-15239) producerPerformance system test for old client failed after v3.5.0

2023-08-10 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15239. - Fix Version/s: 3.6.0 Reviewer: Greg Harris Resolution: Fixed > producerPerforman

  1   2   >