Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1643386529
Hi @cmccabe @mimaison @divijvaidya Any further updates on nightly job
enablement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
jeqo commented on code in PR #14045:
URL: https://github.com/apache/kafka/pull/14045#discussion_r1269038188
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##
@@ -182,13 +182,12 @@ private CompletableFuture
s
nizhikov commented on PR #13278:
URL: https://github.com/apache/kafka/pull/13278#issuecomment-1643445734
@mimaison I reworked `parseOffsetJsonStringWithoutDedup` to return
`Map>`.
Now, Tuple class eliminated from PR. Please, review.
--
This is an automated message from the Apache Git S
dajac commented on PR #14053:
URL: https://github.com/apache/kafka/pull/14053#issuecomment-1643446391
@CalvinConfluent Thanks for the PR. There is indeed something fishy here.
Could you please try to better explain the race condition in the description?
My understanding is that we may pick
dajac commented on code in PR #14053:
URL: https://github.com/apache/kafka/pull/14053#discussion_r1269075133
##
core/src/main/scala/kafka/cluster/Replica.scala:
##
@@ -98,31 +101,39 @@ class Replica(val brokerId: Int, val topicPartition:
TopicPartition) extends Log
* fetch
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1643452195
@Vaibhav-Nazare The KIP needs to be voted. So far you've only started a
discussion. I'd recommend replying to the discussion thread to ask for any more
feedback, otherwise you can start
dajac commented on code in PR #14053:
URL: https://github.com/apache/kafka/pull/14053#discussion_r1269078528
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -858,13 +858,22 @@ class Partition(val topicPartition: TopicPartition,
// No need to calculate low waterm
[
https://issues.apache.org/jira/browse/KAFKA-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744943#comment-17744943
]
zhangzhisheng commented on KAFKA-13303:
---
its's ture that RoundRobinPartitioner lea
[
https://issues.apache.org/jira/browse/KAFKA-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744944#comment-17744944
]
zhangzhisheng commented on KAFKA-9965:
--
(y)
> Uneven distribution with RoundRobinPa
Owen-CH-Leung opened a new pull request, #14057:
URL: https://github.com/apache/kafka/pull/14057
Prepend the offset information to the filename.
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x] Verify test coverage and CI build
[
https://issues.apache.org/jira/browse/KAFKA-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744947#comment-17744947
]
zhangzhisheng commented on KAFKA-9964:
--
it's bug, pls follow RoundRobinPartitioner b
[
https://issues.apache.org/jira/browse/KAFKA-9964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744947#comment-17744947
]
zhangzhisheng edited comment on KAFKA-9964 at 7/20/23 8:41 AM:
dajac commented on PR #14046:
URL: https://github.com/apache/kafka/pull/14046#issuecomment-1643522968
@jolshan I was actually thinking about the `AuthorizerIntegrationTest`
failures overnight and I found an issue with the `latestVersionUnstable` flag.
Let me try to explain.
The `late
muralibasani commented on PR #13417:
URL: https://github.com/apache/kafka/pull/13417#issuecomment-1643531272
> Thanks @muralibasani, let me know when you are ready for another review.
@fvaleri made the necessary changes I believe. Pls take a look. Thanks.
--
This is an automated mes
cadonna commented on code in PR #13931:
URL: https://github.com/apache/kafka/pull/13931#discussion_r1265659668
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java:
##
@@ -93,13 +99,19 @@
import static org.junit.Assert.assertFalse;
imp
dajac commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1269152813
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -386,6 +386,18 @@ public short groupMetadataValueVersion() {
}
}
dajac commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1269155972
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
dajac commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1269156330
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java:
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
cadonna commented on code in PR #13983:
URL: https://github.com/apache/kafka/pull/13983#discussion_r1269179717
##
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##
@@ -133,77 +112,69 @@ public class StreamsResetter {
+ "*** Warning! This tool makes
cadonna commented on code in PR #13983:
URL: https://github.com/apache/kafka/pull/13983#discussion_r1269179717
##
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##
@@ -133,77 +112,69 @@ public class StreamsResetter {
+ "*** Warning! This tool makes
satishd commented on code in PR #14045:
URL: https://github.com/apache/kafka/pull/14045#discussion_r1269184601
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -353,4 +358,10 @@ public void close() {
}
}
divijvaidya commented on code in PR #14057:
URL: https://github.com/apache/kafka/pull/14057#discussion_r1269189609
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageTest.java:
##
@@ -399,20 +403,21 @@ public Verifier(final LocalTieredStorage r
divijvaidya commented on PR #14040:
URL: https://github.com/apache/kafka/pull/14040#issuecomment-1643579946
Unrelated test failures. Merging this in.
```
[Build / JDK 20 and Scala 2.13 /
org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()](https://ci-buil
divijvaidya merged PR #14040:
URL: https://github.com/apache/kafka/pull/14040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
[
https://issues.apache.org/jira/browse/KAFKA-15212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya resolved KAFKA-15212.
--
Reviewer: Divij Vaidya
Resolution: Fixed
> Remove unneeded classgraph license file
> ---
vamossagar12 commented on code in PR #13983:
URL: https://github.com/apache/kafka/pull/13983#discussion_r1269194729
##
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##
@@ -133,77 +112,69 @@ public class StreamsResetter {
+ "*** Warning! This tool
divijvaidya commented on PR #14032:
URL: https://github.com/apache/kafka/pull/14032#issuecomment-1643590831
Interestingly the failure rate has gone down today. I guess we will
encounter it every time we upgrade gradle?! Let's wait and observer for another
24 hours.
Separately, upgrad
hudeqi opened a new pull request, #14058:
URL: https://github.com/apache/kafka/pull/14058
This pr is used to remove the metrics in log when broker shutdown.
This pr has passed the corresponding unit test, and it is part of
[KAFKA-15129](https://issues.apache.org/jira/browse/KAFKA-15129).
dajac commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1269199183
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java:
##
@@ -52,33 +42,22 @@ public Map members() {
return members;
vamossagar12 commented on code in PR #14051:
URL: https://github.com/apache/kafka/pull/14051#discussion_r1269230642
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -998,7 +998,13 @@ class Partition(val topicPartition: TopicPartition,
// 3. Its metadata cached
vamossagar12 commented on PR #14051:
URL: https://github.com/apache/kafka/pull/14051#issuecomment-1643633746
Thanks @showuon I did consider writing a test but felt since this is looks
like a race condition i.e fetch request from follower coming in around the
same time the `remoteReplicasMa
[
https://issues.apache.org/jira/browse/KAFKA-12525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao resolved KAFKA-12525.
---
Resolution: Fixed
> Inaccurate task status due to status record interleaving in fast rebalances
> i
fvaleri opened a new pull request, #14059:
URL: https://github.com/apache/kafka/pull/14059
Added --bootstrap-sever to align with other tools, --broker-list is now
deprecated. Added warnings for all deprecated options, that will be removed in
the next major release. Updated replica_verificat
fvaleri commented on code in PR #13983:
URL: https://github.com/apache/kafka/pull/13983#discussion_r1269261271
##
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##
@@ -133,77 +112,69 @@ public class StreamsResetter {
+ "*** Warning! This tool makes
fvaleri commented on code in PR #13983:
URL: https://github.com/apache/kafka/pull/13983#discussion_r1269261271
##
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##
@@ -133,77 +112,69 @@ public class StreamsResetter {
+ "*** Warning! This tool makes
[
https://issues.apache.org/jira/browse/KAFKA-15218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao reassigned KAFKA-15218:
-
Assignee: Sagar Rao
> NPE will be thrown while deleting topic and fetch from follower concurren
vamossagar12 commented on code in PR #13983:
URL: https://github.com/apache/kafka/pull/13983#discussion_r1269262979
##
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##
@@ -133,77 +112,69 @@ public class StreamsResetter {
+ "*** Warning! This tool
Said BOUDJELDA created KAFKA-15222:
--
Summary: Upgrade zinc scala incremental compiler plugin version to
a latests stable fit version
Key: KAFKA-15222
URL: https://issues.apache.org/jira/browse/KAFKA-15222
[
https://issues.apache.org/jira/browse/KAFKA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15222:
---
Summary: Upgrade zinc scala incremental compiler plugin version to a
latests stable fit vers
bmscomp opened a new pull request, #14060:
URL: https://github.com/apache/kafka/pull/14060
The existing version of zinc incremental scala compiler plugin is getting a
bit old, upgrading to last stable version 1.9.2
### Committer Checklist (excluded from commit message)
- [x] Ve
showuon commented on PR #13983:
URL: https://github.com/apache/kafka/pull/13983#issuecomment-1643688414
Failed tests are unrelated:
```
Build / JDK 17 and Scala 2.13 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindRepl
showuon merged PR #13983:
URL: https://github.com/apache/kafka/pull/13983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mimaison commented on code in PR #14005:
URL: https://github.com/apache/kafka/pull/14005#discussion_r1269268948
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java:
##
@@ -65,27 +72,170 @@ static String encodeTopicPartition(TopicPartition
topicParti
[
https://issues.apache.org/jira/browse/KAFKA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745034#comment-17745034
]
Said BOUDJELDA commented on KAFKA-15222:
I made a small pull request for this Ji
[
https://issues.apache.org/jira/browse/KAFKA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Said BOUDJELDA updated KAFKA-15222:
---
Docs Text:
Upgrading the version of zinc incremental scala compiler plugin, is far a good
i
jeqo commented on code in PR #14045:
URL: https://github.com/apache/kafka/pull/14045#discussion_r1269305190
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -353,4 +358,10 @@ public void close() {
}
}
bmscomp opened a new pull request, #14061:
URL: https://github.com/apache/kafka/pull/14061
Adding the value 20 to the JDK version that can build Apache Kafka into
README.md
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [x]
divijvaidya commented on PR #14060:
URL: https://github.com/apache/kafka/pull/14060#issuecomment-1643732810
Please add link to release notes explaining the difference amongst version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
bmscomp commented on PR #14060:
URL: https://github.com/apache/kafka/pull/14060#issuecomment-1643741474
@divijvaidya I am working on it right now, I have a good resource
https://github.com/sbt/zinc/compare/v1.8.0...v1.9.2
--
This is an automated message from the Apache Git Service.
To re
kaushik srinivas created KAFKA-15223:
Summary: Need clarity in documentation for upgrade/downgrade
across releases.
Key: KAFKA-15223
URL: https://issues.apache.org/jira/browse/KAFKA-15223
Project:
[
https://issues.apache.org/jira/browse/KAFKA-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kaushik srinivas updated KAFKA-15223:
-
Summary: Need more clarity in documentation for upgrade/downgrade
procedures and limitat
[
https://issues.apache.org/jira/browse/KAFKA-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kaushik srinivas updated KAFKA-15223:
-
Description:
Referring to the upgrade documentation for apache kafka.
[https://kafka.ap
[
https://issues.apache.org/jira/browse/KAFKA-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kaushik srinivas updated KAFKA-15223:
-
Affects Version/s: 3.4.1
3.5.0
3.3.2
dajac commented on code in PR #14017:
URL: https://github.com/apache/kafka/pull/14017#discussion_r1269398879
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2643,9 +2652,175 @@ private CoordinatorResult
updateStaticMemberA
dajac commented on code in PR #14017:
URL: https://github.com/apache/kafka/pull/14017#discussion_r1269401629
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2643,9 +2652,175 @@ private CoordinatorResult
updateStaticMemberA
bmscomp commented on PR #14060:
URL: https://github.com/apache/kafka/pull/14060#issuecomment-1643853720
The current pull request CI, the errors related to zinc appeared again in
current Jenkins build, rebasing the branch again will run the build again, the
strange behaviour is that the rela
Owen-CH-Leung commented on code in PR #14057:
URL: https://github.com/apache/kafka/pull/14057#discussion_r1269422337
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageTest.java:
##
@@ -399,20 +403,21 @@ public Verifier(final LocalTieredStorage
Owen-CH-Leung commented on code in PR #14057:
URL: https://github.com/apache/kafka/pull/14057#discussion_r1269422337
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorageTest.java:
##
@@ -399,20 +403,21 @@ public Verifier(final LocalTieredStorage
Divij Vaidya created KAFKA-15224:
Summary: Automate version change to snapshot
Key: KAFKA-15224
URL: https://issues.apache.org/jira/browse/KAFKA-15224
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15224:
-
Description:
We require changing to SNAPSHOT version as part of the release process [1]. The
sp
[
https://issues.apache.org/jira/browse/KAFKA-15200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15200:
-
Description:
At the start of release.py, the first thing it should do is verify that
dependency
cadonna commented on PR #13942:
URL: https://github.com/apache/kafka/pull/13942#issuecomment-1643982125
Build failures are unrelated:
```
Build / JDK 20 and Scala 2.13 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehi
cadonna merged PR #13942:
URL: https://github.com/apache/kafka/pull/13942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
C0urante merged PR #14044:
URL: https://github.com/apache/kafka/pull/14044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
C0urante merged PR #14041:
URL: https://github.com/apache/kafka/pull/14041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14669:
--
Priority: Major (was: Blocker)
> Include MirrorMaker connector configurations in docs
> -
[
https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-14669.
---
Resolution: Done
> Include MirrorMaker connector configurations in docs
> --
[
https://issues.apache.org/jira/browse/KAFKA-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-15216:
--
Fix Version/s: 3.5.2
> InternalSinkRecord::newRecord method ignores the headers argument
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-15216:
--
Fix Version/s: 3.4.2
> InternalSinkRecord::newRecord method ignores the headers argument
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-15216:
--
Fix Version/s: 3.3.3
> InternalSinkRecord::newRecord method ignores the headers argument
> ---
yashmayya commented on PR #14024:
URL: https://github.com/apache/kafka/pull/14024#issuecomment-1644061803
Thanks Chris, I've rebased this on the latest `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
bmscomp commented on PR #14060:
URL: https://github.com/apache/kafka/pull/14060#issuecomment-1644078470
@It's ok now, things seems more stable, but there is some failure on
building kafak with jdk 20 that has no relation with zinc compiler,
Notice that for all build the retry_zinc st
gharris1727 commented on PR #13313:
URL: https://github.com/apache/kafka/pull/13313#issuecomment-1644151941
I ran a full system test run:
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.11.3
divijvaidya commented on code in PR #14057:
URL: https://github.com/apache/kafka/pull/14057#discussion_r1269646588
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentFileset.java:
##
@@ -59,9 +59,9 @@
* the local tiered storage:
*
*
- * /
gharris1727 commented on PR #13313:
URL: https://github.com/apache/kafka/pull/13313#issuecomment-1644153313
@ijuma Could you take another look at this? This is blocking KIP-898 that
I'm trying to get landed in time for 3.6.0. Thanks!
--
This is an automated message from the Apache Git Ser
rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1269665264
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java:
##
@@ -52,33 +42,22 @@ public Map members() {
return memb
divijvaidya merged PR #13874:
URL: https://github.com/apache/kafka/pull/13874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
junrao commented on PR #13990:
URL: https://github.com/apache/kafka/pull/13990#issuecomment-1644221461
@kirktrue : It seems there were 4 test failures for jdk 11. But the tests
for jdk 17 and 20 were aborted. Do you know why?
--
This is an automated message from the Apache Git Service.
To
mumrah opened a new pull request, #14062:
URL: https://github.com/apache/kafka/pull/14062
The number of arguments for KRaftMigrationDriver has grown rather large and
there are already two constructors. This PR refactors the class to have a
single package-private constructor and a builder th
mumrah commented on code in PR #14046:
URL: https://github.com/apache/kafka/pull/14046#discussion_r1269710067
##
clients/src/main/java/org/apache/kafka/common/errors/StaleMemberEpochException.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
jolshan commented on code in PR #14046:
URL: https://github.com/apache/kafka/pull/14046#discussion_r1269711912
##
clients/src/main/resources/common/message/OffsetCommitRequest.json:
##
@@ -31,13 +31,19 @@
// version 7 adds a new field called groupInstanceId to indicate member
mumrah commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1269713183
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(
jolshan commented on PR #14046:
URL: https://github.com/apache/kafka/pull/14046#issuecomment-1644264091
> @jolshan I was actually thinking about the AuthorizerIntegrationTest
failures overnight and I found an issue with the latestVersionUnstable flag.
Let me try to explain.
I was cur
dajac commented on code in PR #14046:
URL: https://github.com/apache/kafka/pull/14046#discussion_r1269732280
##
clients/src/main/resources/common/message/OffsetCommitRequest.json:
##
@@ -31,13 +31,19 @@
// version 7 adds a new field called groupInstanceId to indicate member
dajac commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1269737507
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(
dajac commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1269744467
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(
dajac commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1269744467
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(
jolshan commented on PR #14046:
URL: https://github.com/apache/kafka/pull/14046#issuecomment-1644292908
Looking at the tests `[Build / JDK 20 and Scala 2.13 /
kafka.server.FetchRequestTest.testCurrentEpochValidationV12()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14046/7/tes
msn-tldr opened a new pull request, #14063:
URL: https://github.com/apache/kafka/pull/14063
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
rreddy-22 commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1644359975
Looks good to me! Thanks @flashmouse for the changes and replies! @dajac is
a committer so he'll give the final approval!
--
This is an automated message from the Apache Git Service.
dajac commented on code in PR #14047:
URL: https://github.com/apache/kafka/pull/14047#discussion_r1269799340
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -467,6 +471,72 @@ public static Record newEmptyGroupMetadataRecord(
David Jacot created KAFKA-15225:
---
Summary: Define constants for record types
Key: KAFKA-15225
URL: https://issues.apache.org/jira/browse/KAFKA-15225
Project: Kafka
Issue Type: Sub-task
rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1269837065
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Softw
rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1269846580
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Softw
Greg Harris created KAFKA-15226:
---
Summary: System tests for plugin.discovery worker configuration
Key: KAFKA-15226
URL: https://issues.apache.org/jira/browse/KAFKA-15226
Project: Kafka
Issue Ty
Greg Harris created KAFKA-15227:
---
Summary: Use plugin.discovery=SERVICE_LOAD in all plugin test
suites
Key: KAFKA-15227
URL: https://issues.apache.org/jira/browse/KAFKA-15227
Project: Kafka
Is
gharris1727 merged PR #13313:
URL: https://github.com/apache/kafka/pull/13313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
gharris1727 commented on PR #13313:
URL: https://github.com/apache/kafka/pull/13313#issuecomment-1644520071
Thanks for your help Ismael!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
C0urante commented on code in PR #14005:
URL: https://github.com/apache/kafka/pull/14005#discussion_r1269901272
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java:
##
@@ -597,7 +596,9 @@ private Set listPartitions(
Admi
rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1269927386
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Softw
1 - 100 of 153 matches
Mail list logo
