[
https://issues.apache.org/jira/browse/KAFKA-14849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zou shengfu updated KAFKA-14849:
Description:
# At first, we modify the group.instance.id for consumers wrongly, so different
cons
viktorsomogyi merged PR #13441:
URL: https://github.com/apache/kafka/pull/13441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
cadonna commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1149019632
##
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java:
##
@@ -16,7 +16,7 @@
*/
package org.apache.kafka.streams.tools;
-import kafka.too
Luke Chen created KAFKA-14850:
-
Summary: Introduce InMemoryLeaderEpochCheckpoint to allow quick
write/read
Key: KAFKA-14850
URL: https://issues.apache.org/jira/browse/KAFKA-14850
Project: Kafka
showuon opened a new pull request, #13456:
URL: https://github.com/apache/kafka/pull/13456
Introduce `InMemoryLeaderEpochCheckpoint` to allow quick read/write
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage
cadonna commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1484819384
I restarted the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
rajinisivaram commented on code in PR #13350:
URL: https://github.com/apache/kafka/pull/13350#discussion_r1149063073
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -519,13 +641,14 @@ Map> build() {
return assi
rajinisivaram commented on code in PR #13350:
URL: https://github.com/apache/kafka/pull/13350#discussion_r1149064166
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -574,6 +697,42 @@ private void assignOwnedPartitions() {
rajinisivaram commented on PR #13350:
URL: https://github.com/apache/kafka/pull/13350#issuecomment-1484836832
@dajac Thanks for the initial review, have addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
showuon opened a new pull request, #13457:
URL: https://github.com/apache/kafka/pull/13457
1. remote `remoteStorageManager` parameter in UnifiedLog because
remoteStorageManager needs wait for logManager got started before it can be
initialized. And the `UnifiedLog` is created/initialized in
chia7712 commented on PR #13326:
URL: https://github.com/apache/kafka/pull/13326#issuecomment-1484917669
failed test is traced by #13452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
chia7712 merged PR #13326:
URL: https://github.com/apache/kafka/pull/13326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-14774.
Fix Version/s: 3.5.0
Resolution: Fixed
> the removed listeners should not be reconf
yashmayya commented on code in PR #13453:
URL: https://github.com/apache/kafka/pull/13453#discussion_r1149108767
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java:
##
@@ -596,7 +596,11 @@ private void readTaskStatus(String key, byte[]
chia7712 commented on code in PR #13452:
URL: https://github.com/apache/kafka/pull/13452#discussion_r1149136794
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchConfig.java:
##
@@ -101,8 +103,8 @@ public FetchConfig(ConsumerConfig config,
this.m
[
https://issues.apache.org/jira/browse/KAFKA-14851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-14851:
--
Priority: Minor (was: Major)
> Move StreamResetterTest to tools module
>
[
https://issues.apache.org/jira/browse/KAFKA-14851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao updated KAFKA-14851:
--
Description: This came up as a suggestion here:
https://github.com/apache/kafka/pull/13127#discussion_
Sagar Rao created KAFKA-14851:
-
Summary: Move StreamResetterTest to tools module
Key: KAFKA-14851
URL: https://issues.apache.org/jira/browse/KAFKA-14851
Project: Kafka
Issue Type: Sub-task
vamossagar12 commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1149149145
##
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java:
##
@@ -16,7 +16,7 @@
*/
package org.apache.kafka.streams.tools;
-import kafk
yashmayya commented on code in PR #13453:
URL: https://github.com/apache/kafka/pull/13453#discussion_r1149123939
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java:
##
@@ -596,7 +596,11 @@ private void readTaskStatus(String key, byte[]
cadonna commented on code in PR #13269:
URL: https://github.com/apache/kafka/pull/13269#discussion_r1149189233
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1699,7 +1705,8 @@ public void
shouldReturnOffsetsForRepartitionTopics
pierDipi commented on code in PR #13325:
URL: https://github.com/apache/kafka/pull/13325#discussion_r1149221534
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -2547,9 +2547,10 @@ private void acquireAndEnsureOpen() {
* @throws Concurre
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1485037330
Hello David, this PR has been updated and is ready for review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/KAFKA-14838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban updated KAFKA-14838:
-
Summary: MM2 Worker/Connector/Task clients should specify client ID based
on flow and role (was
[
https://issues.apache.org/jira/browse/KAFKA-14838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban updated KAFKA-14838:
-
Description:
MM2 code creates a lot of Kafka clients internally. These clients generate a
lot o
Alexandre Dupriez created KAFKA-14852:
-
Summary: Propagate Topic Ids to the Group Coordinator for Offset
Fetch
Key: KAFKA-14852
URL: https://issues.apache.org/jira/browse/KAFKA-14852
Project: Kafk
[
https://issues.apache.org/jira/browse/KAFKA-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-14690:
--
Fix Version/s: 3.5.0
> OffsetCommit API Version 9
> --
>
>
emissionnebula commented on PR #13437:
URL: https://github.com/apache/kafka/pull/13437#issuecomment-1485100563
Oops. Thanks @rondagostino for pointing this out. I have updated the
description with the correct details.
--
This is an automated message from the Apache Git Service.
To respond
C0urante commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1148760142
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
[
https://issues.apache.org/jira/browse/KAFKA-14852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14852:
-
Assignee: Alexandre Dupriez
> Propagate Topic Ids to the Group Coordinator for
[
https://issues.apache.org/jira/browse/KAFKA-14852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez updated KAFKA-14852:
--
Description:
This task is the sibling of KAFKA-14793 which propagates topic ids in the
urbandan opened a new pull request, #13458:
URL: https://github.com/apache/kafka/pull/13458
…ient.id configs
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
urbandan commented on PR #13458:
URL: https://github.com/apache/kafka/pull/13458#issuecomment-1485136651
@viktorsomogyi @C0urante @mimaison You had some changes/review in this part
of the code lately, could you please review?
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-14652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Urban updated KAFKA-14652:
-
Description:
MirrorMaker2 runs multiple Connect worker instances in a single process. In
Connec
philipnee commented on code in PR #13269:
URL: https://github.com/apache/kafka/pull/13269#discussion_r1149285314
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1699,7 +1705,8 @@ public void
shouldReturnOffsetsForRepartitionTopi
pprovenzano commented on PR #13374:
URL: https://github.com/apache/kafka/pull/13374#issuecomment-1485244811
> This seems to have broken `FeatureCommandUnitTest.testHandleDowngrade`
because of changes to storage tool.
> This seems to have broken `FeatureCommandUnitTest.testHand
C0urante commented on PR #12637:
URL: https://github.com/apache/kafka/pull/12637#issuecomment-1485251519
I'm also wondering about the spec for V2 field syntax. The KIP states that
"if the backticks are in a wrapping position (opening or closing a field name),
then need to be escaped with ba
C0urante commented on PR #12637:
URL: https://github.com/apache/kafka/pull/12637#issuecomment-1485252002
I'm also wondering about the spec for V2 field syntax. The KIP states that
"if the backticks are in a wrapping position (opening or closing a field name),
then need to be escaped with ba
C0urante commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1149375240
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
C0urante commented on PR #13458:
URL: https://github.com/apache/kafka/pull/13458#issuecomment-1485288081
Hey @urbandan, it's looking like this week is going to be pretty busy for me
so I may not be able to take a look immediately. I can try to take a look next
week if this still hasn't rece
urbandan commented on PR #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-1485386852
Thanks a lot @C0urante, will review that one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
urbandan commented on code in PR #13433:
URL: https://github.com/apache/kafka/pull/13433#discussion_r1149465857
##
connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java:
##
@@ -289,29 +291,202 @@ public ConnectSchema schema() {
@Override
public boo
urbandan commented on code in PR #13433:
URL: https://github.com/apache/kafka/pull/13433#discussion_r1149488176
##
connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java:
##
@@ -289,29 +291,202 @@ public ConnectSchema schema() {
@Override
public boo
C0urante commented on code in PR #13433:
URL: https://github.com/apache/kafka/pull/13433#discussion_r1149494051
##
connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java:
##
@@ -289,29 +291,202 @@ public ConnectSchema schema() {
@Override
public boo
junrao commented on code in PR #13408:
URL: https://github.com/apache/kafka/pull/13408#discussion_r1149498020
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1159,16 +1171,20 @@ private Errors validateAlterPartitionData(
retu
tinaselenge opened a new pull request, #13459:
URL: https://github.com/apache/kafka/pull/13459
```
=== tests
$./bin/kafka-features.sh --bootstrap-server localhost:9092 --command-config
test describe
Feature: metadata.version SupportedMinVersion: 3.0-IV1
SupportedMaxVersio
guozhangwang commented on PR #13452:
URL: https://github.com/apache/kafka/pull/13452#issuecomment-1485490464
LGTM. Merging to trunk to unblock @rayokota and SR, please feel free to
address @chia7712 's comments in a follow-up PR.
--
This is an automated message from the Apache Git Service
guozhangwang merged PR #13452:
URL: https://github.com/apache/kafka/pull/13452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
CalvinConfluent commented on code in PR #13408:
URL: https://github.com/apache/kafka/pull/13408#discussion_r1149550057
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1159,16 +1171,20 @@ private Errors validateAlterPartitionData(
Chia-Ping Tsai created KAFKA-14853:
--
Summary: the serializer/deserialize which extends
ClusterResourceListener is never called
Key: KAFKA-14853
URL: https://issues.apache.org/jira/browse/KAFKA-14853
[
https://issues.apache.org/jira/browse/KAFKA-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-14853:
---
Summary: the serializer/deserialize which extends ClusterResourceListener
is not added to Me
chia7712 opened a new pull request, #13460:
URL: https://github.com/apache/kafka/pull/13460
https://issues.apache.org/jira/browse/KAFKA-14853
I noticed this issue when reviewing #13452. We use the incorrect reference
of serializer/deserializer
### Committer Checklist (exclu
Justine Olshan created KAFKA-14854:
--
Summary: Refactor inter broker send thread to handle all
interbroker requests on one thread
Key: KAFKA-14854
URL: https://issues.apache.org/jira/browse/KAFKA-14854
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1149586417
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149630814
##
checkstyle/suppressions.xml:
##
@@ -320,6 +320,14 @@
+
+
+
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149644261
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java:
##
@@ -37,29 +39,28 @@ public class AssignmentMemberSpec {
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149647453
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
gharris1727 commented on code in PR #13445:
URL: https://github.com/apache/kafka/pull/13445#discussion_r1149638851
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -836,10 +836,19 @@ public List connectorPluginConfig(String
pluginName
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149648624
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149650468
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149655641
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
gharris1727 commented on code in PR #13433:
URL: https://github.com/apache/kafka/pull/13433#discussion_r1149656291
##
connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java:
##
@@ -289,29 +291,202 @@ public ConnectSchema schema() {
@Override
public
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149658306
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149659044
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149659044
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149666320
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
jeqo commented on PR #13445:
URL: https://github.com/apache/kafka/pull/13445#issuecomment-1485705474
Sure, thanks @gharris1727! let me know how it looks now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jeqo commented on code in PR #13445:
URL: https://github.com/apache/kafka/pull/13445#discussion_r1149677176
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -856,11 +867,8 @@ public List connectorPluginConfig(String
pluginName) {
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1149655641
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/KAFKA-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Spacrocket reassigned KAFKA-14746:
--
Assignee: Spacrocket
> Throwing in Connector.taskConfigs generates a lot of logs
> --
gharris1727 commented on code in PR #13445:
URL: https://github.com/apache/kafka/pull/13445#discussion_r1149755190
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -856,11 +867,8 @@ public List connectorPluginConfig(String
pluginName)
C0urante commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1149500829
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -25,17 +25,37 @@
import org.apache.kafka.common.utils.Utils;
import org.a
Chris Egerton created KAFKA-14855:
-
Summary: Harden integration testing logic for asserting that a
connector is deleted
Key: KAFKA-14855
URL: https://issues.apache.org/jira/browse/KAFKA-14855
Project:
C0urante commented on code in PR #13424:
URL: https://github.com/apache/kafka/pull/13424#discussion_r1149773408
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##
@@ -325,6 +325,181 @@ public void
testSourceTaskNotBlocked
C0urante commented on code in PR #13424:
URL: https://github.com/apache/kafka/pull/13424#discussion_r1149776904
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##
@@ -237,6 +237,17 @@ private synchronized void putConnectorConfi
C0urante commented on code in PR #13424:
URL: https://github.com/apache/kafka/pull/13424#discussion_r1149778430
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1090,6 +1090,40 @@ public void putConnectorConfig(final St
anatasiavela commented on PR #13078:
URL: https://github.com/apache/kafka/pull/13078#issuecomment-1485869027
@mimaison I've marked the JIRA as resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Jeff Kim created KAFKA-14856:
Summary: Next gen group coordinator dynamic configs should be
forward compatible
Key: KAFKA-14856
URL: https://issues.apache.org/jira/browse/KAFKA-14856
Project: Kafka
C0urante commented on code in PR #13434:
URL: https://github.com/apache/kafka/pull/13434#discussion_r1149813420
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -866,4 +867,19 @@ public List connectorPluginConfig(String
pluginName) {
[
https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705687#comment-17705687
]
Philip Nee commented on KAFKA-14757:
Hey [~sanand] - I'm unfamiliar with ConsumerAwa
[ https://issues.apache.org/jira/browse/KAFKA-14757 ]
Philip Nee deleted comment on KAFKA-14757:
was (Author: JIRAUSER283568):
Hey [~sanand] - I'm unfamiliar with ConsumerAwareRebalanceListener, but do you
know if it revokes the partitions upon
[
https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705689#comment-17705689
]
Philip Nee commented on KAFKA-14757:
Hi [~sanand] - I'm not sure what's behavior of
C0urante commented on code in PR #13434:
URL: https://github.com/apache/kafka/pull/13434#discussion_r1149828648
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java:
##
@@ -343,12 +336,38 @@ public Future set(final Map
values, final Cal
artemlivshits commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1149838206
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or m
C0urante commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1149838213
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -540,10 +601,13 @@ Map describeTopicConfigs(Set
topics)
Confi
gharris1727 commented on code in PR #13433:
URL: https://github.com/apache/kafka/pull/13433#discussion_r1149838302
##
connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java:
##
@@ -289,29 +291,202 @@ public ConnectSchema schema() {
@Override
public
C0urante commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1149841456
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/ConfigPropertyFilter.java:
##
@@ -25,8 +25,19 @@
@InterfaceStability.Evolving
public interface Config
C0urante commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1149842964
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java:
##
@@ -30,6 +30,9 @@ public class DefaultConfigPropertyFilter impleme
C0urante commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1149843748
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -96,6 +99,7 @@ public class MirrorSourceConnector extends SourceConne
Colin McCabe created KAFKA-14857:
Summary: Fix some MetadataLoader bugs
Key: KAFKA-14857
URL: https://issues.apache.org/jira/browse/KAFKA-14857
Project: Kafka
Issue Type: Bug
Repo
C0urante commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1149844200
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/IdentityReplicationIntegrationTest.java:
##
@@ -41,12 +41,12 @@
import org.junit.jupiter.a
cmccabe opened a new pull request, #13462:
URL: https://github.com/apache/kafka/pull/13462
The MetadataLoader is not supposed to publish metadata updates until we have
loaded up to the high water mark. Previously, this logic was broken, and we
published updates immediately. This PR fixes th
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1149847782
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
C0urante commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1149844764
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/IdentityReplicationIntegrationTest.java:
##
@@ -41,12 +41,12 @@
import org.junit.jupiter.a
C0urante commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1149857584
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -514,6 +543,41 @@ private void updateTopicConfigs(Map
topicConfigs)
cmccabe merged PR #13368:
URL: https://github.com/apache/kafka/pull/13368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths}
import kafka.server.{BrokerMetadataCheckpoint, KafkaCo
artemlivshits commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1149873099
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or m
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1149876669
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -128,6 +152,108 @@ object StorageTool extends Logging {
.getOrElse(defaultValue)
}
+ def getUse
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths}
import kafka.server.{BrokerMetadataCheckpoint, KafkaCo
1 - 100 of 132 matches
Mail list logo
