[GitHub] [kafka] Schm1tz1 commented on a diff in pull request #12992: KAFKA-14376-KIP887: Add ConfigProvider to make use of environment variables

Schm1tz1 commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1132075208 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1463470303 > Hello, the relevant test code has been submitted, please help to review, thank you. @showuon -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (KAFKA-14112) Expose replication-offset-lag Mirror metric

[ https://issues.apache.org/jira/browse/KAFKA-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698824#comment-17698824 ] Viktor Somogyi-Vass commented on KAFKA-14112: - [~elkkhan] do you have a PR f

[jira] [Commented] (KAFKA-13679) Superfluous node disconnected log messages

[ https://issues.apache.org/jira/browse/KAFKA-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698830#comment-17698830 ] Prashanth Joseph Babu commented on KAFKA-13679: --- we're seeing this issue a

[jira] [Comment Edited] (KAFKA-13679) Superfluous node disconnected log messages

[ https://issues.apache.org/jira/browse/KAFKA-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698830#comment-17698830 ] Prashanth Joseph Babu edited comment on KAFKA-13679 at 3/10/23 9:11 AM: --

[GitHub] [kafka] hudeqi commented on pull request #10726: KAFKA-12478: optimize offset reset strategy and fix lose consumer data when add pa…

hudeqi commented on PR #10726: URL: https://github.com/apache/kafka/pull/10726#issuecomment-1463509666 [this link](https://cwiki.apache.org/confluence/display/KAFKA/KIP-842%3A+Add+richer+group+offset+reset+mechanisms) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] vamossagar12 commented on pull request #13376: KAFKA-14091: Leader proactively aborting tasks from lost workers in rebalance in EOS mode

vamossagar12 commented on PR #13376: URL: https://github.com/apache/kafka/pull/13376#issuecomment-1463648551 @C0urante , I created a draft PR based on the approach I outlined here: https://issues.apache.org/jira/browse/KAFKA-14091?filter=-1#:~:text=added%20a%20comment%20%2D-,06/Mar/23%2012%3

[GitHub] [kafka] chia7712 commented on a diff in pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

chia7712 commented on code in PR #13348: URL: https://github.com/apache/kafka/pull/13348#discussion_r1132455184 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -113,7 +113,7 @@ void start(String[] args) throws IOException { record =

[GitHub] [kafka] hudeqi commented on a diff in pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on code in PR #13348: URL: https://github.com/apache/kafka/pull/13348#discussion_r1132477341 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -113,7 +113,7 @@ void start(String[] args) throws IOException { record = n

[GitHub] [kafka] Hangleton opened a new pull request, #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton opened a new pull request, #13378: URL: https://github.com/apache/kafka/pull/13378 **WIP - tests are being added.** [KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit](https://issues.apache.org/jira/browse/KAFKA-14793) This PR is a pre-r

[GitHub] [kafka] dajac commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

dajac commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132487254 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1034,16 +1035,21 @@ private[group] class GroupCoordinator( if (validationErrorOpt.isD

[GitHub] [kafka] dajac commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

dajac commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132490026 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -388,18 +393,27 @@ private[group] class GroupCoordinatorAdapter( case retention

[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132523221 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -388,18 +393,27 @@ private[group] class GroupCoordinatorAdapter( case reten

[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132525996 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1034,16 +1035,21 @@ private[group] class GroupCoordinator( if (validationErrorOpt

[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132525996 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -1034,16 +1035,21 @@ private[group] class GroupCoordinator( if (validationErrorOpt

[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132523221 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -388,18 +393,27 @@ private[group] class GroupCoordinatorAdapter( case reten

[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132627550 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +320,19 @@ public String toString() { } } +// Downgrades the

[jira] [Created] (KAFKA-14800) Upgrade snappy-java Version to 1.1.9.1

Juan Ramos created KAFKA-14800: -- Summary: Upgrade snappy-java Version to 1.1.9.1 Key: KAFKA-14800 URL: https://issues.apache.org/jira/browse/KAFKA-14800 Project: Kafka Issue Type: Bug

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13097: [Draft] KAFKA-10532: close clean for EOS when it's RUNNING standby or RESTORING active

guozhangwang commented on code in PR #13097: URL: https://github.com/apache/kafka/pull/13097#discussion_r1132707585 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java: ## @@ -276,6 +276,11 @@ private void close(final boolean clean) {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13301: KAFKA-14758: Extract inner classes from Fetcher for reuse in refactoring

guozhangwang commented on code in PR #13301: URL: https://github.com/apache/kafka/pull/13301#discussion_r1132719577 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchManagerMetrics.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] guozhangwang merged pull request #13301: KAFKA-14758: Extract inner classes from Fetcher for reuse in refactoring

guozhangwang merged PR #13301: URL: https://github.com/apache/kafka/pull/13301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] mumrah commented on a diff in pull request #13344: MINOR: Replace BrokerMetadataListener with MetadataLoader

mumrah commented on code in PR #13344: URL: https://github.com/apache/kafka/pull/13344#discussion_r1132741472 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -362,16 +326,13 @@ class BrokerServer( config.brokerSessionTimeoutMs / 2 // KAFKA-14392 )

[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132780881 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -971,8 +971,11 @@ private[group] class GroupCoordinator( if (validationErrorOpt.is

[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132780881 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -971,8 +971,11 @@ private[group] class GroupCoordinator( if (validationErrorOpt.is

[GitHub] [kafka] Hangleton commented on a diff in pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on code in PR #13378: URL: https://github.com/apache/kafka/pull/13378#discussion_r1132780881 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -971,8 +971,11 @@ private[group] class GroupCoordinator( if (validationErrorOpt.is

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132807275 ## core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala: ## @@ -44,7 +44,10 @@ object KafkaNetworkChannel { case fetchRequest: FetchRequestData =>

[GitHub] [kafka] mumrah merged pull request #13258: KAFKA-14447: remove stale TODO comment

mumrah merged PR #13258: URL: https://github.com/apache/kafka/pull/13258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] Hangleton commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

Hangleton commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132839586 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -144,18 +146,28 @@ public static class Builder extends AbstractRequest.Builder {

[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793 - Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1464417180 Apologies for the delay, David - I have applied the changes to correct the PR. There may still be under-propagation of topic ids, though. The class `GroupMetadata` is intentionally left

[GitHub] [kafka] C0urante opened a new pull request, #13379: KAFKA-14799: Ignore source task requests to abort empty transactions

C0urante opened a new pull request, #13379: URL: https://github.com/apache/kafka/pull/13379 [Jira](https://issues.apache.org/jira/browse/KAFKA-14799) Since invoking `KafkaProducer::abortTransaction` when no transaction is currently open (via `KafkaProducer::beginTransaction`) causes a

[jira] [Updated] (KAFKA-14799) Source tasks fail if connector attempts to abort empty transaction

[ https://issues.apache.org/jira/browse/KAFKA-14799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14799: -- Affects Version/s: 3.3.2 3.3.1 3.4.0

[jira] [Comment Edited] (KAFKA-14776) Update SCRAM integration tests to run with KRaft

[ https://issues.apache.org/jira/browse/KAFKA-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698719#comment-17698719 ] Proven Provenzano edited comment on KAFKA-14776 at 3/10/23 9:55 PM: --

[jira] [Updated] (KAFKA-14776) Update SCRAM integration tests to run with KRaft

[ https://issues.apache.org/jira/browse/KAFKA-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano updated KAFKA-14776: -- Description: I will update the SCRAM integration tests to run under both ZK and KRaft

[jira] [Updated] (KAFKA-14776) Update SCRAM integration tests to run with KRaft

[ https://issues.apache.org/jira/browse/KAFKA-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano updated KAFKA-14776: -- Summary: Update SCRAM integration tests to run with KRaft (was: Update SCRAM system t

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132937282 ## core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala: ## @@ -105,14 +108,18 @@ class KafkaNetworkChannel( private val correlationIdCounter = new Atomi

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132956895 ## core/src/test/scala/kafka/server/RemoteLeaderEndPointTest.scala: ## @@ -58,7 +58,7 @@ class RemoteLeaderEndPointTest { blockingSend = new MockBlocki

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132957256 ## core/src/test/scala/unit/kafka/raft/KafkaNetworkChannelTest.scala: ## @@ -159,6 +167,29 @@ class KafkaNetworkChannelTest { } } + @ParameterizedTes

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132965843 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -1103,14 +1136,18 @@ class ReplicaFetcherThreadTest { assertProcessPartition

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r113296 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -1272,6 +1274,7 @@ class ReplicaManagerTest { } verify(mockLogMgr).fini

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1132971982 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -1436,6 +1438,28 @@ public void testInvalidFetchRequest() throws Exception {

[GitHub] [kafka] mjsax commented on a diff in pull request #13292: KAFKA-14491: [14/N] Set changelog topic configs for versioned stores

mjsax commented on code in PR #13292: URL: https://github.com/apache/kafka/pull/13292#discussion_r1132987512 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -1293,12 +1306,16 @@ private void setRegexMatchedTopicToStateSto

[GitHub] [kafka] mjsax commented on a diff in pull request #13340: KAFKA-14491: [15/N] Add integration tests for versioned stores

mjsax commented on code in PR #13340: URL: https://github.com/apache/kafka/pull/13340#discussion_r1132988958 ## streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java: ## @@ -0,0 +1,592 @@ +/* + * Licensed to the Apache Software Fou

[jira] [Assigned] (KAFKA-13884) KRaft Obsever are not required to flush on every append

[ https://issues.apache.org/jira/browse/KAFKA-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-13884: -- Assignee: José Armando García Sancio > KRaft Obsever are not

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1133007633 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -958,7 +959,10 @@ private CompletableFuture handleFetchRequest( Errors

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1133024404 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -144,18 +146,28 @@ public static class Builder extends AbstractRequest.Build

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1133007633 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -958,7 +959,10 @@ private CompletableFuture handleFetchRequest( Errors