satishd commented on code in PR #13304:
URL: https://github.com/apache/kafka/pull/13304#discussion_r1118411232
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1112,7 +1079,8 @@ class UnifiedLog(@volatile var logStartOffset: Long,
new LogAppendInfo(firstOffset, l
ijuma merged PR #13311:
URL: https://github.com/apache/kafka/pull/13311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ijuma commented on PR #13205:
URL: https://github.com/apache/kafka/pull/13205#issuecomment-1445905740
The `spotlessScala` issue was fixed via #13311.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ijuma commented on PR #13263:
URL: https://github.com/apache/kafka/pull/13263#issuecomment-1445906790
@guozhangwang Note that we found a way to re-enable this when running with
Java 11 or newer, see #13311.
--
This is an automated message from the Apache Git Service.
To respond to the mes
[
https://issues.apache.org/jira/browse/KAFKA-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-14749.
-
Assignee: Ismael Juma
Resolution: Fixed
We found a way to re-enable this when running with
[
https://issues.apache.org/jira/browse/KAFKA-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-14749:
Fix Version/s: 3.5.0
(was: 4.0.0)
> Re-enable 'spotlessScalaCheck' task (in
[
https://issues.apache.org/jira/browse/KAFKA-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-14749:
Priority: Major (was: Blocker)
> Re-enable 'spotlessScalaCheck' task (in Jenkinsfile)
> -
[
https://issues.apache.org/jira/browse/KAFKA-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-14680.
-
Fix Version/s: 3.5.0
Resolution: Fixed
> Gradle version upgrade 7 -->> 8
> --
satishd commented on PR #13304:
URL: https://github.com/apache/kafka/pull/13304#issuecomment-1445917205
Thanks @showuon for your review. Addressed them with inline replies or the
latest commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dajac commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118380508
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -34,22 +43,40 @@ public class AddPartitionsToTxnRequest extends
AbstractR
mimaison merged PR #13174:
URL: https://github.com/apache/kafka/pull/13174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valeriy Kassenbayev updated KAFKA-14206:
Fix Version/s: 3.4.1
(was: 3.4.0)
> Upgrade zookeeper to 3.
[
https://issues.apache.org/jira/browse/KAFKA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valeriy Kassenbayev reopened KAFKA-14206:
-
Still have the same CVEs reported:
{code:java}
✗ Denial of Service (DoS) [High
Se
mimaison commented on PR #13145:
URL: https://github.com/apache/kafka/pull/13145#issuecomment-1446008315
@C0urante can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on PR #13170:
URL: https://github.com/apache/kafka/pull/13170#issuecomment-1446015320
@tombentley can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Gantigmaa Selenge created KAFKA-14763:
-
Summary: Add integration test for DelegationTokenCommand tool
Key: KAFKA-14763
URL: https://issues.apache.org/jira/browse/KAFKA-14763
Project: Kafka
tinaselenge commented on PR #13172:
URL: https://github.com/apache/kafka/pull/13172#issuecomment-1446056568
Created a Jira issue for adding integration test for this tool later on:
https://issues.apache.org/jira/browse/KAFKA-14763
--
This is an automated message from the Apache Git Servic
edoardocomar commented on code in PR #13291:
URL: https://github.com/apache/kafka/pull/13291#discussion_r1118563985
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java:
##
@@ -81,6 +81,7 @@
import static
org.apache.kafka.
edoardocomar commented on code in PR #13291:
URL: https://github.com/apache/kafka/pull/13291#discussion_r1118569732
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java:
##
@@ -266,6 +267,7 @@ public void testPollBoundary()
edoardocomar commented on code in PR #13291:
URL: https://github.com/apache/kafka/pull/13291#discussion_r1118563985
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java:
##
@@ -81,6 +81,7 @@
import static
org.apache.kafka.
[
https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693955#comment-17693955
]
Mickael Maison commented on KAFKA-2967:
---
Thanks [~jeqo] for picking this up, your P
mimaison merged PR #13145:
URL: https://github.com/apache/kafka/pull/13145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
edoardocomar commented on code in PR #13291:
URL: https://github.com/apache/kafka/pull/13291#discussion_r1118569732
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExactlyOnceSourceIntegrationTest.java:
##
@@ -266,6 +267,7 @@ public void testPollBoundary()
C0urante commented on PR #13302:
URL: https://github.com/apache/kafka/pull/13302#issuecomment-1446393595
Hey @gharris1727, thanks for the PR. While I personally agree with the
rationale here and would be happy to merge the changes, I think this may still
require a KIP as it removes connecto
C0urante merged PR #13191:
URL: https://github.com/apache/kafka/pull/13191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694048#comment-17694048
]
Andras Katona commented on KAFKA-14041:
---
Java compiler doesn't mind. {{var}} can b
[
https://issues.apache.org/jira/browse/KAFKA-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-14060.
---
Resolution: Done
> Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTe
[
https://issues.apache.org/jira/browse/KAFKA-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Katona resolved KAFKA-14738.
---
Resolution: Not A Bug
> Topic disappears from kafka_topic.sh --list after modifying it with
rondagostino commented on PR #13280:
URL: https://github.com/apache/kafka/pull/13280#issuecomment-1446491240
The `topicIdInfo` benchmark now performs equivalently. I eliminated the
`TranslatedValueMapView` class in favor of adding a value mapper to the
`VavrMapAsJava` class.
--
This is
[
https://issues.apache.org/jira/browse/KAFKA-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Katona resolved KAFKA-14387.
---
Resolution: Information Provided
> kafka.common.KafkaException | kafka_2.12-3.3.1.jar
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694068#comment-17694068
]
Andras Katona commented on KAFKA-14387:
---
it was removed here:
https://github.com/a
David Jacot created KAFKA-14764:
---
Summary: Metadata API ignores topic names if at least one topic is
provided with an id
Key: KAFKA-14764
URL: https://issues.apache.org/jira/browse/KAFKA-14764
Project:
[
https://issues.apache.org/jira/browse/KAFKA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano reassigned KAFKA-14765:
-
Assignee: Proven Provenzano
> Support SCRAM for brokers at bootstrap
>
Proven Provenzano created KAFKA-14765:
-
Summary: Support SCRAM for brokers at bootstrap
Key: KAFKA-14765
URL: https://issues.apache.org/jira/browse/KAFKA-14765
Project: Kafka
Issue Type:
dajac commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1446539881
@Hangleton Thanks for the update. I will take a look shortly. In the
meantime, could you already add a few integration test for the
OffsetCommitRequest like we have for the OffsetFetchReque
[
https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693369#comment-17693369
]
Chris Egerton edited comment on KAFKA-14750 at 2/27/23 3:28 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694074#comment-17694074
]
Proven Provenzano commented on KAFKA-14765:
---
[KIP-900|https://cwiki.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694076#comment-17694076
]
David Jacot commented on KAFKA-14764:
-
[~dengziming] If I remember correctly, you di
hgeraldino commented on PR #13193:
URL: https://github.com/apache/kafka/pull/13193#issuecomment-1446570858
Thanks @clolov,
Now that https://github.com/apache/kafka/pull/13191 has been merged, this PR
has been rebased and is ready for review.
CC @C0urante
--
This is an aut
[
https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14764:
Summary: Metadata API ignores topic names if at least one topic ID is
provided (was: Metadata API
[
https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14764:
Summary: Metadata API ignores topic names if at least one topic id is
provided with an id (was: M
[
https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14764:
Summary: Metadata API ignores topic names if at least one topic is provided
with an id (was: Meta
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118946985
##
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##
@@ -23,17 +23,39 @@
// Version 2 adds the support for new error code PRODUCER_FENCED.
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118948279
##
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##
@@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118949475
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -1303,11 +1305,13 @@ public void
testCommitWithTopicAuthorizati
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118951636
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel,
if (config.interBrokerProtocol
jolshan commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118952253
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel,
if (config.interBrokerProtocol
dajac commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118980264
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel,
if (config.interBrokerProtocolVe
dajac commented on code in PR #13231:
URL: https://github.com/apache/kafka/pull/13231#discussion_r1118981498
##
clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json:
##
@@ -23,17 +23,39 @@
// Version 2 adds the support for new error code PRODUCER_FENCED.
C0urante commented on code in PR #13276:
URL: https://github.com/apache/kafka/pull/13276#discussion_r1119036590
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -3694,6 +3694,54 @@ public void
shouldThrowWhenStartAn
Divij Vaidya created KAFKA-14766:
Summary: Improve performance of VarInt encoding/decoding
Key: KAFKA-14766
URL: https://issues.apache.org/jira/browse/KAFKA-14766
Project: Kafka
Issue Type: I
divijvaidya opened a new pull request, #13312:
URL: https://github.com/apache/kafka/pull/13312
# Motivation
Reading/writing the protocol buffer varInt32 and varInt64 (also called
varLong in our code base) is in the hot path of data plane code in Apache
Kafka. We read multiple varInt in a
kirktrue commented on PR #12813:
URL: https://github.com/apache/kafka/pull/12813#issuecomment-1446745731
@dajac I'm having a bit of a hard time figuring out how to test this.
Per your previous comments, the `NetworkClient` already issues a request for
metadata update when the connecti
[
https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694115#comment-17694115
]
Siddharth Anand commented on KAFKA-14757:
-
Is there documentation that details h
[
https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694119#comment-17694119
]
Philip Nee commented on KAFKA-14757:
Hey Sidd, here you go:
[https://kafka.apache.o
junrao commented on code in PR #13304:
URL: https://github.com/apache/kafka/pull/13304#discussion_r1119112476
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1434,13 +1434,13 @@ class Partition(val topicPartition: TopicPartition,
minOneMessage
)
-L
junrao commented on code in PR #13309:
URL: https://github.com/apache/kafka/pull/13309#discussion_r1119124556
##
core/src/main/scala/kafka/log/LocalLog.scala:
##
@@ -686,40 +685,6 @@ object LocalLog extends Logging {
s"${topicPartition.topic}-${topicPartition.partition}"
gharris1727 commented on PR #13302:
URL: https://github.com/apache/kafka/pull/13302#issuecomment-1446847150
> I think this may still require a KIP as it removes connectors from OOTB
Connect.
This is included as part of KIP-898:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-89
[
https://issues.apache.org/jira/browse/KAFKA-14762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694124#comment-17694124
]
Greg Harris commented on KAFKA-14762:
-
Thanks [~ijuma] for clarifying where the actu
C0urante commented on PR #13302:
URL: https://github.com/apache/kafka/pull/13302#issuecomment-1446859760
Ah yes, good point about KIP-898! Nice that we don't have to file a separate
KIP for this change. Will revisit if/when KIP-898 passes.
--
This is an automated message from the Apache G
C0urante commented on PR #10566:
URL: https://github.com/apache/kafka/pull/10566#issuecomment-1446878483
Hi @urbandan, thanks for clarifying the point about using `Schema` methods.
Agreed that this would be helpful.
I think we should try to keep validation of optionality if possible,
[
https://issues.apache.org/jira/browse/KAFKA-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-14264.
---
Resolution: Fixed
[~pnee] can you fill in the details on the fixed versions? Thanks!
> Refactor coo
[
https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-14468.
---
Resolution: Fixed
[~pnee] can you fill in the details on the fixed versions? Thanks!
> Refactor Com
[
https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-14468:
---
Fix Version/s: 3.5.0
> Refactor Commit Logic
> -
>
> Key: KAFKA-
C0urante commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1097934299
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {
[
https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-14468:
---
Fix Version/s: (was: 3.5.0)
> Refactor Commit Logic
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-14264:
---
Fix Version/s: 3.4.0
> Refactor coordinator code
> -
>
> Key
[
https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-14468:
---
Fix Version/s: 3.5.0
> Refactor Commit Logic
> -
>
> Key: KAFKA-
[
https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694147#comment-17694147
]
Guozhang Wang commented on KAFKA-14748:
---
Originally I think this can be treated wi
guozhangwang merged PR #13308:
URL: https://github.com/apache/kafka/pull/13308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
hgeraldino commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1119214853
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {
guozhangwang commented on PR #13308:
URL: https://github.com/apache/kafka/pull/13308#issuecomment-1446938946
LGTM. Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
C0urante commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1119219553
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {
C0urante commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1119219553
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {
hgeraldino commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1119228442
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {
[
https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694156#comment-17694156
]
Jorge Esteban Quilcate Otoya commented on KAFKA-2967:
-
Thanks [~mimai
dajac commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1119248386
##
clients/src/main/resources/common/message/OffsetCommitRequest.json:
##
@@ -47,8 +49,10 @@
"about": "The time period in ms to retain the offset." },
{ "name
divijvaidya commented on PR #13307:
URL: https://github.com/apache/kafka/pull/13307#issuecomment-1447001588
@showuon I am discarding this PR as I have included it's changes in
https://github.com/apache/kafka/pull/13312
--
This is an automated message from the Apache Git Service.
To respo
divijvaidya closed pull request #13307: MINOR: Make ByteUtilsBenchmark
deterministic
URL: https://github.com/apache/kafka/pull/13307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gharris1727 opened a new pull request, #13313:
URL: https://github.com/apache/kafka/pull/13313
Currently connect-runtime pulls in tools as a dependency in order to use the
ThroughputThrottler.
In the future it will be desirable to have tools pull in connect-runtime as
a (test) dependency
C0urante commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1119262008
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {
hgeraldino commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1119279751
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {
gharris1727 commented on PR #13291:
URL: https://github.com/apache/kafka/pull/13291#issuecomment-1447059390
@edoardocomar
I pulled these values out into three separate constants with descriptive
names, let me know if this is closer to what you had in mind!
--
This is an automated
C0urante commented on code in PR #13184:
URL: https://github.com/apache/kafka/pull/13184#discussion_r1119281474
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/TransformationStage.java:
##
@@ -16,63 +16,58 @@
*/
package org.apache.kafka.connect.runtime;
-i
[
https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694182#comment-17694182
]
Siddharth Anand commented on KAFKA-14757:
-
We follow the pattern below in each c
rittikaadhikari opened a new pull request, #13314:
URL: https://github.com/apache/kafka/pull/13314
Conflicts in Jenkinsfile and build.gradle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
rittikaadhikari closed pull request #13314: [DO NOT MERGE] Sync apache/trunk to
confluentinc/kafka master 27-Feb-2023
URL: https://github.com/apache/kafka/pull/13314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Greg Harris created KAFKA-14767:
---
Summary: Gradle build fails with missing commitId after git gc
Key: KAFKA-14767
URL: https://issues.apache.org/jira/browse/KAFKA-14767
Project: Kafka
Issue Typ
[
https://issues.apache.org/jira/browse/KAFKA-14767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694207#comment-17694207
]
Greg Harris commented on KAFKA-14767:
-
This happens occasionally when git performs a
guozhangwang commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1119357976
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer
gharris1727 commented on code in PR #13184:
URL: https://github.com/apache/kafka/pull/13184#discussion_r1119388653
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -531,8 +543,17 @@ private Converter badConverter() {
re
gharris1727 commented on code in PR #13184:
URL: https://github.com/apache/kafka/pull/13184#discussion_r1119389854
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##
@@ -268,30 +268,30 @@ public boolean includeRecordDetailsInErrorLog() {
gharris1727 commented on code in PR #13184:
URL: https://github.com/apache/kafka/pull/13184#discussion_r1119392537
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ConnectorConfigTest.java:
##
@@ -280,25 +283,18 @@ public void abstractPredicate() {
asse
philipnee commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1119397792
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer) {
philipnee commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1119398074
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1484,6 +1484,8 @@ public void testRebalanceWithMetadataChang
philipnee commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1119399381
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer) {
philipnee commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1119399381
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer) {
philipnee commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1119398074
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1484,6 +1484,8 @@ public void testRebalanceWithMetadataChang
[
https://issues.apache.org/jira/browse/KAFKA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694213#comment-17694213
]
Guozhang Wang commented on KAFKA-14747:
---
Echoing that, I think we can piggy-back o
philipnee commented on code in PR #13190:
URL: https://github.com/apache/kafka/pull/13190#discussion_r1119422842
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -1484,6 +1484,8 @@ public void testRebalanceWithMetadataChang
1 - 100 of 124 matches
Mail list logo
