mimaison commented on PR #13060:
URL: https://github.com/apache/kafka/pull/13060#issuecomment-1406261073
Thanks for the PR! We're moving JmxTool to the tools module in
https://github.com/apache/kafka/pull/13136. Let's do the rewrite/move first,
then I'll take a look at this PR.
--
This i
fvaleri commented on PR #13136:
URL: https://github.com/apache/kafka/pull/13136#issuecomment-1406316345
@mimaison I've rebased and added some tests.
This is now ready for another review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Hangleton commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1088898259
##
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java:
##
@@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable
cause)
Hangleton commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1088918527
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis
Cerchie commented on code in PR #13161:
URL: https://github.com/apache/kafka/pull/13161#discussion_r1088951633
##
clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java:
##
@@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable
cause) {
[
https://issues.apache.org/jira/browse/KAFKA-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681320#comment-17681320
]
Sayed Mohammad Hossein Torabi commented on KAFKA-9975:
--
I would like
[
https://issues.apache.org/jira/browse/KAFKA-14591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-14591:
--
Assignee: Mickael Maison
> Move DeleteRecordsCommand to tools
> -
Hangleton commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1088967227
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
*
[
https://issues.apache.org/jira/browse/KAFKA-14584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Federico Valeri reassigned KAFKA-14584:
---
Assignee: Federico Valeri
> Move StateChangeLogMerger to tools
> --
dpcollins-google commented on code in PR #13162:
URL: https://github.com/apache/kafka/pull/13162#discussion_r1089108841
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel
destChannel,
[
https://issues.apache.org/jira/browse/KAFKA-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edoardo Comar resolved KAFKA-7666.
--
Resolution: Won't Fix
KIP has been retired
> KIP-391: Allow Producing with Offsets for Cluster
[
https://issues.apache.org/jira/browse/KAFKA-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681404#comment-17681404
]
Federico Valeri commented on KAFKA-14615:
-
FYI, there is an open PR to migrate/c
[
https://issues.apache.org/jira/browse/KAFKA-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681404#comment-17681404
]
Federico Valeri edited comment on KAFKA-14615 at 1/27/23 4:49 PM:
[
https://issues.apache.org/jira/browse/KAFKA-5613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681405#comment-17681405
]
Federico Valeri commented on KAFKA-5613:
FYI, there is an open PR to migrate/conv
Edoardo Comar created KAFKA-14657:
-
Summary: Admin.fenceProducers fails when Producer has ongoing
transaction - but Producer gets fenced
Key: KAFKA-14657
URL: https://issues.apache.org/jira/browse/KAFKA-14657
[
https://issues.apache.org/jira/browse/KAFKA-14657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edoardo Comar updated KAFKA-14657:
--
Description:
Admin.fenceProducers()
fails with a ConcurrentTransactionsException if invoked w
[
https://issues.apache.org/jira/browse/KAFKA-14657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edoardo Comar updated KAFKA-14657:
--
Description:
Admin.fenceProducers()
fails with a ConcurrentTransactionsException if invoked w
mimaison opened a new pull request, #13170:
URL: https://github.com/apache/kafka/pull/13170
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
[
https://issues.apache.org/jira/browse/KAFKA-14657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681416#comment-17681416
]
Justine Olshan commented on KAFKA-14657:
Is the issue here that it appears the c
cmccabe commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1089233294
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis()
cmccabe commented on code in PR #13169:
URL: https://github.com/apache/kafka/pull/13169#discussion_r1089236363
##
server-common/src/main/java/org/apache/kafka/server/util/FutureUtils.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Colin McCabe created KAFKA-14658:
Summary: Do not open broker ports until we are ready to accept
traffic
Key: KAFKA-14658
URL: https://issues.apache.org/jira/browse/KAFKA-14658
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-14658:
-
Summary: When listening on fixed ports, defer port opening until we're
ready (was: Do not open
[
https://issues.apache.org/jira/browse/KAFKA-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-14658:
-
Description:
We should not open the ports on the broker until we are ready to accept
traffic. T
[
https://issues.apache.org/jira/browse/KAFKA-14658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-14658:
-
Description:
When we are listening on fixed ports, we should defer opening ports until we're
re
hachikuji commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089298321
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1153,6 +1157,8 @@ object KafkaConfig {
.define(MetadataMaxRetentionBytesProp, LONG,
Defaults.Met
cmccabe commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089313497
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis()
cmccabe commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089352604
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1153,6 +1157,8 @@ object KafkaConfig {
.define(MetadataMaxRetentionBytesProp, LONG,
Defaults.Metad
hachikuji commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089358150
##
server-common/src/main/java/org/apache/kafka/server/util/Deadline.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
cmccabe commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089524442
##
server-common/src/main/java/org/apache/kafka/server/util/Deadline.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
cmccabe commented on code in PR #13153:
URL: https://github.com/apache/kafka/pull/13153#discussion_r1089524563
##
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##
@@ -86,4 +89,30 @@ default Timer timer(Duration timeout) {
return timer(timeout.toMillis()
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1089556608
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -0,0 +1,523 @@
+/*
+ * Licensed to the Apache S
cmccabe commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1407227921
Can we have a test in `ControllerApisTest`? These are mainly to verify that
our authorization logic is sound.
--
This is an automated message from the Apache Git Service.
To respond to
cmccabe commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1407228067
We should not be changing `BrokerMetadataSnapshotterTest.scala` here --
doesn't seem needed
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
cmccabe commented on PR #13114:
URL: https://github.com/apache/kafka/pull/13114#issuecomment-1407228326
* We need a `ScramControlManagerTest` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Chris Beard created KAFKA-14659:
---
Summary: source-record-write-[rate|total] metrics include filtered
records
Key: KAFKA-14659
URL: https://issues.apache.org/jira/browse/KAFKA-14659
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Beard updated KAFKA-12225:
Priority: Major (was: Minor)
> Unexpected broker bottleneck when scaling producers
>
[
https://issues.apache.org/jira/browse/KAFKA-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Beard updated KAFKA-12225:
Priority: Minor (was: Major)
> Unexpected broker bottleneck when scaling producers
>
[
https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Beard updated KAFKA-14659:
Priority: Minor (was: Major)
> source-record-write-[rate|total] metrics include filtered records
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1407268172
> EndToEndLatencyService
Thanks @mimaison . Actually I lack some context here. The class,
`TestEndToEndLatency` was renamed to `EndToEndLatency` with this very old PR:
https:/
vamossagar12 commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1089609015
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1407272563
> @vamossagar12 Thanks for the PR!
>
> I had one major comment.
Thanks @cadonna . I think that comment has been addressed now based on the
conversation.
--
This is an
42 matches
Mail list logo
