[GitHub] [kafka] cadonna commented on pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2

cadonna commented on PR #12301: URL: https://github.com/apache/kafka/pull/12301#issuecomment-1378391578 Failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft Build / JDK 17 and Scala 2.13 / kafka.serve

[GitHub] [kafka] cadonna merged pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2

cadonna merged PR #12301: URL: https://github.com/apache/kafka/pull/12301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] OneCricketeer commented on pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

OneCricketeer commented on PR #12992: URL: https://github.com/apache/kafka/pull/12992#issuecomment-1378401283 For reference, the workaround I have been using for this is a bash script around the connect ones that executes something like ``` env | grep -e ^KAFKA_CONNECT_ENV_ > /t

[GitHub] [kafka] tombentley commented on a diff in pull request #13099: KAFKA-14604: avoid SASL session expiration time overflowed when calculation

tombentley commented on code in PR #13099: URL: https://github.com/apache/kafka/pull/13099#discussion_r1066808165 ## clients/src/test/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticatorTest.java: ## @@ -243,6 +243,40 @@ public void testSessionExpiresAtTok

[jira] [Resolved] (KAFKA-14566) Please Close This Ticket As It Was Inadvertently Created. See KAFKA-14565 For The Correct Ticket.

[ https://issues.apache.org/jira/browse/KAFKA-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley resolved KAFKA-14566. - Resolution: Invalid > Please Close This Ticket As It Was Inadvertently Created. See KAFKA-14565

[GitHub] [kafka] mimaison commented on a diff in pull request #13094: MINOR: Various cleanups in client tests

mimaison commented on code in PR #13094: URL: https://github.com/apache/kafka/pull/13094#discussion_r1066839046 ## clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java: ## @@ -266,7 +266,14 @@ public void add(TopicPartition topicPartition, PartitionData data)

[jira] [Created] (KAFKA-14614) Missing cluster tool script for Windows

Mickael Maison created KAFKA-14614: -- Summary: Missing cluster tool script for Windows Key: KAFKA-14614 URL: https://issues.apache.org/jira/browse/KAFKA-14614 Project: Kafka Issue Type: Bug

[GitHub] [kafka] mimaison commented on pull request #13080: KAFKA-14575: Move ClusterTool to tools module

mimaison commented on PR #13080: URL: https://github.com/apache/kafka/pull/13080#issuecomment-1378583171 @dengziming I opened https://issues.apache.org/jira/browse/KAFKA-14614 to look at the missing script for Windows -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-9350) IllegalStateException when materializing transactional offset commits

[ https://issues.apache.org/jira/browse/KAFKA-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675543#comment-17675543 ] zhangzhisheng commented on KAFKA-9350: --   kafka version: 2.13_2.7.2 I've found the

[jira] [Commented] (KAFKA-14613) Move BrokerReconfigurable/KafkaConfig to server-common module.

[ https://issues.apache.org/jira/browse/KAFKA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675560#comment-17675560 ] Satish Duggana commented on KAFKA-14613: [~ijuma] okay, that makes sense to me.

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1066981875 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -116,4 +118,80 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs) {

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1066988206 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -116,4 +118,80 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs) {

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1066989454 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,79 @@ class GroupCoordinatorAdapter( } CompletableFuture.complet

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1066999003 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,79 @@ class GroupCoordinatorAdapter( } CompletableFuture.complet

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r106727 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -411,137 +411,144 @@ class KafkaApis(val requestChannel: RequestChannel, /** * Handle an offset commit r

[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1067001037 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -436,4 +440,74 @@ class GroupCoordinatorAdapterTest { assertEquals(exp

[GitHub] [kafka] dajac commented on pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on PR #12886: URL: https://github.com/apache/kafka/pull/12886#issuecomment-1378782340 @jeffkbkim @jolshan Updated and rebased the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dajac commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067043771 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,67 @@ class GroupCoordinatorAdapter( } CompletableFuture.complet

[GitHub] [kafka] dajac commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067044728 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -58,7 +62,7 @@ class GroupCoordinatorAdapterTest { @ApiKeyVersionsSource(a

[GitHub] [kafka] dajac commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067047982 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2464,90 +2464,108 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleTxnOffsetC

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067049106 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -483,7 +483,7 @@ class KafkaApis(val requestChannel: RequestChannel, case (topicPartition, par

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067051486 ## core/src/main/scala/kafka/controller/ControllerContext.scala: ## @@ -487,7 +487,7 @@ class ControllerContext extends ControllerChannelContext { partitionLea

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067053138 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -1420,7 +1420,7 @@ class KafkaController(val config: KafkaConfig, val replicasInError = pa

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067054361 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -2359,7 +2359,7 @@ class KafkaController(val config: KafkaConfig, } else if (newLead

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067055043 ## core/src/main/scala/kafka/coordinator/group/MemberMetadata.scala: ## @@ -107,7 +107,7 @@ private[group] class MemberMetadata(var memberId: String, * Check if

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067058675 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -897,7 +897,7 @@ private[log] class Cleaner(val id: Int, * @return The estimated last offset for the f

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067059894 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -505,7 +505,7 @@ class BrokerServer( protected def createRemoteLogManager(config: KafkaConfig): Op

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067060444 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -952,7 +952,7 @@ class DynamicListenerConfig(server: KafkaBroker) extends BrokerReconfigurable

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067061923 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1967,7 +1967,7 @@ class KafkaApis(val requestChannel: RequestChannel, // Special handling to add

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067062308 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1175,7 +1175,7 @@ class KafkaApis(val requestChannel: RequestChannel, val topicResponses = metadata

[GitHub] [kafka] dajac commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067063067 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2464,90 +2464,108 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleTxnOffsetC

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067063294 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -575,7 +575,7 @@ class KafkaServer( protected def createRemoteLogManager(config: KafkaConfig): Opti

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067064604 ## core/src/main/scala/kafka/server/epoch/LeaderEpochFileCache.scala: ## @@ -106,7 +106,7 @@ class LeaderEpochFileCache(topicPartition: TopicPartition, entry

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067068943 ## core/src/main/scala/kafka/log/LogCleanerManager.scala: ## @@ -321,14 +321,7 @@ private[log] class LogCleanerManager(val logDirs: Seq[File], * Check if the

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1067069590 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067070504 ## core/src/main/scala/kafka/server/FetchSession.scala: ## @@ -705,10 +705,7 @@ class FetchSessionCache(private val maxEntries: Int, } def remove(sessionId:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067070504 ## core/src/main/scala/kafka/server/FetchSession.scala: ## @@ -705,10 +705,7 @@ class FetchSessionCache(private val maxEntries: Int, } def remove(sessionId:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067072339 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -761,10 +761,7 @@ class KRaftClusterTest { image: ClusterImage, brokerId: In

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067074631 ## core/src/main/scala/kafka/tools/JmxTool.scala: ## @@ -212,7 +212,7 @@ object JmxTool extends Logging { // print csv header val keys = List("time") ++

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067076574 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -364,10 +364,7 @@ class KRaftMetadataCache(val brokerId: Int) extends MetadataCache wi

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067077954 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1514,10 +1514,7 @@ class ReplicaManager(val config: KafkaConfig, * @return true if the request

[GitHub] [kafka] divijvaidya commented on pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on PR #13096: URL: https://github.com/apache/kafka/pull/13096#issuecomment-1378858028 Thanks for your comments @ijuma. I have addressed your concerns and added comments to all changes that will be helpful for reviewers (without having to manually look into each file).

[GitHub] [kafka] ijuma commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

ijuma commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067091105 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -761,10 +761,7 @@ class KRaftClusterTest { image: ClusterImage, brokerId: Int )

[jira] [Updated] (KAFKA-14003) Part 2

[ https://issues.apache.org/jira/browse/KAFKA-14003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14003: Fix Version/s: 3.5.0 > Part 2 > -- > > Key: KAFKA-14003 > URL:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067120704 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -761,10 +761,7 @@ class KRaftClusterTest { image: ClusterImage, brokerId: In

[GitHub] [kafka] ijuma commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

ijuma commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067125601 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -761,10 +761,7 @@ class KRaftClusterTest { image: ClusterImage, brokerId: Int )

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067070504 ## core/src/main/scala/kafka/server/FetchSession.scala: ## @@ -705,10 +705,7 @@ class FetchSessionCache(private val maxEntries: Int, } def remove(sessionId:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067138511 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -484,10 +484,7 @@ private[group] class GroupMetadata(val groupId: String, initialState: G

[jira] [Assigned] (KAFKA-14580) Move EndToEndLatency to tools

[ https://issues.apache.org/jira/browse/KAFKA-14580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-14580: - Assignee: Christo Lolov > Move EndToEndLatency to tools > -

[jira] [Assigned] (KAFKA-14580) Move EndToEndLatency to tools

[ https://issues.apache.org/jira/browse/KAFKA-14580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-14580: - Assignee: (was: Christo Lolov) > Move EndToEndLatency to tools > --

[GitHub] [kafka] mumrah commented on a diff in pull request #13089: KAFKA-14601: Improve exception handling in KafkaEventQueue

mumrah commented on code in PR #13089: URL: https://github.com/apache/kafka/pull/13089#discussion_r1067114622 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataSnapshotter.scala: ## @@ -61,7 +61,7 @@ class BrokerMetadataSnapshotter( /** * The event queue which ru

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

tinaselenge commented on code in PR #13102: URL: https://github.com/apache/kafka/pull/13102#discussion_r1067142496 ## raft/src/main/resources/common/message/QuorumStateData.json: ## @@ -19,7 +19,6 @@ "validVersions": "0", Review Comment: Thank you for the feedback. I have

[jira] [Assigned] (KAFKA-14594) Move LogDirsCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov reassigned KAFKA-14594: - Assignee: Christo Lolov > Move LogDirsCommand to tools > >

[jira] [Created] (KAFKA-14615) Use sizeCompare(Iterable[_]) to compare two iterables

Divij Vaidya created KAFKA-14615: Summary: Use sizeCompare(Iterable[_]) to compare two iterables Key: KAFKA-14615 URL: https://issues.apache.org/jira/browse/KAFKA-14615 Project: Kafka Issue T

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067162495 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -761,10 +761,7 @@ class KRaftClusterTest { image: ClusterImage, brokerId: In

[jira] [Updated] (KAFKA-14615) Use sizeCompare(Iterable[_]) to compare two iterables

[ https://issues.apache.org/jira/browse/KAFKA-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14615: - Description: Since Scala 2.12 is being deprecated in 4.x version, we can utilize some improved

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13096: MINOR: Multiple clean ups associated with scala collection

divijvaidya commented on code in PR #13096: URL: https://github.com/apache/kafka/pull/13096#discussion_r1067185821 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -761,10 +761,7 @@ class KRaftClusterTest { image: ClusterImage, brokerId: In

[jira] [Commented] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675640#comment-17675640 ] Chris Egerton commented on KAFKA-14565: --- [~beardt] sorry, to be clear, I was sugge

[GitHub] [kafka] justinrlee commented on pull request #12797: MINOR: Remove requirement to specify --bootstrap-server in utility scripts if specified in property file

justinrlee commented on PR #12797: URL: https://github.com/apache/kafka/pull/12797#issuecomment-1379128398 Hey @dengziming @dajac I've updated the PR to remove the public interface changes (adding optional alternate command line flag) and have done relatively extensive local testing manuall

[jira] [Resolved] (KAFKA-14613) Move BrokerReconfigurable/KafkaConfig to server-common module.

[ https://issues.apache.org/jira/browse/KAFKA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana resolved KAFKA-14613. Resolution: Won't Do > Move BrokerReconfigurable/KafkaConfig to server-common module. > --

[GitHub] [kafka] cmccabe commented on a diff in pull request #13089: KAFKA-14601: Improve exception handling in KafkaEventQueue

cmccabe commented on code in PR #13089: URL: https://github.com/apache/kafka/pull/13089#discussion_r1067332344 ## server-common/src/test/resources/test/log4j.properties: ## @@ -0,0 +1,21 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor lice

[GitHub] [kafka] cmccabe commented on a diff in pull request #13089: KAFKA-14601: Improve exception handling in KafkaEventQueue

cmccabe commented on code in PR #13089: URL: https://github.com/apache/kafka/pull/13089#discussion_r1067367679 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -116,33 +116,33 @@ boolean isSingleton() { /** * Run the event asso

[GitHub] [kafka] mumrah commented on pull request #13103: KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record

mumrah commented on PR #13103: URL: https://github.com/apache/kafka/pull/13103#issuecomment-1379387869 Two runs with different sets of flaky tests. They are all unrelated to this change (which is gated behind the migration config) -- This is an automated message from the Apache Git Servic

[GitHub] [kafka] mumrah merged pull request #13103: KAFKA-14304 Use boolean for ZK migrating brokers in RPC/record

mumrah merged PR #13103: URL: https://github.com/apache/kafka/pull/13103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

artemlivshits commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1067448086 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jolshan commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1067488043 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,78 @@ class GroupCoordinatorAdapter( } CompletableFuture.compl

[GitHub] [kafka] jolshan commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1067494981 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -116,4 +118,80 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs) {

[GitHub] [kafka] jolshan commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067526170 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -58,7 +62,7 @@ class GroupCoordinatorAdapterTest { @ApiKeyVersionsSource

[GitHub] [kafka] jolshan commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067525498 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,67 @@ class GroupCoordinatorAdapter( } CompletableFuture.compl

[GitHub] [kafka] jolshan commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067526680 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2464,90 +2464,108 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleTxnOffse

[GitHub] [kafka] jolshan commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067528730 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -608,4 +610,77 @@ class GroupCoordinatorAdapterTest { future.get().a

[GitHub] [kafka] jolshan commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1067528730 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -608,4 +610,77 @@ class GroupCoordinatorAdapterTest { future.get().a

[GitHub] [kafka] peternied commented on pull request #12407: [BUG] Remove duplicate common.message.* from clients:test jar file

peternied commented on PR #12407: URL: https://github.com/apache/kafka/pull/12407#issuecomment-1379626692 Thanks for the reply, I would like this fix available sooner since we have to disable jar hell checks in our project to work around this issue for nearly 6 months. Do you have an appro

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

CalvinConfluent commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1067573213 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3110,61 +3110,69 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleO

[GitHub] [kafka] ijuma commented on pull request #12407: [BUG] Remove duplicate common.message.* from clients:test jar file

ijuma commented on PR #12407: URL: https://github.com/apache/kafka/pull/12407#issuecomment-1379638315 Likely this month and it would happen before other releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] hachikuji commented on a diff in pull request #13104: KAFKA-14612: Make sure to write a new topics ConfigRecords to metadata log iff the topic is created

hachikuji commented on code in PR #13104: URL: https://github.com/apache/kafka/pull/13104#discussion_r1067582346 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -605,6 +617,45 @@ public void testCreateTopicsWithConfigs() throws Exc

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1067611094 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -164,5 +166,20 @@ CompletableFuture> fetch String groupId

[GitHub] [kafka] andymg3 commented on a diff in pull request #13104: KAFKA-14612: Make sure to write a new topics ConfigRecords to metadata log iff the topic is created

andymg3 commented on code in PR #13104: URL: https://github.com/apache/kafka/pull/13104#discussion_r1067622704 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -172,20 +172,30 @@ ControllerResult> incrementalAlterConfigs( Ma

[GitHub] [kafka] showuon commented on a diff in pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

showuon commented on code in PR #13102: URL: https://github.com/apache/kafka/pull/13102#discussion_r1067632210 ## raft/src/test/java/org/apache/kafka/raft/FileBasedStateStoreTest.java: ## @@ -90,6 +98,43 @@ public void testWriteElectionState() throws IOException { asser

[GitHub] [kafka] showuon commented on a diff in pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

showuon commented on code in PR #13102: URL: https://github.com/apache/kafka/pull/13102#discussion_r1067632210 ## raft/src/test/java/org/apache/kafka/raft/FileBasedStateStoreTest.java: ## @@ -90,6 +98,43 @@ public void testWriteElectionState() throws IOException { asser

[GitHub] [kafka] showuon commented on a diff in pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

showuon commented on code in PR #13102: URL: https://github.com/apache/kafka/pull/13102#discussion_r1067632210 ## raft/src/test/java/org/apache/kafka/raft/FileBasedStateStoreTest.java: ## @@ -90,6 +98,43 @@ public void testWriteElectionState() throws IOException { asser

[GitHub] [kafka] peternied commented on pull request #12407: [BUG] Remove duplicate common.message.* from clients:test jar file

peternied commented on PR #12407: URL: https://github.com/apache/kafka/pull/12407#issuecomment-1379798226 That sounds good, thanks for letting me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] mjsax commented on pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

mjsax commented on PR #10747: URL: https://github.com/apache/kafka/pull/10747#issuecomment-1379807976 Great! Sure, this works. Looking forward to your KIP -- let me know if you have any question about the KIP process. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kamalcph commented on pull request #13059: MINOR: KafkaConfig should not expose internal config when queried for non-internal values

kamalcph commented on PR #13059: URL: https://github.com/apache/kafka/pull/13059#issuecomment-1379857363 @showuon Rebased with the trunk. Thanks for reviewing it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] zhpyc opened a new pull request, #13105: MINOR: fix typo in KafkaConsumer.java #99999

zhpyc opened a new pull request, #13105: URL: https://github.com/apache/kafka/pull/13105 ### Change Logs As above. ### Impact Only typo fixes. ### Risk level (write none, low medium or high below) None ### Documentation Update N/A ### Committer Checklist (e

[GitHub] [kafka] dengziming commented on a diff in pull request #13105: MINOR: fix typo in KafkaConsumer.java

dengziming commented on code in PR #13105: URL: https://github.com/apache/kafka/pull/13105#discussion_r1067804443 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2460,7 +2460,7 @@ private void close(long timeoutMs, boolean swallowException)