[GitHub] [kafka] fvaleri commented on a diff in pull request #13050: MINOR: add error reason when controller failed to handle events

2022-12-30 Thread GitBox
fvaleri commented on code in PR #13050: URL: https://github.com/apache/kafka/pull/13050#discussion_r1059285394 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -432,8 +432,8 @@ private Throwable handleEventException(String name,

[GitHub] [kafka] kamalcph opened a new pull request, #13060: MINOR: Fix JMX tool to handle the object names with wild cards and optional attributes

2022-12-30 Thread GitBox
kamalcph opened a new pull request, #13060: URL: https://github.com/apache/kafka/pull/13060 JMX tool doesn't handle the object names with wild card. The below exceptions are thrown: ❯ sh kafka-run-class.sh kafka.tools.JmxTool --jmx-url service:jmx:rmi:///jndi/rmi://127.0.0.1:/jmx

[GitHub] [kafka] kamalcph commented on pull request #13060: MINOR: Fix JMX tool to handle the object names with wild cards and optional attributes

2022-12-30 Thread GitBox
kamalcph commented on PR #13060: URL: https://github.com/apache/kafka/pull/13060#issuecomment-1367826069 @showuon @chia7712 Please take a look when you get a chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] kamalcph commented on pull request #13059: MINOR: KafkaConfig should not expose internal config when queried for non-internal values

2022-12-30 Thread GitBox
kamalcph commented on PR #13059: URL: https://github.com/apache/kafka/pull/13059#issuecomment-1367828128 Test failures are unrelated to this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-14559) Handle object name with wildcards in the Jmx tool

2022-12-30 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-14559: Summary: Handle object name with wildcards in the Jmx tool Key: KAFKA-14559 URL: https://issues.apache.org/jira/browse/KAFKA-14559 Project: Kafka

[GitHub] [kafka] C0urante commented on pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

2022-12-30 Thread GitBox
C0urante commented on PR #11818: URL: https://github.com/apache/kafka/pull/11818#issuecomment-1368004001 Thanks @emilnkrastev, good to know we're on the same page! Thinking about this a little more, I wonder if a slightly more-involved approach is warranted. With the current proposal,

[jira] [Updated] (KAFKA-14555) Segfault in RocksDB DumpDataBlocks

2022-12-30 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14555: Description: I encountered this SIGSEGV while running the streams tests with gradle locally. I am

[jira] [Commented] (KAFKA-14555) Segfault in RocksDB DumpDataBlocks

2022-12-30 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653182#comment-17653182 ] Greg Harris commented on KAFKA-14555: - [~ableegoldman] I opened an issue upstream an

[GitHub] [kafka] emilnkrastev commented on pull request #11818: KAFKA-12558: Do not prematurely mutate partiton state and provide con…

2022-12-30 Thread GitBox
emilnkrastev commented on PR #11818: URL: https://github.com/apache/kafka/pull/11818#issuecomment-1368071838 @C0urante Your suggestion sounds perfect. I have updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] ijuma commented on a diff in pull request #13039: KAFKA-14550 Move SnapshotFile and CorruptSnapshotException to storage module

2022-12-30 Thread GitBox
ijuma commented on code in PR #13039: URL: https://github.com/apache/kafka/pull/13039#discussion_r1059505967 ## storage/src/main/java/org/apache/kafka/server/log/internals/SnapshotFile.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2022-12-30 Thread GitBox
gharris1727 commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1059537788 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -712,8 +733,16 @@ KafkaBasedLog setupAndCreateKafkaBasedLog(S

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2022-12-30 Thread GitBox
gharris1727 commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1059538758 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -723,7 +752,11 @@ private void sendPrivileged(String key, byte

[GitHub] [kafka] ableegoldman opened a new pull request, #13061: [MINOR] Update upgrade documentation for 3.4

2022-12-30 Thread GitBox
ableegoldman opened a new pull request, #13061: URL: https://github.com/apache/kafka/pull/13061 Update documentation and upgrade guide to point to 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman merged pull request #13061: [MINOR] Update upgrade documentation for 3.4

2022-12-30 Thread GitBox
ableegoldman merged PR #13061: URL: https://github.com/apache/kafka/pull/13061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] ableegoldman merged pull request #13062: MINOR: Update LICENSE-binary based on the 3.4 dependencies

2022-12-30 Thread GitBox
ableegoldman merged PR #13062: URL: https://github.com/apache/kafka/pull/13062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Updated] (KAFKA-12622) Automate LICENSE file validation

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12622: --- Fix Version/s: 3.5.0 (was: 3.4.0) > Automate LICENSE

[jira] [Commented] (KAFKA-12622) Automate LICENSE file validation

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653252#comment-17653252 ] A. Sophie Blee-Goldman commented on KAFKA-12622: Updates for 3.4: https

[jira] [Updated] (KAFKA-14175) KRaft Upgrades Part 2

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14175: --- Fix Version/s: (was: 3.4.0) > KRaft Upgrades Part 2 > --

[jira] [Updated] (KAFKA-12886) Enable request forwarding by default

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12886: --- Fix Version/s: 3.5.0 (was: 3.4.0) > Enable request fo

[jira] [Updated] (KAFKA-14305) KRaft Metadata Transactions

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14305: --- Fix Version/s: 3.5.0 (was: 3.4.0) > KRaft Metadata Tr

[jira] [Updated] (KAFKA-14175) KRaft Upgrades Part 2

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14175: --- Fix Version/s: 3.5.0 > KRaft Upgrades Part 2 > - > >

[jira] [Commented] (KAFKA-12886) Enable request forwarding by default

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653253#comment-17653253 ] A. Sophie Blee-Goldman commented on KAFKA-12886: Temporarily bumping to

[jira] [Commented] (KAFKA-14279) Add 3.3.1 to broker/client and stream upgrade/compatibility tests

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653254#comment-17653254 ] A. Sophie Blee-Goldman commented on KAFKA-14279: Temporarily bumping to

[jira] [Updated] (KAFKA-14279) Add 3.3.1 to broker/client and stream upgrade/compatibility tests

2022-12-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-14279: --- Fix Version/s: 3.5.0 (was: 3.4.0) > Add 3.3.1 to brok

[GitHub] [kafka] ableegoldman opened a new pull request, #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox
ableegoldman opened a new pull request, #13063: URL: https://github.com/apache/kafka/pull/13063 Followup to add a section for upgrading KRaft clusters to 3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ableegoldman commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox
ableegoldman commented on code in PR #13063: URL: https://github.com/apache/kafka/pull/13063#discussion_r1059585428 ## docs/upgrade.html: ## @@ -61,6 +61,25 @@ Upgrading to 3.4.0 from any vers +Upgrading a KRaft-based cluster to 3.4.0 from any version 3.0.x t

[GitHub] [kafka] ableegoldman commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox
ableegoldman commented on code in PR #13063: URL: https://github.com/apache/kafka/pull/13063#discussion_r1059585428 ## docs/upgrade.html: ## @@ -61,6 +61,25 @@ Upgrading to 3.4.0 from any vers +Upgrading a KRaft-based cluster to 3.4.0 from any version 3.0.x t

[GitHub] [kafka] ijuma commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox
ijuma commented on code in PR #13063: URL: https://github.com/apache/kafka/pull/13063#discussion_r1059586573 ## docs/upgrade.html: ## @@ -61,6 +61,25 @@ Upgrading to 3.4.0 from any vers +Upgrading a KRaft-based cluster to 3.4.0 from any version 3.0.x through

[GitHub] [kafka] ableegoldman opened a new pull request, #13064: MINOR: bump streams quickstart pom versions and add to list in gradle.properties

2022-12-30 Thread GitBox
ableegoldman opened a new pull request, #13064: URL: https://github.com/apache/kafka/pull/13064 The three pom files for the Streams quickstart also need to bump their versions after a branch cut. For some reason these are included (late) in the Release Process guide, but are missing from th

[GitHub] [kafka] ableegoldman commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox
ableegoldman commented on code in PR #13063: URL: https://github.com/apache/kafka/pull/13063#discussion_r1059604603 ## docs/upgrade.html: ## @@ -61,6 +61,25 @@ Upgrading to 3.4.0 from any vers +Upgrading a KRaft-based cluster to 3.4.0 from any version 3.0.x t

[GitHub] [kafka] ableegoldman commented on a diff in pull request #13063: MINOR: Update KRaft cluster upgrade documentation for 3.4

2022-12-30 Thread GitBox
ableegoldman commented on code in PR #13063: URL: https://github.com/apache/kafka/pull/13063#discussion_r1059604660 ## docs/upgrade.html: ## @@ -103,7 +122,7 @@ Upgrading to 3.3.1 from any vers -Upgrading a KRaft-based cluster to 3.3.1 from any version 3.0.x through