[GitHub] [kafka] fvaleri commented on a diff in pull request #13048: KAFKA-14554: Move ClassLoaderAwareRemoteStorageManagerTest to storage module

2022-12-28 Thread GitBox
fvaleri commented on code in PR #13048: URL: https://github.com/apache/kafka/pull/13048#discussion_r1058184040 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAwareRemoteStorageManagerTest.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache So

[jira] [Updated] (KAFKA-14554) Move ClassLoaderAwareRemoteStorageManagerTest to storage module

2022-12-28 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14554: Fix Version/s: 3.5.0 > Move ClassLoaderAwareRemoteStorageManagerTest to storage module > -

[GitHub] [kafka] showuon opened a new pull request, #13050: MINOR: add error reason when controller failed to handle events

2022-12-28 Thread GitBox
showuon opened a new pull request, #13050: URL: https://github.com/apache/kafka/pull/13050 In KRaft, when controller failed to handle events, we'll log error and return back to brokers. But in some cases, we only log error class name, and return error class name back to brokers, which is un

[GitHub] [kafka] showuon commented on pull request #13050: MINOR: add error reason when controller failed to handle events

2022-12-28 Thread GitBox
showuon commented on PR #13050: URL: https://github.com/apache/kafka/pull/13050#issuecomment-1366523644 @jsancio @dengziming , call for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mimaison commented on a diff in pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

2022-12-28 Thread GitBox
mimaison commented on code in PR #13038: URL: https://github.com/apache/kafka/pull/13038#discussion_r1058234223 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogOffsetMetadata.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Assigned] (KAFKA-8206) A consumer can't discover new group coordinator when the cluster was partly restarted

2022-12-28 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Yurchenko reassigned KAFKA-8206: - Assignee: Ivan Yurchenko > A consumer can't discover new group coordinator when the clus

[GitHub] [kafka] ijuma commented on a diff in pull request #13048: KAFKA-14554: Move ClassLoaderAwareRemoteStorageManagerTest to storage module

2022-12-28 Thread GitBox
ijuma commented on code in PR #13048: URL: https://github.com/apache/kafka/pull/13048#discussion_r1058393160 ## storage/src/test/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAwareRemoteStorageManagerTest.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] ijuma merged pull request #13048: KAFKA-14554: Move ClassLoaderAwareRemoteStorageManagerTest to storage module

2022-12-28 Thread GitBox
ijuma merged PR #13048: URL: https://github.com/apache/kafka/pull/13048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ashmeet13 commented on pull request #12988: KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams

2022-12-28 Thread GitBox
ashmeet13 commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-1366703839 Hi @ableegoldman thank you for the review! I went through the producer configs and was not able to find any config with the name `default.partitioner`. Were you referring to the `part

[GitHub] [kafka] ijuma opened a new pull request, #13051: MINOR: Call LogConfig.validate instead of validateValues in `KafkaMetadataLog`

2022-12-28 Thread GitBox
ijuma opened a new pull request, #13051: URL: https://github.com/apache/kafka/pull/13051 The former may fail or return misleading results if the properties don't include defaults. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[jira] [Resolved] (KAFKA-14554) Move ClassLoaderAwareRemoteStorageManagerTest to storage module

2022-12-28 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri resolved KAFKA-14554. - Resolution: Fixed > Move ClassLoaderAwareRemoteStorageManagerTest to storage module > --

[jira] [Updated] (KAFKA-14552) Remove no longer required server protocol versions in Kafka 4.0

2022-12-28 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14552: Description: Kafka 4.0 will remove support for zk mode and kraft mode became production ready in

[jira] [Assigned] (KAFKA-13748) Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default

2022-12-28 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-13748: - Assignee: Chris Egerton (was: Konstantine Karantasis) > Do not include file stream con

[GitHub] [kafka] ijuma commented on pull request #13051: MINOR: Use `LogConfig.validate` instead of `validateValues` in `KafkaMetadataLog`

2022-12-28 Thread GitBox
ijuma commented on PR #13051: URL: https://github.com/apache/kafka/pull/13051#issuecomment-1366843677 @jsancio Yes, right - this preempts a potential issue if KRaft starts using some of the other properties. This fix also means we don't need to add a workaround in the PR that moves LogConfi

[GitHub] [kafka] ijuma commented on pull request #13051: MINOR: Use `LogConfig.validate` instead of `validateValues` in `KafkaMetadataLog`

2022-12-28 Thread GitBox
ijuma commented on PR #13051: URL: https://github.com/apache/kafka/pull/13051#issuecomment-1366844162 JDK 17 build passed, the other failures are unrelated: > Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft > Bu

[GitHub] [kafka] ijuma merged pull request #13051: MINOR: Use `LogConfig.validate` instead of `validateValues` in `KafkaMetadataLog`

2022-12-28 Thread GitBox
ijuma merged PR #13051: URL: https://github.com/apache/kafka/pull/13051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax merged pull request #12166: KAFKA-13817 Always sync nextTimeToEmit with wall clock

2022-12-28 Thread GitBox
mjsax merged PR #12166: URL: https://github.com/apache/kafka/pull/12166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax commented on pull request #12166: KAFKA-13817 Always sync nextTimeToEmit with wall clock

2022-12-28 Thread GitBox
mjsax commented on PR #12166: URL: https://github.com/apache/kafka/pull/12166#issuecomment-1366902096 Thanks for the PR! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] mjsax closed pull request #12999: [REVERT] Kip-837

2022-12-28 Thread GitBox
mjsax closed pull request #12999: [REVERT] Kip-837 URL: https://github.com/apache/kafka/pull/12999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2022-12-28 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058580168 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -544,7 +544,7 @@ case class MetadataLogConfig(logSegmentBytes: Int, retentio

[GitHub] [kafka] mjsax merged pull request #12613: fix punctuation marks

2022-12-28 Thread GitBox
mjsax merged PR #12613: URL: https://github.com/apache/kafka/pull/12613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax commented on pull request #12613: fix punctuation marks

2022-12-28 Thread GitBox
mjsax commented on PR #12613: URL: https://github.com/apache/kafka/pull/12613#issuecomment-1366909926 Thanks for the PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] mjsax commented on pull request #12608: Enable KStream to be merged with itself

2022-12-28 Thread GitBox
mjsax commented on PR #12608: URL: https://github.com/apache/kafka/pull/12608#issuecomment-1366911487 Can you create a JIRA ticket for this PR? If it's not working right now, I would consider it a bug. And yes, I agree that merging a KStream with itself should result in duplicating e

[GitHub] [kafka] mjsax commented on a diff in pull request #12608: Enable KStream to be merged with itself

2022-12-28 Thread GitBox
mjsax commented on code in PR #12608: URL: https://github.com/apache/kafka/pull/12608#discussion_r1058585746 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java: ## @@ -1694,6 +1694,28 @@ public void shouldMergeMultipleStreams() {

[GitHub] [kafka] mjsax commented on a diff in pull request #12608: Enable KStream to be merged with itself

2022-12-28 Thread GitBox
mjsax commented on code in PR #12608: URL: https://github.com/apache/kafka/pull/12608#discussion_r1058586441 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamPassThrough.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mjsax commented on pull request #12895: KAFKA-13881: Add Clients package description javadocs

2022-12-28 Thread GitBox
mjsax commented on PR #12895: URL: https://github.com/apache/kafka/pull/12895#issuecomment-1366920157 Cherry-picked to `3.4` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] mjsax commented on pull request #12937: KAFKA-13881: Add Connect package infos

2022-12-28 Thread GitBox
mjsax commented on PR #12937: URL: https://github.com/apache/kafka/pull/12937#issuecomment-1366920260 Cherry-picked to `3.4` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Resolved] (KAFKA-13881) Add package.java for public package javadoc

2022-12-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-13881. - Fix Version/s: 3.4.0 (was: 3.5.0) Resolution: Fixed > Add

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2022-12-28 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058599006 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1211,50 +1184,50 @@ object KafkaConfig { .define(NumPartitionsProp, INT, Defaults.NumPartitions, atLe

[GitHub] [kafka] mjsax commented on pull request #12154: KAFKA-12828 Remove deprecated methods in KeyQueryMetadata

2022-12-28 Thread GitBox
mjsax commented on PR #12154: URL: https://github.com/apache/kafka/pull/12154#issuecomment-1366925372 We can remove deprecated APIs only after keeping them for at least one year, plus only in a major release. Cannot merge this PR. Closing it for now -- feel free to re-open when we announce

[GitHub] [kafka] mjsax closed pull request #12154: KAFKA-12828 Remove deprecated methods in KeyQueryMetadata

2022-12-28 Thread GitBox
mjsax closed pull request #12154: KAFKA-12828 Remove deprecated methods in KeyQueryMetadata URL: https://github.com/apache/kafka/pull/12154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] ijuma commented on pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2022-12-28 Thread GitBox
ijuma commented on PR #13049: URL: https://github.com/apache/kafka/pull/13049#issuecomment-1366926066 JDK 8 and JDK 11 builds passed, JDK 17 had one unrelated failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] mjsax merged pull request #11049: MINOR: Fix small warning on javadoc and scaladoc

2022-12-28 Thread GitBox
mjsax merged PR #11049: URL: https://github.com/apache/kafka/pull/11049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax commented on pull request #11049: MINOR: Fix small warning on javadoc and scaladoc

2022-12-28 Thread GitBox
mjsax commented on PR #11049: URL: https://github.com/apache/kafka/pull/11049#issuecomment-1366930598 Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] jlprat commented on pull request #11049: MINOR: Fix small warning on javadoc and scaladoc

2022-12-28 Thread GitBox
jlprat commented on PR #11049: URL: https://github.com/apache/kafka/pull/11049#issuecomment-1366931538 Thank you for reviewing and merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2022-12-28 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058615668 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mjsax commented on a diff in pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder.

2022-12-28 Thread GitBox
mjsax commented on code in PR #11047: URL: https://github.com/apache/kafka/pull/11047#discussion_r1058616311 ## streams/src/test/java/org/apache/kafka/streams/state/internals/WindowStoreBuilderTest.java: ## @@ -143,17 +143,6 @@ public void shouldThrowNullPointerIfInnerIsNull() {

[GitHub] [kafka] mjsax commented on pull request #10373: MINOR: Typo fixes

2022-12-28 Thread GitBox
mjsax commented on PR #10373: URL: https://github.com/apache/kafka/pull/10373#issuecomment-1366934397 @andygarfield Thanks for the PR -- seems there are merge conflict. Could you rebase the PR so we can merge it? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2022-12-28 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058623037 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2022-12-28 Thread GitBox
ijuma commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1058623369 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogConfig.java: ## @@ -0,0 +1,504 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mjsax commented on pull request #8431: MINOR: Rename description of flatMapValues transformation

2022-12-28 Thread GitBox
mjsax commented on PR #8431: URL: https://github.com/apache/kafka/pull/8431#issuecomment-1366950411 @maseiler -- thanks for your PR -- could you update it so we can merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] mjsax closed pull request #7330: KAFKA-8894: Bump streams test topic deletion assertion timeout from 30s to 60s

2022-12-28 Thread GitBox
mjsax closed pull request #7330: KAFKA-8894: Bump streams test topic deletion assertion timeout from 30s to 60s URL: https://github.com/apache/kafka/pull/7330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] mjsax commented on pull request #7330: KAFKA-8894: Bump streams test topic deletion assertion timeout from 30s to 60s

2022-12-28 Thread GitBox
mjsax commented on PR #7330: URL: https://github.com/apache/kafka/pull/7330#issuecomment-1366953638 Closing this PR as the corresponding Jira ticket is marked "resolved". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mjsax commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

2022-12-28 Thread GitBox
mjsax commented on PR #9972: URL: https://github.com/apache/kafka/pull/9972#issuecomment-1366954511 > KAFKA-8779: Reintroduce flaky tests @tombentley -- I don't think we should re-introduce flaky tests 😁 (sorry, not sorry; couldn't resist) -- This is an automated message from the A

[GitHub] [kafka] mjsax commented on pull request #7034: MINOR: Do not end Javadoc comments with `**/`

2022-12-28 Thread GitBox
mjsax commented on PR #7034: URL: https://github.com/apache/kafka/pull/7034#issuecomment-1366955141 @eneveu -- Thanks for the PR. Seems it's outdated. Would you like to update it so we can merge it? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] mjsax commented on pull request #6640: MINOR: Fix directory name inconsistency in the Kafka Streams tutorial

2022-12-28 Thread GitBox
mjsax commented on PR #6640: URL: https://github.com/apache/kafka/pull/6640#issuecomment-1366956240 @sekikn -- Thanks for the PR -- could you rebase it so we can merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] mjsax closed pull request #6512: Add KStream branch with fluent API

2022-12-28 Thread GitBox
mjsax closed pull request #6512: Add KStream branch with fluent API URL: https://github.com/apache/kafka/pull/6512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] mjsax commented on pull request #6512: Add KStream branch with fluent API

2022-12-28 Thread GitBox
mjsax commented on PR #6512: URL: https://github.com/apache/kafka/pull/6512#issuecomment-1366957170 This PR proposed a public API change, and thus we need to do a KIP first: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals Closing this PR for now. We can r

[GitHub] [kafka] mjsax merged pull request #8335: MINOR: Add implicit for Serde[UUID] to Streams Scala API

2022-12-28 Thread GitBox
mjsax merged PR #8335: URL: https://github.com/apache/kafka/pull/8335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

[GitHub] [kafka] mjsax commented on pull request #8335: MINOR: Add implicit for Serde[UUID] to Streams Scala API

2022-12-28 Thread GitBox
mjsax commented on PR #8335: URL: https://github.com/apache/kafka/pull/8335#issuecomment-1366968297 Thanks for the PR @vkorenev -- merge to `trunk` (better late than never...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Commented] (KAFKA-8403) Make suppression results queriable

2022-12-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652611#comment-17652611 ] Matthias J. Sax commented on KAFKA-8403: [~vvcephei] – given https://issues.apach

[GitHub] [kafka] mjsax commented on pull request #6856: KAFKA-8410: [POC] strong typing for processors

2022-12-28 Thread GitBox
mjsax commented on PR #6856: URL: https://github.com/apache/kafka/pull/6856#issuecomment-1366969603 The corresponding Jira is resolved. Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] mjsax closed pull request #6856: KAFKA-8410: [POC] strong typing for processors

2022-12-28 Thread GitBox
mjsax closed pull request #6856: KAFKA-8410: [POC] strong typing for processors URL: https://github.com/apache/kafka/pull/6856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [kafka] mjsax merged pull request #11569: DOCS-9992: Fix method name in table-table FK left join example

2022-12-28 Thread GitBox
mjsax merged PR #11569: URL: https://github.com/apache/kafka/pull/11569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax commented on pull request #11569: DOCS-9992: Fix method name in table-table FK left join example

2022-12-28 Thread GitBox
mjsax commented on PR #11569: URL: https://github.com/apache/kafka/pull/11569#issuecomment-1366969914 Thanks for the PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] mjsax merged pull request #12008: KAFKA-13439: move upgrade note to stream upgrade doc

2022-12-28 Thread GitBox
mjsax merged PR #12008: URL: https://github.com/apache/kafka/pull/12008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax commented on pull request #12008: KAFKA-13439: move upgrade note to stream upgrade doc

2022-12-28 Thread GitBox
mjsax commented on PR #12008: URL: https://github.com/apache/kafka/pull/12008#issuecomment-1366971324 Thanks for the PR! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] csolidum opened a new pull request, #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2022-12-28 Thread GitBox
csolidum opened a new pull request, #13052: URL: https://github.com/apache/kafka/pull/13052 Now returns an empty Optional instead of throwing a NullPointerException Added a new test case to cover passing in a null offsetAndMetadata to make sure the works as expected. ### Commit

[jira] [Commented] (KAFKA-14545) MirrorCheckpointTask throws NullPointerException when group hasn't consumed from some partitions

2022-12-28 Thread Chris Solidum (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652612#comment-17652612 ] Chris Solidum commented on KAFKA-14545: --- ended up making the change in checkpoint

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2022-12-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652613#comment-17652613 ] Matthias J. Sax commented on KAFKA-10493: - Given that "version KTable" KIP is ap

[jira] [Resolved] (KAFKA-10493) KTable out-of-order updates are not being ignored

2022-12-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10493. - Fix Version/s: (was: 4.0.0) Assignee: (was: Matthias J. Sax) Reso

[GitHub] [kafka] mjsax commented on pull request #12356: KAFKA-10493: Drop out-of-order records in KTable

2022-12-28 Thread GitBox
mjsax commented on PR #12356: URL: https://github.com/apache/kafka/pull/12356#issuecomment-1366975287 Given that we have https://cwiki.apache.org/confluence/display/KAFKA/KIP-889%3A+Versioned+State+Stores approved, I close the corresponding Jira (and the other open PR for it: https://githu

[GitHub] [kafka] mjsax closed pull request #12356: KAFKA-10493: Drop out-of-order records in KTable

2022-12-28 Thread GitBox
mjsax closed pull request #12356: KAFKA-10493: Drop out-of-order records in KTable URL: https://github.com/apache/kafka/pull/12356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [kafka] mjsax commented on pull request #10533: KAFKA-10493: Drop out-of-order KTable records (WIP)

2022-12-28 Thread GitBox
mjsax commented on PR #10533: URL: https://github.com/apache/kafka/pull/10533#issuecomment-1366975494 Given that we have https://cwiki.apache.org/confluence/display/KAFKA/KIP-889%3A+Versioned+State+Stores approved, I close the corresponding Jira (and the other open PR for it: https://githu

[GitHub] [kafka] mjsax closed pull request #10533: KAFKA-10493: Drop out-of-order KTable records (WIP)

2022-12-28 Thread GitBox
mjsax closed pull request #10533: KAFKA-10493: Drop out-of-order KTable records (WIP) URL: https://github.com/apache/kafka/pull/10533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] mjsax merged pull request #12431: MINOR : typo in trace log

2022-12-28 Thread GitBox
mjsax merged PR #12431: URL: https://github.com/apache/kafka/pull/12431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] gharris1727 opened a new pull request, #13053: KAFKA-13881: Add Storage package info

2022-12-28 Thread GitBox
gharris1727 opened a new pull request, #13053: URL: https://github.com/apache/kafka/pull/13053 This module exposes a single package as public API that needs a package description. Similar to #12895. Signed-off-by: Greg Harris ### Committer Checklist (excluded from commi

[GitHub] [kafka] gharris1727 commented on pull request #13053: KAFKA-13881: Add Storage package info

2022-12-28 Thread GitBox
gharris1727 commented on PR #13053: URL: https://github.com/apache/kafka/pull/13053#issuecomment-1366977403 @mimaison Sorry for the delay on opening this, I didn't notice this package was public API. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] mjsax commented on a diff in pull request #12608: Enable KStream to be merged with itself

2022-12-28 Thread GitBox
mjsax commented on code in PR #12608: URL: https://github.com/apache/kafka/pull/12608#discussion_r1058650295 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -532,29 +532,36 @@ private KStream merge(final InternalStreamsBuilder builder

[GitHub] [kafka] mjsax commented on a diff in pull request #12608: Enable KStream to be merged with itself

2022-12-28 Thread GitBox
mjsax commented on code in PR #12608: URL: https://github.com/apache/kafka/pull/12608#discussion_r1058650447 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java: ## @@ -1694,6 +1694,28 @@ public void shouldMergeMultipleStreams() {

[GitHub] [kafka] mjsax merged pull request #12470: Update WordCountTransformerDemo comments

2022-12-28 Thread GitBox
mjsax merged PR #12470: URL: https://github.com/apache/kafka/pull/12470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax commented on pull request #12470: Update WordCountTransformerDemo comments

2022-12-28 Thread GitBox
mjsax commented on PR #12470: URL: https://github.com/apache/kafka/pull/12470#issuecomment-1366983200 Thanks for the PR. Merged to `trunk` and cherry-picked to `3.4` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-13295) Long restoration times for new tasks can lead to transaction timeouts

2022-12-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652620#comment-17652620 ] Matthias J. Sax commented on KAFKA-13295: - [~ableegoldman] – I am wondering if t

[GitHub] [kafka] mjsax commented on pull request #11977: KAFKA-13787 explicitly delete left over state directory contents to a…

2022-12-28 Thread GitBox
mjsax commented on PR #11977: URL: https://github.com/apache/kafka/pull/11977#issuecomment-1366985040 @nico-javadev -- you never followed up on the PR comment. Are you still interested to work on this? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on pull request #9328: MINOR: Add deleteDir for streams quickstart test

2022-12-28 Thread GitBox
mjsax commented on PR #9328: URL: https://github.com/apache/kafka/pull/9328#issuecomment-1366985275 @mumrah -- do you still want to get this done? Or should we close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] mjsax merged pull request #10164: MINOR: remove unused org.apache.kafka.streams.processor.internals.Res…

2022-12-28 Thread GitBox
mjsax merged PR #10164: URL: https://github.com/apache/kafka/pull/10164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mjsax commented on pull request #10164: MINOR: remove unused org.apache.kafka.streams.processor.internals.Res…

2022-12-28 Thread GitBox
mjsax commented on PR #10164: URL: https://github.com/apache/kafka/pull/10164#issuecomment-1366985697 Thanks for the PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

2022-12-28 Thread GitBox
mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1058656046 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -45,34 +45,30 @@ public void setIfUnset(final Serializer defaultKeySeri

[GitHub] [kafka] mjsax merged pull request #6867: Fixed error in KTable.java

2022-12-28 Thread GitBox
mjsax merged PR #6867: URL: https://github.com/apache/kafka/pull/6867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

[GitHub] [kafka] mjsax commented on pull request #6867: Fixed error in KTable.java

2022-12-28 Thread GitBox
mjsax commented on PR #6867: URL: https://github.com/apache/kafka/pull/6867#issuecomment-1366991182 Thanks for the PR. Merged to `trunk` and cherry-picked to `3.4` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] mjsax closed pull request #6851: MINOR: Check for needed commits inside numIterations loop to avoid txn timeouts

2022-12-28 Thread GitBox
mjsax closed pull request #6851: MINOR: Check for needed commits inside numIterations loop to avoid txn timeouts URL: https://github.com/apache/kafka/pull/6851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] mjsax commented on pull request #6851: MINOR: Check for needed commits inside numIterations loop to avoid txn timeouts

2022-12-28 Thread GitBox
mjsax commented on PR #6851: URL: https://github.com/apache/kafka/pull/6851#issuecomment-1366991898 Closing this PR as outdated. We did fix a few things with regard to committing and transaction timeout in the mean time anyway. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax commented on pull request #6530: add break keyword, when globalGroups has already updated.

2022-12-28 Thread GitBox
mjsax commented on PR #6530: URL: https://github.com/apache/kafka/pull/6530#issuecomment-1366992418 Closing this PR and re-open it to retrigger a test run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] mjsax closed pull request #6530: add break keyword, when globalGroups has already updated.

2022-12-28 Thread GitBox
mjsax closed pull request #6530: add break keyword, when globalGroups has already updated. URL: https://github.com/apache/kafka/pull/6530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mjsax commented on pull request #6530: add break keyword, when globalGroups has already updated.

2022-12-28 Thread GitBox
mjsax commented on PR #6530: URL: https://github.com/apache/kafka/pull/6530#issuecomment-1366992569 Seems, cannot re-open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [kafka] mjsax commented on pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class

2022-12-28 Thread GitBox
mjsax commented on PR #10569: URL: https://github.com/apache/kafka/pull/10569#issuecomment-1366993106 Closing this PR due to inactivity. We never received a KIP proposal that would be required for a public API change. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] mjsax closed pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class

2022-12-28 Thread GitBox
mjsax closed pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class URL: https://github.com/apache/kafka/pull/10569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mjsax commented on pull request #1668: KAFKA-3973: feasibility caching bytes vs records

2022-12-28 Thread GitBox
mjsax commented on PR #1668: URL: https://github.com/apache/kafka/pull/1668#issuecomment-1366994295 Closing this old PR -- the corresponding Jira is marked as "resolved". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mjsax closed pull request #1668: KAFKA-3973: feasibility caching bytes vs records

2022-12-28 Thread GitBox
mjsax closed pull request #1668: KAFKA-3973: feasibility caching bytes vs records URL: https://github.com/apache/kafka/pull/1668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] mjsax closed pull request #2159: KAFKA-4273 - Add TTL support for RocksDB

2022-12-28 Thread GitBox
mjsax closed pull request #2159: KAFKA-4273 - Add TTL support for RocksDB URL: https://github.com/apache/kafka/pull/2159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [kafka] mjsax commented on pull request #2159: KAFKA-4273 - Add TTL support for RocksDB

2022-12-28 Thread GitBox
mjsax commented on PR #2159: URL: https://github.com/apache/kafka/pull/2159#issuecomment-1366994483 Closing this stale PR due to inactivity. We would need a KIP for this change to begin with. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] mjsax closed pull request #3134: KAFKA-5315: should not subtract for empty key in KTable.aggregate/reduce

2022-12-28 Thread GitBox
mjsax closed pull request #3134: KAFKA-5315: should not subtract for empty key in KTable.aggregate/reduce URL: https://github.com/apache/kafka/pull/3134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax commented on pull request #3581: KAFKA-5648: make Merger extend Aggregator

2022-12-28 Thread GitBox
mjsax commented on PR #3581: URL: https://github.com/apache/kafka/pull/3581#issuecomment-1366995064 Closing this stale PR due to inactivity. We would need an approved KIP anyway before we could merge it. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] mjsax closed pull request #3581: KAFKA-5648: make Merger extend Aggregator

2022-12-28 Thread GitBox
mjsax closed pull request #3581: KAFKA-5648: make Merger extend Aggregator URL: https://github.com/apache/kafka/pull/3581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [kafka] mjsax commented on pull request #3657: Kafka-5676: MockStreamsMetrics should be in o.a.k.test

2022-12-28 Thread GitBox
mjsax commented on PR #3657: URL: https://github.com/apache/kafka/pull/3657#issuecomment-1366995270 Closing this old PR due to inactivity. PR would need to be rebased anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] mjsax closed pull request #3657: Kafka-5676: MockStreamsMetrics should be in o.a.k.test

2022-12-28 Thread GitBox
mjsax closed pull request #3657: Kafka-5676: MockStreamsMetrics should be in o.a.k.test URL: https://github.com/apache/kafka/pull/3657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] mjsax closed pull request #4453: KAFKA-6035: Avoid creating changelog topics for state stores that are directly piped to a sink topic

2022-12-28 Thread GitBox
mjsax closed pull request #4453: KAFKA-6035: Avoid creating changelog topics for state stores that are directly piped to a sink topic URL: https://github.com/apache/kafka/pull/4453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mjsax commented on pull request #4453: KAFKA-6035: Avoid creating changelog topics for state stores that are directly piped to a sink topic

2022-12-28 Thread GitBox
mjsax commented on PR #4453: URL: https://github.com/apache/kafka/pull/4453#issuecomment-1366995849 Closing this stale PR due to inactivity. We still want this improvement, but the PR would need to be updated to the latest code base. -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] mjsax commented on pull request #4680: Feature/refactor subscription info

2022-12-28 Thread GitBox
mjsax commented on PR #4680: URL: https://github.com/apache/kafka/pull/4680#issuecomment-1366996267 Closing this stale PR due to inactivity. Not even sure if we would still need this refactoring given all the changes we applied in the mean time. -- This is an automated message from the Ap

[GitHub] [kafka] mjsax closed pull request #4680: Feature/refactor subscription info

2022-12-28 Thread GitBox
mjsax closed pull request #4680: Feature/refactor subscription info URL: https://github.com/apache/kafka/pull/4680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

  1   2   >