[GitHub] [kafka] dajac commented on a diff in pull request #12886: KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

dajac commented on code in PR #12886: URL: https://github.com/apache/kafka/pull/12886#discussion_r1057149271 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -234,4 +240,78 @@ class GroupCoordinatorAdapter( } CompletableFuture.complet

[GitHub] [kafka] dajac commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

dajac commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1057150940 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java: ## @@ -227,6 +227,24 @@ public boolean requireStable() { return data.requireSt

[GitHub] [kafka] dajac commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

dajac commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1057151410 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java: ## @@ -227,6 +227,24 @@ public boolean requireStable() { return data.requireSt

[GitHub] [kafka] dajac commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

dajac commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1057152045 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java: ## @@ -208,6 +203,56 @@ public OffsetFetchResponse(int throttleTimeMs, this.e

[GitHub] [kafka] dajac commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

dajac commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1057152725 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1338,27 +1337,22 @@ class KafkaApis(val requestChannel: RequestChannel, /** * Handle an offset fetch re

[GitHub] [kafka] mimaison commented on a diff in pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

mimaison commented on code in PR #13038: URL: https://github.com/apache/kafka/pull/13038#discussion_r1057264707 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -444,13 +444,12 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ def maybeUpdateHighWatermark

[GitHub] [kafka] mimaison commented on a diff in pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

mimaison commented on code in PR #13038: URL: https://github.com/apache/kafka/pull/13038#discussion_r1057271751 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogOffsetMetadata.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Created] (KAFKA-14553) RecordAccumulator hangs in infinite NOP loop

Viczai Gábor created KAFKA-14553: Summary: RecordAccumulator hangs in infinite NOP loop Key: KAFKA-14553 URL: https://issues.apache.org/jira/browse/KAFKA-14553 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-14553) RecordAccumulator hangs in infinite NOP loop

[ https://issues.apache.org/jira/browse/KAFKA-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14553. --- Fix Version/s: 3.4.0 3.3.2 Resolution: Duplicate > RecordAccumulator hangs

[jira] [Commented] (KAFKA-14553) RecordAccumulator hangs in infinite NOP loop

[ https://issues.apache.org/jira/browse/KAFKA-14553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652076#comment-17652076 ] Luke Chen commented on KAFKA-14553: --- [~gviczai] , thanks for reporting the issue. This

[GitHub] [kafka] showuon merged pull request #13045: MINOR: Add .vscode/ to git ignore for devs using vscode or codium

showuon merged PR #13045: URL: https://github.com/apache/kafka/pull/13045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

showuon commented on code in PR #13037: URL: https://github.com/apache/kafka/pull/13037#discussion_r1057419517 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -423,7 +423,24 @@ object TestUtils extends Logging { } result.topicId(topic).get() -} + } +

[GitHub] [kafka] showuon commented on pull request #13037: MINOR: make sure all partition info is propagated

showuon commented on PR #13037: URL: https://github.com/apache/kafka/pull/13037#issuecomment-1365582924 @ijuma , I've addressed your comments. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ijuma commented on a diff in pull request #13038: KAFKA-14543: Move LogOffsetMetadata to storage module

ijuma commented on code in PR #13038: URL: https://github.com/apache/kafka/pull/13038#discussion_r1057419575 ## storage/src/main/java/org/apache/kafka/server/log/internals/LogOffsetMetadata.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under