[GitHub] [kafka] chia7712 commented on pull request #12979: KAFKA-14544 The "is-future" should be removed from metrics tags after future log becomes current log

2022-12-24 Thread GitBox
chia7712 commented on PR #12979: URL: https://github.com/apache/kafka/pull/12979#issuecomment-1364541293 @showuon Could you take a look again? the latest commit includes extra changes to address your comment. -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Created] (KAFKA-14552) Remove no longer required server protocol versions in Kafka 4.0

2022-12-24 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-14552: --- Summary: Remove no longer required server protocol versions in Kafka 4.0 Key: KAFKA-14552 URL: https://issues.apache.org/jira/browse/KAFKA-14552 Project: Kafka

[jira] [Updated] (KAFKA-14552) Remove no longer required server protocol versions in Kafka 4.0

2022-12-24 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14552: Description: Kafka 4.0 will remove support for zk mode and kraft mode became production ready in

[GitHub] [kafka] showuon commented on a diff in pull request #12979: KAFKA-14544 The "is-future" should be removed from metrics tags after future log becomes current log

2022-12-24 Thread GitBox
showuon commented on code in PR #12979: URL: https://github.com/apache/kafka/pull/12979#discussion_r1056904583 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1795,10 +1803,10 @@ class UnifiedLog(@volatile var logStartOffset: Long, * remove deleted log metrics

[GitHub] [kafka] showuon commented on a diff in pull request #12979: KAFKA-14544 The "is-future" should be removed from metrics tags after future log becomes current log

2022-12-24 Thread GitBox
showuon commented on code in PR #12979: URL: https://github.com/apache/kafka/pull/12979#discussion_r1056904807 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1795,10 +1803,10 @@ class UnifiedLog(@volatile var logStartOffset: Long, * remove deleted log metrics

[GitHub] [kafka] chia7712 commented on a diff in pull request #12979: KAFKA-14544 The "is-future" should be removed from metrics tags after future log becomes current log

2022-12-24 Thread GitBox
chia7712 commented on code in PR #12979: URL: https://github.com/apache/kafka/pull/12979#discussion_r1056909612 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1795,10 +1803,10 @@ class UnifiedLog(@volatile var logStartOffset: Long, * remove deleted log metrics