[jira] [Commented] (KAFKA-14379) consumer should refresh preferred read replica on update metadata

2022-11-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638188#comment-17638188 ] Luke Chen commented on KAFKA-14379: --- [~jeffkbkim] , we recently also encountered this

[jira] [Updated] (KAFKA-14379) consumer should refresh preferred read replica on update metadata

2022-11-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14379: -- Description: The consumer (fetcher) refreshes the preferred read replica only on three conditions: #

[jira] [Commented] (KAFKA-14379) consumer should refresh preferred read replica on update metadata

2022-11-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638191#comment-17638191 ] Luke Chen commented on KAFKA-14379: --- Oh, sorry, I saw you have a WIP PR opened. Thanks

[GitHub] [kafka] lucasbru opened a new pull request, #12903: KAFKA-14415: Faster ThreadCache

2022-11-24 Thread GitBox
lucasbru opened a new pull request, #12903: URL: https://github.com/apache/kafka/pull/12903 Optimization of `ThreadCache`. The original implementation showed significant slow-down when many caches were registered. `sizeBytes` was called at least once, and potentially many times in eve

[GitHub] [kafka] lucasbru commented on pull request #12903: KAFKA-14415: Faster ThreadCache

2022-11-24 Thread GitBox
lucasbru commented on PR #12903: URL: https://github.com/apache/kafka/pull/12903#issuecomment-1326138928 @ableegoldman Could you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-24 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638225#comment-17638225 ] Mikael commented on KAFKA-14362: I can confirm that there is no duplication in this scen

[GitHub] [kafka] patrik-marton commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

2022-11-24 Thread GitBox
patrik-marton commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1031302727 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,84 @@ public void han

[GitHub] [kafka] lucasbru opened a new pull request, #12904: KAFKA-14299: Handle double rebalances better

2022-11-24 Thread GitBox
lucasbru opened a new pull request, #12904: URL: https://github.com/apache/kafka/pull/12904 The original implementation of the state updater could not handle double rebalances within one poll phase correctly, because it could create tasks more than once if they hadn't finished initia

[GitHub] [kafka] lucasbru commented on pull request #12904: KAFKA-14299: Handle double rebalances better

2022-11-24 Thread GitBox
lucasbru commented on PR #12904: URL: https://github.com/apache/kafka/pull/12904#issuecomment-1326221089 @cadonna could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] clolov commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-11-24 Thread GitBox
clolov commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1326276846 Polite bump for a review here @cadonna. I have rebased on the latest trunk and I believe I have answered the majority of the comments already on the pull request. Given the size of the cha

[jira] [Created] (KAFKA-14418) Add safety checks for modifying partitions of __consumer_offsets

2022-11-24 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-14418: Summary: Add safety checks for modifying partitions of __consumer_offsets Key: KAFKA-14418 URL: https://issues.apache.org/jira/browse/KAFKA-14418 Project: Kafka

[jira] [Updated] (KAFKA-14418) Add safety checks for modifying partitions of __consumer_offsets

2022-11-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14418: - Description: Today a user can change the number of partitions of {{{}_{}}}{_}{{_consumer}}{_}{{

[GitHub] [kafka] divijvaidya commented on pull request #12890: KAFKA-14414: Remove unnecessary usage of ObjectSerializationCache

2022-11-24 Thread GitBox
divijvaidya commented on PR #12890: URL: https://github.com/apache/kafka/pull/12890#issuecomment-1326424695 @mimaison please take a look when you get a chance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Created] (KAFKA-14419) Same message consumed again by the same stream task after partition is lost and reassigned

2022-11-24 Thread Mikael (Jira)
Mikael created KAFKA-14419: -- Summary: Same message consumed again by the same stream task after partition is lost and reassigned Key: KAFKA-14419 URL: https://issues.apache.org/jira/browse/KAFKA-14419 Projec

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-24 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638282#comment-17638282 ] Mikael commented on KAFKA-14362: Created KAFKA-14419 for the stream consumer duplication

[jira] [Updated] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-24 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael updated KAFKA-14362: --- Attachment: (was: KAFKA-14362_Do_not_return_any_records_from_KafkaConsumer_poll()_while_rebalance_is_in_

[GitHub] [kafka] divijvaidya commented on pull request #12900: MINOR: Improve Scala collection usage

2022-11-24 Thread GitBox
divijvaidya commented on PR #12900: URL: https://github.com/apache/kafka/pull/12900#issuecomment-1326457410 > Were these suggestions generated through some sort of a tool? No. I checked them manually. This came up while I was trying to find optimisation opportunities for toSet scala o

[GitHub] [kafka] dajac commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-24 Thread GitBox
dajac commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1031512818 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -44,14 +46,26 @@ public AbstractStickyAssignor createAssignor() {

[GitHub] [kafka] lucasbru commented on pull request #12903: KAFKA-14415: Faster ThreadCache

2022-11-24 Thread GitBox
lucasbru commented on PR #12903: URL: https://github.com/apache/kafka/pull/12903#issuecomment-1326489671 Test failures are unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] dajac commented on a diff in pull request #12877: KAFKA-14372: choose replicas only from isr for preferred read replica

2022-11-24 Thread GitBox
dajac commented on code in PR #12877: URL: https://github.com/apache/kafka/pull/12877#discussion_r1031546311 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -84,9 +84,58 @@ class FetchFromFollowerIntegrationTest extends BaseFetchReq

[GitHub] [kafka] dajac merged pull request #12877: KAFKA-14372: choose replicas only from isr for preferred read replica

2022-11-24 Thread GitBox
dajac merged PR #12877: URL: https://github.com/apache/kafka/pull/12877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac commented on pull request #12877: KAFKA-14372: choose replicas only from isr for preferred read replica

2022-11-24 Thread GitBox
dajac commented on PR #12877: URL: https://github.com/apache/kafka/pull/12877#issuecomment-1326505121 Merged to trunk and 3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (KAFKA-14372) RackAwareReplicaSelector should choose a replica from the isr

2022-11-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14372. - Fix Version/s: 3.4.0 3.3.2 Resolution: Fixed > RackAwareReplicaSelecto

[GitHub] [kafka] dajac merged pull request #12308: KAFKA-14009: Rebalance timeout should be updated when static member rejoins

2022-11-24 Thread GitBox
dajac merged PR #12308: URL: https://github.com/apache/kafka/pull/12308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-14009) Rebalance timeout should be updated when static member rejoins

2022-11-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14009: Summary: Rebalance timeout should be updated when static member rejoins (was: Consumers do not re

[jira] [Assigned] (KAFKA-14009) Rebalance timeout should be updated when static member rejoins

2022-11-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-14009: --- Assignee: zou shengfu > Rebalance timeout should be updated when static member rejoins > --

[GitHub] [kafka] dajac commented on pull request #12308: KAFKA-14009: Rebalance timeout should be updated when static member rejoins

2022-11-24 Thread GitBox
dajac commented on PR #12308: URL: https://github.com/apache/kafka/pull/12308#issuecomment-1326519129 @Stephan14 Thanks for the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (KAFKA-14009) Rebalance timeout should be updated when static member rejoins

2022-11-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14009. - Fix Version/s: 3.4.0 3.3.2 Resolution: Fixed > Rebalance timeout shoul

[GitHub] [kafka] dajac commented on pull request #12308: KAFKA-14009: Rebalance timeout should be updated when static member rejoins

2022-11-24 Thread GitBox
dajac commented on PR #12308: URL: https://github.com/apache/kafka/pull/12308#issuecomment-1326519325 Merged to trunk and 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] divijvaidya commented on pull request #12891: MINOR: Reduce impact of trace logging produce request hot path

2022-11-24 Thread GitBox
divijvaidya commented on PR #12891: URL: https://github.com/apache/kafka/pull/12891#issuecomment-1326539413 Hi @C0urante @showuon I didn't find much difference in CPU usage after this optimization (thanks to Chris's tip on adding after/before profile), hence I am aborting this PR. It

[GitHub] [kafka] divijvaidya closed pull request #12891: MINOR: Reduce impact of trace logging produce request hot path

2022-11-24 Thread GitBox
divijvaidya closed pull request #12891: MINOR: Reduce impact of trace logging produce request hot path URL: https://github.com/apache/kafka/pull/12891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-14418) Add safety checks for modifying partitions of __consumer_offsets

2022-11-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14418: - Description: Today a user can change the number of partitions of {{{}{}}}{{{}_consumer_{}}}{{{}

[GitHub] [kafka] jonathan-albrecht-ibm commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-11-24 Thread GitBox
jonathan-albrecht-ibm commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1031785630 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -2263,7 +2263,10 @@ public void configure(Map configs) {

[GitHub] [kafka] jonathan-albrecht-ibm commented on a diff in pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-11-24 Thread GitBox
jonathan-albrecht-ibm commented on code in PR #12343: URL: https://github.com/apache/kafka/pull/12343#discussion_r1031785699 ## core/src/test/scala/kafka/security/minikdc/MiniKdc.scala: ## @@ -260,11 +260,17 @@ class MiniKdc(config: Properties, workDir: File) extends Logging {

[GitHub] [kafka] jonathan-albrecht-ibm commented on pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-11-24 Thread GitBox
jonathan-albrecht-ibm commented on PR #12343: URL: https://github.com/apache/kafka/pull/12343#issuecomment-1326790440 TFTR @cadonna, I've updated the changes according to your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] lucasbru commented on pull request #12875: KAFKA-12679: Handle lock exceptions in state updater

2022-11-24 Thread GitBox
lucasbru commented on PR #12875: URL: https://github.com/apache/kafka/pull/12875#issuecomment-1326818177 Okay, I revised the change and it is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] Scanteianu opened a new pull request, #12906: make CI pass

2022-11-24 Thread GitBox
Scanteianu opened a new pull request, #12906: URL: https://github.com/apache/kafka/pull/12906 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-24 Thread GitBox
showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1032023101 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -44,14 +46,26 @@ public AbstractStickyAssignor createAssignor() {

[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-24 Thread GitBox
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1327047070 @dajac , thanks for the comment. And thanks to the test, I found there's one thing I missed, which is in eager rebalance protocol like StickyAssignor, the ownedPartitions will all get rev