[jira] [Commented] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-21 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636512#comment-17636512 ] Victor van den Hoven commented on KAFKA-14400: -- !Afbeelding 2.png! > KStre

[jira] [Updated] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-21 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor van den Hoven updated KAFKA-14400: - Attachment: Afbeelding 2.png > KStream - KStream - LeftJoin() does not call Valu

[jira] [Comment Edited] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-21 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636512#comment-17636512 ] Victor van den Hoven edited comment on KAFKA-14400 at 11/21/22 8:05 AM: --

[jira] [Comment Edited] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-21 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636512#comment-17636512 ] Victor van den Hoven edited comment on KAFKA-14400 at 11/21/22 8:06 AM: --

[jira] [Comment Edited] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-21 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636509#comment-17636509 ] Victor van den Hoven edited comment on KAFKA-14400 at 11/21/22 8:07 AM: --

[GitHub] [kafka] ceki commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-11-21 Thread GitBox
ceki commented on PR #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1321685023 @Indupa The correct fully qualified class name for `RollingFileAppender` is `org.apache.log4j.RollingFileAppender` and not `org.apache.log4j.rolling.RollingFileAppender`. -- This is an aut

[jira] [Created] (KAFKA-14410) Allow connect runtime to run multiple versions of a connector.

2022-11-21 Thread Snehashis Pal (Jira)
Snehashis Pal created KAFKA-14410: - Summary: Allow connect runtime to run multiple versions of a connector. Key: KAFKA-14410 URL: https://issues.apache.org/jira/browse/KAFKA-14410 Project: Kafka

[GitHub] [kafka] dajac commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
dajac commented on code in PR #12870: URL: https://github.com/apache/kafka/pull/12870#discussion_r1027741608 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -150,42 +149,6 @@ class OffsetFetchRequestTest extends BaseRequestTest { } } - @Te

[GitHub] [kafka] cadonna commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-11-21 Thread GitBox
cadonna commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1321749658 I restarted the builds to ensure everything is still fine with current trunk since they were run 18 days ago last time. If the builds are acceptable, I will merge the PR. -- This i

[GitHub] [kafka] nicktelford commented on pull request #12842: KAFKA-14406: Fix double iteration of restoring records

2022-11-21 Thread GitBox
nicktelford commented on PR #12842: URL: https://github.com/apache/kafka/pull/12842#issuecomment-1321789047 @ableegoldman Thanks. My JIRA username is `nicktelford`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Assigned] (KAFKA-14406) Double iteration of records in batches to be restored

2022-11-21 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford reassigned KAFKA-14406: Assignee: Nicholas Telford > Double iteration of records in batches to be restore

[GitHub] [kafka] vamossagar12 commented on pull request #12778: KAFKA-13152: Add cache size metrics

2022-11-21 Thread GitBox
vamossagar12 commented on PR #12778: URL: https://github.com/apache/kafka/pull/12778#issuecomment-1321796046 @ableegoldman , looks like the tests ran this time. Error seem unrelated to this change. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (KAFKA-14411) Logging warning when partitions don't exist on assign request

2022-11-21 Thread Paolo Patierno (Jira)
Paolo Patierno created KAFKA-14411: -- Summary: Logging warning when partitions don't exist on assign request Key: KAFKA-14411 URL: https://issues.apache.org/jira/browse/KAFKA-14411 Project: Kafka

[GitHub] [kafka] cadonna commented on pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-11-21 Thread GitBox
cadonna commented on PR #12505: URL: https://github.com/apache/kafka/pull/12505#issuecomment-1321960582 Build failures are not related: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslVersionsTransportLayerTest.tlsServerProtocol = [TLSv1.2, TLSv1.3], tlsClientPr

[GitHub] [kafka] cadonna merged pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-11-21 Thread GitBox
cadonna merged PR #12505: URL: https://github.com/apache/kafka/pull/12505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-14412) Transactional semantics for StateStores

2022-11-21 Thread Nicholas Telford (Jira)
Nicholas Telford created KAFKA-14412: Summary: Transactional semantics for StateStores Key: KAFKA-14412 URL: https://issues.apache.org/jira/browse/KAFKA-14412 Project: Kafka Issue Type: I

[jira] [Updated] (KAFKA-13586) ConfigExceptions thrown by FileConfigProvider during connector/task startup crash worker

2022-11-21 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13586: -- Priority: Major (was: Minor) > ConfigExceptions thrown by FileConfigProvider during connector

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12233: MINOR: Clean up tmp files created by tests

2022-11-21 Thread GitBox
divijvaidya commented on code in PR #12233: URL: https://github.com/apache/kafka/pull/12233#discussion_r1028199478 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -142,26 +142,40 @@ public static String randomString(final int len) { } /** - *

[GitHub] [kafka] dajac commented on a diff in pull request #12877: KAFKA-14372: choose replicas only from isr for preferred read replica

2022-11-21 Thread GitBox
dajac commented on code in PR #12877: URL: https://github.com/apache/kafka/pull/12877#discussion_r1028216090 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1244,8 +1244,12 @@ class ReplicaManager(val config: KafkaConfig, partition.remoteReplicas.fo

[GitHub] [kafka] C0urante commented on a diff in pull request #12233: MINOR: Clean up tmp files created by tests

2022-11-21 Thread GitBox
C0urante commented on code in PR #12233: URL: https://github.com/apache/kafka/pull/12233#discussion_r1028257185 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -142,26 +142,40 @@ public static String randomString(final int len) { } /** - * Cr

[GitHub] [kafka] philipnee commented on pull request #12832: KAFKA-14365: Refactor Fetcher to allow different implementations 1/2

2022-11-21 Thread GitBox
philipnee commented on PR #12832: URL: https://github.com/apache/kafka/pull/12832#issuecomment-1322329040 @hachikuji @vvcephei - could you take a look at it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] jsancio opened a new pull request, #12884: KAFKA-14393; Default metadata retition by bytes

2022-11-21 Thread GitBox
jsancio opened a new pull request, #12884: URL: https://github.com/apache/kafka/pull/12884 Now that Kafka is generating a metadata snapshot every hour and the default metadata retention is to delete snapshots after 7 days, every cluster metadata partition will have 168 (1 snapshot per hour

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-21 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636769#comment-17636769 ] Mikael commented on KAFKA-14362: I think I have identified the root cause of the duplica

[GitHub] [kafka] junrao merged pull request #12880: Minor; fix sticky partitioner doc to say at least batch.size

2022-11-21 Thread GitBox
junrao merged PR #12880: URL: https://github.com/apache/kafka/pull/12880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] kirktrue commented on a diff in pull request #12832: KAFKA-14365: Refactor Fetcher to allow different implementations 1/2

2022-11-21 Thread GitBox
kirktrue commented on code in PR #12832: URL: https://github.com/apache/kafka/pull/12832#discussion_r1028332997 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java: ## @@ -47,7 +47,7 @@ import java.util.function.Predicate; import java.ut

[GitHub] [kafka] kirktrue commented on a diff in pull request #12832: KAFKA-14365: Refactor Fetcher to allow different implementations 1/2

2022-11-21 Thread GitBox
kirktrue commented on code in PR #12832: URL: https://github.com/apache/kafka/pull/12832#discussion_r1028332650 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultFetcher.java: ## @@ -130,7 +130,7 @@ * on a different thread. * */ -public class

[GitHub] [kafka] jsancio opened a new pull request, #12885: KAFKA-14358; Disallow creation of cluster metadata partition

2022-11-21 Thread GitBox
jsancio opened a new pull request, #12885: URL: https://github.com/apache/kafka/pull/12885 With KRaft the cluster metadata topic (__cluster_metadata) has a different implementation compared to regular topic. The user should not be allowed to create this topic. This can cause issues if the m

[GitHub] [kafka] mumrah commented on a diff in pull request #12883: Kip 866 part 1

2022-11-21 Thread GitBox
mumrah commented on code in PR #12883: URL: https://github.com/apache/kafka/pull/12883#discussion_r1028380355 ## metadata/src/main/java/org/apache/kafka/migration/MigrationState.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] hachikuji commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
hachikuji commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1028360492 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,15 @@ object KafkaConfig { "This is required configuration when running in KRaft mode."

[jira] [Created] (KAFKA-14413) Separate MirrorMaker configurations for each connector

2022-11-21 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14413: -- Summary: Separate MirrorMaker configurations for each connector Key: KAFKA-14413 URL: https://issues.apache.org/jira/browse/KAFKA-14413 Project: Kafka Is

[jira] [Created] (KAFKA-14414) Remove unnecessary usage of ObjectSerializationCache

2022-11-21 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-14414: Summary: Remove unnecessary usage of ObjectSerializationCache Key: KAFKA-14414 URL: https://issues.apache.org/jira/browse/KAFKA-14414 Project: Kafka Issue Ty

[GitHub] [kafka] jolshan commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jolshan commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1028449377 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1647,69 +1656,51 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleJoinGroup

[GitHub] [kafka] jolshan commented on pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jolshan commented on PR #12845: URL: https://github.com/apache/kafka/pull/12845#issuecomment-1322572419 @dajac This is looking close to ready. I just had a few points. 1. I left a comment about leaving more comments on tests, not a big deal either way, but just wanted to remind. 2. I s

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1028467761 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long delayNs

[GitHub] [kafka] jolshan commented on a diff in pull request #12541: MINOR: reduce Metadata log volume when last seen epoch is not updated

2022-11-21 Thread GitBox
jolshan commented on code in PR #12541: URL: https://github.com/apache/kafka/pull/12541#discussion_r1028468986 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -399,9 +399,11 @@ private Optional updateLatestMetadata( // Between the time th

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1028471070 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,15 @@ object KafkaConfig { "This is required configuration when running in KRaft mode."

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1028471411 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,15 @@ object KafkaConfig { "This is required configuration when running in KRaft mode."

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1028472130 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -986,6 +1012,13 @@ public void handleCommit(BatchReader reader) {

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1028471411 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,15 @@ object KafkaConfig { "This is required configuration when running in KRaft mode."

[GitHub] [kafka] C0urante commented on a diff in pull request #12805: KAFKA-12610: Implement PluginClassLoader::getResource

2022-11-21 Thread GitBox
C0urante commented on code in PR #12805: URL: https://github.com/apache/kafka/pull/12805#discussion_r1028470717 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java: ## @@ -118,7 +119,8 @@ public void testLoadingMixOfValidAnd

[GitHub] [kafka] dajac opened a new pull request, #12886: [WIP] KAFKA-14367; Add `OffsetCommit` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
dajac opened a new pull request, #12886: URL: https://github.com/apache/kafka/pull/12886 WIP ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1028514280 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1455,30 +1524,56 @@ private void replay(ApiMessage message, Optional snapshotId, lo

[GitHub] [kafka] jsancio commented on pull request #12863: KAFKA-14358 Do not allow users to create the metadata topic

2022-11-21 Thread GitBox
jsancio commented on PR #12863: URL: https://github.com/apache/kafka/pull/12863#issuecomment-1322644819 Thanks @NLincoln . I'll take a look. I didn't see this PR so I just created https://github.com/apache/kafka/pull/12885. My preliminary concern is that `detectInvalidTopic` is used a

[jira] [Updated] (KAFKA-14386) Change ReplicaPlacer place method to return a class instead of list of list of integers

2022-11-21 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14386: - Description: In KRaft mode, a new interface was introduced, [ReplicaPlacer|https://github.com/a

[jira] [Updated] (KAFKA-14386) Change ReplicaPlacer place method to return a class instead of list of list of integers

2022-11-21 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14386: - Description: In KRaft mode, a new interface was introduced, [ReplicaPlacer|https://github.com/a

[GitHub] [kafka] philipnee closed pull request #12807: Add FindCoordinator and Commit Functionalities

2022-11-21 Thread GitBox
philipnee closed pull request #12807: Add FindCoordinator and Commit Functionalities URL: https://github.com/apache/kafka/pull/12807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] jolshan commented on a diff in pull request #12850: KAFKA-14367; Add `LeaveGroup` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jolshan commented on code in PR #12850: URL: https://github.com/apache/kafka/pull/12850#discussion_r1028558389 ## clients/src/main/java/org/apache/kafka/common/requests/LeaveGroupResponse.java: ## @@ -55,6 +56,22 @@ public LeaveGroupResponse(LeaveGroupResponseData data) {

[GitHub] [kafka] jolshan commented on a diff in pull request #12850: KAFKA-14367; Add `LeaveGroup` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jolshan commented on code in PR #12850: URL: https://github.com/apache/kafka/pull/12850#discussion_r1028558389 ## clients/src/main/java/org/apache/kafka/common/requests/LeaveGroupResponse.java: ## @@ -55,6 +56,22 @@ public LeaveGroupResponse(LeaveGroupResponseData data) {

[GitHub] [kafka] jolshan commented on a diff in pull request #12850: KAFKA-14367; Add `LeaveGroup` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jolshan commented on code in PR #12850: URL: https://github.com/apache/kafka/pull/12850#discussion_r1028565156 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1805,38 +1804,24 @@ class KafkaApis(val requestChannel: RequestChannel, def handleLeaveGroupRequest(reque

[jira] [Commented] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636907#comment-17636907 ] Matthias J. Sax commented on KAFKA-14400: - The old and new API have different se

[jira] [Comment Edited] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636907#comment-17636907 ] Matthias J. Sax edited comment on KAFKA-14400 at 11/21/22 10:40 PM: --

[jira] [Comment Edited] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-11-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636907#comment-17636907 ] Matthias J. Sax edited comment on KAFKA-14400 at 11/21/22 10:40 PM: --

[GitHub] [kafka] jolshan commented on a diff in pull request #12853: KAFKA-14367; Add `ListGroups` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jolshan commented on code in PR #12853: URL: https://github.com/apache/kafka/pull/12853#discussion_r1028580865 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1618,34 +1618,36 @@ class KafkaApis(val requestChannel: RequestChannel, def handleListGroupsRequest(req

[GitHub] [kafka] jolshan commented on a diff in pull request #12853: KAFKA-14367; Add `ListGroups` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jolshan commented on code in PR #12853: URL: https://github.com/apache/kafka/pull/12853#discussion_r1028583013 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1618,34 +1618,36 @@ class KafkaApis(val requestChannel: RequestChannel, def handleListGroupsRequest(req

[GitHub] [kafka] jolshan commented on a diff in pull request #12853: KAFKA-14367; Add `ListGroups` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jolshan commented on code in PR #12853: URL: https://github.com/apache/kafka/pull/12853#discussion_r1028596112 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala: ## @@ -135,4 +134,48 @@ class GroupCoordinatorAdapterTest { assertEquals(exp

[GitHub] [kafka] ableegoldman opened a new pull request, #12887: HOTFIX: fix compilation error in StreamThreadTest

2022-11-21 Thread GitBox
ableegoldman opened a new pull request, #12887: URL: https://github.com/apache/kafka/pull/12887 When I was cherrypicking the fix for KAFKA-14382 back to older branches, I had been running the StreamThreadTest on all versions before pushing the fix -- but when I got to 3.0, I began to hit

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-11-21 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1028619193 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -221,7 +221,8 @@ class BrokerServer( config, channelName = "forwarding", thread

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12805: KAFKA-12610: Implement PluginClassLoader::getResource

2022-11-21 Thread GitBox
gharris1727 commented on code in PR #12805: URL: https://github.com/apache/kafka/pull/12805#discussion_r1028619236 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java: ## @@ -118,7 +119,8 @@ public void testLoadingMixOfValid

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-11-21 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1028619470 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -344,7 +345,8 @@ class BrokerServer( config, "heartbeat", threadNamePrefix, -

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-11-21 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1028619818 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -282,8 +286,9 @@ class BrokerToControllerRequestThread( config: KafkaConfig, tim

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-11-21 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1028619578 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -344,7 +345,8 @@ class BrokerServer( config, "heartbeat", threadNamePrefix, -

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-11-21 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1028619470 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -344,7 +345,8 @@ class BrokerServer( config, "heartbeat", threadNamePrefix, -

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-11-21 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1028622710 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -121,16 +121,18 @@ object BrokerToControllerChannelManager { config: KafkaConfig,

[GitHub] [kafka] cmccabe commented on a diff in pull request #12856: KAFKA-14392: KRaft broker heartbeat timeout should not exceed broker.session.timeout.ms

2022-11-21 Thread GitBox
cmccabe commented on code in PR #12856: URL: https://github.com/apache/kafka/pull/12856#discussion_r1028619648 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -159,7 +161,8 @@ class BrokerToControllerChannelManagerImpl( config: KafkaConfig,

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r1028467761 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -568,45 +576,62 @@ void cancel() { } void reschedule(long delayNs

[GitHub] [kafka] gharris1727 commented on pull request #12805: KAFKA-12610: Implement PluginClassLoader::getResource

2022-11-21 Thread GitBox
gharris1727 commented on PR #12805: URL: https://github.com/apache/kafka/pull/12805#issuecomment-1322880268 @C0urante I've refactored the `hideFromPluginPath` and `pluginPath(TestPlugin)` functionality to hopefully resolve the awkwardness of both when dealing with default/non-default plugin

[GitHub] [kafka] jsancio merged pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-11-21 Thread GitBox
jsancio merged PR #12761: URL: https://github.com/apache/kafka/pull/12761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon merged pull request #12882: MINOR: Don't call `scheduleAtFixedRate` when period is 0

2022-11-21 Thread GitBox
showuon merged PR #12882: URL: https://github.com/apache/kafka/pull/12882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

2022-11-21 Thread GitBox
jeffkbkim commented on code in PR #12845: URL: https://github.com/apache/kafka/pull/12845#discussion_r1028803896 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -184,6 +195,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.OFFSET_FETCH =>

[GitHub] [kafka] dajac closed pull request #11229: KAFKA-12961; Verify group generation in `DelayedJoin`

2022-11-21 Thread GitBox
dajac closed pull request #11229: KAFKA-12961; Verify group generation in `DelayedJoin` URL: https://github.com/apache/kafka/pull/11229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] dajac closed pull request #10799: WIP

2022-11-21 Thread GitBox
dajac closed pull request #10799: WIP URL: https://github.com/apache/kafka/pull/10799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@k

[GitHub] [kafka] dajac closed pull request #12542: MINOR: Fix locking in GroupMetadataManager's metrics

2022-11-21 Thread GitBox
dajac closed pull request #12542: MINOR: Fix locking in GroupMetadataManager's metrics URL: https://github.com/apache/kafka/pull/12542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] 1mr0-tech opened a new pull request, #12888: GCE VM Installation guide and command documentation

2022-11-21 Thread GitBox
1mr0-tech opened a new pull request, #12888: URL: https://github.com/apache/kafka/pull/12888 The documentation for the installation of Kafka on a GCE VM is short of understanding and unavailable in clarity on the internet. This document is the first revision of commands and instructions on

[jira] [Assigned] (KAFKA-12317) Relax non-null key requirement for left/outer KStream joins

2022-11-21 Thread Juan C. Gonzalez-Zurita (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juan C. Gonzalez-Zurita reassigned KAFKA-12317: --- Assignee: (was: Juan C. Gonzalez-Zurita) > Relax non-null key r