[jira] [Commented] (KAFKA-13887) Running multiple instance of same stateful KafkaStreams application on single host raise Exception

2022-11-07 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629647#comment-17629647 ] A. Sophie Blee-Goldman commented on KAFKA-13887: [~cadonna]  think we ca

[jira] [Commented] (KAFKA-14325) NullPointer in ProcessorParameters.toString

2022-11-07 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629652#comment-17629652 ] A. Sophie Blee-Goldman commented on KAFKA-14325: Hm, nice catch, we shou

[jira] [Assigned] (KAFKA-14325) NullPointer in ProcessorParameters.toString

2022-11-07 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-14325: -- Assignee: A. Sophie Blee-Goldman > NullPointer in ProcessorParameters

[jira] [Commented] (KAFKA-14282) RecordCollector throws exception on message processing

2022-11-07 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629661#comment-17629661 ] A. Sophie Blee-Goldman commented on KAFKA-14282: Thanks for the report.

[GitHub] [kafka] urbandan commented on pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

2022-11-07 Thread GitBox
urbandan commented on PR #12392: URL: https://github.com/apache/kafka/pull/12392#issuecomment-1305253651 @artemlivshits The scenario you mentioned is already covered, even without this change - when a transaction times out, the transaction coordinator bumps the epoch, so it already fences o

[jira] [Resolved] (KAFKA-13887) Running multiple instance of same stateful KafkaStreams application on single host raise Exception

2022-11-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13887. --- Resolution: Not A Problem > Running multiple instance of same stateful KafkaStreams applicat

[jira] [Commented] (KAFKA-13887) Running multiple instance of same stateful KafkaStreams application on single host raise Exception

2022-11-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629692#comment-17629692 ] Bruno Cadonna commented on KAFKA-13887: --- [~ableegoldman] Agreed! Closed the ticket

[jira] [Updated] (KAFKA-14211) Streams log message has partition and offset transposed

2022-11-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-14211: -- Fix Version/s: 3.2.0 > Streams log message has partition and offset transposed > -

[GitHub] [kafka] dajac commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-07 Thread GitBox
dajac commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1015152908 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -3455,6 +3455,21 @@ class UnifiedLogTest { assertFalse(newDir.exists()) } + @Test + def test

[GitHub] [kafka] cadonna commented on pull request #12808: KAFKA-14299: Avoid allocation & synchronization overhead in StreamThread loop

2022-11-07 Thread GitBox
cadonna commented on PR #12808: URL: https://github.com/apache/kafka/pull/12808#issuecomment-1305329469 Test failures in `TaskManagerTest` are related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] tombentley commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-07 Thread GitBox
tombentley commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1015179206 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java: ## @@ -56,7 +58,11 @@ public class MirrorClientConfig extends Abstrac

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

2022-11-07 Thread GitBox
showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1015224638 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -117,30 +117,41 @@ private boolean allSubscriptionsEqual(Set al

[GitHub] [kafka] dajac commented on a diff in pull request #12308: KAFKA-14009: update rebalance timeout in memory when consumers use st…

2022-11-07 Thread GitBox
dajac commented on code in PR #12308: URL: https://github.com/apache/kafka/pull/12308#discussion_r1015231438 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala: ## @@ -1036,6 +1036,52 @@ class GroupCoordinatorTest { assertEquals(Errors.NONE, sync

[GitHub] [kafka] mimaison merged pull request #12804: [Minior] [Test] KAFKA-14344 : Build EmbeddedKafkaCluster with common configs used for all clients

2022-11-07 Thread GitBox
mimaison merged PR #12804: URL: https://github.com/apache/kafka/pull/12804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-14344) Improve MM2 integration test by building EmbeddedKafkaCluster with common configs used for all clients

2022-11-07 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14344. Fix Version/s: 3.4.0 Resolution: Fixed > Improve MM2 integration test by building E

[GitHub] [kafka] clolov commented on a diff in pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on code in PR #12823: URL: https://github.com/apache/kafka/pull/12823#discussion_r1015259138 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java: ## @@ -71,122 +74,74 @@ public void setup() { Long

[GitHub] [kafka] clolov commented on a diff in pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on code in PR #12823: URL: https://github.com/apache/kafka/pull/12823#discussion_r1015261223 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java: ## @@ -71,122 +74,74 @@ public void setup() { Long

[GitHub] [kafka] clolov commented on a diff in pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on code in PR #12823: URL: https://github.com/apache/kafka/pull/12823#discussion_r1015276765 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java: ## @@ -71,122 +74,74 @@ public void setup() { Long

[GitHub] [kafka] clolov commented on a diff in pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on code in PR #12823: URL: https://github.com/apache/kafka/pull/12823#discussion_r1015279648 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java: ## @@ -71,122 +74,74 @@ public void setup() { Long

[GitHub] [kafka] clolov commented on pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on PR #12823: URL: https://github.com/apache/kafka/pull/12823#issuecomment-1305432745 Hey @C0urante! Thanks a lot for the review. Hopefully I have addressed the first batch of comments :) -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] cadonna commented on a diff in pull request #12795: KAFKA-14299: Initialize directly after handleAssignment

2022-11-07 Thread GitBox
cadonna commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1015362789 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -395,8 +395,10 @@ private void createNewTasks(final Map> activeTasksTo

[GitHub] [kafka] cadonna commented on pull request #12773: KAFKA-14299: Return emptied ChangelogReader to ACTIVE_RESTORING

2022-11-07 Thread GitBox
cadonna commented on PR #12773: URL: https://github.com/apache/kafka/pull/12773#issuecomment-1305538249 Build failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.security.oauthbearer.internals.secured.RefreshingHttpsJwksTest.testSecondaryRefreshAfterElap

[GitHub] [kafka] cadonna merged pull request #12773: KAFKA-14299: Return emptied ChangelogReader to ACTIVE_RESTORING

2022-11-07 Thread GitBox
cadonna merged PR #12773: URL: https://github.com/apache/kafka/pull/12773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12684: KAFKA-14254; Format timestamps as dates in logs

2022-11-07 Thread GitBox
cadonna commented on PR #12684: URL: https://github.com/apache/kafka/pull/12684#issuecomment-1305550037 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.consumer.CooperativeStickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription(

[GitHub] [kafka] cadonna merged pull request #12684: KAFKA-14254; Format timestamps as dates in logs

2022-11-07 Thread GitBox
cadonna merged PR #12684: URL: https://github.com/apache/kafka/pull/12684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cadonna commented on pull request #12772: KAFKA-14299: Avoid busy polling in state updater

2022-11-07 Thread GitBox
cadonna commented on PR #12772: URL: https://github.com/apache/kafka/pull/12772#issuecomment-1305567683 I restarted the builds. Once the build results are acceptable, I will merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] clolov commented on pull request #12809: [KAFKA-14324] Upgrade RocksDB to 7.1.2

2022-11-07 Thread GitBox
clolov commented on PR #12809: URL: https://github.com/apache/kafka/pull/12809#issuecomment-1305605846 Hey @cadonna, Adam Retter has been very helpful in responding to my mail, so I have updated the pull request with his suggestion. I believe this is option 2, but the reasoning behind it ma

[jira] [Created] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-07 Thread Mikael (Jira)
Mikael created KAFKA-14362: -- Summary: Same message consumed by two consumers in the same group after client restart Key: KAFKA-14362 URL: https://issues.apache.org/jira/browse/KAFKA-14362 Project: Kafka

[jira] [Commented] (KAFKA-14362) Same message consumed by two consumers in the same group after client restart

2022-11-07 Thread Mikael (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629832#comment-17629832 ] Mikael commented on KAFKA-14362: The main thing that has caught my attention is the tigh

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-07 Thread GitBox
OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1015481020 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java: ## @@ -69,6 +74,17 @@ public ReplicationPolicy replicationPolicy() {

[jira] [Created] (KAFKA-14363) Add new `coordinator` module

2022-11-07 Thread David Jacot (Jira)
David Jacot created KAFKA-14363: --- Summary: Add new `coordinator` module Key: KAFKA-14363 URL: https://issues.apache.org/jira/browse/KAFKA-14363 Project: Kafka Issue Type: Sub-task R

[GitHub] [kafka] dajac opened a new pull request, #12827: KAFKA-14363; Add new `coordinator` module (KIP-848)

2022-11-07 Thread GitBox
dajac opened a new pull request, #12827: URL: https://github.com/apache/kafka/pull/12827 Introduce new `coordinator` module that will host the future new group coordinator as part of KIP-848. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementat

[GitHub] [kafka] C0urante merged pull request #12817: KAFKA-14346: Remove difficult to mock Plugins.compareAndSwapLoader usages

2022-11-07 Thread GitBox
C0urante merged PR #12817: URL: https://github.com/apache/kafka/pull/12817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on a diff in pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
C0urante commented on code in PR #12823: URL: https://github.com/apache/kafka/pull/12823#discussion_r1015522678 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java: ## @@ -185,8 +160,13 @@ public void testRemove() throws Exception

[jira] [Resolved] (KAFKA-14346) Remove static methods from internal Connect APIs for easier testing

2022-11-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14346. --- Fix Version/s: 3.4.0 Resolution: Fixed > Remove static methods from internal Connect

[GitHub] [kafka] C0urante commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-11-07 Thread GitBox
C0urante commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1015535668 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { private

[GitHub] [kafka] C0urante commented on pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

2022-11-07 Thread GitBox
C0urante commented on PR #12418: URL: https://github.com/apache/kafka/pull/12418#issuecomment-1305757854 @clolov do you plan on revisiting this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] cadonna commented on pull request #12772: KAFKA-14299: Avoid busy polling in state updater

2022-11-07 Thread GitBox
cadonna commented on PR #12772: URL: https://github.com/apache/kafka/pull/12772#issuecomment-1305801994 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[2] Type=Raft-CoReside, Name=testAllTopicPartition, MetadataVersion=3.3-IV

[GitHub] [kafka] cadonna merged pull request #12772: KAFKA-14299: Avoid busy polling in state updater

2022-11-07 Thread GitBox
cadonna merged PR #12772: URL: https://github.com/apache/kafka/pull/12772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] clolov commented on pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

2022-11-07 Thread GitBox
clolov commented on PR #12418: URL: https://github.com/apache/kafka/pull/12418#issuecomment-1305829036 Hello, yes I am, it is the next one on my list :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] clolov commented on a diff in pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on code in PR #12823: URL: https://github.com/apache/kafka/pull/12823#discussion_r1015610959 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java: ## @@ -71,112 +75,83 @@ public void setup() { Long

[GitHub] [kafka] clolov commented on a diff in pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on code in PR #12823: URL: https://github.com/apache/kafka/pull/12823#discussion_r1015611423 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java: ## @@ -185,8 +160,13 @@ public void testRemove() throws Exception {

[GitHub] [kafka] clolov commented on a diff in pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on code in PR #12823: URL: https://github.com/apache/kafka/pull/12823#discussion_r1015611950 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java: ## @@ -185,8 +160,13 @@ public void testRemove() throws Exception {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-07 Thread GitBox
OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1015617856 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,553 @@ +/* + *

[jira] [Updated] (KAFKA-14363) Add new `group-coordinator` module

2022-11-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14363: Summary: Add new `group-coordinator` module (was: Add new `coordinator` module) > Add new `group

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

2022-11-07 Thread GitBox
clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015639016 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java: ## @@ -214,7 +214,7 @@ public void configure(final WorkerConfig config) {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

2022-11-07 Thread GitBox
clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015639560 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

2022-11-07 Thread GitBox
clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015640636 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {

[GitHub] [kafka] C0urante commented on pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
C0urante commented on PR #12823: URL: https://github.com/apache/kafka/pull/12823#issuecomment-1305875235 Changes in last commit were trivially verifiable, and the CI run for the commit before that did not contain any relevant test failures. Merging... -- This is an automated message from

[GitHub] [kafka] C0urante merged pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
C0urante merged PR #12823: URL: https://github.com/apache/kafka/pull/12823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-14345) Flakey Tests for Connection Quotas should use correct error bounds

2022-11-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14345: Summary: Flakey Tests for Connection Quotas should use correct error bounds (was: Flakey DynamicC

[jira] [Updated] (KAFKA-14345) Flakey Tests for Connection Quotas should use correct error bounds

2022-11-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14345: Description: The DynamicConnectionQuotaTest is an integration test targeting the throttling behav

[jira] [Updated] (KAFKA-14345) Flakey Tests for Connection Quotas should use correct error bounds

2022-11-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14345: Description: The DynamicConnectionQuotaTest is an integration test targeting the throttling behav

[GitHub] [kafka] clolov commented on pull request #12823: KAFKA-14132: Replace PowerMock and EasyMock with Mockito in connect tests

2022-11-07 Thread GitBox
clolov commented on PR #12823: URL: https://github.com/apache/kafka/pull/12823#issuecomment-1305894872 Thank you very much for the quick turnaround @C0urante! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Created] (KAFKA-14364) Support evolving serde with Foreign Key Join

2022-11-07 Thread John Roesler (Jira)
John Roesler created KAFKA-14364: Summary: Support evolving serde with Foreign Key Join Key: KAFKA-14364 URL: https://issues.apache.org/jira/browse/KAFKA-14364 Project: Kafka Issue Type: Impr

[GitHub] [kafka] mimaison commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-11-07 Thread GitBox
mimaison commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1015686984 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -289,15 +292,16 @@ public static String RESTART_KEY(String connec

[jira] [Commented] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

2022-11-07 Thread Jocelyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629931#comment-17629931 ] Jocelyn commented on KAFKA-13891: - This ticket was reverted, see PR here: [https://gith

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

2022-11-07 Thread GitBox
clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015721355 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {

[GitHub] [kafka] clolov commented on a diff in pull request #12418: KAFKA-13414: Replace PowerMock/EasyMock with Mockito in connect.storage.KafkaOffsetBackingStoreTest

2022-11-07 Thread GitBox
clolov commented on code in PR #12418: URL: https://github.com/apache/kafka/pull/12418#discussion_r1015721786 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java: ## @@ -105,34 +112,53 @@ public class KafkaOffsetBackingStoreTest {

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2022-11-07 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14132: -- Description: {color:#de350b}Some of the tests below use EasyMock as well. For those migrate b

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12826: Using Timer class to track expiry in IncrementalCooperativeAssignor

2022-11-07 Thread GitBox
gharris1727 commented on code in PR #12826: URL: https://github.com/apache/kafka/pull/12826#discussion_r1015749550 ## clients/src/main/java/org/apache/kafka/common/utils/Timer.java: ## @@ -172,6 +172,17 @@ public long currentTimeMs() { return currentTimeMs; } +

[GitHub] [kafka] C0urante commented on pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-11-07 Thread GitBox
C0urante commented on PR #12544: URL: https://github.com/apache/kafka/pull/12544#issuecomment-1306016049 Thanks @mimaison, good catch with the missing hyphen suffixes in the default client IDs. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] gharris1727 commented on pull request #12826: Using Timer class to track expiry in IncrementalCooperativeAssignor

2022-11-07 Thread GitBox
gharris1727 commented on PR #12826: URL: https://github.com/apache/kafka/pull/12826#issuecomment-1306029257 @vamossagar12 Can you expand on the importance of this change? Is the single `long` with `0` as a sentinel any different in readability than a `Timer` object with `null` as a se

[jira] [Created] (KAFKA-14365) Refactor Fetcher to allow different implementations

2022-11-07 Thread Kirk True (Jira)
Kirk True created KAFKA-14365: - Summary: Refactor Fetcher to allow different implementations Key: KAFKA-14365 URL: https://issues.apache.org/jira/browse/KAFKA-14365 Project: Kafka Issue Type: Imp

[jira] [Updated] (KAFKA-14354) Add 'destroyed()' callback method to Connector API

2022-11-07 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino updated KAFKA-14354: - Summary: Add 'destroyed()' callback method to Connector API (was: Add delete callback m

[GitHub] [kafka] hachikuji commented on pull request #12819: MINOR: Change system test console consumer default log level

2022-11-07 Thread GitBox
hachikuji commented on PR #12819: URL: https://github.com/apache/kafka/pull/12819#issuecomment-1306108755 @jsancio Here is a link to a run of the `reassign_partitions_test.py`, which uses the console consumer service: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.am

[GitHub] [kafka] qingwei91 commented on a diff in pull request #12166: KAFKA-13817 Always sync nextTimeToEmit with wall clock

2022-11-07 Thread GitBox
qingwei91 commented on code in PR #12166: URL: https://github.com/apache/kafka/pull/12166#discussion_r1015852039 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java: ## @@ -333,6 +352,87 @@ public void shouldJoinWithCustomStoreSupplier

[GitHub] [kafka] gharris1727 opened a new pull request, #12828: KAFKA-14346: Remove hard-to-mock RestClient calls

2022-11-07 Thread GitBox
gharris1727 opened a new pull request, #12828: URL: https://github.com/apache/kafka/pull/12828 Currently, all RestClient methods are static, and require more complicated mocking mechanisms compared to an implementation which uses instance methods. Additionally, the current model creates a s

[GitHub] [kafka] lihaosky commented on pull request #12166: KAFKA-13817 Always sync nextTimeToEmit with wall clock

2022-11-07 Thread GitBox
lihaosky commented on PR #12166: URL: https://github.com/apache/kafka/pull/12166#issuecomment-1306192045 @mjsax can help approve and merge as a committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] jsancio merged pull request #12819: MINOR: Change system test console consumer default log level

2022-11-07 Thread GitBox
jsancio merged PR #12819: URL: https://github.com/apache/kafka/pull/12819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-14345) Flakey Tests for Connection Quotas should use correct error bounds

2022-11-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14345: Labels: flaky-test (was: ) > Flakey Tests for Connection Quotas should use correct error bounds >

[GitHub] [kafka] philipnee closed pull request #12792: [Test]gradle oom fix

2022-11-07 Thread GitBox
philipnee closed pull request #12792: [Test]gradle oom fix URL: https://github.com/apache/kafka/pull/12792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [kafka] Scanteianu commented on pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

2022-11-07 Thread GitBox
Scanteianu commented on PR #12753: URL: https://github.com/apache/kafka/pull/12753#issuecomment-1306344430 @showuon could I get another review please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman merged pull request #12760: KAFKA-14309: FK join upgrades not tested with DEV_VERSION

2022-11-07 Thread GitBox
ableegoldman merged PR #12760: URL: https://github.com/apache/kafka/pull/12760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] cmccabe opened a new pull request, #12829: MINOR: Avoid highestSupportedVersion outside tests

2022-11-07 Thread GitBox
cmccabe opened a new pull request, #12829: URL: https://github.com/apache/kafka/pull/12829 We should avoid using Message.highestSupportedVersion to generate metadata records. Instead, we need to pick the correct record version based on the current metadata version which is in effect. In cas

[jira] [Commented] (KAFKA-14294) Kafka Streams should commit transaction when no records are processed

2022-11-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630098#comment-17630098 ] Matthias J. Sax commented on KAFKA-14294: - Why do you think we don't commit? Bas

[jira] [Commented] (KAFKA-8154) Buffer Overflow exceptions between brokers and with clients

2022-11-07 Thread tony mancill (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630099#comment-17630099 ] tony mancill commented on KAFKA-8154: - We have observed this this behavior when using

[GitHub] [kafka] gharris1727 opened a new pull request, #12830: KAFKA-8115: Reduce flakiness in Trogdor JsonRestServer shutdown

2022-11-07 Thread GitBox
gharris1727 opened a new pull request, #12830: URL: https://github.com/apache/kafka/pull/12830 Signed-off-by: Greg Harris The GRACEFUL_SHUTDOWN_TIMEOUT_MS for the Trogdor JsonRestServer is 100ms. In heavily loaded CI environments, this timeout can be exceeded. When this happens, it

[GitHub] [kafka] jeffkbkim commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-11-07 Thread GitBox
jeffkbkim commented on PR #12783: URL: https://github.com/apache/kafka/pull/12783#issuecomment-1306499515 @dajac thanks for the review, i have addressed the comments. i'm a bit confused since the new parameterized replica fetcher test seems to be failing in jdk 8 / scala 2.12 -- This is

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12826: Using Timer class to track expiry in IncrementalCooperativeAssignor

2022-11-07 Thread GitBox
vamossagar12 commented on code in PR #12826: URL: https://github.com/apache/kafka/pull/12826#discussion_r1016131415 ## clients/src/main/java/org/apache/kafka/common/utils/Timer.java: ## @@ -172,6 +172,17 @@ public long currentTimeMs() { return currentTimeMs; } +

[GitHub] [kafka] vamossagar12 commented on pull request #12826: Using Timer class to track expiry in IncrementalCooperativeAssignor

2022-11-07 Thread GitBox
vamossagar12 commented on PR #12826: URL: https://github.com/apache/kafka/pull/12826#issuecomment-1306629502 > @vamossagar12 Can you expand on the importance of this change? > > Is the single `long` with `0` as a sentinel any different in readability than a `Timer` object with `null`

[jira] [Commented] (KAFKA-14282) RecordCollector throws exception on message processing

2022-11-07 Thread Ramiz Mehran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630184#comment-17630184 ] Ramiz Mehran commented on KAFKA-14282: -- I am also facing the same. Adding logs belo

[GitHub] [kafka] kirktrue opened a new pull request, #12831: KAFKA-14365: Refactor Fetcher to allow different implementations

2022-11-07 Thread GitBox
kirktrue opened a new pull request, #12831: URL: https://github.com/apache/kafka/pull/12831 Generalize `Fetcher` into an interface of the same name and rename the original `Fetcher` into `FetcherThreadSafe`. Generalize appropriate call sites to use the general interface instead of the concr

[jira] [Created] (KAFKA-14366) Kafka consumer rebalance issue, offsets points back to very old committed offset

2022-11-07 Thread Chetan (Jira)
Chetan created KAFKA-14366: -- Summary: Kafka consumer rebalance issue, offsets points back to very old committed offset Key: KAFKA-14366 URL: https://issues.apache.org/jira/browse/KAFKA-14366 Project: Kafka

[jira] [Updated] (KAFKA-14366) Kafka consumer rebalance issue, offsets points back to very old committed offset

2022-11-07 Thread Chetan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan updated KAFKA-14366: --- Description: Hi All, We are facing an issue while the client consumer restart (again not all restarts are