showuon commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1013697955
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -1100,6 +1102,66 @@ class ReplicaFetcherThreadTest {
assertEquals(Collections.single
dajac commented on PR #12794:
URL: https://github.com/apache/kafka/pull/12794#issuecomment-1303070785
@showuon What's the plan with this one? I tend to agree that reverting it
makes sense. Is there are reason why you did not merge it yet?
--
This is an automated message from the Apache Gi
showuon commented on PR #12794:
URL: https://github.com/apache/kafka/pull/12794#issuecomment-1303078559
Ah, sorry, was waiting for jenkins build results, and ... forgot it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon commented on PR #12794:
URL: https://github.com/apache/kafka/pull/12794#issuecomment-1303080802
Build results:
```
Build / JDK 8 and Scala 2.12 /
kafka.admin.TopicCommandIntegrationTest.testDeleteInternalTopic(String).quorum=kraft
Build / JDK 8 and Scala 2.12 /
kafk
dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1013705694
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -433,6 +432,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
+ /**
+ * Update high wat
dajac merged PR #12811:
URL: https://github.com/apache/kafka/pull/12811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1013722215
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -117,30 +117,41 @@ private boolean allSubscriptionsEqual(Set
allT
showuon commented on PR #12756:
URL: https://github.com/apache/kafka/pull/12756#issuecomment-1303186809
@vamossagar12 , sorry, could you help point to me where this PR is different
from https://github.com/apache/kafka/pull/11211. That would help me have
quicker review. Thanks.
--
This is
clolov opened a new pull request, #12821:
URL: https://github.com/apache/kafka/pull/12821
Batch 1 of the tests detailed in
https://issues.apache.org/jira/browse/KAFKA-14132 which use PowerMock/EasyMock
and need to be moved to Mockito.
--
This is an automated message from the Apache Git S
vamossagar12 commented on PR #12756:
URL: https://github.com/apache/kafka/pull/12756#issuecomment-1303348490
> @vamossagar12 , sorry, could you help point to me where this PR is
different from #11211. That would help me have quicker review. Thanks.
@showuon , it is mainly around =>
s
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
b
Minoru Tomioka created KAFKA-14355:
--
Summary: Integer overflow occurs in kafka-producer-perf-test.sh
(class ProducerProfrmance ).
Key: KAFKA-14355
URL: https://issues.apache.org/jira/browse/KAFKA-14355
[
https://issues.apache.org/jira/browse/KAFKA-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Minoru Tomioka updated KAFKA-14355:
---
Priority: Minor (was: Major)
> Integer overflow occurs in kafka-producer-perf-test.sh (clas
[
https://issues.apache.org/jira/browse/KAFKA-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Minoru Tomioka updated KAFKA-14355:
---
Description:
An integer overflow occurs if a fairly large value is passed to
{{{}--num-r
showuon commented on code in PR #12729:
URL: https://github.com/apache/kafka/pull/12729#discussion_r1013994799
##
core/src/main/scala/kafka/zk/AdminZkClient.scala:
##
@@ -355,18 +355,43 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
* @param entityName Th
runom opened a new pull request, #12822:
URL: https://github.com/apache/kafka/pull/12822
In `kafka-producer-perf-test.sh`, an integer overflow occurs if a fairly
large value is passed to `--num-records`. It causes a
NegativeArraySizeException error. This PR fixed this problem by changing ty
Jakub Scholz created KAFKA-14356:
Summary: Make it possible to detect changes to SCRAM-SHA
credentials using the Admin API
Key: KAFKA-14356
URL: https://issues.apache.org/jira/browse/KAFKA-14356
Proje
C0urante commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1014046291
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -116,14 +115,12 @@ public void run() {
LoggingContext.clear();
C0urante commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1014046291
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -116,14 +115,12 @@ public void run() {
LoggingContext.clear();
Jakub Scholz created KAFKA-14357:
Summary: Make it possible to batch describe requests in the Kafka
Admin API
Key: KAFKA-14357
URL: https://issues.apache.org/jira/browse/KAFKA-14357
Project: Kafka
C0urante commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1014047751
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java:
##
@@ -155,10 +143,22 @@ public LoaderSwap withClassLoader(ClassLoader loader
C0urante commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1014063487
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##
@@ -1957,6 +1789,61 @@ private void verifyTaskHeaderConverter() {
verify
C0urante commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1014063487
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##
@@ -1957,6 +1789,61 @@ private void verifyTaskHeaderConverter() {
verify
clolov opened a new pull request, #12823:
URL: https://github.com/apache/kafka/pull/12823
Batch 2 of the tests detailed in
https://issues.apache.org/jira/browse/KAFKA-14132 which use PowerMock/EasyMock
and need to be moved to Mockito.
--
This is an automated message from the Apache Git S
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
b
clolov commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1014077019
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -71,122 +74,74 @@ public void setup() {
Long
clolov commented on PR #12823:
URL: https://github.com/apache/kafka/pull/12823#issuecomment-1303625752
Hey @C0urante! Tagging you for visibility as this is a Connect-related test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
clolov commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1014079123
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionTopicsTest.java:
##
@@ -47,22 +47,18 @@
import static
org.apache.kafka.streams.process
clolov commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1014080005
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionTopicsTest.java:
##
@@ -151,22 +147,17 @@ public void shouldSetupRepartitionTopics() {
clolov commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1014081545
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionTopicsTest.java:
##
@@ -447,13 +414,9 @@ private void
setupClusterWithMissingTopicsAndM
clolov commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1014082612
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java:
##
@@ -42,77 +39,54 @@
import static java.util.Collections.emptyList;
clolov commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1014084531
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java:
##
@@ -187,151 +139,92 @@ public void
testCloseStateManagerThrowsExcept
clolov commented on PR #12821:
URL: https://github.com/apache/kafka/pull/12821#issuecomment-1303633189
Hey @cadonna 👋! Adding you for visibility as these are Streams-related tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
dajac commented on PR #12794:
URL: https://github.com/apache/kafka/pull/12794#issuecomment-1303633764
Last build had two failures:
```
Build / JDK 11 and Scala 2.13 /
testLargeAssignmentAndGroupWithNonEqualSubscription() –
org.apache.kafka.clients.consumer.CooperativeStickyAssignorTes
C0urante commented on PR #12823:
URL: https://github.com/apache/kafka/pull/12823#issuecomment-1303685374
Hi @clolov - thanks for the PR! The title mentions streams tests; should
that be updated?
I plan to take a look sometime within the next week.
--
This is an automated message fr
C0urante commented on code in PR #12823:
URL: https://github.com/apache/kafka/pull/12823#discussion_r1014154097
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitterTest.java:
##
@@ -71,122 +74,74 @@ public void setup() {
Lo
gharris1727 commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1014264009
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##
@@ -1957,6 +1789,61 @@ private void verifyTaskHeaderConverter() {
ver
gharris1727 commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1014266416
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java:
##
@@ -1957,6 +1789,61 @@ private void verifyTaskHeaderConverter() {
ver
niket-goel closed pull request #11208: MINOR: Refactored
BrokerHeartbeatManager::findOneStaleBroker to not use iterator
URL: https://github.com/apache/kafka/pull/11208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
ekeric13 commented on PR #8575:
URL: https://github.com/apache/kafka/pull/8575#issuecomment-1304001620
I think it would be great to get this in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gharris1727 commented on PR #12806:
URL: https://github.com/apache/kafka/pull/12806#issuecomment-1304036956
My worst-case bounds test had a typo that made the results invalid. I've
fixed that and this is the current behavior:
```
PASS numSamples = 1
PASS numSamples = 10
PASS numS
jolshan opened a new pull request, #12824:
URL: https://github.com/apache/kafka/pull/12824
This test has failed on a few PR runs.
Using a waitUntil instead.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test cov
José Armando García Sancio created KAFKA-14358:
--
Summary: Users should not be able to create a regular topic name
__cluster_metadata
Key: KAFKA-14358
URL: https://issues.apache.org/jira/browse/KAFKA-1
[
https://issues.apache.org/jira/browse/KAFKA-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14358:
---
Description:
The following test passes and it should not:
{code:java
gharris1727 commented on PR #12806:
URL: https://github.com/apache/kafka/pull/12806#issuecomment-1304289836
Okay, I've just loosened the bound to compensate for the variable-length
windows. This means that the flakey tests should now be resolved, while not
changing the behavior of the windo
hgeraldino opened a new pull request, #12825:
URL: https://github.com/apache/kafka/pull/12825
This PR contains a small change to the Connector public API, and a few
tweaks on the Worker/WorkerConnector and Herder classes - all this in context
of
[KIP-893](https://cwiki.apache.org/confluenc
soarez commented on code in PR #12822:
URL: https://github.com/apache/kafka/pull/12822#discussion_r1014501624
##
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##
@@ -350,7 +351,7 @@ public Stats(long numRecords, int reportingInterval) {
this.s
[
https://issues.apache.org/jira/browse/KAFKA-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629223#comment-17629223
]
Matthias J. Sax commented on KAFKA-13813:
-
Sorry for late reply – I was on leave
Justine Olshan created KAFKA-14359:
--
Summary: Idempotent Producer continues to retry on
OutOfOrderSequence error when first batch fails
Key: KAFKA-14359
URL: https://issues.apache.org/jira/browse/KAFKA-14359
[
https://issues.apache.org/jira/browse/KAFKA-14359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629231#comment-17629231
]
Justine Olshan commented on KAFKA-14359:
might be the same as https://issues.apa
showuon merged PR #12824:
URL: https://github.com/apache/kafka/pull/12824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon merged PR #12794:
URL: https://github.com/apache/kafka/pull/12794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on code in PR #12729:
URL: https://github.com/apache/kafka/pull/12729#discussion_r1014593992
##
core/src/main/scala/kafka/zk/AdminZkClient.scala:
##
@@ -355,18 +355,43 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
* @param entityName Th
54 matches
Mail list logo
