dajac commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1012620903
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -433,6 +433,22 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
+ /**
Review Comment:
n
cadonna commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1301816227
@clolov, to get option 1 rolling I think you could open an issue at
https://github.com/facebook/rocksdb/issues and ask if it is possible to get a
patch release of 6.29 with the zlib CVE f
OmniaGM commented on PR #12577:
URL: https://github.com/apache/kafka/pull/12577#issuecomment-1301870054
> Thanks for the updates @OmniaGM. There's a test failure:
>
> ```
> org.apache.kafka.common.KafkaException: The constructor of
org.apache.kafka.clients.admin.ForwardingAdmin thr
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1301915739
@cadonna, I wrote earlier today to
https://groups.google.com/g/rocksdb/c/DWsH8Yda5gc. I will wait for a day and if
there isn't a response I will also open an issue as you suggest :)
--
mimaison commented on code in PR #12804:
URL: https://github.com/apache/kafka/pull/12804#discussion_r1012744812
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java:
##
@@ -106,12 +106,20 @@ public class EmbeddedKafkaCluster {
pr
lucasbru commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1012833678
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -395,8 +395,10 @@ private void createNewTasks(final Map> activeTasksTo
cadonna commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1012934682
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -395,8 +395,10 @@ private void createNewTasks(final Map> activeTasksTo
C0urante commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1012953885
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -147,6 +148,7 @@ public class AbstractHerderTest {
@Mock private
[
https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628388#comment-17628388
]
Chris Egerton commented on KAFKA-14345:
---
[~gharris1727] is this related to KAFKA-8
[
https://issues.apache.org/jira/browse/KAFKA-14345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628388#comment-17628388
]
Chris Egerton edited comment on KAFKA-14345 at 11/3/22 3:38 PM:
--
clolov opened a new pull request, #12818:
URL: https://github.com/apache/kafka/pull/12818
Batch 6 of the tests detailed in
https://issues.apache.org/jira/browse/KAFKA-14133 which use EasyMock and need
to be moved to Mockito.
--
This is an automated message from the Apache Git Service.
To
clolov commented on PR #12818:
URL: https://github.com/apache/kafka/pull/12818#issuecomment-1302324578
Three points for this pull request:
* I have left `mock()` instead of `@Mock` where abstracting it wouldn't have
proved easy.
* I have used `lenient()` with some strict stubs because
clolov commented on PR #12818:
URL: https://github.com/apache/kafka/pull/12818#issuecomment-1302325278
@cadonna for visibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
b
lucasbru commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1013142335
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -395,8 +395,10 @@ private void createNewTasks(final Map> activeTasksTo
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14132:
--
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
b
[
https://issues.apache.org/jira/browse/KAFKA-14058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-14058.
---
Fix Version/s: 3.4.0
Resolution: Fixed
> Replace EasyMock and PowerMock with Mockito
C0urante commented on PR #12409:
URL: https://github.com/apache/kafka/pull/12409#issuecomment-1302382288
Thanks @mimaison. Test failures appear unrelated, going to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
C0urante merged PR #12409:
URL: https://github.com/apache/kafka/pull/12409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
cmccabe commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1013166571
##
server-common/src/test/java/org/apache/kafka/queue/KafkaEventQueueTest.java:
##
@@ -240,4 +242,29 @@ public void handleException(Throwable e) {
assertEquals
C0urante commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r1013182540
##
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##
@@ -106,6 +108,7 @@ public Connect startConnect(Map
workerProps) {
C0urante commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r1013182540
##
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:
##
@@ -106,6 +108,7 @@ public Connect startConnect(Map
workerProps) {
vamossagar12 commented on PR #12756:
URL: https://github.com/apache/kafka/pull/12756#issuecomment-1302449679
@vpapavas , @ableegoldman I was able to fix the failing test cases. Plz
review whenever you get the chance. I ran the tests locally and they seemed to
have passed.
--
This is an a
hachikuji opened a new pull request, #12819:
URL: https://github.com/apache/kafka/pull/12819
For tests which use the console consumer service, we are currently enabling
TRACE logging by default. I have seen some system tests where this produces GBs
of logging. A better default is probably D
jsancio commented on PR #12819:
URL: https://github.com/apache/kafka/pull/12819#issuecomment-1302501942
@hachikuji Are you planning to run Confluent' branch builder job and share
the results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
hachikuji commented on PR #12819:
URL: https://github.com/apache/kafka/pull/12819#issuecomment-1302513330
@jsancio Maybe it's good enough to post one test which uses the console
consumer service?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/KAFKA-13434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino resolved KAFKA-13434.
--
Resolution: Won't Do
KIP has been discarded
> Add a public API for AbstractCoordinato
Hector Geraldino created KAFKA-14354:
Summary: Add delete callback method to Connector API
Key: KAFKA-14354
URL: https://issues.apache.org/jira/browse/KAFKA-14354
Project: Kafka
Issue Typ
[
https://issues.apache.org/jira/browse/KAFKA-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-14354:
-
Component/s: KafkaConnect
(was: clients)
> Add delete callback meth
[
https://issues.apache.org/jira/browse/KAFKA-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-14354:
-
Priority: Minor (was: Major)
> Add delete callback method to Connector API
> --
[
https://issues.apache.org/jira/browse/KAFKA-14354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino updated KAFKA-14354:
-
Description: It would be useful to have a callback method added to the
Connector API, so
ashmeet13 commented on code in PR #12684:
URL: https://github.com/apache/kafka/pull/12684#discussion_r1013311309
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1450,4 +1453,15 @@ public static String[] enumOptions(Class> enumClass) {
.
ashmeet13 commented on code in PR #12684:
URL: https://github.com/apache/kafka/pull/12684#discussion_r1013311309
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1450,4 +1453,15 @@ public static String[] enumOptions(Class> enumClass) {
.
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1013413433
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -132,9 +139,22 @@ class ReplicaFetcherThread(name: String,
brokerTopicStats.updateReplica
qingwei91 commented on PR #12166:
URL: https://github.com/apache/kafka/pull/12166#issuecomment-1302692988
@mjsax sorry, I will try to pick this back up this weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
gharris1727 commented on code in PR #12817:
URL: https://github.com/apache/kafka/pull/12817#discussion_r1013212435
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java:
##
@@ -155,10 +143,22 @@ public LoaderSwap withClassLoader(ClassLoader loa
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1013457033
##
core/src/test/scala/unit/kafka/server/FetchRequestTest.scala:
##
@@ -51,7 +51,7 @@ class FetchRequestTest extends BaseFetchRequestTest {
def createFetchRequ
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1302757888
@dajac thanks for the review. i have addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
badaiaqrandista opened a new pull request, #12820:
URL: https://github.com/apache/kafka/pull/12820
NOTE: This PR should be merged using CLI to preserve commit history
Based on
https://confluentinc.atlassian.net/wiki/spaces/KAFKA/pages/776700227/ce-kafka+merge+process#Kafka.1
Ch
badaiaqrandista closed pull request #12820: [DO NOT MERGE] 3.2 sync upstream 4
nov 2022
URL: https://github.com/apache/kafka/pull/12820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
47 matches
Mail list logo
