[GitHub] [kafka] divijvaidya commented on a diff in pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

2022-10-24 Thread GitBox
divijvaidya commented on code in PR #12777: URL: https://github.com/apache/kafka/pull/12777#discussion_r1002953413 ## streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedWindowStoreTest.java: ## @@ -1166,58 +1164,47 @@ public void shouldNotThrowInvalidBack

[jira] [Created] (KAFKA-14329) KafkaAdminClient#listOffsets should query by partition dimension

2022-10-24 Thread shizhenzhen (Jira)
shizhenzhen created KAFKA-14329: --- Summary: KafkaAdminClient#listOffsets should query by partition dimension Key: KAFKA-14329 URL: https://issues.apache.org/jira/browse/KAFKA-14329 Project: Kafka

[jira] [Updated] (KAFKA-14329) KafkaAdminClient#listOffsets should query by partition dimension

2022-10-24 Thread shizhenzhen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shizhenzhen updated KAFKA-14329: Attachment: image-2022-10-24-16-47-03-180.png > KafkaAdminClient#listOffsets should query by parti

[jira] [Commented] (KAFKA-14329) KafkaAdminClient#listOffsets should query by partition dimension

2022-10-24 Thread shizhenzhen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623054#comment-17623054 ] shizhenzhen commented on KAFKA-14329: - 对于这里的异常 ,我觉得没有必只要有分区异常就抛出来,而是应该判断查询的分区有异常的话就抛

[jira] [Created] (KAFKA-14330) The Kafka Connection Is High During Service Startup

2022-10-24 Thread flybird (Jira)
flybird created KAFKA-14330: --- Summary: The Kafka Connection Is High During Service Startup Key: KAFKA-14330 URL: https://issues.apache.org/jira/browse/KAFKA-14330 Project: Kafka Issue Type: Improve

[jira] [Updated] (KAFKA-14330) The Kafka Connection Is High During Service Startup

2022-10-24 Thread flybird (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] flybird updated KAFKA-14330: Description: The Kafka Connection Is High During Service Startup During service restart, the number of Ka

[jira] [Updated] (KAFKA-14330) The Kafka Connection Is High During Service Startup

2022-10-24 Thread flybird (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] flybird updated KAFKA-14330: Description: The Kafka Connection Is High During Service Startup During service restart, the number of Ka

[GitHub] [kafka] lucasbru commented on pull request #12731: MINOR: Fix usage instruction of skipSigning build parameter

2022-10-24 Thread GitBox
lucasbru commented on PR #12731: URL: https://github.com/apache/kafka/pull/12731#issuecomment-1288748552 Test failures are unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] lucasbru commented on pull request #12719: MINOR: Get console output in quickstart examples

2022-10-24 Thread GitBox
lucasbru commented on PR #12719: URL: https://github.com/apache/kafka/pull/12719#issuecomment-1288749331 Test failures are unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] omkreddy opened a new pull request, #12779: MINOR: Fix allDepInsight gradle task with gradle 7.5

2022-10-24 Thread GitBox
omkreddy opened a new pull request, #12779: URL: https://github.com/apache/kafka/pull/12779 gradle allDepInsight task is failing with gradle 7.5. Fixed the issue by setting the option `showingAllVariants = false` for DependencyInsightReportTask ``` ➜ ./gradlew allDepInsight --conf

[GitHub] [kafka] Gerrrr commented on a diff in pull request #12760: KAFKA-14309: FK join upgrades not tested with DEV_VERSION

2022-10-24 Thread GitBox
Ge commented on code in PR #12760: URL: https://github.com/apache/kafka/pull/12760#discussion_r1003148402 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -345,13 +353,13 @@ def start_all_nodes_with(self, version): second_monitor.wait_unti

[jira] [Updated] (KAFKA-14309) Kafka Streams upgrade tests do not cover for FK-joins

2022-10-24 Thread Alex Sorokoumov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Sorokoumov updated KAFKA-14309: Reviewer: Alex Sorokoumov > Kafka Streams upgrade tests do not cover for FK-joins > --

[jira] [Created] (KAFKA-14331) Upgrade to Scala 2.13.10

2022-10-24 Thread Viktor Somogyi-Vass (Jira)
Viktor Somogyi-Vass created KAFKA-14331: --- Summary: Upgrade to Scala 2.13.10 Key: KAFKA-14331 URL: https://issues.apache.org/jira/browse/KAFKA-14331 Project: Kafka Issue Type: Improvemen

[jira] [Created] (KAFKA-14332) Split out checkstyle configs between test and main

2022-10-24 Thread Matthew de Detrich (Jira)
Matthew de Detrich created KAFKA-14332: -- Summary: Split out checkstyle configs between test and main Key: KAFKA-14332 URL: https://issues.apache.org/jira/browse/KAFKA-14332 Project: Kafka

[jira] [Assigned] (KAFKA-14332) Split out checkstyle configs between test and main

2022-10-24 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich reassigned KAFKA-14332: -- Assignee: Matthew de Detrich > Split out checkstyle configs between test and

[jira] [Updated] (KAFKA-14332) Split out checkstyle configs between test and main

2022-10-24 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich updated KAFKA-14332: --- Component/s: system tests unit tests > Split out checkstyle configs

[jira] [Updated] (KAFKA-14332) Split out checkstyle configs between test and main

2022-10-24 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich updated KAFKA-14332: --- Description: Currently in Kafka we have one global import-control.xml that is used t

[jira] [Created] (KAFKA-14333) Kafka Admin delete records java doc is missing information about supported cleanup.policy

2022-10-24 Thread Tomasz Kaszuba (Jira)
Tomasz Kaszuba created KAFKA-14333: -- Summary: Kafka Admin delete records java doc is missing information about supported cleanup.policy Key: KAFKA-14333 URL: https://issues.apache.org/jira/browse/KAFKA-14333

[GitHub] [kafka] mdedetrich opened a new pull request, #12780: KAFKA-14332; Make Kafka tests use their own separate import-control.xml

2022-10-24 Thread GitBox
mdedetrich opened a new pull request, #12780: URL: https://github.com/apache/kafka/pull/12780 Currently in Kafka we have a global import-control.xml that is used for both main source code and tests. This change move test related allow import rules from import-control.xml to import-control-t

[GitHub] [kafka] mdedetrich opened a new pull request, #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

2022-10-24 Thread GitBox
mdedetrich opened a new pull request, #12781: URL: https://github.com/apache/kafka/pull/12781 Migrates the tests from EasyMock to Mockito. Notes about non trivial changes below * Originally the test was using `PowerMock.expectPrivate` to mock protected fields. There is no equivalent

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1003264688 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -135,8 +161,7 @@ public class KafkaBasedLogTest { @SuppressWarnings

[GitHub] [kafka] mdedetrich commented on pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

2022-10-24 Thread GitBox
mdedetrich commented on PR #12781: URL: https://github.com/apache/kafka/pull/12781#issuecomment-1288975433 @C0urante Pinging for visibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Commented] (KAFKA-14331) Upgrade to Scala 2.13.10

2022-10-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623150#comment-17623150 ] Mickael Maison commented on KAFKA-14331: There's a PR in progress: [https://gith

[GitHub] [kafka] soarez commented on a diff in pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-24 Thread GitBox
soarez commented on code in PR #12752: URL: https://github.com/apache/kafka/pull/12752#discussion_r1003267952 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -55,6 +58,30 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1003264688 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -135,8 +161,7 @@ public class KafkaBasedLogTest { @SuppressWarnings

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003403323 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -319,35 +318,28 @@ public void testRestartConnectorNewT

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003415030 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -319,35 +318,28 @@ public void testRestartConnectorNewT

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003416194 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -319,35 +318,28 @@ public void testRestartConnectorNewT

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003416709 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003423802 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] C0urante commented on pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

2022-10-24 Thread GitBox
C0urante commented on PR #12366: URL: https://github.com/apache/kafka/pull/12366#issuecomment-1289174125 Hi @OmniaGM--good questions. Due to [KAFKA-10586](https://issues.apache.org/jira/browse/KAFKA-10586), exactly-once isn't supported when running Mirror Maker 2 in dedicated mode (i.e., vi

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003426382 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -218,43 +229,37 @@ public void testCreateConnectorAlrea

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003427723 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -218,43 +229,37 @@ public void testCreateConnectorAlrea

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003430230 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -272,35 +277,31 @@ public void testDestroyConnector() t

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003431402 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -272,35 +277,31 @@ public void testDestroyConnector() t

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003426382 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -218,43 +229,37 @@ public void testCreateConnectorAlrea

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003458373 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -153,19 +157,23 @@ public class ConnectorsResourc

[jira] [Created] (KAFKA-14334) DelayedFetch purgatory not completed when appending as follower

2022-10-24 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-14334: Summary: DelayedFetch purgatory not completed when appending as follower Key: KAFKA-14334 URL: https://issues.apache.org/jira/browse/KAFKA-14334 Project: Kafka Issu

[GitHub] [kafka] bbejeck commented on pull request #12719: MINOR: Get console output in quickstart examples

2022-10-24 Thread GitBox
bbejeck commented on PR #12719: URL: https://github.com/apache/kafka/pull/12719#issuecomment-1289232881 Failure unrelated merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] bbejeck merged pull request #12719: MINOR: Get console output in quickstart examples

2022-10-24 Thread GitBox
bbejeck merged PR #12719: URL: https://github.com/apache/kafka/pull/12719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] bbejeck commented on pull request #12719: MINOR: Get console output in quickstart examples

2022-10-24 Thread GitBox
bbejeck commented on PR #12719: URL: https://github.com/apache/kafka/pull/12719#issuecomment-1289233877 merged #12719 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] bbejeck commented on pull request #12731: MINOR: Fix usage instruction of skipSigning build parameter

2022-10-24 Thread GitBox
bbejeck commented on PR #12731: URL: https://github.com/apache/kafka/pull/12731#issuecomment-1289245984 Failures unrelated - changes made in the README file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] bbejeck merged pull request #12731: MINOR: Fix usage instruction of skipSigning build parameter

2022-10-24 Thread GitBox
bbejeck merged PR #12731: URL: https://github.com/apache/kafka/pull/12731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] bbejeck commented on pull request #12731: MINOR: Fix usage instruction of skipSigning build parameter

2022-10-24 Thread GitBox
bbejeck commented on PR #12731: URL: https://github.com/apache/kafka/pull/12731#issuecomment-1289248229 merged #12731 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Assigned] (KAFKA-14334) DelayedFetch purgatory not completed when appending as follower

2022-10-24 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim reassigned KAFKA-14334: Assignee: Jeff Kim > DelayedFetch purgatory not completed when appending as follower > --

[GitHub] [kafka] nicktelford commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-10-24 Thread GitBox
nicktelford commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r1003497784 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractTransactionalStore.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] nicktelford commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

2022-10-24 Thread GitBox
nicktelford commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r1003504997 ## streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractTransactionalStore.java: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003508600 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -262,127 +254,96 @@ public void testFullExpandCon

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003508600 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -262,127 +254,96 @@ public void testFullExpandCon

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003515713 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -899,250 +750,199 @@ public void testFenceZombie

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003516803 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -899,250 +750,199 @@ public void testFenceZombie

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003516803 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -899,250 +750,199 @@ public void testFenceZombie

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003519590 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -547,118 +473,88 @@ public void testGetTasksConfi

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003521644 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -262,127 +254,96 @@ public void testFullExpandCon

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003521644 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -262,127 +254,96 @@ public void testFullExpandCon

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1003526116 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -841,55 +702,45 @@ public void testRestartConnect

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003529940 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003423802 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003529940 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] vvcephei commented on a diff in pull request #12775: KAFKA-14247: add handler impl to the prototype

2022-10-24 Thread GitBox
vvcephei commented on code in PR #12775: URL: https://github.com/apache/kafka/pull/12775#discussion_r1003534227 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -135,4 +214,34 @@ public boolean process() { retur

[GitHub] [kafka] OmniaGM commented on pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

2022-10-24 Thread GitBox
OmniaGM commented on PR #12366: URL: https://github.com/apache/kafka/pull/12366#issuecomment-1289344091 Can we also add an integration test for EOS in MM2 as well? > Hi @OmniaGM -- good questions! Due to [KAFKA-10586](https://issues.apache.org/jira/browse/KAFKA-10586), exactly-once

[GitHub] [kafka] omkreddy merged pull request #12768: MINOR: Upgrade spotbugs dependency

2022-10-24 Thread GitBox
omkreddy merged PR #12768: URL: https://github.com/apache/kafka/pull/12768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] omkreddy commented on pull request #11579: KAFKA-13518: Update gson dependency

2022-10-24 Thread GitBox
omkreddy commented on PR #11579: URL: https://github.com/apache/kafka/pull/11579#issuecomment-1289373220 Closing this PR in favour of https://github.com/apache/kafka/pull/12768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] omkreddy closed pull request #11579: KAFKA-13518: Update gson dependency

2022-10-24 Thread GitBox
omkreddy closed pull request #11579: KAFKA-13518: Update gson dependency URL: https://github.com/apache/kafka/pull/11579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[jira] [Resolved] (KAFKA-13518) Update gson dependency

2022-10-24 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-13518. --- Fix Version/s: 3.4.0 Resolution: Fixed > Update gson dependency > -- > >

[jira] [Assigned] (KAFKA-14326) kafka-application-reset-tool should accept spaces between input/intermediate topics

2022-10-24 Thread Richard Joerger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Joerger reassigned KAFKA-14326: --- Assignee: Richard Joerger Going to grab this to work on. > kafka-application-rese

[GitHub] [kafka] C0urante commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

2022-10-24 Thread GitBox
C0urante commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1003623254 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { private

[jira] [Created] (KAFKA-14335) Admin.listConsumerGroups should allow filtering, pagination

2022-10-24 Thread Kirk True (Jira)
Kirk True created KAFKA-14335: - Summary: Admin.listConsumerGroups should allow filtering, pagination Key: KAFKA-14335 URL: https://issues.apache.org/jira/browse/KAFKA-14335 Project: Kafka Issue

[jira] [Created] (KAFKA-14336) Reduce allocations from MetadataResponse#convertToNodeArray

2022-10-24 Thread David Schlosnagle (Jira)
David Schlosnagle created KAFKA-14336: - Summary: Reduce allocations from MetadataResponse#convertToNodeArray Key: KAFKA-14336 URL: https://issues.apache.org/jira/browse/KAFKA-14336 Project: Kafka

[jira] [Updated] (KAFKA-14335) Admin.listConsumerGroups should allow filtering, pagination

2022-10-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14335: -- Description: The [Admin|https://kafka.apache.org/33/javadoc/org/apache/kafka/clients/admin/Admin.html

[GitHub] [kafka] schlosna opened a new pull request, #12782: KAFKA-14336: MetadataResponse#convertToNodeArray uses iteration

2022-10-24 Thread GitBox
schlosna opened a new pull request, #12782: URL: https://github.com/apache/kafka/pull/12782 Avoids stream allocation on hot code path. [KAFKA-14336:](https://issues.apache.org/jira/browse/KAFKA-14336) While profiling a Kafka consumer application that utilizes `org.apache.kafka.

[jira] [Commented] (KAFKA-14336) Reduce allocations from MetadataResponse#convertToNodeArray

2022-10-24 Thread David Schlosnagle (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623342#comment-17623342 ] David Schlosnagle commented on KAFKA-14336: --- PR for review: https://github.com

[GitHub] [kafka] kirktrue commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2022-10-24 Thread GitBox
kirktrue commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1003656846 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -996,20 +1010,21 @@ private void ensureTransactional() { }

[GitHub] [kafka] philipnee commented on pull request #12775: KAFKA-14247: add handler impl to the prototype

2022-10-24 Thread GitBox
philipnee commented on PR #12775: URL: https://github.com/apache/kafka/pull/12775#issuecomment-1289524756 Added a test for the subscription() method. It's a bit complicated to test other method as the class is still Abstract. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

2022-10-24 Thread GitBox
mdedetrich commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1003753991 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java: ## @@ -547,32 +540,22 @@ public void testReadEndOffsetsUsingAdminThatFailsWit

[jira] [Assigned] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2022-10-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-10228: - Assignee: Kirk True (was: Philip Nee) > producer: NETWORK_EXCEPTION is thrown instead of a req

[jira] [Commented] (KAFKA-14317) ProduceRequest timeouts are logged as network exceptions

2022-10-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623413#comment-17623413 ] Kirk True commented on KAFKA-14317: --- This looks related to KAFKA-10228, but that Jira

[jira] [Commented] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2022-10-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623414#comment-17623414 ] Kirk True commented on KAFKA-10228: --- The logging change is pull request [11449|https:

[jira] [Comment Edited] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

2022-10-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623414#comment-17623414 ] Kirk True edited comment on KAFKA-10228 at 10/24/22 8:57 PM: -

[jira] [Updated] (KAFKA-14317) ProduceRequest timeouts are logged as network exceptions

2022-10-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14317: -- Description: In {{{}NetworkClient.handleTimedOutRequests{}}}, we disconnect the broker connection: {c

[GitHub] [kafka] jeffkbkim opened a new pull request, #12783: KAFKA-14334: complete delayed purgatory after replication

2022-10-24 Thread GitBox
jeffkbkim opened a new pull request, #12783: URL: https://github.com/apache/kafka/pull/12783 When a consumer makes a fetch request to a follower (for [KIP-392](https://cwiki.apache.org/confluence/display/KAFKA/KIP-392%3A+Allow+consumers+to+fetch+from+closest+replica#KIP392:Allowconsumerstofe

[GitHub] [kafka] showuon commented on pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-24 Thread GitBox
showuon commented on PR #12752: URL: https://github.com/apache/kafka/pull/12752#issuecomment-1289858511 @ijuma , do you want to have another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] showuon commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-10-24 Thread GitBox
showuon commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1003930984 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] bedilbek commented on pull request #5001: KAFKA-6895: (WIP) Schema Inferencing for JsonConverter

2022-10-24 Thread GitBox
bedilbek commented on PR #5001: URL: https://github.com/apache/kafka/pull/5001#issuecomment-1289989187 Any updates on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] showuon commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

2022-10-24 Thread GitBox
showuon commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1004042695 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u