[GitHub] [kafka] showuon commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-11 Thread GitBox
showuon commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r967815118 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -446,6 +429,31 @@ private RequestFuture sendMetadataRequest(MetadataRequest.Bui

[GitHub] [kafka] ijuma commented on pull request #12591: MINOR: Replace usage of File.createTempFile() with TestUtils.tempFile()

2022-09-11 Thread GitBox
ijuma commented on PR #12591: URL: https://github.com/apache/kafka/pull/12591#issuecomment-1243001431 I think this incremental improvement is probably fine on its own. To improve things further, we should consider something like https://www.baeldung.com/junit-5-temporary-directory -- Thi

[GitHub] [kafka] ijuma commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-11 Thread GitBox
ijuma commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r967857699 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1941,76 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] ijuma commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-11 Thread GitBox
ijuma commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r967858332 ## clients/src/test/java/org/apache/kafka/common/security/authenticator/ClientAuthenticationFailureTest.java: ## @@ -90,12 +90,12 @@ public void testConsumerWithInvalidCre

[GitHub] [kafka] mumrah commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-11 Thread GitBox
mumrah commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r967876053 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -325,7 +325,7 @@ class BrokerMetadataListener( try { _image = _delta.apply()

[jira] [Commented] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-11 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602906#comment-17602906 ] Ismael Juma commented on KAFKA-14196: - To clarify, this was introduced in 3.2.1 (not

[jira] [Comment Edited] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-11 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602906#comment-17602906 ] Ismael Juma edited comment on KAFKA-14196 at 9/11/22 7:38 PM:

[jira] [Commented] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602912#comment-17602912 ] Philip Nee commented on KAFKA-14196: [~ijuma] - I think that's right, according to t

[jira] [Comment Edited] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602912#comment-17602912 ] Philip Nee edited comment on KAFKA-14196 at 9/11/22 9:39 PM: -

[jira] [Comment Edited] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602912#comment-17602912 ] Philip Nee edited comment on KAFKA-14196 at 9/11/22 9:39 PM: -

[jira] [Updated] (KAFKA-14215) KRaft forwarded requests have no quota enforcement

2022-09-11 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14215: - Fix Version/s: 3.3 Affects Version/s: 3.3.0 3.3 Prior

[GitHub] [kafka] showuon commented on pull request #12591: MINOR: Replace usage of File.createTempFile() with TestUtils.tempFile()

2022-09-11 Thread GitBox
showuon commented on PR #12591: URL: https://github.com/apache/kafka/pull/12591#issuecomment-1243088692 > I think this incremental improvement is probably fine on its own. To improve things further, we should consider something like https://www.baeldung.com/junit-5-temporary-directory (vers

[jira] [Created] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

2022-09-11 Thread Luke Chen (Jira)
Luke Chen created KAFKA-14218: - Summary: replace temp file handler with JUnit 5 Temporary Directory Support Key: KAFKA-14218 URL: https://issues.apache.org/jira/browse/KAFKA-14218 Project: Kafka

[GitHub] [kafka] showuon commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-11 Thread GitBox
showuon commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r967917752 ## clients/src/test/java/org/apache/kafka/common/security/authenticator/ClientAuthenticationFailureTest.java: ## @@ -90,12 +90,12 @@ public void testConsumerWithInvalidC

[jira] [Updated] (KAFKA-14217) app-reset-tool.html should remove reference to --zookeeper flag that no longer exists

2022-09-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14217: -- Affects Version/s: 3.3.0 (was: 3.30) > app-reset-tool.html should remove re

[GitHub] [kafka] philipnee commented on pull request #12603: KAFKA-14196: Pausing partition to prevent duplication when autocommit is enabled

2022-09-11 Thread GitBox
philipnee commented on PR #12603: URL: https://github.com/apache/kafka/pull/12603#issuecomment-1243094204 Thanks @showuon @hachikuji for the inputs, I just made this PR reviewable, so please review it if possible :) -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] showuon commented on a diff in pull request #12611: KAFKA-14208: Should not wake-up with non-blocking coordinator discovery

2022-09-11 Thread GitBox
showuon commented on code in PR #12611: URL: https://github.com/apache/kafka/pull/12611#discussion_r967930755 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java: ## @@ -272,6 +272,39 @@ public void testCoordinatorDiscoveryBackoff()

[GitHub] [kafka] showuon opened a new pull request, #12620: KAFKA-14206: upgrade zookeeper version to 3.7.1

2022-09-11 Thread GitBox
showuon opened a new pull request, #12620: URL: https://github.com/apache/kafka/pull/12620 Upgrade zookeeper version to the latest stable release 3.7.1 due to some CVEs. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify t

[jira] [Commented] (KAFKA-13563) FindCoordinatorFuture never get cleared in non-group mode( consumer#assign)

2022-09-11 Thread Jaebin Yoon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602946#comment-17602946 ] Jaebin Yoon commented on KAFKA-13563: - Affected versions should include 2.6.2, which

[jira] [Assigned] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

2022-09-11 Thread vinay kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinay kumar reassigned KAFKA-14218: --- Assignee: vinay kumar > replace temp file handler with JUnit 5 Temporary Directory Support

[jira] [Assigned] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

2022-09-11 Thread vinay kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinay kumar reassigned KAFKA-14218: --- Assignee: (was: vinay kumar) > replace temp file handler with JUnit 5 Temporary Directo

[jira] [Updated] (KAFKA-13563) FindCoordinatorFuture never get cleared in non-group mode( consumer#assign)

2022-09-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13563: -- Affects Version/s: 2.6.2 > FindCoordinatorFuture never get cleared in non-group mode( consumer#assign)

[jira] [Created] (KAFKA-14219) Kafka messages are not read in certain bytes or message count in batches when read from Spark

2022-09-11 Thread Madhav Madhu (Jira)
Madhav Madhu created KAFKA-14219: Summary: Kafka messages are not read in certain bytes or message count in batches when read from Spark Key: KAFKA-14219 URL: https://issues.apache.org/jira/browse/KAFKA-14219

[GitHub] [kafka] showuon commented on pull request #12620: KAFKA-14206: upgrade zookeeper version to 3.7.1

2022-09-11 Thread GitBox
showuon commented on PR #12620: URL: https://github.com/apache/kafka/pull/12620#issuecomment-1243274820 @jsancio , should we include this upgrade into 3.3? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above