[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-26 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929602456 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-26 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929602456 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] mnegodaev commented on pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

2022-07-26 Thread GitBox
mnegodaev commented on PR #11442: URL: https://github.com/apache/kafka/pull/11442#issuecomment-1195099586 @rhauch @mimaison @kkonstantine @pjmagee If you guys don't mind I'm going to wait till Wednesday and then call a [VOTE] to have the proposal adopted. Thanks! -- This is an automat

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-26 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929615594 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,62 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] cadonna commented on pull request #12436: MINOR: Use builder for mock task in DefaultStateUpdaterTest

2022-07-26 Thread GitBox
cadonna commented on PR #12436: URL: https://github.com/apache/kafka/pull/12436#issuecomment-1195152136 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest.testReplication() Build / JDK 8 a

[GitHub] [kafka] cadonna merged pull request #12436: MINOR: Use builder for mock task in DefaultStateUpdaterTest

2022-07-26 Thread GitBox
cadonna merged PR #12436: URL: https://github.com/apache/kafka/pull/12436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] clolov commented on pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-26 Thread GitBox
clolov commented on PR #12422: URL: https://github.com/apache/kafka/pull/12422#issuecomment-1195214901 Heya @C0urante and @ijuma I just want to confirm whether we are waiting on a change which I need to make? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-26 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929731476 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true) }

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-26 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929731476 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true) }

[GitHub] [kafka] rajinisivaram commented on pull request #12416: KAFKA-13559: Fix issue where responses intermittently takes 300+ ms to respond, even when the server is idle.

2022-07-26 Thread GitBox
rajinisivaram commented on PR #12416: URL: https://github.com/apache/kafka/pull/12416#issuecomment-1195238184 @badaiaqrandista Thanks for the update, looks good. But looks like there is a timing issue in the test since it has failed for the JDK8 PR build, can you take a look? Remember seein

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-26 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929748156 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] mimaison commented on pull request #10528: KAFKA-12497: Skip periodic offset commits for failed source tasks

2022-07-26 Thread GitBox
mimaison commented on PR #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-1195254372 @tombentley @vvcephei Can you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] mdedetrich commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-26 Thread GitBox
mdedetrich commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929748156 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true)

[GitHub] [kafka] showuon commented on a diff in pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

2022-07-26 Thread GitBox
showuon commented on code in PR #11478: URL: https://github.com/apache/kafka/pull/11478#discussion_r929766809 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -252,16 +255,60 @@ object CoreUtils { listenerListToEndPoints(listeners, securityProtocolMap, true) }

[GitHub] [kafka] mimaison commented on pull request #12429: KAFKA-14089: Only check for committed seqnos after disabling exactly-once support in Connect integration test

2022-07-26 Thread GitBox
mimaison commented on PR #12429: URL: https://github.com/apache/kafka/pull/12429#issuecomment-1195330919 I've run the tests a dozen times and I've not seen any failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] zigarn commented on pull request #12434: KAFKA-14099 - Fix request logs in connect

2022-07-26 Thread GitBox
zigarn commented on PR #12434: URL: https://github.com/apache/kafka/pull/12434#issuecomment-1195358695 @C0urante In the meantime I added a test by copying the `LogCaptureAppender` from #10528. Not the best with the while loop to wait for the log to be created in the completion phase.

[GitHub] [kafka] ijuma commented on a diff in pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-26 Thread GitBox
ijuma commented on code in PR #12422: URL: https://github.com/apache/kafka/pull/12422#discussion_r929857189 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerConfigTransformerTest.java: ## @@ -53,64 +50,72 @@ public class WorkerConfigTransformerTest {

[GitHub] [kafka] ijuma commented on pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-26 Thread GitBox
ijuma commented on PR #12422: URL: https://github.com/apache/kafka/pull/12422#issuecomment-1195370508 @C0urante you can use your committer privileges to merge this. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Resolved] (KAFKA-14001) Part 1

2022-07-26 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov resolved KAFKA-14001. --- Reviewer: Bruno Cadonna Resolution: Fixed > Part 1 > -- > > Key: K

[jira] [Updated] (KAFKA-14001) Part 1

2022-07-26 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14001: -- Labels: streams (was: ) > Part 1 > -- > > Key: KAFKA-14001 >

[jira] [Created] (KAFKA-14107) Upgrade Jetty for CVE fixes

2022-07-26 Thread Andrew Borley (Jira)
Andrew Borley created KAFKA-14107: - Summary: Upgrade Jetty for CVE fixes Key: KAFKA-14107 URL: https://issues.apache.org/jira/browse/KAFKA-14107 Project: Kafka Issue Type: Bug Compo

[jira] [Created] (KAFKA-14108) Allow JUnit 4 and JUnit 5 tests to run while the migration is going on

2022-07-26 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-14108: - Summary: Allow JUnit 4 and JUnit 5 tests to run while the migration is going on Key: KAFKA-14108 URL: https://issues.apache.org/jira/browse/KAFKA-14108 Project: Kaf

[GitHub] [kafka] ajborley opened a new pull request, #12440: KAFKA-14107: Upgrade Jetty version for CVE fixes

2022-07-26 Thread GitBox
ajborley opened a new pull request, #12440: URL: https://github.com/apache/kafka/pull/12440 KAFKA-14107 Upgrade Jetty for CVE fixes. Jetty: [CVE-2022-2048](https://nvd.nist.gov/vuln/detail/CVE-2022-2048) and [CVE-2022-2047](https://nvd.nist.gov/vuln/detail/CVE-2022-2047) - Fixed

[jira] [Created] (KAFKA-14109) Clean up JUnit 4 test infrastructure

2022-07-26 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-14109: - Summary: Clean up JUnit 4 test infrastructure Key: KAFKA-14109 URL: https://issues.apache.org/jira/browse/KAFKA-14109 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-14109) Clean up JUnit 4 test infrastructure

2022-07-26 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14109: -- Description: We need to cleanup the setup in https://issues.apache.org/jira/browse/KAFKA-14108

[jira] [Commented] (KAFKA-14107) Upgrade Jetty for CVE fixes

2022-07-26 Thread Andrew Borley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571392#comment-17571392 ] Andrew Borley commented on KAFKA-14107: --- I think this is a dup of https://issues.a

[GitHub] [kafka] clolov opened a new pull request, #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

2022-07-26 Thread GitBox
clolov opened a new pull request, #12441: URL: https://github.com/apache/kafka/pull/12441 This pull request addresses the problem reported in https://github.com/apache/kafka/pull/12285 and tracked in https://issues.apache.org/jira/browse/KAFKA-14108 -- This is an automated message from t

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-26 Thread GitBox
clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195428834 Hello @cadonna! I spoke with Divij offline and we found a way to run both JUnit 4 and JUnit 5 tests while the migration is going on. The pull request which should enable this is https://gi

[GitHub] [kafka] divijvaidya commented on pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

2022-07-26 Thread GitBox
divijvaidya commented on PR #12441: URL: https://github.com/apache/kafka/pull/12441#issuecomment-1195438950 @clolov 1. don't we need to remove "streams" from ``` def shouldUseJUnit5 = !(["runtime", "streams"].contains(it.project.name)) ``` as well? 2. please add the

[GitHub] [kafka] mimaison commented on pull request #12429: KAFKA-14089: Only check for committed seqnos after disabling exactly-once support in Connect integration test

2022-07-26 Thread GitBox
mimaison commented on PR #12429: URL: https://github.com/apache/kafka/pull/12429#issuecomment-1195440012 @tombentley Do you want to take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ijuma commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

2022-07-26 Thread GitBox
ijuma commented on PR #12413: URL: https://github.com/apache/kafka/pull/12413#issuecomment-1195448786 > Just curious, the latest zinc is 1.7.1 (ref: https://mvnrepository.com/artifact/org.scala-sbt/zinc), why did we only upgrade to 1.6.1? I'm fine to stick to 1.6.1 since it fixes the log4j2

[GitHub] [kafka] ijuma merged pull request #12413: MINOR: Upgrade to Gradle 7.5

2022-07-26 Thread GitBox
ijuma merged PR #12413: URL: https://github.com/apache/kafka/pull/12413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] showuon commented on pull request #12413: MINOR: Upgrade to Gradle 7.5

2022-07-26 Thread GitBox
showuon commented on PR #12413: URL: https://github.com/apache/kafka/pull/12413#issuecomment-1195464946 > I'll do some testing regarding that, but will merge this PR in the meantime. Sure. Thank you. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController

2022-07-26 Thread GitBox
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1195483345 @mumrah could you take another look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cadonna commented on pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

2022-07-26 Thread GitBox
cadonna commented on PR #12441: URL: https://github.com/apache/kafka/pull/12441#issuecomment-1195488452 Thanks for the PR, @clolov ! The builds have errors: ``` * What went wrong: [2022-07-26T12:41:05.041Z] A problem occurred evaluating root project 'Kafka_kafka-pr_PR-12441'.

[GitHub] [kafka] C0urante commented on pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-26 Thread GitBox
C0urante commented on PR #12422: URL: https://github.com/apache/kafka/pull/12422#issuecomment-1195498271 Thanks @ijuma. No test failures in Connect and all others appear unrelated; this looks good to go. Thanks for the PR @clolov! -- This is an automated message from the Apache Git

[GitHub] [kafka] C0urante merged pull request #12422: KAFKA-13982: Move WorkerConfigTransformerTest to use Mockito

2022-07-26 Thread GitBox
C0urante merged PR #12422: URL: https://github.com/apache/kafka/pull/12422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] ijuma commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-26 Thread GitBox
ijuma commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195515462 Doing things incrementally over a long period of time is a bit confusing since you cannot enforce that JUnit 4 or JUnit 5 is used at any point in time. My take is that it's simplest if the

[GitHub] [kafka] ijuma commented on a diff in pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

2022-07-26 Thread GitBox
ijuma commented on code in PR #12441: URL: https://github.com/apache/kafka/pull/12441#discussion_r929996127 ## build.gradle: ## @@ -466,6 +466,10 @@ subprojects { if (shouldUseJUnit5) { useJUnitPlatform { includeTags "integration" +// KAFKA-14109 +

[GitHub] [kafka] cadonna commented on pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

2022-07-26 Thread GitBox
cadonna commented on PR #12441: URL: https://github.com/apache/kafka/pull/12441#issuecomment-119551 @clolov I also found a mistake in #12285: In `KTableSourceTopicRestartIntegrationTest` line 103 should be ``` sourceTopic = SOURCE_TOPIC + "-" + testInfo.getTestMethod().map(Meth

[GitHub] [kafka] ijuma commented on a diff in pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

2022-07-26 Thread GitBox
ijuma commented on code in PR #12441: URL: https://github.com/apache/kafka/pull/12441#discussion_r929996624 ## build.gradle: ## @@ -466,6 +466,10 @@ subprojects { if (shouldUseJUnit5) { useJUnitPlatform { includeTags "integration" +// KAFKA-14109 Re

[GitHub] [kafka] ijuma commented on a diff in pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

2022-07-26 Thread GitBox
ijuma commented on code in PR #12441: URL: https://github.com/apache/kafka/pull/12441#discussion_r929998599 ## gradle/dependencies.gradle: ## @@ -159,6 +159,10 @@ libs += [ jmhGeneratorAnnProcess: "org.openjdk.jmh:jmh-generator-annprocess:$versions.jmh", joptSimple: "net.

[GitHub] [kafka] C0urante commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-07-26 Thread GitBox
C0urante commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1195531314 @dstelljes I just noticed that, with the changes in this PR, it's no longer possible to run individual test cases in this suite. For example, this command now fails: ```bash ./

[jira] [Assigned] (KAFKA-13586) ConfigExceptions thrown by FileConfigProvider during connector/task startup crash worker

2022-07-26 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-13586: - Assignee: (was: Greg Harris) > ConfigExceptions thrown by FileConfigProvider during

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

2022-07-26 Thread GitBox
divijvaidya commented on code in PR #12441: URL: https://github.com/apache/kafka/pull/12441#discussion_r930013162 ## build.gradle: ## @@ -466,6 +466,10 @@ subprojects { if (shouldUseJUnit5) { useJUnitPlatform { includeTags "integration" +// KAFKA-141

[jira] [Updated] (KAFKA-13982) Replace EasyMock and PowerMock with Mockito for WorkerConfigTransformerTest

2022-07-26 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13982: -- Fix Version/s: 3.4.0 > Replace EasyMock and PowerMock with Mockito for WorkerConfigTransformer

[GitHub] [kafka] mimaison commented on a diff in pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page

2022-07-26 Thread GitBox
mimaison commented on code in PR #12438: URL: https://github.com/apache/kafka/pull/12438#discussion_r930015414 ## docs/streams/index.html: ## @@ -35,32 +35,25 @@ Kafka Streams The easiest way to write mission-critical real-time applications and microservices

[jira] [Commented] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-26 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571454#comment-17571454 ] Chris Egerton commented on KAFKA-14101: --- [~tombentley] Yeah, a renaming would help

[jira] [Commented] (KAFKA-14101) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary

2022-07-26 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571464#comment-17571464 ] Tom Bentley commented on KAFKA-14101: - Both those seem reasonable to me [~ChrisEgert

[GitHub] [kafka] cadonna commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-26 Thread GitBox
cadonna commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195567473 I agree that the migration should be done quickly. As far as I understand @clolov plans to do the whole migration quickly. Is this correct? If this is the case, I do not see the issue

[GitHub] [kafka] cadonna opened a new pull request, #12442: KAFKA-10199: Bookkeep tasks during assignment for use with state updater

2022-07-26 Thread GitBox
cadonna opened a new pull request, #12442: URL: https://github.com/apache/kafka/pull/12442 Bookkeeps tasks to be recycled, closed, and updated during handling of the assignment. The bookkeeping is needed for integrating the state updater. These change is hidden behind internal co

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page

2022-07-26 Thread GitBox
divijvaidya commented on code in PR #12438: URL: https://github.com/apache/kafka/pull/12438#discussion_r930066946 ## docs/streams/index.html: ## @@ -35,32 +35,25 @@ Kafka Streams The easiest way to write mission-critical real-time applications and microservices

[GitHub] [kafka] mimaison merged pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page

2022-07-26 Thread GitBox
mimaison merged PR #12438: URL: https://github.com/apache/kafka/pull/12438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison commented on a diff in pull request #12438: KAFKA-13868: Replace YouTube embedded video with links on streams page

2022-07-26 Thread GitBox
mimaison commented on code in PR #12438: URL: https://github.com/apache/kafka/pull/12438#discussion_r930099870 ## docs/streams/index.html: ## @@ -35,32 +35,25 @@ Kafka Streams The easiest way to write mission-critical real-time applications and microservices

[GitHub] [kafka] ijuma commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-07-26 Thread GitBox
ijuma commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1195629498 Do we have a PR for converting this particular test to use mockito or not yet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Created] (KAFKA-14110) Streaming recursion in Kafka Streams

2022-07-26 Thread Nicholas Telford (Jira)
Nicholas Telford created KAFKA-14110: Summary: Streaming recursion in Kafka Streams Key: KAFKA-14110 URL: https://issues.apache.org/jira/browse/KAFKA-14110 Project: Kafka Issue Type: Impr

[jira] [Updated] (KAFKA-14110) Streaming recursion in Kafka Streams

2022-07-26 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated KAFKA-14110: - Description: Some use-cases require {_}streaming recursion{_}, which involves piping the

[jira] [Updated] (KAFKA-14110) Streaming recursion in Kafka Streams

2022-07-26 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Telford updated KAFKA-14110: - Description: [KIP-857 Streaming recursion in Kafka Streams|https://cwiki.apache.org/con

[GitHub] [kafka] ijuma commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-26 Thread GitBox
ijuma commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195649633 I am fine with 3 as long as we don't make changes that make it worse for modules that have already converted to JUnit 5. -- This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] cadonna commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
cadonna commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930069951 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java: ## @@ -211,13 +209,36 @@ private RecordCollector createRecordCollector(fina

[GitHub] [kafka] clolov commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-26 Thread GitBox
clolov commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195674893 Divij and I also prefer option 3 because of the same reasons posted by Bruno. So the next steps on our side are: 1) Address comments on https://github.com/apache/kafka/pull/12441 which

[GitHub] [kafka] ijuma commented on pull request #12285: KAFKA-14001: Migrate streams module to JUnit 5 - Part 1

2022-07-26 Thread GitBox
ijuma commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195681900 Option 3 says not to continue JUnit 5 migrations though - it says to do the mockito migration first. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r929297148 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1213,7 +1270,6 @@ void maybeCloseTasksFromRemovedTopologies(final Se

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930170868 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java: ## @@ -211,13 +209,36 @@ private RecordCollector createRecordCollector

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930175351 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -493,7 +531,9 @@ boolean tryToCompleteRestoration(final long now, fina

[GitHub] [kafka] C0urante commented on pull request #11792: Replace EasyMock/PowerMock with Mockito in DistributedHerderTest

2022-07-26 Thread GitBox
C0urante commented on PR #11792: URL: https://github.com/apache/kafka/pull/11792#issuecomment-1195701534 @jeff303 do you still plan to work on this? Happy to provide a round of review for what's here already if you'd like some feedback. -- This is an automated message from the Apache Git

[GitHub] [kafka] C0urante commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-07-26 Thread GitBox
C0urante commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1195702185 There's https://github.com/apache/kafka/pull/11792, but it's gone a bit stale (last activity was March 24th) and is marked as a draft. I've pinged the author to check on the status. --

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930178451 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -480,6 +503,21 @@ private void closeAndRecycleTasks(final Map> tasksTo

[jira] [Updated] (KAFKA-14039) Fix KRaft AlterConfigPolicy usage

2022-07-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14039: - Fix Version/s: 3.3.0 3.4.0 > Fix KRaft AlterConfigPolicy usage >

[GitHub] [kafka] mumrah commented on pull request #12403: KAFKA-13166 Fix missing ControllerApis error handling

2022-07-26 Thread GitBox
mumrah commented on PR #12403: URL: https://github.com/apache/kafka/pull/12403#issuecomment-1195746529 Hey @cmccabe, thanks for the review! I agree it's a bit weird to return the completed feature here from the authorizer calls. I tried a few different approaches, and having all the handler

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12442: KAFKA-10199: Bookkeep tasks during assignment for use with state updater

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12442: URL: https://github.com/apache/kafka/pull/12442#discussion_r930193079 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -396,11 +460,8 @@ private Map> pendingTasksToCreate(final Map> tasks

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930242497 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadata.java: ## @@ -77,6 +93,22 @@ public void registerTaskError(final Task tas

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930245276 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutionMetadata.java: ## @@ -77,6 +93,22 @@ public void registerTaskError(final Task tas

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930246317 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -377,7 +390,17 @@ public void handleAssignment(final Map> activeTasks,

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930248847 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -544,7 +548,7 @@ public void updateInputPartitions(final Set topicPart

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930278502 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java: ## @@ -91,7 +92,7 @@ public boolean isActive() { * @throws StreamsExce

[GitHub] [kafka] cmccabe opened a new pull request, #12443: MINOR: Convert some junit tests to kraft

2022-07-26 Thread GitBox
cmccabe opened a new pull request, #12443: URL: https://github.com/apache/kafka/pull/12443 Convert ProducerCompressionTest, MirrorMakerIntegrationTest, EdgeCaseRequestTest to kraft. Make it explicit that ServerShutdownTest#testControllerShutdownDuringSend is ZK-only. -- This is an

[GitHub] [kafka] cmccabe commented on pull request #12403: KAFKA-13166 Fix missing ControllerApis error handling

2022-07-26 Thread GitBox
cmccabe commented on PR #12403: URL: https://github.com/apache/kafka/pull/12403#issuecomment-1195865697 I looked into this more, and I think this approach could be a good start. But let's keep an eye out for if we can simplify this in the future. LGTM -- This is an automated message from

[jira] [Updated] (KAFKA-14079) Source task will not commit offsets and develops memory leak if "error.tolerance" is set to "all"

2022-07-26 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-14079: -- Fix Version/s: 3.4.0 > Source task will not commit offsets and develops memory leak if > "err

[jira] [Commented] (KAFKA-14079) Source task will not commit offsets and develops memory leak if "error.tolerance" is set to "all"

2022-07-26 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571601#comment-17571601 ] Randall Hauch commented on KAFKA-14079: --- Merged to the `3.3` branch with permissio

[jira] [Created] (KAFKA-14111) Dynamic config update fails for "password" configs in KRaft

2022-07-26 Thread David Arthur (Jira)
David Arthur created KAFKA-14111: Summary: Dynamic config update fails for "password" configs in KRaft Key: KAFKA-14111 URL: https://issues.apache.org/jira/browse/KAFKA-14111 Project: Kafka

[jira] [Updated] (KAFKA-14111) Dynamic config update fails for "password" configs in KRaft

2022-07-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14111: - Component/s: kraft > Dynamic config update fails for "password" configs in KRaft > -

[GitHub] [kafka] C0urante opened a new pull request, #12444: KAFKA-14101: Improve documentation for consuming from embedded Kafka cluster topics in Connect integration testing framework

2022-07-26 Thread GitBox
C0urante opened a new pull request, #12444: URL: https://github.com/apache/kafka/pull/12444 [Jira](https://issues.apache.org/jira/browse/KAFKA-14101) Depends on https://github.com/apache/kafka/pull/12429, which should implement a logical fix for KAFKA-14101. This follow-up PR is inten

[jira] [Updated] (KAFKA-13166) EOFException when Controller handles unknown API

2022-07-26 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13166: - Fix Version/s: 3.3.0 3.4.0 > EOFException when Controller handles unknown API

[jira] [Resolved] (KAFKA-13806) Check CRC when reading snapshots

2022-07-26 Thread Niket Goel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel resolved KAFKA-13806. Fix Version/s: 3.3 Resolution: Duplicate > Check CRC when reading snapshots > -

[GitHub] [kafka] mumrah merged pull request #12403: KAFKA-13166 Fix missing ControllerApis error handling

2022-07-26 Thread GitBox
mumrah merged PR #12403: URL: https://github.com/apache/kafka/pull/12403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] lihaosky opened a new pull request, #12445: remove unnecessary stubbing

2022-07-26 Thread GitBox
lihaosky opened a new pull request, #12445: URL: https://github.com/apache/kafka/pull/12445 Unnecessary stubbing caused job failure ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12439: KAFKA-10199: Further refactor task lifecycle management

2022-07-26 Thread GitBox
guozhangwang commented on code in PR #12439: URL: https://github.com/apache/kafka/pull/12439#discussion_r930512882 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -480,6 +503,21 @@ private void closeAndRecycleTasks(final Map> tasksTo

[GitHub] [kafka] dstelljes commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-07-26 Thread GitBox
dstelljes commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1196168380 Hmm, if this is what you see than I have the same thing: ``` No tests found for given includes: [**/*Suite.class](exclude rules) [org.apache.kafka.connect.runtime.distributed.D

[GitHub] [kafka] vvcephei merged pull request #12445: MINOR: remove unnecessary test stubbing

2022-07-26 Thread GitBox
vvcephei merged PR #12445: URL: https://github.com/apache/kafka/pull/12445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] vvcephei commented on a diff in pull request #12437: KAFKA-13769 Add tests for ForeignJoinSubscriptionProcessorSupplier

2022-07-26 Thread GitBox
vvcephei commented on code in PR #12437: URL: https://github.com/apache/kafka/pull/12437#discussion_r930562541 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ForeignJoinSubscriptionProcessorSupplierTest.java: ## @@ -0,0 +1,371 @@ +/* + * Licen

[jira] [Assigned] (KAFKA-7438) Replace EasyMock and PowerMock with Mockito

2022-07-26 Thread Dalibor Plavcic (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dalibor Plavcic reassigned KAFKA-7438: -- Assignee: Dalibor Plavcic > Replace EasyMock and PowerMock with Mockito >