[
https://issues.apache.org/jira/browse/KAFKA-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535931#comment-17535931
]
Bruno Cadonna commented on KAFKA-12657:
---
I do not know the specifics of the build
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535936#comment-17535936
]
Luke Chen commented on KAFKA-12495:
---
[~mcabrera] , thanks for the sharing. Looks like
vamossagar12 commented on PR #12104:
URL: https://github.com/apache/kafka/pull/12104#issuecomment-1124705707
> Thanks @vamossagar12 , the failed tests still contains
`testDescribeUnderMinIsrPartitionsMixed(String).quorum=zk](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12104/4/
dajac commented on PR #12147:
URL: https://github.com/apache/kafka/pull/12147#issuecomment-1124713446
@dengziming Good catch, thanks. I have renamed those as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
mimaison commented on PR #10528:
URL: https://github.com/apache/kafka/pull/10528#issuecomment-1124743001
I see 2 committers approved the changes but this was not merged.
@C0urante can you rebase to fix the conflicts ? Thanks
--
This is an automated message from the Apache Git Service.
ahuang98 commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r870770149
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Tom Bentley created KAFKA-13895:
---
Summary: Fix javadocs build with JDK < 12
Key: KAFKA-13895
URL: https://issues.apache.org/jira/browse/KAFKA-13895
Project: Kafka
Issue Type: Task
Com
showuon commented on code in PR #11748:
URL: https://github.com/apache/kafka/pull/11748#discussion_r871177514
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java:
##
@@ -232,11 +240,10 @@ private void refreshIdleConsumerGroupOffset() {
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536037#comment-17536037
]
Lim Qing Wei commented on KAFKA-13882:
--
Hi [~tombentley] , I am picking this up, I
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536054#comment-17536054
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 opened a new pull request, #4
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536055#comment-17536055
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL: ht
[
https://issues.apache.org/jira/browse/KAFKA-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536082#comment-17536082
]
Ismael Juma commented on KAFKA-13895:
-
I thought the release script requested Java 1
[
https://issues.apache.org/jira/browse/KAFKA-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536084#comment-17536084
]
Tom Bentley commented on KAFKA-13895:
-
It does. Mickael has subsequently pointed me
[
https://issues.apache.org/jira/browse/KAFKA-13895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536097#comment-17536097
]
Ismael Juma commented on KAFKA-13895:
-
I see. If you can think of a way to tighten t
showuon merged PR #12112:
URL: https://github.com/apache/kafka/pull/12112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871388241
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -108,7 +108,8 @@ class KafkaRaftManager[T](
time: Time,
metrics: Metrics,
threadNamePrefixOpt: Option[
divijvaidya commented on code in PR #12087:
URL: https://github.com/apache/kafka/pull/12087#discussion_r871388325
##
core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871388241
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -108,7 +108,8 @@ class KafkaRaftManager[T](
time: Time,
metrics: Metrics,
threadNamePrefixOpt: Option[
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871392227
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
divijvaidya commented on code in PR #12087:
URL: https://github.com/apache/kafka/pull/12087#discussion_r871396306
##
core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
divijvaidya commented on code in PR #12087:
URL: https://github.com/apache/kafka/pull/12087#discussion_r871397465
##
core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
showuon commented on code in PR #12087:
URL: https://github.com/apache/kafka/pull/12087#discussion_r871398002
##
core/src/test/scala/unit/kafka/server/DeleteRecordsRequestTest.scala:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
David Arthur created KAFKA-13896:
Summary: Support unsafe downgrades in KRaft
Key: KAFKA-13896
URL: https://issues.apache.org/jira/browse/KAFKA-13896
Project: Kafka
Issue Type: Sub-task
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871404277
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -93,84 +129,187 @@ boolean featureExists(String featureName) {
return quo
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871491412
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -93,84 +129,187 @@ boolean featureExists(String featureName) {
return quo
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871494219
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -927,6 +981,31 @@ private void appendRaftEvent(String name, Runnable
runnable) {
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871495442
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -93,84 +129,187 @@ boolean featureExists(String featureName) {
return quo
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536197#comment-17536197
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536210#comment-17536210
]
Niket Goel commented on KAFKA-13888:
Hi [~Jack-Lee],
Thanks for the suggestion.
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niket Goel reassigned KAFKA-13888:
--
Assignee: Niket Goel
> KIP-836: Addition of Information in DescribeQuorumResponse about Voter
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536212#comment-17536212
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536220#comment-17536220
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536221#comment-17536221
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on code in PR #410:
[
https://issues.apache.org/jira/browse/KAFKA-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536230#comment-17536230
]
Sagar Rao commented on KAFKA-13745:
---
[~guozhang] , i looked at few of the builds happe
cmccabe commented on code in PR #11969:
URL: https://github.com/apache/kafka/pull/11969#discussion_r871644131
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1509,4 +1512,29 @@ class KafkaConfigTest {
assertNotNull(config.getLong(KafkaConfig.SaslOAut
junrao commented on code in PR #12136:
URL: https://github.com/apache/kafka/pull/12136#discussion_r871593948
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -376,8 +381,10 @@ class LogManager(logDirs: Seq[File],
s"($currentNumLoaded/${logsToLoad.length}
Richard-Cranium commented on code in PR #11712:
URL: https://github.com/apache/kafka/pull/11712#discussion_r871688180
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##
@@ -270,6 +278,23 @@ Task task(final TaskId taskId) {
return readOn
milindmantri opened a new pull request, #12152:
URL: https://github.com/apache/kafka/pull/12152
Minor typo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
joel-hamill opened a new pull request, #12153:
URL: https://github.com/apache/kafka/pull/12153
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
joel-hamill commented on PR #12153:
URL: https://github.com/apache/kafka/pull/12153#issuecomment-1125308244
cc @guozhangwang @hachikuji
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
cmccabe commented on code in PR #11969:
URL: https://github.com/apache/kafka/pull/11969#discussion_r871712580
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -725,7 +727,11 @@ object KafkaConfig {
/* Authorizer Configuration ***/
val Auth
divijvaidya commented on code in PR #12153:
URL: https://github.com/apache/kafka/pull/12153#discussion_r871713953
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -894,7 +894,7 @@ object KafkaConfig {
"record batch size accepted by the broker is defined via
mes
jsancio merged PR #12141:
URL: https://github.com/apache/kafka/pull/12141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
HorizonNet opened a new pull request, #12154:
URL: https://github.com/apache/kafka/pull/12154
*Remove the deprecated `getActiveHost()`, `getStandbyHosts()` and
`getPartition()` methods in `KeyQueryMetadata`*
*Summary of testing strategy (including rationale)
for the feature or bug
hachikuji commented on code in PR #12153:
URL: https://github.com/apache/kafka/pull/12153#discussion_r871786929
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -894,7 +894,7 @@ object KafkaConfig {
"record batch size accepted by the broker is defined via
messa
cmccabe commented on PR #11634:
URL: https://github.com/apache/kafka/pull/11634#issuecomment-1125411622
This has now already been done by a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cmccabe closed pull request #11634: MINOR: enable KRaft in
TopicCommandIntegrationTest
URL: https://github.com/apache/kafka/pull/11634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jsancio commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871793140
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
guozhangwang commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r871816260
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTest
cmccabe opened a new pull request, #12155:
URL: https://github.com/apache/kafka/pull/12155
Convert EndToEndClusterIdTest, ConsumerGroupCommandTest,
ListConsumerGroupTest, and LogOffsetTest to test KRaft mode.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535020#comment-17535020
]
Manuel Garcia Cabrera edited comment on KAFKA-12495 at 5/12/22 9:59 PM:
--
cmccabe closed pull request #11640: MINOR: enable KRaft on ListConsumerGroupTest
URL: https://github.com/apache/kafka/pull/11640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
cmccabe commented on PR #11640:
URL: https://github.com/apache/kafka/pull/11640#issuecomment-1125462073
merged into #12155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cmccabe merged PR #11969:
URL: https://github.com/apache/kafka/pull/11969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe closed pull request #11639: MINOR: enable KRaft in EndToEndClusterIdTest
URL: https://github.com/apache/kafka/pull/11639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
cmccabe commented on PR #11639:
URL: https://github.com/apache/kafka/pull/11639#issuecomment-1125462571
merged into #12155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cmccabe commented on PR #11636:
URL: https://github.com/apache/kafka/pull/11636#issuecomment-1125462878
merged into #12155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cmccabe closed pull request #11636: MINOR: enable KRaft in LogOffsetTest
URL: https://github.com/apache/kafka/pull/11636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871851698
##
core/src/main/scala/kafka/server/BrokerFeatures.scala:
##
@@ -72,6 +73,12 @@ class BrokerFeatures private (@volatile var
supportedFeatures: Features[Supporte
object
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871851698
##
core/src/main/scala/kafka/server/BrokerFeatures.scala:
##
@@ -72,6 +73,12 @@ class BrokerFeatures private (@volatile var
supportedFeatures: Features[Supporte
object
jsancio commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871793140
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871852945
##
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##
@@ -102,6 +102,10 @@ class RawMetaProperties(val props: Properties = new
Properties()) {
}
ob
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871853134
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -324,7 +324,8 @@ class BrokerServer(
time,
jsancio commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871808351
##
metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java:
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871856970
##
metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java:
##
@@ -17,32 +17,73 @@
package org.apache.kafka.controller;
+import org.apache.kafka.clie
hachikuji commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1125508412
@dengziming I didn't quite follow this:
> Yeah, it's unnecessary to change `ReplicationControlManager`, however,
there is still a difference, in KRaft mode, the null config value
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871908541
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -53,7 +55,7 @@ public class ClusterConfig {
ClusterConfig(Type type, int brokers, int controllers, Stri
cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871910034
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -927,6 +984,29 @@ private void appendRaftEvent(String name, Runnable
runnable) {
dengziming commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1125579394
> Are you saying that in KRaft, we ignore null config values instead of
failing topic creation?
Yes, We will pass the topic configs to `ConfigurationControlManager` in
which nul
vamossagar12 commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r871988254
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTest
dengziming commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r872006433
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -732,7 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHa
dadufour commented on code in PR #11748:
URL: https://github.com/apache/kafka/pull/11748#discussion_r872036738
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java:
##
@@ -169,6 +172,7 @@ public String version() {
return listConsumer
72 matches
Mail list logo
