[jira] [Commented] (KAFKA-13136) kafka-connect task.max : active task in consumer group is limited by the bigger topic to consume

2022-03-17 Thread raphaelauv (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508032#comment-17508032 ] raphaelauv commented on KAFKA-13136: thank you very much for that explaination , it'

[jira] [Comment Edited] (KAFKA-13136) kafka-connect task.max : active task in consumer group is limited by the bigger topic to consume

2022-03-17 Thread raphaelauv (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508032#comment-17508032 ] raphaelauv edited comment on KAFKA-13136 at 3/17/22, 8:01 AM:

[jira] [Commented] (KAFKA-13740) kafka-stream-client-shutdown

2022-03-17 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508043#comment-17508043 ] Bruno Cadonna commented on KAFKA-13740: --- [~prashanthjbabu] Glad that you could sor

[jira] [Closed] (KAFKA-13740) kafka-stream-client-shutdown

2022-03-17 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna closed KAFKA-13740. - > kafka-stream-client-shutdown > > > Key: KAFKA-13740 >

[GitHub] [kafka] dengziming opened a new pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode

2022-03-17 Thread GitBox
dengziming opened a new pull request #11910: URL: https://github.com/apache/kafka/pull/11910 *More detailed description of your change* In zk mode, the topic "foo_bar" will conflict with "foo.bar" because of limitations in metric names, we should implement this in KRaft mode. Add an i

[GitHub] [kafka] RivenSun2 opened a new pull request #11911: KAFKA-13463: Make pause behavior consistent between cooperative and eager protocols

2022-03-17 Thread GitBox
RivenSun2 opened a new pull request #11911: URL: https://github.com/apache/kafka/pull/11911 Make pause behavior consistent between cooperative and eager protocols -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] RivenSun2 commented on pull request #11911: KAFKA-13463: Make pause behavior consistent between cooperative and eager protocols

2022-03-17 Thread GitBox
RivenSun2 commented on pull request #11911: URL: https://github.com/apache/kafka/pull/11911#issuecomment-1070603378 Hi @guozhangwang and @showuon please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-13689) AbstractConfig log print information is incorrect

2022-03-17 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508083#comment-17508083 ] RivenSun commented on KAFKA-13689: -- Hi [~showuon] [~guozhang]  After rethinking the dis

[jira] [Updated] (KAFKA-13751) On the broker side, OAUTHBEARER is not compatible with other SASL mechanisms

2022-03-17 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun updated KAFKA-13751: - Reviewer: Ismael Juma (was: Luke Chen) > On the broker side, OAUTHBEARER is not compatible with other S

[GitHub] [kafka] dajac commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-17 Thread GitBox
dajac commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r828928713 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -103,59 +104,77 @@ object GetOffsetShell { throw new IllegalArgumentExceptio

[GitHub] [kafka] dajac commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-17 Thread GitBox
dajac commented on pull request #11909: URL: https://github.com/apache/kafka/pull/11909#issuecomment-1070707701 @jolshan Would you have a link to a successful run of the tests with your change? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mimaison commented on a change in pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2022-03-17 Thread GitBox
mimaison commented on a change in pull request #11471: URL: https://github.com/apache/kafka/pull/11471#discussion_r829001380 ## File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java ## @@ -73,7 +75,6 @@ public void teardown() {

[jira] [Created] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Xiaobing Fang (Jira)
Xiaobing Fang created KAFKA-13752: - Summary: Using `equals` instead of `==` when Uuid compare in Java Key: KAFKA-13752 URL: https://issues.apache.org/jira/browse/KAFKA-13752 Project: Kafka Is

[GitHub] [kafka] dengziming commented on a change in pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2022-03-17 Thread GitBox
dengziming commented on a change in pull request #11471: URL: https://github.com/apache/kafka/pull/11471#discussion_r829040670 ## File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java ## @@ -73,7 +75,6 @@ public void teardown() {

[jira] [Updated] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13752: -- Description: `Uuid.ZERO_UUID == new Uuid(0L, 0L)` is true in scala, but in java is false.  

[jira] [Updated] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13752: -- Description: `Uuid.ZERO_UUID == new Uuid(0L, 0L)` is true in scala, but in java is false.  

[jira] [Updated] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13752: -- Description: {code:java} Uuid.ZERO_UUID == new Uuid(0L, 0L){code} is true in scala, but in jav

[jira] [Commented] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508157#comment-17508157 ] Ismael Juma commented on KAFKA-13752: - cc [~jolshan]  > Using `equals` instead of `

[GitHub] [kafka] fxbing opened a new pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-17 Thread GitBox
fxbing opened a new pull request #11912: URL: https://github.com/apache/kafka/pull/11912 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Updated] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaobing Fang updated KAFKA-13752: -- Description: {code:java} Uuid.ZERO_UUID == new Uuid(0L, 0L){code} is true in scala, but in jav

[GitHub] [kafka] dengziming commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-17 Thread GitBox
dengziming commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r829057799 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -103,59 +104,77 @@ object GetOffsetShell { throw new IllegalArgumentExc

[GitHub] [kafka] dengziming commented on pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-17 Thread GitBox
dengziming commented on pull request #11173: URL: https://github.com/apache/kafka/pull/11173#issuecomment-1070856842 Thank you @dajac for your efforts, I reworded the error message according to your suggestions, PTAL. -- This is an automated message from the Apache Git Service. To respon

[jira] [Commented] (KAFKA-9542) ZSTD Compression Not Working

2022-03-17 Thread Olumide Ajiboye (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508163#comment-17508163 ] Olumide Ajiboye commented on KAFKA-9542: Hi,   I just upgraded to `quay.io/stri

[GitHub] [kafka] dengziming opened a new pull request #11913: MINOR: Remove scala KafkaException

2022-03-17 Thread GitBox
dengziming opened a new pull request #11913: URL: https://github.com/apache/kafka/pull/11913 *More detailed description of your change* We use org.apache.kafka.common.KafkaException instead of kafka.common.KafkaException *Summary of testing strategy (including rationale)* QA

[GitHub] [kafka] dengziming commented on pull request #11913: MINOR: Remove scala KafkaException

2022-03-17 Thread GitBox
dengziming commented on pull request #11913: URL: https://github.com/apache/kafka/pull/11913#issuecomment-1070870414 We can safely remove this class since we have removed kafka.security.auth.Authorizer in #10450 , ping @ijuma to have a look -- This is an automated message from the Apache

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-17 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508199#comment-17508199 ] Dongjin Lee commented on KAFKA-9366: [~roncraig] Sorry for being late. the PR is now

[GitHub] [kafka] dengziming commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-17 Thread GitBox
dengziming commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1070947835 Thank you for this PR, can you also add a test case in `MetadataRequestTest.testTopicIdAndNullTopicNameRequests`? -- This is an automated message from the Apache Git Servi

[GitHub] [kafka] jolshan commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-17 Thread GitBox
jolshan commented on pull request #11909: URL: https://github.com/apache/kafka/pull/11909#issuecomment-1070978591 Here is a link to a successful run: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2022-03-17--001.system-test-kafka-branch-builder-

[jira] [Commented] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508255#comment-17508255 ] Justine Olshan commented on KAFKA-13752: Ah, so I think the line that is causing

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-17 Thread Ron Craig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508256#comment-17508256 ] Ron Craig commented on KAFKA-9366: -- Perfect!  Thanks, [~dongjin] . > Upgrade log4j to l

[jira] [Comment Edited] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508255#comment-17508255 ] Justine Olshan edited comment on KAFKA-13752 at 3/17/22, 3:49 PM:

[GitHub] [kafka] fxbing commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-17 Thread GitBox
fxbing commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1071008981 > done, PTAL. @dengziming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Xiaobing Fang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508270#comment-17508270 ] Xiaobing Fang commented on KAFKA-13752: --- [~jolshan] I have done it in PR, PTAL. >

[jira] [Resolved] (KAFKA-13136) kafka-connect task.max : active task in consumer group is limited by the bigger topic to consume

2022-03-17 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13136. --- Resolution: Fixed > kafka-connect task.max : active task in consumer group is limited by the

[GitHub] [kafka] mimaison merged pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2022-03-17 Thread GitBox
mimaison merged pull request #11471: URL: https://github.com/apache/kafka/pull/11471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[jira] [Commented] (KAFKA-13404) Kafka sink connectors do not commit offset correctly if messages are produced in transaction

2022-03-17 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508282#comment-17508282 ] Chris Egerton commented on KAFKA-13404: --- [~yujhe.li] can you clarify the impact of

[GitHub] [kafka] dajac commented on pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-17 Thread GitBox
dajac commented on pull request #11173: URL: https://github.com/apache/kafka/pull/11173#issuecomment-1071074769 The build looks good [here](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-11173/18/pipeline). I am not sure why github still shows it in prog

[GitHub] [kafka] dajac commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-17 Thread GitBox
dajac commented on pull request #11909: URL: https://github.com/apache/kafka/pull/11909#issuecomment-1071077188 @jolshan Thanks. Do we need to backport it to older branches? I guess that we need it in 3.1 and 3.0, right? -- This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] C0urante opened a new pull request #11914: MINOR: Correct Connect docs on connector/task states

2022-03-17 Thread GitBox
C0urante opened a new pull request #11914: URL: https://github.com/apache/kafka/pull/11914 The `DESTROYED` state is represented internally as a tombstone record when running in distributed mode ([1]) and by the removal of the connector/task from the in-memory status map when running in sta

[GitHub] [kafka] dajac merged pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-17 Thread GitBox
dajac merged pull request #11173: URL: https://github.com/apache/kafka/pull/11173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Resolved] (KAFKA-13509) Support max timestamp in GetOffsetShell

2022-03-17 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13509. - Reviewer: David Jacot Resolution: Fixed > Support max timestamp in GetOffsetShell > --

[GitHub] [kafka] dajac commented on pull request #11906: MINOR: Doc updates for Kafka 3.0.1

2022-03-17 Thread GitBox
dajac commented on pull request #11906: URL: https://github.com/apache/kafka/pull/11906#issuecomment-1071088775 @mimaison Thanks. Do we need to update the doc in the 3.0 branch as well? Otherwise, we will miss the update that you did if we would ever release 3.0.2. -- This is an automate

[GitHub] [kafka] dajac commented on pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-17 Thread GitBox
dajac commented on pull request #11909: URL: https://github.com/apache/kafka/pull/11909#issuecomment-1071090738 We don't need to wait for the build as this is a python change. Merging to trunk, 3.1 and 3.0. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] dajac merged pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-17 Thread GitBox
dajac merged pull request #11909: URL: https://github.com/apache/kafka/pull/11909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Resolved] (KAFKA-13750) Client Compatability KafkaTest uses invalid idempotency configs

2022-03-17 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13750. - Fix Version/s: 3.2.0 3.1.1 3.0.2 Resolution: Fixed

[GitHub] [kafka] dajac commented on pull request #11904: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-17 Thread GitBox
dajac commented on pull request #11904: URL: https://github.com/apache/kafka/pull/11904#issuecomment-1071105004 @guizmaii Good catch! Why did you target 3.1 branch? We should fix it in trunk and I can back port it to older branches. -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] dajac commented on a change in pull request #11903: KAFKA-13497: Add trace logging to RegexRouter

2022-03-17 Thread GitBox
dajac commented on a change in pull request #11903: URL: https://github.com/apache/kafka/pull/11903#discussion_r82930 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/RegexRouter.java ## @@ -57,7 +61,10 @@ public R apply(R record) {

[jira] [Created] (KAFKA-13753) Log cleaner should transaction metadata in index until corresponding marker is removed

2022-03-17 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13753: --- Summary: Log cleaner should transaction metadata in index until corresponding marker is removed Key: KAFKA-13753 URL: https://issues.apache.org/jira/browse/KAFKA-13753

[GitHub] [kafka] junrao commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
junrao commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829355001 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,73 @@ public PartitionChangeBuilder setTa

[GitHub] [kafka] C0urante commented on a change in pull request #11903: KAFKA-13497: Add trace logging to RegexRouter

2022-03-17 Thread GitBox
C0urante commented on a change in pull request #11903: URL: https://github.com/apache/kafka/pull/11903#discussion_r829392255 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/RegexRouter.java ## @@ -57,7 +61,10 @@ public R apply(R record) {

[jira] [Created] (KAFKA-13754) Follower should reject Fetch request while the leader is recovering

2022-03-17 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-13754: -- Summary: Follower should reject Fetch request while the leader is recovering Key: KAFKA-13754 URL: https://issues.apache.org/jira/browse/KAFKA-13754

[GitHub] [kafka] jsancio commented on pull request #11733: KAFKA-13587; Implement leader recovery for KIP-704

2022-03-17 Thread GitBox
jsancio commented on pull request #11733: URL: https://github.com/apache/kafka/pull/11733#issuecomment-1071229122 > The PR looks good overall. I think there is one problem with the fetch validation. We are expecting that followers will detect the RECOVERED state through a `LeaderAndIsr` re

[jira] [Commented] (KAFKA-13714) Flaky test IQv2StoreIntegrationTest

2022-03-17 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508386#comment-17508386 ] John Roesler commented on KAFKA-13714: -- Another local repro:   {code:java} org.apa

[jira] [Commented] (KAFKA-13752) Using `equals` instead of `==` when Uuid compare in Java

2022-03-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508389#comment-17508389 ] Ismael Juma commented on KAFKA-13752: - What is the impact of this bug? > Using `equ

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829411491 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,73 @@ public PartitionChangeBuilder setT

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829414517 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,73 @@ public PartitionChangeBuilder setT

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829419392 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,73 @@ public PartitionChangeBuilder setT

[jira] [Comment Edited] (KAFKA-13714) Flaky test IQv2StoreIntegrationTest

2022-03-17 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508386#comment-17508386 ] John Roesler edited comment on KAFKA-13714 at 3/17/22, 7:32 PM: --

[jira] [Commented] (KAFKA-13601) Add option to support sync offset commit in Kafka Connect Sink

2022-03-17 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508423#comment-17508423 ] Chris Egerton commented on KAFKA-13601: --- [~dasarianil] I don't see how synchronous

[jira] [Updated] (KAFKA-13460) Issue reporting

2022-03-17 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13460: -- Component/s: (was: KafkaConnect) > Issue reporting > --- > > K

[GitHub] [kafka] tchiotludo commented on pull request #11905: MINOR: Fix incorrect log for out-of-order KTable

2022-03-17 Thread GitBox
tchiotludo commented on pull request #11905: URL: https://github.com/apache/kafka/pull/11905#issuecomment-1071509762 @showuon must be done I think ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829521940 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,73 @@ public PartitionChangeBuilder setT

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829522253 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -953,6 +972,56 @@ private void cancelMaybeFenceReplicas() {

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829532685 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,73 @@ public PartitionChangeBuilder setT

[GitHub] [kafka] jolshan commented on a change in pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

2022-03-17 Thread GitBox
jolshan commented on a change in pull request #11909: URL: https://github.com/apache/kafka/pull/11909#discussion_r829541377 ## File path: tools/src/main/java/org/apache/kafka/tools/ClientCompatibilityTest.java ## @@ -172,6 +174,13 @@ public static void main(String[] args) thro

[GitHub] [kafka] junrao commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
junrao commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829550657 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,94 @@ public PartitionChangeBuilder setTa

[GitHub] [kafka] wsun-confluent commented on a change in pull request #11874: Fix typos in configuration docs

2022-03-17 Thread GitBox
wsun-confluent commented on a change in pull request #11874: URL: https://github.com/apache/kafka/pull/11874#discussion_r829578541 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -216,8 +216,10 @@ private static final String

[GitHub] [kafka] dengziming commented on pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

2022-03-17 Thread GitBox
dengziming commented on pull request #11173: URL: https://github.com/apache/kafka/pull/11173#issuecomment-1071767117 @dajac @showuon @jolshan Thank you for your patience. 🤝 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (KAFKA-13753) Log cleaner should retain transaction metadata in index until corresponding marker is removed

2022-03-17 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13753: Summary: Log cleaner should retain transaction metadata in index until corresponding marke

[GitHub] [kafka] jolshan commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-17 Thread GitBox
jolshan commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1071812161 I was thinking adding the test from the ticket and verifying it _**doesn't**_ return an error. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] jolshan removed a comment on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-17 Thread GitBox
jolshan removed a comment on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1071812161 I was thinking adding the test from the ticket and verifying it _**doesn't**_ return an error. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] jolshan commented on pull request #11912: KAFKA-13752: Uuid compare using equals in java

2022-03-17 Thread GitBox
jolshan commented on pull request #11912: URL: https://github.com/apache/kafka/pull/11912#issuecomment-1071816320 Ah yeah, that could be useful? I think it's less necessary since the server should be building the response, but doesn't hurt. -- This is an automated message from the Apache

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829589585 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,94 @@ public PartitionChangeBuilder setT

[GitHub] [kafka] jsancio commented on a change in pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-17 Thread GitBox
jsancio commented on a change in pull request #11893: URL: https://github.com/apache/kafka/pull/11893#discussion_r829589585 ## File path: metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java ## @@ -104,53 +117,94 @@ public PartitionChangeBuilder setT

[jira] [Commented] (KAFKA-13744) Quota metric tags are inconsistent

2022-03-17 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508473#comment-17508473 ] Jorge Esteban Quilcate Otoya commented on KAFKA-13744: -- Thanks, [~j

[jira] [Resolved] (KAFKA-13744) Quota metric tags are inconsistent

2022-03-17 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya resolved KAFKA-13744. -- Resolution: Not A Problem > Quota metric tags are inconsistent

[jira] [Resolved] (KAFKA-13742) Quota byte-rate/request metrics are loaded only when at least one quota is register

2022-03-17 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya resolved KAFKA-13742. -- Resolution: Not A Problem Given that I got a better understand

[jira] [Updated] (KAFKA-7077) KIP-318: Make Kafka Connect Source idempotent

2022-03-17 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-7077: - Fix Version/s: 3.2.0 > KIP-318: Make Kafka Connect Source idempotent > --

[jira] [Commented] (KAFKA-7077) KIP-318: Make Kafka Connect Source idempotent

2022-03-17 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508513#comment-17508513 ] Luke Chen commented on KAFKA-7077: -- Everything goes with idempotent producer by default

[jira] [Resolved] (KAFKA-7077) KIP-318: Make Kafka Connect Source idempotent

2022-03-17 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-7077. -- Resolution: Fixed > KIP-318: Make Kafka Connect Source idempotent > ---

[GitHub] [kafka] showuon commented on pull request #11905: MINOR: Fix incorrect log for out-of-order KTable

2022-03-17 Thread GitBox
showuon commented on pull request #11905: URL: https://github.com/apache/kafka/pull/11905#issuecomment-1071946079 Failed tests are unrelated: ``` Build / JDK 17 and Scala 2.13 / kafka.server.LogDirFailureTest.testReplicaFetcherThreadAfterLogDirFailureOnFollower() Build / JD

[GitHub] [kafka] showuon merged pull request #11905: MINOR: Fix incorrect log for out-of-order KTable

2022-03-17 Thread GitBox
showuon merged pull request #11905: URL: https://github.com/apache/kafka/pull/11905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] showuon commented on pull request #11905: MINOR: Fix incorrect log for out-of-order KTable

2022-03-17 Thread GitBox
showuon commented on pull request #11905: URL: https://github.com/apache/kafka/pull/11905#issuecomment-1071946919 @tchiotludo , thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] guizmaii commented on pull request #11904: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-17 Thread GitBox
guizmaii commented on pull request #11904: URL: https://github.com/apache/kafka/pull/11904#issuecomment-1071947794 @dajac I opened a PR on trunk here: https://github.com/apache/kafka/pull/11915 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guizmaii closed pull request #11904: MINOR: Fix `ConsumerConfig.ISOLATION_LEVEL_DOC`

2022-03-17 Thread GitBox
guizmaii closed pull request #11904: URL: https://github.com/apache/kafka/pull/11904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[jira] [Commented] (KAFKA-13601) Add option to support sync offset commit in Kafka Connect Sink

2022-03-17 Thread Anil Dasari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508566#comment-17508566 ] Anil Dasari commented on KAFKA-13601: - File name in the filed partitioner uses start

[jira] [Comment Edited] (KAFKA-13601) Add option to support sync offset commit in Kafka Connect Sink

2022-03-17 Thread Anil Dasari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508566#comment-17508566 ] Anil Dasari edited comment on KAFKA-13601 at 3/18/22, 4:52 AM: ---

[GitHub] [kafka] dengziming commented on pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode

2022-03-17 Thread GitBox
dengziming commented on pull request #11910: URL: https://github.com/apache/kafka/pull/11910#issuecomment-1072029922 cc @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com