ableegoldman commented on pull request #11738:
URL: https://github.com/apache/kafka/pull/11738#issuecomment-1044143849
Test failures are unrelated. Merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ableegoldman commented on a change in pull request #11738:
URL: https://github.com/apache/kafka/pull/11738#discussion_r809780324
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apac
ableegoldman merged pull request #11738:
URL: https://github.com/apache/kafka/pull/11738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
showuon commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r809773328
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,295 @@
+
ruanwenjun commented on a change in pull request #11789:
URL: https://github.com/apache/kafka/pull/11789#discussion_r809894308
##
File path: core/src/main/scala/kafka/tools/StorageTool.scala
##
@@ -56,6 +55,11 @@ object StorageTool extends Logging {
formatParser.addArgum
showuon commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r809980650
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignmentUtils.java
##
@@ -0,0 +1,54 @@
+/*
+ * L
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r810003432
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,295
[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494610#comment-17494610
]
Bruno Cadonna commented on KAFKA-8391:
--
{code:java}
java.lang.AssertionError: Tasks
[
https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494611#comment-17494611
]
Bruno Cadonna commented on KAFKA-12511:
---
https://ci-builds.apache.org/job/Kafka/jo
[
https://issues.apache.org/jira/browse/KAFKA-13672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494613#comment-17494613
]
Bruno Cadonna commented on KAFKA-13672:
---
https://ci-builds.apache.org/job/Kafka/jo
[
https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494616#comment-17494616
]
Bruno Cadonna commented on KAFKA-8541:
--
https://ci-builds.apache.org/job/Kafka/job/k
[
https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494617#comment-17494617
]
Bruno Cadonna commented on KAFKA-8541:
--
Should we open a separate ticket for the Ass
cadonna commented on pull request #11752:
URL: https://github.com/apache/kafka/pull/11752#issuecomment-1044551717
Test failures are unrelated and known to be flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cadonna merged pull request #11752:
URL: https://github.com/apache/kafka/pull/11752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
[
https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13666:
--
Fix Version/s: 3.2.0
> Tests should not ignore exceptions for supported OS
> -
[
https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-13666.
---
Resolution: Fixed
> Tests should not ignore exceptions for supported OS
> --
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r810019916
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,295
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r810020380
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,295
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1044574529
Hi @showuon Thanks for the feedback.
I've addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wcarlson5 closed pull request #10543:
URL: https://github.com/apache/kafka/pull/10543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
wcarlson5 closed pull request #10544:
URL: https://github.com/apache/kafka/pull/10544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
Walker Carlson created KAFKA-13676:
--
Summary: When processing in ALOS we might as well commit progress
made other tasks on a task specific exception
Key: KAFKA-13676
URL: https://issues.apache.org/jira/browse/KAF
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r810019916
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,295
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r810019916
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,295
SethTisue commented on pull request #11432:
URL: https://github.com/apache/kafka/pull/11432#issuecomment-1044840351
As an aside: once this lands it would be great to get Kafka in the Scala 3
community build. I think VirtusLab hopes to support other build tools besides
sbt there eventually,
SethTisue edited a comment on pull request #11432:
URL: https://github.com/apache/kafka/pull/11432#issuecomment-1044840351
As an aside: once this lands it would be great to get Kafka in the Scala 3
community build. (Among other reasons, because there is a lot of Java code in
Kafka, and the
jlprat commented on pull request #11432:
URL: https://github.com/apache/kafka/pull/11432#issuecomment-1044848322
Hi @SethTisue thanks! I definitely will take a look at it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
wcarlson5 opened a new pull request #11791:
URL: https://github.com/apache/kafka/pull/11791
When we hit an exception when processing tasks we should save the work we
have done so far.
This will only be relevant with ALOS, not EOS. It will actually reduce the
number of duplicated record
wcarlson5 commented on pull request #11791:
URL: https://github.com/apache/kafka/pull/11791#issuecomment-1044861346
@guozhangwang @ableegoldman This is ready for a pass when you have a sec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
splett2 commented on a change in pull request #11754:
URL: https://github.com/apache/kafka/pull/11754#discussion_r810211960
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer
e
splett2 commented on a change in pull request #11754:
URL: https://github.com/apache/kafka/pull/11754#discussion_r810211960
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer
e
[
https://issues.apache.org/jira/browse/KAFKA-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494824#comment-17494824
]
shylaja kokoori commented on KAFKA-13418:
-
[~ijuma] Thank you. Let me test with
C0urante commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r803045306
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##
@@ -532,23 +531,23 @@ pr
ijuma commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -461,27 +464,55 @@ private void
postProcessAndValidateIdem
ijuma commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -461,27 +464,55 @@ private void
postProcessAndValidateIdem
ijuma commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r810402844
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -461,27 +464,55 @@ private void
postProcessAndValidateIdem
ruanwenjun commented on a change in pull request #11754:
URL: https://github.com/apache/kafka/pull/11754#discussion_r810426220
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer
ruanwenjun commented on a change in pull request #11754:
URL: https://github.com/apache/kafka/pull/11754#discussion_r810426220
##
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##
@@ -764,10 +764,7 @@ public static ByteBuffer ensureCapacity(ByteBuffer
38 matches
Mail list logo