twobeeb commented on pull request #11575:
URL: https://github.com/apache/kafka/pull/11575#issuecomment-1042696537
@tombentley
Thanks for your inputs.
Regarding your last comment which I fixed, the same case could be made for
`target.type`.
https://github.com/apache/kafka/blob/tr
showuon commented on pull request #11768:
URL: https://github.com/apache/kafka/pull/11768#issuecomment-1042730089
@RivenSun2 , do you think we can close this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dengziming closed pull request #11261:
URL: https://github.com/apache/kafka/pull/11261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubs
RivenSun2 commented on pull request #11768:
URL: https://github.com/apache/kafka/pull/11768#issuecomment-1042743233
@showuon
I think this PR makes sense to make each line code of
AccessControlEntryFilter#matches consistent in style
`!host().equals(other.host())`
`!operation().
showuon commented on pull request #11768:
URL: https://github.com/apache/kafka/pull/11768#issuecomment-1042750546
Yes, I know what you mean, but I don't think this is better and have one
more function called. If you still think this change makes sense, you can ask
for other reviewer's comm
RivenSun2 commented on pull request #11768:
URL: https://github.com/apache/kafka/pull/11768#issuecomment-1042758697
@showuon Thank you for your reply
In fact, both the `AccessControlEntryFilter` and `AccessControlEntry`
classes access each attribute field of the `AccessControlEntryDa
dengziming opened a new pull request #11784:
URL: https://github.com/apache/kafka/pull/11784
*More detailed description of your change*
Normally, a broker connects to the active controller to learn its
ApiVersions, and in co-resident KRaft mode, a broker get the ApiVersions
directly fro
dengziming commented on a change in pull request #11784:
URL: https://github.com/apache/kafka/pull/11784#discussion_r808859493
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -159,12 +161,12 @@ class BrokerToControllerChannelManagerI
tim-patterson commented on a change in pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#discussion_r808822957
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1140,6 +1196,13 @@ private bo
tim-patterson commented on pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#issuecomment-1042767690
Thanks for the review @showuon.
I've pushed up some of the minor stuff, I'll finish off the unit tests and
try merging `assignStatefulTasksToThreads` and `assignStatele
dengziming opened a new pull request #11785:
URL: https://github.com/apache/kafka/pull/11785
*More detailed description of your change*
Remove unused AdminZkClient in MetadataSupport
*Summary of testing strategy (including rationale)*
QA
### Committer Checklist (excluded
Hong Yi Zhang created KAFKA-13674:
-
Summary: Failure on ZOS due to IOException when attempting to
fsync the parent directory
Key: KAFKA-13674
URL: https://issues.apache.org/jira/browse/KAFKA-13674
Pro
[
https://issues.apache.org/jira/browse/KAFKA-13674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hong Yi Zhang updated KAFKA-13674:
--
Description:
It appears to be the similar issue with [#KAFKA-13391]on ZOS due to fsync the
pa
cadonna commented on a change in pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#discussion_r808907120
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -102,17 +109,26 @@ static int assignA
cadonna commented on a change in pull request #11760:
URL: https://github.com/apache/kafka/pull/11760#discussion_r808913458
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java
##
@@ -102,17 +109,26 @@ static int assignA
[
https://issues.apache.org/jira/browse/KAFKA-13674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hong Yi Zhang updated KAFKA-13674:
--
Description:
It appears to be the similar issue with
[KAFKA-13391|https://issues.apache.org/
[
https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493881#comment-17493881
]
Abhijit commented on KAFKA-13671:
-
On the ppc64le VM provided to community, I built kafk
[
https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhijit updated KAFKA-13671:
Attachment: (was: kafka_ConsumerBounceTest_IT.txt)
> Power (ppc64le) support for kafka
> -
[
https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhijit updated KAFKA-13671:
Attachment: kafka_ConsumerBounceTest_IT.txt
> Power (ppc64le) support for kafka
>
[
https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhijit updated KAFKA-13671:
Attachment: kafka_ConsumerBounceTest_IT.txt
kafka_IT.txt
kafka_UnitTest.txt
dengziming opened a new pull request #11786:
URL: https://github.com/apache/kafka/pull/11786
*More detailed description of your change*
Currently in the [kafka protocols page](https://kafka.apache.org/protocol),
we miss some KRaft protocol, for example DescribeQuorumRequest(55)
Disable idempotence when config conflicts and add tests
### Committer Checklist (excluded from commit message)
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r809037746
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -514,7 +514,7 @@ private TransactionManager
configureTran
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r809039418
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -511,15 +542,6 @@ public ProducerConfig(Map props) {
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r809040186
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -461,27 +464,55 @@ private void
postProcessAndValidateId
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r809041039
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -461,27 +464,55 @@ private void
postProcessAndValidateId
showuon commented on pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#issuecomment-1042944712
@mimaison @hachikuji @vvcephei , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
ruanwenjun opened a new pull request #11789:
URL: https://github.com/apache/kafka/pull/11789
* Print help in StorageTool when no args input.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build sta
nicktelford commented on pull request #11610:
URL: https://github.com/apache/kafka/pull/11610#issuecomment-1043126322
@mjsax I don't see a `StreamThreadTest`. Do you mean
`GlobalStreamThreadTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
nicktelford removed a comment on pull request #11610:
URL: https://github.com/apache/kafka/pull/11610#issuecomment-1043126322
@mjsax I don't see a `StreamThreadTest`. Do you mean
`GlobalStreamThreadTest`?
--
This is an automated message from the Apache Git Service.
To respond to the mess
vvcephei closed pull request #11767:
URL: https://github.com/apache/kafka/pull/11767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
vvcephei commented on pull request #11767:
URL: https://github.com/apache/kafka/pull/11767#issuecomment-1043135161
Closing in favor of https://issues.apache.org/jira/browse/KAFKA-13673 /
https://github.com/apache/kafka/pull/11788
--
This is an automated message from the Apache Git Servic
nicktelford commented on pull request #11610:
URL: https://github.com/apache/kafka/pull/11610#issuecomment-1043171527
@mjsax I've added some tests as suggested and re-based against `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
C0urante edited a comment on pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#issuecomment-1032801881
Thanks Mickael, I can take a stab at that. I don't think I can get each PR
to be buildable on its own without a lot of work but I can definitely isolate
high-level sect
cadonna commented on a change in pull request #11765:
URL: https://github.com/apache/kafka/pull/11765#discussion_r809336171
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java
##
@@ -0,0 +1,390 @@
+package org.apache.kafka.
cadonna commented on a change in pull request #11765:
URL: https://github.com/apache/kafka/pull/11765#discussion_r809340005
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java
##
@@ -0,0 +1,390 @@
+package org.apache.kafka.
cadonna commented on a change in pull request #11765:
URL: https://github.com/apache/kafka/pull/11765#discussion_r809347698
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java
##
@@ -0,0 +1,390 @@
+package org.apache.kafka.
ijuma commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1043304328
I agree with the suggestions here. Especially since the idempotence change
did not land in 3.0.0 as originally intended. We can continue the discussion in
#11788.
--
This is a
ijuma commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r809370789
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -461,27 +464,55 @@ private void
postProcessAndValidateIdem
eas5 commented on pull request #10682:
URL: https://github.com/apache/kafka/pull/10682#issuecomment-1043317472
> @eas5 , thanks for the patch! Since it's been a while, could you rebase to
trunk and check the jenkins test results again. Thanks.
Hi @showuon! Done as requested! Thank yo
guozhangwang commented on a change in pull request #11738:
URL: https://github.com/apache/kafka/pull/11738#discussion_r809378947
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java
##
@@ -316,6 +315,14 @@ StreamsProducer threadProducer()
seanli-rallyhealth commented on a change in pull request #11789:
URL: https://github.com/apache/kafka/pull/11789#discussion_r809395420
##
File path: core/src/main/scala/kafka/tools/StorageTool.scala
##
@@ -56,6 +55,11 @@ object StorageTool extends Logging {
formatParser.
wcarlson5 commented on a change in pull request #11738:
URL: https://github.com/apache/kafka/pull/11738#discussion_r809488943
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache
C0urante commented on pull request #11780:
URL: https://github.com/apache/kafka/pull/11780#issuecomment-1043508835
Jenkins build failures appear to be due to the issue addressed by
https://github.com/apache/kafka/pull/10702. I've pushed a change that applies
the same fix from that PR to th
Paul Callahan created KAFKA-13675:
-
Summary: Null pointer exception with kafka streams application
reset tool with --to-datetime
Key: KAFKA-13675
URL: https://issues.apache.org/jira/browse/KAFKA-13675
[
https://issues.apache.org/jira/browse/KAFKA-13675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Callahan updated KAFKA-13675:
--
Description:
When I try to run the the reset tool with {{{}--to-datetime{}}}, such as:
{cod
hachikuji opened a new pull request #11790:
URL: https://github.com/apache/kafka/pull/11790
There seemed to be a little sloppiness in the integration tests in regard to
admin client creation. Not only was there duplicated logic, but it wasn't
always clear which listener the admin client wa
showuon commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1043738331
@dengziming , could you please rebase to the latest trunk and trigger
jenkins build again? I'd like to confirm it won't break any tests. Thanks.
--
This is an automated messa
dengziming commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1043741005
@showuon Aha, I just rebased it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r809621101
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##
@@ -461,27 +464,55 @@ private void
postProcessAndValidateId
ruanwenjun commented on a change in pull request #11789:
URL: https://github.com/apache/kafka/pull/11789#discussion_r809624055
##
File path: core/src/main/scala/kafka/tools/StorageTool.scala
##
@@ -56,6 +55,11 @@ object StorageTool extends Logging {
formatParser.addArgum
showuon commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1043982299
Failed tests are unrelated.
```
Build / ARM /
kafka.network.SocketServerTest.remoteCloseWithoutBufferedReceives()
Build / JDK 11 and Scala 2.13 /
kafka.server.
showuon commented on pull request #11785:
URL: https://github.com/apache/kafka/pull/11785#issuecomment-1043989800
Confirmed this `adminZkClient` is not used anywhere else. So, it makes sense
to remove it. If the `ZkSupport` object needs to create `adminZkClient`, it can
create an `AdminZkC
showuon merged pull request #11785:
URL: https://github.com/apache/kafka/pull/11785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
C0urante commented on pull request #11775:
URL: https://github.com/apache/kafka/pull/11775#issuecomment-1043994054
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
C0urante commented on pull request #11779:
URL: https://github.com/apache/kafka/pull/11779#issuecomment-1043994712
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
C0urante commented on pull request #11776:
URL: https://github.com/apache/kafka/pull/11776#issuecomment-1043994222
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
C0urante commented on pull request #11778:
URL: https://github.com/apache/kafka/pull/11778#issuecomment-1043994475
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
showuon commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r809711301
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,289 @@
+
C0urante commented on pull request #11782:
URL: https://github.com/apache/kafka/pull/11782#issuecomment-1043995560
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
C0urante commented on pull request #11780:
URL: https://github.com/apache/kafka/pull/11780#issuecomment-1043994995
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
C0urante commented on pull request #11781:
URL: https://github.com/apache/kafka/pull/11781#issuecomment-1043995270
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
C0urante commented on pull request #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1043997079
Converting to draft until upstream PRs are reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dengziming commented on a change in pull request #11789:
URL: https://github.com/apache/kafka/pull/11789#discussion_r809729180
##
File path: core/src/main/scala/kafka/tools/StorageTool.scala
##
@@ -56,6 +55,11 @@ object StorageTool extends Logging {
formatParser.addArgum
70 matches
Mail list logo
