[jira] [Commented] (KAFKA-13669) Log messages for source tasks with no offsets to commit are noisy and confusing

2022-02-16 Thread Giovanni Marigi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493053#comment-17493053 ] Giovanni Marigi commented on KAFKA-13669: - Seen this with replicator and my cust

[jira] [Commented] (KAFKA-13390) Kafka 3 fails to run on Windows

2022-02-16 Thread Slawomir Messner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493059#comment-17493059 ] Slawomir Messner commented on KAFKA-13390: -- When will this fix be released? It

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-16 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r807660376 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-16 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r807663879 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289

[GitHub] [kafka] mosesonline commented on pull request #11426: KAFKA-13391: don't fsync directory on Windows OS

2022-02-16 Thread GitBox
mosesonline commented on pull request #11426: URL: https://github.com/apache/kafka/pull/11426#issuecomment-1041238766 When will this PR will be released in the 3.0.1/X releases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mimaison commented on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
mimaison commented on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1041242867 It looks like this also affects system tests: https://github.com/apache/kafka/pull/11769 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] showuon commented on pull request #11426: KAFKA-13391: don't fsync directory on Windows OS

2022-02-16 Thread GitBox
showuon commented on pull request #11426: URL: https://github.com/apache/kafka/pull/11426#issuecomment-1041249965 @mosesonline , here's the release plan for v3.0.1. FYI https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.0.1 -- This is an automated message from the Apache

[jira] [Commented] (KAFKA-13390) Kafka 3 fails to run on Windows

2022-02-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493082#comment-17493082 ] Luke Chen commented on KAFKA-13390: --- [~mosesonline] , v3.1.0 was released containing t

[jira] [Updated] (KAFKA-13510) KIP-769: Connect APIs to list all connector plugins and retrieve their configuration definitions

2022-02-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13510: -- Fix Version/s: 3.2.0 > KIP-769: Connect APIs to list all connector plugins and retrieve their

[jira] [Updated] (KAFKA-13511) Add support for different unix precisions in TimestampConverter SMT

2022-02-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13511: -- Fix Version/s: 3.2.0 > Add support for different unix precisions in TimestampConverter SMT > -

[jira] [Commented] (KAFKA-13666) Tests should not ignore exceptions for supported OS

2022-02-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493110#comment-17493110 ] Bruno Cadonna commented on KAFKA-13666: --- I see you point. Dropping support for Win

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-16 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r807738730 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-16 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r807738730 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289

[GitHub] [kafka] cadonna commented on a change in pull request #11752: KAFKA-13666 Only ignore test exceptions for windows OS.

2022-02-16 Thread GitBox
cadonna commented on a change in pull request #11752: URL: https://github.com/apache/kafka/pull/11752#discussion_r807751843 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -1094,29 +1095,37 @@ private void throwIfBuiltInSto

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-16 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r807810480 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,289

[GitHub] [kafka] lkokhreidze commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2022-02-16 Thread GitBox
lkokhreidze commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-1041380775 Hi @showuon, @cadonna Thanks for the valuable feedback. I've addressed your comments and pushed the changes. I also resolved conversations feel free to unresolve the

[GitHub] [kafka] ruanwenjun commented on pull request #11763: MINOR: Remove unused params in ZkConfigManager

2022-02-16 Thread GitBox
ruanwenjun commented on pull request #11763: URL: https://github.com/apache/kafka/pull/11763#issuecomment-1041398013 @hachikuji Thanks for your review. I have removed the unused import. Now, it should pass the `checkstyle` task. By the way, how can I control the import order of kafka

[GitHub] [kafka] mimaison commented on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
mimaison commented on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1041402113 With this change, if a user explicitly sets `acks` to 0 or 1, we're throwing an error. Currently in order to change `acks`, users also have to set `enable.idempotence=false`.

[GitHub] [kafka] mimaison merged pull request #11764: Install missing 'tc' utility - iproute2 for systemtests

2022-02-16 Thread GitBox
mimaison merged pull request #11764: URL: https://github.com/apache/kafka/pull/11764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] cadonna commented on a change in pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-02-16 Thread GitBox
cadonna commented on a change in pull request #11760: URL: https://github.com/apache/kafka/pull/11760#discussion_r807858181 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -102,17 +109,26 @@ static int assignA

[GitHub] [kafka] mimaison commented on a change in pull request #11756: MINOR: Small cleanups in connect:runtime

2022-02-16 Thread GitBox
mimaison commented on a change in pull request #11756: URL: https://github.com/apache/kafka/pull/11756#discussion_r807883399 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java ## @@ -137,11 +137,6 @@ private int gener

[GitHub] [kafka] showuon commented on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
showuon commented on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1041473036 @mimaison , do you mean: So, do you mean, we have some different cases: 1. if user **doesn't** set enable.idempotence explicitly: the idempotent producer is **only enabled

[GitHub] [kafka] showuon edited a comment on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
showuon edited a comment on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1041473036 @mimaison , do you mean: So, do you mean, we have some different cases: 1. if user **doesn't** set enable.idempotence explicitly: the idempotent producer is **only

[GitHub] [kafka] showuon edited a comment on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
showuon edited a comment on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1041473036 @mimaison , do you mean: So, do you mean, we have some different cases: 1. if user **doesn't** set enable.idempotence explicitly: the idempotent producer is **only

[GitHub] [kafka] C0urante commented on a change in pull request #11758: MINOR: Clarify logging behavior with errors.log.include.messages property

2022-02-16 Thread GitBox
C0urante commented on a change in pull request #11758: URL: https://github.com/apache/kafka/pull/11758#discussion_r807517678 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -150,9 +150,11 @@ public static final Strin

[GitHub] [kafka] C0urante opened a new pull request #11770: KAFKA-13669: Demote empty offset commit messages for source tasks to DEBUG level

2022-02-16 Thread GitBox
C0urante opened a new pull request #11770: URL: https://github.com/apache/kafka/pull/11770 [Jira](https://issues.apache.org/jira/browse/KAFKA-13669) Enough users have provided feedback about this message being scary/spammy/misleading that we should take their thoughts into account an

[GitHub] [kafka] mimaison commented on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
mimaison commented on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1041540013 I too think it makes sense to apply the same logic to `retries` and `max.in.flight.requests.per.connection`. When disabling idempotency due to a conflicting config, we should

[jira] [Created] (KAFKA-13671) Power (ppc64le) support for kafka

2022-02-16 Thread Abhijit (Jira)
Abhijit created KAFKA-13671: --- Summary: Power (ppc64le) support for kafka Key: KAFKA-13671 URL: https://issues.apache.org/jira/browse/KAFKA-13671 Project: Kafka Issue Type: Improvement Com

[jira] [Updated] (KAFKA-13671) Power (ppc64le) support for kafka

2022-02-16 Thread Abhijit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit updated KAFKA-13671: Description: Support for Power architecture (ppc64le) for apache kafka. What is IBM Power architecture? I

[GitHub] [kafka] mjsax merged pull request #11759: MINOR: improve JavaDocs for ReadOnlySessionStore

2022-02-16 Thread GitBox
mjsax merged pull request #11759: URL: https://github.com/apache/kafka/pull/11759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] jwiederholdconfluent commented on a change in pull request #11758: MINOR: Clarify logging behavior with errors.log.include.messages property

2022-02-16 Thread GitBox
jwiederholdconfluent commented on a change in pull request #11758: URL: https://github.com/apache/kafka/pull/11758#discussion_r808247925 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -150,9 +150,11 @@ public static

[GitHub] [kafka] free2create commented on a change in pull request #11752: KAFKA-13666 Only ignore test exceptions for windows OS.

2022-02-16 Thread GitBox
free2create commented on a change in pull request #11752: URL: https://github.com/apache/kafka/pull/11752#discussion_r808258300 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -1094,29 +1095,37 @@ private void throwIfBuiltI

[GitHub] [kafka] Hangleton opened a new pull request #11771: Build fix: removed unused import in RemoteIndexCacheTest

2022-02-16 Thread GitBox
Hangleton opened a new pull request #11771: URL: https://github.com/apache/kafka/pull/11771 Removed unused import in RemoteIndexCacheTest. Verified with `./gradlew build` and `./gradlew :core:compileTestScala`. ### Committer Checklist (excluded from commit message) - [N/A] Verify

[GitHub] [kafka] Hangleton closed pull request #11771: Build fix: removed unused import in RemoteIndexCacheTest

2022-02-16 Thread GitBox
Hangleton closed pull request #11771: URL: https://github.com/apache/kafka/pull/11771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Commented] (KAFKA-13666) Tests should not ignore exceptions for supported OS

2022-02-16 Thread Rob Leland (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493382#comment-17493382 ] Rob Leland commented on KAFKA-13666: I am Just learning Kafka and other things Apach

[GitHub] [kafka] tombentley commented on a change in pull request #11575: KAFKA-13511: Add support for different unix precisions in TimestampConverter SMT

2022-02-16 Thread GitBox
tombentley commented on a change in pull request #11575: URL: https://github.com/apache/kafka/pull/11575#discussion_r808304776 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/TimestampConverter.java ## @@ -65,14 +66,22 @@ public static f

[GitHub] [kafka] hachikuji commented on pull request #11763: MINOR: Remove unused params in ZkConfigManager

2022-02-16 Thread GitBox
hachikuji commented on pull request #11763: URL: https://github.com/apache/kafka/pull/11763#issuecomment-1041960369 @ruanwenjun To be honest, I don't think we have official guidelines on import ordering. The only style enforcement I'm aware of is avoiding `*` imports in the Java code. If y

[GitHub] [kafka] hachikuji merged pull request #11763: MINOR: Remove unused params in ZkConfigManager

2022-02-16 Thread GitBox
hachikuji merged pull request #11763: URL: https://github.com/apache/kafka/pull/11763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] mimaison merged pull request #11756: MINOR: Small cleanups in connect:runtime

2022-02-16 Thread GitBox
mimaison merged pull request #11756: URL: https://github.com/apache/kafka/pull/11756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[jira] [Created] (KAFKA-13672) Flaky test kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()

2022-02-16 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-13672: - Summary: Flaky test kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize() Key: KAFKA-13672 URL: https://issues.apache.org/jira/browse/KAFKA-13672 Pro

[jira] [Commented] (KAFKA-6823) Transient failure in DynamicBrokerReconfigurationTest.testThreadPoolResize

2022-02-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493457#comment-17493457 ] Bruno Cadonna commented on KAFKA-6823: -- I opened the following ticket for the new fa

[GitHub] [kafka] cadonna commented on pull request #11751: MINOR: Add state directory to exceptions regarding state diretory

2022-02-16 Thread GitBox
cadonna commented on pull request #11751: URL: https://github.com/apache/kafka/pull/11751#issuecomment-1042083707 Test failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize() Build / JDK 11 and Scala 2.13 / k

[GitHub] [kafka] cadonna merged pull request #11751: MINOR: Add state directory to exceptions regarding state diretory

2022-02-16 Thread GitBox
cadonna merged pull request #11751: URL: https://github.com/apache/kafka/pull/11751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] twobeeb commented on a change in pull request #11575: KAFKA-13511: Add support for different unix precisions in TimestampConverter SMT

2022-02-16 Thread GitBox
twobeeb commented on a change in pull request #11575: URL: https://github.com/apache/kafka/pull/11575#discussion_r808393677 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/TimestampConverter.java ## @@ -65,14 +66,22 @@ public static fina

[GitHub] [kafka] tim-patterson commented on a change in pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-02-16 Thread GitBox
tim-patterson commented on a change in pull request #11760: URL: https://github.com/apache/kafka/pull/11760#discussion_r808418617 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -102,17 +109,26 @@ static int a

[GitHub] [kafka] ableegoldman commented on a change in pull request #11705: KAFKA-9847: add config to set default store type

2022-02-16 Thread GitBox
ableegoldman commented on a change in pull request #11705: URL: https://github.com/apache/kafka/pull/11705#discussion_r808518197 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -81,14 +81,19 @@ public StreamsBuilder() { internalSt

[jira] [Assigned] (KAFKA-7499) Extend ProductionExceptionHandler to cover serialization exceptions

2022-02-16 Thread Bangarraju Vadapalli (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bangarraju Vadapalli reassigned KAFKA-7499: --- Assignee: Bangarraju Vadapalli > Extend ProductionExceptionHandler to cover

[GitHub] [kafka] showuon commented on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
showuon commented on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1042484001 @ijuma @hachikuji @vvcephei @kirktrue , any thoughts about this suggestion? This way, we don't need https://github.com/apache/kafka/pull/11767 https://github.com/apache/kafka/p

[GitHub] [kafka] hachikuji merged pull request #11770: KAFKA-13669: Demote empty offset commit messages for source tasks to DEBUG level

2022-02-16 Thread GitBox
hachikuji merged pull request #11770: URL: https://github.com/apache/kafka/pull/11770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Resolved] (KAFKA-13669) Log messages for source tasks with no offsets to commit are noisy and confusing

2022-02-16 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13669. - Fix Version/s: 3.2.0 Resolution: Fixed > Log messages for source tasks with no of

[GitHub] [kafka] C0urante commented on pull request #11770: KAFKA-13669: Demote empty offset commit messages for source tasks to DEBUG level

2022-02-16 Thread GitBox
C0urante commented on pull request #11770: URL: https://github.com/apache/kafka/pull/11770#issuecomment-1042488844 Thanks Jason, appreciate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] hachikuji commented on pull request #11767: KAFKA-13598: set log4j appender to default acks

2022-02-16 Thread GitBox
hachikuji commented on pull request #11767: URL: https://github.com/apache/kafka/pull/11767#issuecomment-1042497943 > Yes, I don't know the getters serve any purpose, either. But I'm still worried that there's someone relying on it. I'd like to hear what @hachikuji 's thought since he d

[GitHub] [kafka] hachikuji edited a comment on pull request #11767: KAFKA-13598: set log4j appender to default acks

2022-02-16 Thread GitBox
hachikuji edited a comment on pull request #11767: URL: https://github.com/apache/kafka/pull/11767#issuecomment-1042497943 > Yes, I don't know the getters serve any purpose, either. But I'm still worried that there's someone relying on it. I'd like to hear what @hachikuji 's thought sin

[jira] [Commented] (KAFKA-13668) Failed cluster authorization should not be fatal for producer

2022-02-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493601#comment-17493601 ] Luke Chen commented on KAFKA-13668: --- Nice suggestion! We should improve it! > Failed

[GitHub] [kafka] hachikuji commented on a change in pull request #11681: KAFKA-8785: fix request timeout by waiting for brokers up at the begining

2022-02-16 Thread GitBox
hachikuji commented on a change in pull request #11681: URL: https://github.com/apache/kafka/pull/11681#discussion_r808619827 ## File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala ## @@ -55,9 +54,18 @@ final class LeaderElectionCommandTest(cluster:

[GitHub] [kafka] showuon commented on a change in pull request #11753: MINOR: Add license header in suppressions.xml

2022-02-16 Thread GitBox
showuon commented on a change in pull request #11753: URL: https://github.com/apache/kafka/pull/11753#discussion_r808620042 ## File path: checkstyle/suppressions.xml ## @@ -1,9 +1,24 @@ - + Review comment: Is this necessary to add this line? -- This is an automated

[GitHub] [kafka] showuon commented on a change in pull request #11681: KAFKA-8785: fix request timeout by waiting for brokers up at the begining

2022-02-16 Thread GitBox
showuon commented on a change in pull request #11681: URL: https://github.com/apache/kafka/pull/11681#discussion_r808620691 ## File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala ## @@ -55,9 +54,18 @@ final class LeaderElectionCommandTest(cluster: C

[GitHub] [kafka] hachikuji commented on a change in pull request #11681: KAFKA-8785: fix request timeout by waiting for brokers up at the begining

2022-02-16 Thread GitBox
hachikuji commented on a change in pull request #11681: URL: https://github.com/apache/kafka/pull/11681#discussion_r808622838 ## File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala ## @@ -55,9 +54,18 @@ final class LeaderElectionCommandTest(cluster:

[GitHub] [kafka] hachikuji commented on a change in pull request #11681: KAFKA-8785: fix request timeout by waiting for brokers up at the begining

2022-02-16 Thread GitBox
hachikuji commented on a change in pull request #11681: URL: https://github.com/apache/kafka/pull/11681#discussion_r808622838 ## File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala ## @@ -55,9 +54,18 @@ final class LeaderElectionCommandTest(cluster:

[GitHub] [kafka] showuon commented on a change in pull request #11681: KAFKA-8785: fix request timeout by waiting for brokers up at the begining

2022-02-16 Thread GitBox
showuon commented on a change in pull request #11681: URL: https://github.com/apache/kafka/pull/11681#discussion_r808623633 ## File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala ## @@ -55,9 +54,18 @@ final class LeaderElectionCommandTest(cluster: C

[GitHub] [kafka] hachikuji commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for brokers up at the begining

2022-02-16 Thread GitBox
hachikuji commented on pull request #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1042520005 > it doesn't work to put the admin client creating after cluster.waitForReadyBrokers(), because the waitForReadyBrokers only wait for all brokers registered and unfenced (re

[GitHub] [kafka] showuon commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for brokers up at the begining

2022-02-16 Thread GitBox
showuon commented on pull request #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1042521794 @hachikuji , let me check it and let you know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2022-02-16 Thread GitBox
showuon commented on pull request #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1042525944 @vamossagar12 , thanks for the PR. I'll take a look in next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] C0urante opened a new pull request #11772: KAFKA-10000: Add new metrics for source task transactions (KIP-618)

2022-02-16 Thread GitBox
C0urante opened a new pull request #11772: URL: https://github.com/apache/kafka/pull/11772 Adds the new metrics described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnceSupportforSourceConnectors-Newmetr

[GitHub] [kafka] C0urante opened a new pull request #11773: KAFKA-10000: Add new source connector APIs related to exactly-once support

2022-02-16 Thread GitBox
C0urante opened a new pull request #11773: URL: https://github.com/apache/kafka/pull/11773 Adds the new exactly-once-related source connector APIs described in [KIP-618]. Note that these APIs are not used by the framework in this PR, just defined. They will be used in downstream PRs

[GitHub] [kafka] C0urante opened a new pull request #11774: KAFKA-10000: Widely-used utility methods

2022-02-16 Thread GitBox
C0urante opened a new pull request #11774: URL: https://github.com/apache/kafka/pull/11774 Adds some reusable utility methods for: - Overriding (and logging a warning) user-supplied properties if they do not contain an expected value - Generating an array of the names (or, to be p

[GitHub] [kafka] C0urante opened a new pull request #11775: KAFKA-10000: Add all public-facing config properties related to exactly-once source support

2022-02-16 Thread GitBox
C0urante opened a new pull request #11775: URL: https://github.com/apache/kafka/pull/11775 Adds the new connector- and worker-level properties described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnceSup

[GitHub] [kafka] vvcephei commented on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
vvcephei commented on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1042545763 I have to admit that I find all these breakages that are cropping up to be a bit disturbing. I like the idea to default to stronger guarantees, but if the cost is that a lot o

[GitHub] [kafka] showuon commented on pull request #10682: MINOR: Refactored test using parameterization

2022-02-16 Thread GitBox
showuon commented on pull request #10682: URL: https://github.com/apache/kafka/pull/10682#issuecomment-1042548348 @eas5 , thanks for the patch! Since it's been a while, could you rebase to trunk and check the jenkins test results again. Thanks. -- This is an automated message from the Ap

[GitHub] [kafka] C0urante opened a new pull request #11776: KAFKA-10000: Add new preflight connector config validation logic (KIP-618)

2022-02-16 Thread GitBox
C0urante opened a new pull request #11776: URL: https://github.com/apache/kafka/pull/11776 Implements the preflight validation logic described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnceSupportforSou

[GitHub] [kafka] C0urante opened a new pull request #11777: KAFKA-10000: Add producer fencing API to admin client (KIP-618)

2022-02-16 Thread GitBox
C0urante opened a new pull request #11777: URL: https://github.com/apache/kafka/pull/11777 Implements the new admin client API described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnceSupportforSourceCon

[GitHub] [kafka] C0urante opened a new pull request #11778: KAFKA-10000: Use transactional producer for config topic

2022-02-16 Thread GitBox
C0urante opened a new pull request #11778: URL: https://github.com/apache/kafka/pull/11778 Implements the behavior described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnceSupportforSourceConnectors-Lead

[GitHub] [kafka] C0urante opened a new pull request #11779: KAFKA-10000: Zombie fencing (KIP-618)

2022-02-16 Thread GitBox
C0urante opened a new pull request #11779: URL: https://github.com/apache/kafka/pull/11779 Implements the zombie fencing logic described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnceSupportforSourceCon

[GitHub] [kafka] C0urante opened a new pull request #11780: KAFKA-10000: Exactly-once source tasks

2022-02-16 Thread GitBox
C0urante opened a new pull request #11780: URL: https://github.com/apache/kafka/pull/11780 Implements a source task wrapper (`ExactlyOnceWorkerSourceTask`) that follows the behavior described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for

[GitHub] [kafka] C0urante opened a new pull request #11781: KAFKA-10000: Per-connector offsets topics (KIP-618)

2022-02-16 Thread GitBox
C0urante opened a new pull request #11781: URL: https://github.com/apache/kafka/pull/11781 Implements support for per-connector offsets topics as described in [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors#KIP618:ExactlyOnce

[GitHub] [kafka] C0urante commented on a change in pull request #11780: KAFKA-10000: Exactly-once source tasks (KIP-618)

2022-02-16 Thread GitBox
C0urante commented on a change in pull request #11780: URL: https://github.com/apache/kafka/pull/11780#discussion_r808667916 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java ## @@ -0,0 +1,72 @@ +/* + * Licensed to th

[GitHub] [kafka] C0urante opened a new pull request #11782: KAFKA-10000: Integration tests (KIP-618)

2022-02-16 Thread GitBox
C0urante opened a new pull request #11782: URL: https://github.com/apache/kafka/pull/11782 Implements embedded end-to-end integration tests for [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors), and brings together previously

[GitHub] [kafka] C0urante opened a new pull request #11783: KAFKA-10000: System tests (KIP-618)

2022-02-16 Thread GitBox
C0urante opened a new pull request #11783: URL: https://github.com/apache/kafka/pull/11783 Implements system tests for [KIP-618](https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors). Relies on changes from: - https://github.com/a

[GitHub] [kafka] C0urante closed pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

2022-02-16 Thread GitBox
C0urante closed pull request #10907: URL: https://github.com/apache/kafka/pull/10907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] C0urante commented on pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

2022-02-16 Thread GitBox
C0urante commented on pull request #10907: URL: https://github.com/apache/kafka/pull/10907#issuecomment-1042573696 @mimaison @rhauch I've broken things down into smaller PRs. These can all be reviewed immediately: - https://github.com/apache/kafka/pull/11777 (cc @hachikuji in case

[GitHub] [kafka] ijuma commented on pull request #11769: Use default non-zero value for retries in producer

2022-02-16 Thread GitBox
ijuma commented on pull request #11769: URL: https://github.com/apache/kafka/pull/11769#issuecomment-1042574221 I think you would want to disable idempotence instead. Retries were intentionally disabled here. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] C0urante edited a comment on pull request #10907: KAFKA-10000: Exactly-once support for source connectors (KIP-618)

2022-02-16 Thread GitBox
C0urante edited a comment on pull request #10907: URL: https://github.com/apache/kafka/pull/10907#issuecomment-1042573696 @mimaison @rhauch I've broken things down into smaller PRs. These can all be reviewed immediately: - https://github.com/apache/kafka/pull/11777 (cc @hachikuji i

[GitHub] [kafka] ruanwenjun commented on a change in pull request #11753: MINOR: Add license header in suppressions.xml

2022-02-16 Thread GitBox
ruanwenjun commented on a change in pull request #11753: URL: https://github.com/apache/kafka/pull/11753#discussion_r808702569 ## File path: checkstyle/suppressions.xml ## @@ -1,9 +1,24 @@ - + Review comment: Thanks for your review. To be honestly, I am not sure if

[GitHub] [kafka] showuon commented on a change in pull request #11705: KAFKA-9847: add config to set default store type

2022-02-16 Thread GitBox
showuon commented on a change in pull request #11705: URL: https://github.com/apache/kafka/pull/11705#discussion_r808708709 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -81,14 +81,19 @@ public StreamsBuilder() { internalStreams

[GitHub] [kafka] showuon commented on a change in pull request #11753: MINOR: Add license header in suppressions.xml

2022-02-16 Thread GitBox
showuon commented on a change in pull request #11753: URL: https://github.com/apache/kafka/pull/11753#discussion_r808713500 ## File path: checkstyle/suppressions.xml ## @@ -1,9 +1,24 @@ - + Review comment: OK, from the XML spec [1], it said: _XML documents SHOULD

[GitHub] [kafka] showuon commented on pull request #11753: MINOR: Add license header in suppressions.xml

2022-02-16 Thread GitBox
showuon commented on pull request #11753: URL: https://github.com/apache/kafka/pull/11753#issuecomment-1042619446 failed tests are unrelated: ``` [Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()](https://ci-builds.apache.org/job/Kaf

[GitHub] [kafka] showuon merged pull request #11753: MINOR: Add license header in suppressions.xml

2022-02-16 Thread GitBox
showuon merged pull request #11753: URL: https://github.com/apache/kafka/pull/11753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[jira] [Created] (KAFKA-13673) disable idempotent producer when acks/retries/max.in.flight config conflicts

2022-02-16 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13673: - Summary: disable idempotent producer when acks/retries/max.in.flight config conflicts Key: KAFKA-13673 URL: https://issues.apache.org/jira/browse/KAFKA-13673 Project: Kafka

[GitHub] [kafka] showuon commented on pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

2022-02-16 Thread GitBox
showuon commented on pull request #11691: URL: https://github.com/apache/kafka/pull/11691#issuecomment-1042640027 [KAFKA-13673](https://issues.apache.org/jira/browse/KAFKA-13673) is created for this proposal. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (KAFKA-13673) disable idempotent producer when acks/retries/max.in.flight config conflicts

2022-02-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13673: - Assignee: Luke Chen > disable idempotent producer when acks/retries/max.in.flight config confli

[GitHub] [kafka] RivenSun2 commented on pull request #11768: MINOR: Optimize the matches method of AccessControlEntryFilter

2022-02-16 Thread GitBox
RivenSun2 commented on pull request #11768: URL: https://github.com/apache/kafka/pull/11768#issuecomment-1042652006 @showuon Yeah i agree with you I just want to keep the code style in the AccessControlEntryFilter#matches method consistent~ Like the following lines of code: the