[GitHub] [kafka] dajac commented on pull request #11726: KAFKA-13637: Use default.api.timeout.ms as default timeout value for KafkaConsumer.endOffsets

2022-02-02 Thread GitBox
dajac commented on pull request #11726: URL: https://github.com/apache/kafka/pull/11726#issuecomment-1027677422 Good catch! It seems that we forgot it in https://github.com/apache/kafka/commit/53ca52f855e903907378188d29224b3f9cefa6cb. Have you tried to add a unit test for the bug? -- Th

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-02 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1027702595 @Indupa I'm sorry. There was a mistake rebasing onto 2.8.1. You can see the updated patch with built tarball [here](https://github.com/dongjinleekr/kafka/releases/tag/2.8.1%

[GitHub] [kafka] Indupa commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-02 Thread GitBox
Indupa commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1027741356 Thank you so much @dongjinleekr . Let me try to apply a patch and build.Will update you -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] cadonna commented on pull request #11690: KAFKA-13599: Upgrade RocksDB to 6.27.3

2022-02-02 Thread GitBox
cadonna commented on pull request #11690: URL: https://github.com/apache/kafka/pull/11690#issuecomment-1027763171 Failing test are unrelated: ``` Build / JDK 11 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition, Security=PLAINTEXT Build /

[GitHub] [kafka] cadonna merged pull request #11690: KAFKA-13599: Upgrade RocksDB to 6.27.3

2022-02-02 Thread GitBox
cadonna merged pull request #11690: URL: https://github.com/apache/kafka/pull/11690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] HyunSangHan commented on pull request #11418: MINOR: Write log differently according to the size of missingListenerPartitions

2022-02-02 Thread GitBox
HyunSangHan commented on pull request #11418: URL: https://github.com/apache/kafka/pull/11418#issuecomment-1027773412 Can someone look at this PR? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (KAFKA-13599) Upgrade RocksDB to 6.27.3

2022-02-02 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-13599. --- Resolution: Resolved > Upgrade RocksDB to 6.27.3 > - > >

[GitHub] [kafka] cadonna commented on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

2022-02-02 Thread GitBox
cadonna commented on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-1027802506 @vamossagar12 Can we close this PR and the corresponding ticket since it seems we decided to look for a more complete solution? -- This is an automated message from the Apac

[GitHub] [kafka] dengziming commented on pull request #11726: KAFKA-13637: Use default.api.timeout.ms as default timeout value for KafkaConsumer.endOffsets

2022-02-02 Thread GitBox
dengziming commented on pull request #11726: URL: https://github.com/apache/kafka/pull/11726#issuecomment-1027842174 @dajac , Yes, I added a unit test for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-02 Thread Ulrik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrik updated KAFKA-13638: -- Description: I have a topology where I stream messages from an input topic, transform the message to multiple

[jira] [Created] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-02 Thread Ulrik (Jira)
Ulrik created KAFKA-13638: - Summary: Slow KTable update when forwarding multiple values from transformer Key: KAFKA-13638 URL: https://issues.apache.org/jira/browse/KAFKA-13638 Project: Kafka Issue

[GitHub] [kafka] dajac commented on a change in pull request #11726: KAFKA-13637: Use default.api.timeout.ms as default timeout value for KafkaConsumer.endOffsets

2022-02-02 Thread GitBox
dajac commented on a change in pull request #11726: URL: https://github.com/apache/kafka/pull/11726#discussion_r797572591 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2948,6 +2948,64 @@ public void testAssignorNameConflict

[GitHub] [kafka] cadonna commented on a change in pull request #11712: WIP: Put failed tasks to end of processing list

2022-02-02 Thread GitBox
cadonna commented on a change in pull request #11712: URL: https://github.com/apache/kafka/pull/11712#discussion_r797611602 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java ## @@ -270,6 +278,23 @@ Task task(final TaskId taskId) {

[GitHub] [kafka] ijuma merged pull request #11518: MINOR: Upgrade to Gradle 7.3.3

2022-02-02 Thread GitBox
ijuma merged pull request #11518: URL: https://github.com/apache/kafka/pull/11518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma merged pull request #11717: KAFKA-13619: zookeeper.sync.time.ms is no longer used

2022-02-02 Thread GitBox
ijuma merged pull request #11717: URL: https://github.com/apache/kafka/pull/11717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma merged pull request #11669: MINOR: Replace if/else with match in KafkaZkClient#getPartitionAssignmentForTopics

2022-02-02 Thread GitBox
ijuma merged pull request #11669: URL: https://github.com/apache/kafka/pull/11669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] jlprat commented on pull request #11518: MINOR: Upgrade to Gradle 7.3.3

2022-02-02 Thread GitBox
jlprat commented on pull request #11518: URL: https://github.com/apache/kafka/pull/11518#issuecomment-1027974346 Thanks @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] ijuma merged pull request #11619: MINOR: allocate 2MB to offset map in connect EmbeddedKafkaCluster

2022-02-02 Thread GitBox
ijuma merged pull request #11619: URL: https://github.com/apache/kafka/pull/11619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma merged pull request #11618: KAFKA-13558: NioEchoServer fails to close resources

2022-02-02 Thread GitBox
ijuma merged pull request #11618: URL: https://github.com/apache/kafka/pull/11618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] jonathan-albrecht-ibm commented on pull request #11690: KAFKA-13599: Upgrade RocksDB to 6.27.3

2022-02-02 Thread GitBox
jonathan-albrecht-ibm commented on pull request #11690: URL: https://github.com/apache/kafka/pull/11690#issuecomment-1027990865 Thanks @cadonna! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ijuma commented on pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
ijuma commented on pull request #11721: URL: https://github.com/apache/kafka/pull/11721#issuecomment-1027997296 Thanks for the detailed analysis! Note that JMH 1.34 (https://mail.openjdk.java.net/pipermail/jmh-dev/2021-December/003406.html) has support for much cheaper blackholes if execut

[jira] [Updated] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-02 Thread Ulrik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrik updated KAFKA-13638: -- Description: I have a topology where I stream messages from an input topic, transform the message to multiple

[jira] [Commented] (KAFKA-13534) Upgrade Log4j to 2.15.0 - CVE-2021-44228

2022-02-02 Thread Fabrice Bauzac-Stehly (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485868#comment-17485868 ] Fabrice Bauzac-Stehly commented on KAFKA-13534: --- Shouldn't this ticket be

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-02 Thread Fabrice Bauzac-Stehly (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485878#comment-17485878 ] Fabrice Bauzac-Stehly commented on KAFKA-9366: -- https://kafka.apache.org/cve

[jira] [Commented] (KAFKA-13626) NullPointerException in Selector.pollSelectionKeys: channel is null

2022-02-02 Thread Kvicii.Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485879#comment-17485879 ] Kvicii.Yu commented on KAFKA-13626: --- [~haeuserd]   Thanks for your report, but what e

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-02 Thread Fabrice Bauzac-Stehly (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485878#comment-17485878 ] Fabrice Bauzac-Stehly edited comment on KAFKA-9366 at 2/2/22, 3:17 PM:

[jira] [Comment Edited] (KAFKA-9366) Upgrade log4j to log4j2

2022-02-02 Thread Fabrice Bauzac-Stehly (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485878#comment-17485878 ] Fabrice Bauzac-Stehly edited comment on KAFKA-9366 at 2/2/22, 3:17 PM:

[GitHub] [kafka] Kvicii opened a new pull request #11727: MINOR:fix AbstractStickyAssignor doc

2022-02-02 Thread GitBox
Kvicii opened a new pull request #11727: URL: https://github.com/apache/kafka/pull/11727 *More detailed description of your change, fix AbstractStickyAssignor doc ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify t

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11712: WIP: Put failed tasks to end of processing list

2022-02-02 Thread GitBox
wcarlson5 commented on a change in pull request #11712: URL: https://github.com/apache/kafka/pull/11712#discussion_r797772309 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java ## @@ -270,6 +278,23 @@ Task task(final TaskId taskId) {

[GitHub] [kafka] Indupa commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-02 Thread GitBox
Indupa commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028142767 Hi @dongjinleekr , need one input from you. Is All dependencies of log4j 1.x is completely Removed in this Patch?, I could see,still dependency on log4j_1.2.17 i

[GitHub] [kafka] Indupa edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-02 Thread GitBox
Indupa edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028142767 Hi @dongjinleekr ,I could able to build latest patch and also need one input from you. Is All dependencies of log4j 1.x is completely Removed in this Patch..

[GitHub] [kafka] Indupa edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-02 Thread GitBox
Indupa edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028142767 Hi @dongjinleekr ,I could able to build latest patch and also need one input from you. Is All dependencies of log4j 1.x is completely Removed in this Patch..

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-02 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r797845874 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java ## @@ -116,14 +123,30 @@ public T

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-02 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r797848030 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -329,7 +330,7 @@ private TopologyTestDriver(fi

[GitHub] [kafka] cmccabe commented on a change in pull request #11689: Fixed documentation and handles null topicPartition for KAFKA-12841

2022-02-02 Thread GitBox
cmccabe commented on a change in pull request #11689: URL: https://github.com/apache/kafka/pull/11689#discussion_r797873026 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -1506,6 +1508,46 @@ public void testNullTopicName() {

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486001#comment-17486001 ] Matthias J. Sax commented on KAFKA-13638: - We did update the RocksDB version in

[jira] [Created] (KAFKA-13639) NotEnoughReplicasException for __consumer_offsets topic due to out of order offset

2022-02-02 Thread Sergey Ivanov (Jira)
Sergey Ivanov created KAFKA-13639: - Summary: NotEnoughReplicasException for __consumer_offsets topic due to out of order offset Key: KAFKA-13639 URL: https://issues.apache.org/jira/browse/KAFKA-13639

[GitHub] [kafka] philipnee commented on a change in pull request #11689: Fixed documentation and handles null topicPartition for KAFKA-12841

2022-02-02 Thread GitBox
philipnee commented on a change in pull request #11689: URL: https://github.com/apache/kafka/pull/11689#discussion_r797884312 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -1506,6 +1508,46 @@ public void testNullTopicName()

[jira] [Updated] (KAFKA-13633) Merging multiple KStreams in one operation

2022-02-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13633: Labels: kip (was: ) > Merging multiple KStreams in one operation > --

[jira] [Commented] (KAFKA-13633) Merging multiple KStreams in one operation

2022-02-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486002#comment-17486002 ] Matthias J. Sax commented on KAFKA-13633: - Thanks! Will try to review the KIP so

[jira] [Commented] (KAFKA-13639) NotEnoughReplicasException for __consumer_offsets topic due to out of order offset

2022-02-02 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486005#comment-17486005 ] Sergey Ivanov commented on KAFKA-13639: --- We found mail thread which describe the s

[GitHub] [kafka] jasonk000 commented on pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
jasonk000 commented on pull request #11721: URL: https://github.com/apache/kafka/pull/11721#issuecomment-1028229086 Good spot on jmh 1.34, TIL! Here's a result from a re-run ``` jkoch@jkoch:~/code/kafka$ java -version openjdk version "17.0.1" 2021-10-19 OpenJDK Runtime Environmen

[GitHub] [kafka] jasonk000 edited a comment on pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
jasonk000 edited a comment on pull request #11721: URL: https://github.com/apache/kafka/pull/11721#issuecomment-1028229086 Good spot on jmh 1.34, TIL! Here's a result from a re-run ``` jkoch@jkoch:~/code/kafka$ java -version openjdk version "17.0.1" 2021-10-19 OpenJDK Runtime Env

[jira] [Comment Edited] (KAFKA-13639) NotEnoughReplicasException for __consumer_offsets topic due to out of order offset

2022-02-02 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486005#comment-17486005 ] Sergey Ivanov edited comment on KAFKA-13639 at 2/2/22, 6:31 PM: --

[jira] [Commented] (KAFKA-12494) Broker raise InternalError after disk sector medium error without marking dir to offline

2022-02-02 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486011#comment-17486011 ] Sergey Ivanov commented on KAFKA-12494: --- Hi all, We faced the similar issue on ou

[GitHub] [kafka] azhur closed pull request #11728: Cherrypick KAFKA-4090: Validate SSL connection in client to 3.1.x

2022-02-02 Thread GitBox
azhur closed pull request #11728: URL: https://github.com/apache/kafka/pull/11728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] guozhangwang commented on pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-02 Thread GitBox
guozhangwang commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-1028264508 @ableegoldman @mjsax My read on the code is that we only need to change the TopologyTestDriver, while the first place seems fine to me. Did I miss anything? -- This is a

[jira] [Comment Edited] (KAFKA-13639) NotEnoughReplicasException for __consumer_offsets topic due to out of order offset

2022-02-02 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486005#comment-17486005 ] Sergey Ivanov edited comment on KAFKA-13639 at 2/2/22, 7:04 PM: --

[GitHub] [kafka] cmccabe opened a new pull request #11729: MINOR: fix control plane listener + kraft error message

2022-02-02 Thread GitBox
cmccabe opened a new pull request #11729: URL: https://github.com/apache/kafka/pull/11729 The current error message suggests that controller.listener.names is a replacement for control.plane.listener.name. This is incorrect since these configurations have very different functions. Th

[GitHub] [kafka] kirktrue commented on pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-02-02 Thread GitBox
kirktrue commented on pull request #11627: URL: https://github.com/apache/kafka/pull/11627#issuecomment-1028296460 This looks pretty straightforward to me, though I'm still learning the consumer client piece. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] hachikuji merged pull request #11725: KAFKA-13221; Implement `PartitionsWithLateTransactionsCount` metric

2022-02-02 Thread GitBox
hachikuji merged pull request #11725: URL: https://github.com/apache/kafka/pull/11725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Resolved] (KAFKA-13221) Add metric for `PartitionsWithLateTransactionsCount`

2022-02-02 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13221. - Fix Version/s: 3.2.0 Resolution: Fixed > Add metric for `PartitionsWithLateTransa

[GitHub] [kafka] artemlivshits commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
artemlivshits commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r797932888 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double valu

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r798002944 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value, B

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r798002944 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value, B

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r798002944 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value, B

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-02 Thread Ulrik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486102#comment-17486102 ] Ulrik commented on KAFKA-13638: --- [~mjsax] I can confirm that using an in-memory store work

[GitHub] [kafka] ijuma commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
ijuma commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r798019651 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/ByteUtilsBenchmark.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software F

[jira] [Created] (KAFKA-13640) Implement final broker heartbeat in kraft

2022-02-02 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13640: Summary: Implement final broker heartbeat in kraft Key: KAFKA-13640 URL: https://issues.apache.org/jira/browse/KAFKA-13640 Project: Kafka Issue Type: Improve

[GitHub] [kafka] ijuma merged pull request #11656: KAFKA-13579: upgrade netty/jetty/jackson to avoid vulnerability

2022-02-02 Thread GitBox
ijuma merged pull request #11656: URL: https://github.com/apache/kafka/pull/11656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r798077165 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/ByteUtilsBenchmark.java ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [kafka] artemlivshits commented on a change in pull request #11721: KAFKA-13629: use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-02 Thread GitBox
artemlivshits commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r798094178 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double valu

[GitHub] [kafka] cmccabe commented on pull request #11689: Fixed documentation and handles null topicPartition for KAFKA-12841

2022-02-02 Thread GitBox
cmccabe commented on pull request #11689: URL: https://github.com/apache/kafka/pull/11689#issuecomment-1028467009 test failures are not related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] cmccabe merged pull request #11689: Fixed documentation and handles null topicPartition for KAFKA-12841

2022-02-02 Thread GitBox
cmccabe merged pull request #11689: URL: https://github.com/apache/kafka/pull/11689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486177#comment-17486177 ] Matthias J. Sax commented on KAFKA-13638: - Seems this does not explain much yet,

[GitHub] [kafka] mjsax commented on pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-02-02 Thread GitBox
mjsax commented on pull request #11424: URL: https://github.com/apache/kafka/pull/11424#issuecomment-1028497889 I did not dig into the details myself. Anyway, might be better to discuss on the new PR? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] stan-confluent opened a new pull request #11730: Use ducktape version 0.7.17

2022-02-02 Thread GitBox
stan-confluent opened a new pull request #11730: URL: https://github.com/apache/kafka/pull/11730 Ducktape 0.7.17 locked a couple of dependencies to their last py2 compatible versions - this ensures more or less stable python 2 builds for kafkatest (until some other package breaks it). S

[GitHub] [kafka] stan-confluent commented on pull request #11730: Use ducktape version 0.7.17

2022-02-02 Thread GitBox
stan-confluent commented on pull request #11730: URL: https://github.com/apache/kafka/pull/11730#issuecomment-102874 @cmccabe @ijuma @ewencp can you folks please take a look and/or suggest who else should be on the approvers list? -- This is an automated message from the Apache Git S

[GitHub] [kafka] dengziming commented on a change in pull request #11726: KAFKA-13637: Use default.api.timeout.ms as default timeout value for KafkaConsumer.endOffsets

2022-02-02 Thread GitBox
dengziming commented on a change in pull request #11726: URL: https://github.com/apache/kafka/pull/11726#discussion_r798204734 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2948,6 +2948,64 @@ public void testAssignorNameCon

[GitHub] [kafka] dengziming commented on a change in pull request #11726: KAFKA-13637: Use default.api.timeout.ms as default timeout value for KafkaConsumer.endOffsets

2022-02-02 Thread GitBox
dengziming commented on a change in pull request #11726: URL: https://github.com/apache/kafka/pull/11726#discussion_r798205426 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2948,6 +2948,64 @@ public void testAssignorNameCon

[GitHub] [kafka] Indupa edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-02-02 Thread GitBox
Indupa edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1028142767 Hi @dongjinleekr ,I could able to build latest patch and also need one input from you. Is All dependencies of log4j 1.x is completely Removed in this Patch..

[jira] [Created] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-02 Thread Mohammad Yousuf Minhaj Zia (Jira)
Mohammad Yousuf Minhaj Zia created KAFKA-13641: -- Summary: Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters Key: KAFKA-13641 URL: https://issues.apache.org/jira/browse/KAFKA-13641

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-02 Thread Ulrik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486257#comment-17486257 ] Ulrik commented on KAFKA-13638: --- I tried the following combination of versions: * strea