[jira] [Commented] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472542#comment-17472542 ] Seungchan Ahn commented on KAFKA-13217: --- [~ableegoldman] [~guozhang] Hello, can I

[jira] [Comment Edited] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472542#comment-17472542 ] Seungchan Ahn edited comment on KAFKA-13217 at 1/11/22, 8:23 AM: -

[GitHub] [kafka] ableegoldman commented on a change in pull request #11600: KAFKA-12648: handle MissingSourceTopicException for named topologies

ableegoldman commented on a change in pull request #11600: URL: https://github.com/apache/kafka/pull/11600#discussion_r781948695 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -380,15 +380,37 @@ public Group

[GitHub] [kafka] dajac commented on a change in pull request #11566: KAFKA-13495: add reason to JoinGroupRequest

dajac commented on a change in pull request #11566: URL: https://github.com/apache/kafka/pull/11566#discussion_r781968801 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1690,6 +1690,7 @@ class KafkaApis(val requestChannel: RequestChannel, joinGro

[GitHub] [kafka] dajac commented on a change in pull request #11571: KAFKA-13496: add reason to LeaveGroupRequest

dajac commented on a change in pull request #11571: URL: https://github.com/apache/kafka/pull/11571#discussion_r782071080 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3907,6 +3909,44 @@ public void testRemoveMembersFromGro

[jira] [Assigned] (KAFKA-13585) Fix `kafka.server.ReplicaManagerTest.testReplicaAlterLogDirsWithAndWithoutIds` flaky test

[ https://issues.apache.org/jira/browse/KAFKA-13585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-13585: --- Assignee: David Jacot > Fix > `kafka.server.ReplicaManagerTest.testReplicaAlterLogDirsWith

[jira] [Updated] (KAFKA-13585) Fix `kafka.server.ReplicaManagerTest.testReplicaAlterLogDirsWithAndWithoutIds` flaky test

[ https://issues.apache.org/jira/browse/KAFKA-13585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13585: Priority: Minor (was: Major) > Fix > `kafka.server.ReplicaManagerTest.testReplicaAlterLogDirsWit

[GitHub] [kafka] YeonCheolGit closed pull request #11660: MINOR: fix comment in ClusterConnectionStates

YeonCheolGit closed pull request #11660: URL: https://github.com/apache/kafka/pull/11660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] YeonCheolGit commented on a change in pull request #11660: MINOR: fix comment in ClusterConnectionStates

YeonCheolGit commented on a change in pull request #11660: URL: https://github.com/apache/kafka/pull/11660#discussion_r782195849 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -68,7 +68,7 @@ public ClusterConnectionStates(long r

[GitHub] [kafka] ableegoldman commented on a change in pull request #11600: KAFKA-12648: handle MissingSourceTopicException for named topologies

ableegoldman commented on a change in pull request #11600: URL: https://github.com/apache/kafka/pull/11600#discussion_r781814872 ## File path: checkstyle/suppressions.xml ## @@ -158,7 +158,7 @@ files="(KafkaStreams|KStreamImpl|KTableImpl|InternalTopologyBuilder|

[GitHub] [kafka] ableegoldman commented on a change in pull request #11600: KAFKA-12648: handle MissingSourceTopicException for named topologies

ableegoldman commented on a change in pull request #11600: URL: https://github.com/apache/kafka/pull/11600#discussion_r782209624 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -380,15 +380,37 @@ public Group

[GitHub] [kafka] ableegoldman commented on a change in pull request #11600: KAFKA-12648: handle MissingSourceTopicException for named topologies

ableegoldman commented on a change in pull request #11600: URL: https://github.com/apache/kafka/pull/11600#discussion_r782215325 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -380,15 +380,37 @@ public Group

[jira] [Created] (KAFKA-13591) Fix flaky test ControllerIntegrationTest.testTopicIdCreatedOnUpgrade

David Jacot created KAFKA-13591: --- Summary: Fix flaky test ControllerIntegrationTest.testTopicIdCreatedOnUpgrade Key: KAFKA-13591 URL: https://issues.apache.org/jira/browse/KAFKA-13591 Project: Kafka

[GitHub] [kafka] dajac opened a new pull request #11665: KAFKA-13585; Fix flaky test `ReplicaManagerTest.testReplicaAlterLogDirsWithAndWithoutIds`

dajac opened a new pull request #11665: URL: https://github.com/apache/kafka/pull/11665 `ReplicaManagerTest.testReplicaAlterLogDirsWithAndWithoutIds` fails regularly because `assertFetcherHasTopicId` can't validate the topic id in the fetch state. The issue is quite subtile. Under the hood

[GitHub] [kafka] dajac opened a new pull request #11666: KAFKA-13591; Fix flaky test `ControllerIntegrationTest.testTopicIdCreatedOnUpgrade`

dajac opened a new pull request #11666: URL: https://github.com/apache/kafka/pull/11666 The issue is that when `zkClient.getTopicIdsForTopics(Set(tp.topic)).get(tp.topic)` is called after the new controller is brought up, there is not guarantee that the controller has already written the

[GitHub] [kafka] nicktelford commented on pull request #11610: KAFKA-13549: Add min.repartition.purge.interval.ms

nicktelford commented on pull request #11610: URL: https://github.com/apache/kafka/pull/11610#issuecomment-1010106545 KIP available at: https://cwiki.apache.org/confluence/display/KAFKA/KIP-811%3A+Add+separate+min.repartition.purge.interval.ms+to+Kafka+Streams The commit and PR descr

[GitHub] [kafka] C0urante commented on a change in pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified

C0urante commented on a change in pull request #11615: URL: https://github.com/apache/kafka/pull/11615#discussion_r782322703 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceConnectorConfigTest.java ## @@ -64,6 +67,18 @@ return props;

[GitHub] [kafka] C0urante commented on a change in pull request #11615: KAFKA-13546: Do not fail connector if default topic creation group is explicitly specified

C0urante commented on a change in pull request #11615: URL: https://github.com/apache/kafka/pull/11615#discussion_r782322703 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SourceConnectorConfigTest.java ## @@ -64,6 +67,18 @@ return props;

[jira] [Assigned] (KAFKA-13591) Fix flaky test ControllerIntegrationTest.testTopicIdCreatedOnUpgrade

[ https://issues.apache.org/jira/browse/KAFKA-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-13591: --- Assignee: David Jacot > Fix flaky test ControllerIntegrationTest.testTopicIdCreatedOnUpgrad

[GitHub] [kafka] diegoazevedo commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

diegoazevedo commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1010167705 @vlsi the problem is that version 1.* is deprecated since 2015. Details: https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces The vu

[GitHub] [kafka] vlsi commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

vlsi commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1010208088 > problem is that version 1.* is deprecated since 2015 @diegoazevedo , let me explain: if there are people willing to support log4j 1.x, then it could be supported and maintai

[GitHub] [kafka] jolshan commented on pull request #11665: KAFKA-13585; Fix flaky test `ReplicaManagerTest.testReplicaAlterLogDirsWithAndWithoutIds`

jolshan commented on pull request #11665: URL: https://github.com/apache/kafka/pull/11665#issuecomment-1010212921 Is this test useful if we can't verify the topic ID? I think we have a similar one that doesn't check topic ID? -- This is an automated message from the Apache Git Service. T

[GitHub] [kafka] dajac commented on pull request #11665: KAFKA-13585; Fix flaky test `ReplicaManagerTest.testReplicaAlterLogDirsWithAndWithoutIds`

dajac commented on pull request #11665: URL: https://github.com/apache/kafka/pull/11665#issuecomment-1010214440 > Is this test useful if we can't verify the topic ID? I think we have a similar one that doesn't check topic ID? Do we? I haven't found it... -- This is an automated me

[GitHub] [kafka] jolshan commented on pull request #11665: KAFKA-13585; Fix flaky test `ReplicaManagerTest.testReplicaAlterLogDirsWithAndWithoutIds`

jolshan commented on pull request #11665: URL: https://github.com/apache/kafka/pull/11665#issuecomment-1010224534 Strange -- I might be misremembering because I can't seem to find it either. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vlsi edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

vlsi edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1010208088 > problem is that version 1.* is deprecated since 2015 @diegoazevedo , let me explain: if there are people willing to support log4j 1.x, then it could be supported and

[jira] [Commented] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473149#comment-17473149 ] Matthias J. Sax commented on KAFKA-13289: - {quote}The app uses a 0ms join window

[GitHub] [kafka] rondagostino commented on a change in pull request #11606: MINOR: Add shutdown tests for KRaft

rondagostino commented on a change in pull request #11606: URL: https://github.com/apache/kafka/pull/11606#discussion_r782538135 ## File path: core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala ## @@ -196,14 +199,16 @@ abstract class QuorumTestHarness extends

[GitHub] [kafka] rondagostino commented on a change in pull request #11606: MINOR: Add shutdown tests for KRaft

rondagostino commented on a change in pull request #11606: URL: https://github.com/apache/kafka/pull/11606#discussion_r782539950 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -253,4 +248,32 @@ abstract class KafkaServerTestHarness

[jira] [Assigned] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seungchan Ahn reassigned KAFKA-13217: - Assignee: Seungchan Ahn > Reconsider skipping the LeaveGroup on close() or add an overl

[jira] [Comment Edited] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472542#comment-17472542 ] Seungchan Ahn edited comment on KAFKA-13217 at 1/12/22, 12:23 AM:

[jira] [Comment Edited] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472542#comment-17472542 ] Seungchan Ahn edited comment on KAFKA-13217 at 1/12/22, 12:24 AM:

[jira] [Commented] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473235#comment-17473235 ] Eugen Dück commented on KAFKA-13289: {quote} bq. The app uses a 0ms join window with

[GitHub] [kafka] dengziming opened a new pull request #11667: MINOR; Enable Kraft in ApiVersionTest

dengziming opened a new pull request #11667: URL: https://github.com/apache/kafka/pull/11667 *More detailed description of your change* 1. Replace ClusterTestExtensions with QuorumTestHarness 2. Enable Kraft in ApiVersionTest *Summary of testing strategy (including rationale)*

[jira] [Updated] (KAFKA-13242) KRaft Controller doesn't handle UpdateFeaturesRequest

[ https://issues.apache.org/jira/browse/KAFKA-13242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-13242: --- Parent: KAFKA-13410 Issue Type: Sub-task (was: Bug) > KRaft Controller doesn't handle Updat

[GitHub] [kafka] jsancio opened a new pull request #11668: MINOR: Update KRaft controller's event processing time

jsancio opened a new pull request #11668: URL: https://github.com/apache/kafka/pull/11668 Make sure that the event queue processing time histogram gets updated and add tests that verify that the update methods modify the correct histogram. ### Committer Checklist (excluded from

[jira] [Comment Edited] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473235#comment-17473235 ] Eugen Dück edited comment on KAFKA-13289 at 1/12/22, 3:04 AM:

[GitHub] [kafka] cmccabe commented on pull request #11668: MINOR: Update KRaft controller's event processing time

cmccabe commented on pull request #11668: URL: https://github.com/apache/kafka/pull/11668#issuecomment-1010658277 Test failures are not related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] cmccabe merged pull request #11668: MINOR: Fix confusion between EventQueueProcessingTimeMs and EventQueueTimeMs

cmccabe merged pull request #11668: URL: https://github.com/apache/kafka/pull/11668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] lmr3796 opened a new pull request #11669: MINOR: Replace if/else with match in KafkaZkClient#getPartitionAssignmentForTopics

lmr3796 opened a new pull request #11669: URL: https://github.com/apache/kafka/pull/11669 The patch apache#4196 (commit f300480f) replaced the if/else with case match in `KafkaZkClient`. The method`getPartitionAssignmentForTopics` seems to be missed in the patch, while similar ones like

[GitHub] [kafka] lmr3796 commented on pull request #11669: MINOR: Replace if/else with match in KafkaZkClient#getPartitionAssignmentForTopics

lmr3796 commented on pull request #11669: URL: https://github.com/apache/kafka/pull/11669#issuecomment-1010717423 Hi @ijuma this serves as a follow-up on #4196. I saw you reviewed that PR and wondering if you can also review this one. -- This is an automated message from the Apache