GOODBOY008 commented on pull request #11644:
URL: https://github.com/apache/kafka/pull/11644#issuecomment-1004601251
@ewencp Please cc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
mimaison commented on a change in pull request #11642:
URL: https://github.com/apache/kafka/pull/11642#discussion_r777904250
##
File path: docs/connect.html
##
@@ -41,7 +41,7 @@ Running
Kafka ConnectIn standalone mode all work is performed in a single process. This
configurat
richard-axual commented on a change in pull request #11535:
URL: https://github.com/apache/kafka/pull/11535#discussion_r777961628
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -1097,15 +1097,20 @@ long decodeTimestamp(fi
mimaison merged pull request #11564:
URL: https://github.com/apache/kafka/pull/11564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
showuon opened a new pull request #11647:
URL: https://github.com/apache/kafka/pull/11647
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
mdshadabin commented on pull request #10056:
URL: https://github.com/apache/kafka/pull/10056#issuecomment-1004827722
>
i still see issue with kafka 2.8.0
few days back i have downloaded kafka 2.8.0 source code (from
https://kafka.apache.org/downloads ) and build binaries (f
lhunyady commented on pull request #11333:
URL: https://github.com/apache/kafka/pull/11333#issuecomment-1004848659
Thank you @C0urante, I have updated the pull request with your valuable
suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-13574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468697#comment-17468697
]
Kyle Kingsbury commented on KAFKA-13574:
> NOT_LEADER_OR_FOLLOWER is considered
liuchang0520 commented on pull request #11641:
URL: https://github.com/apache/kafka/pull/11641#issuecomment-1004972135
Hi @showuon , can you help me to merge this PR? I don't have write access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on a change in pull request #11609:
URL: https://github.com/apache/kafka/pull/11609#discussion_r778297858
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java
##
@@ -296,9 +297,10 @@ private boolean h
guozhangwang commented on a change in pull request #11624:
URL: https://github.com/apache/kafka/pull/11624#discussion_r778303747
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java
##
@@ -365,109 +395,200 @@ public void before
guozhangwang commented on pull request #11624:
URL: https://github.com/apache/kafka/pull/11624#issuecomment-1005074050
Hey @vvcephei , please feel free to merge after addressed the comments and
resolved conflicts.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468879#comment-17468879
]
Matthias J. Sax commented on KAFKA-13289:
-
{quote}However in the cases mentioned
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468912#comment-17468912
]
Eugen Dück commented on KAFKA-13289:
[~mjsax]
I tried setting `max.task.idle.ms` li
guozhangwang commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1005247992
Thanks @vamossagar12 , I do not have further comments now, re-triggering the
jenkins tests.
--
This is an automated message from the Apache Git Service.
To respond to th
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468913#comment-17468913
]
Eugen Dück commented on KAFKA-13289:
[~mjsax]
I just retried with confluentinc/cp-
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468912#comment-17468912
]
Eugen Dück edited comment on KAFKA-13289 at 1/4/22, 11:34 PM:
vvcephei commented on a change in pull request #11624:
URL: https://github.com/apache/kafka/pull/11624#discussion_r778456441
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java
##
@@ -365,109 +395,200 @@ public void beforeTest
vvcephei commented on pull request #11624:
URL: https://github.com/apache/kafka/pull/11624#issuecomment-1005250957
Thanks, @guozhangwang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
guozhangwang commented on pull request #11460:
URL: https://github.com/apache/kafka/pull/11460#issuecomment-1005257929
Thanks @RivenSun2 for the improvement and @showuon for the reviews, LGTM to
clarify it.
--
This is an automated message from the Apache Git Service.
To respond to the me
guozhangwang merged pull request #11460:
URL: https://github.com/apache/kafka/pull/11460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
guozhangwang commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1005259979
@vamossagar12 there are some compilation errors in jenkins, could you rebase
from latest trunk and check what's the issue? Please ping me once that's
resolved.
--
This
ccding commented on pull request #11641:
URL: https://github.com/apache/kafka/pull/11641#issuecomment-1005331649
cc @junrao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-13570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468965#comment-17468965
]
dengziming commented on KAFKA-13570:
I don't think it's a simple problem for a Serv
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468913#comment-17468913
]
Eugen Dück edited comment on KAFKA-13289 at 1/5/22, 2:38 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469004#comment-17469004
]
Luke Chen commented on KAFKA-13563:
---
[~guozhang] [~ableegoldman], you might want to ch
[
https://issues.apache.org/jira/browse/KAFKA-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13563:
--
Affects Version/s: 3.0.0
2.7.1
> FindCoordinatorFuture never get cleared in non
vamossagar12 commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1005361882
@guozhangwang , it's due to the usage of deprecated configs and gradle
having a check against it.
```
[2022-01-04T23:35:30.575Z]
/home/jenkins/jenkins-agent/work
mjsax opened a new pull request #11648:
URL: https://github.com/apache/kafka/pull/11648
MockAdminClient should add `default.replication.factor` to the config of
each node. Otherwise, `describeConfigs()` does not return the default
replication factor correctly.
--
This is an automated me
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469010#comment-17469010
]
Matthias J. Sax commented on KAFKA-13289:
-
You can reproduce with the code in th
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469016#comment-17469016
]
Eugen Dück commented on KAFKA-13289:
Yes, if you use Matthew's repo, which gives the
guozhangwang commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1005381382
@vamossagar12 Note that `TopologyConfig` is an internal class for now, and
hence should not use deprecated values, I think we need to update this class to
directly use the
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469016#comment-17469016
]
Eugen Dück edited comment on KAFKA-13289 at 1/5/22, 4:53 AM:
-
guozhangwang commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-1005381862
Retriggering jenkins tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guozhangwang commented on a change in pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#discussion_r778549345
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -517,15 +517,13 @@ public boolean pol
[
https://issues.apache.org/jira/browse/KAFKA-13563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469023#comment-17469023
]
Guozhang Wang commented on KAFKA-13563:
---
Hi [~showuon] thanks for the report, I've
guozhangwang commented on pull request #11627:
URL: https://github.com/apache/kafka/pull/11627#issuecomment-1005389524
Thanks @showuon , I've made a quick pass and it looks promising to me. I'm
pinging @dajac and @kirktrue who would be the best reviewers for this.
--
This is an automated
showuon commented on pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#issuecomment-1005407357
@guozhangwang , answer your question below:
> I'm wondering if this fix is a bit overkill, e.g. for those consumers who
do not even set the group ID and do not rely on th
showuon edited a comment on pull request #11631:
URL: https://github.com/apache/kafka/pull/11631#issuecomment-1005407357
@guozhangwang , thanks for your comment. Answering your question below:
> I'm wondering if this fix is a bit overkill, e.g. for those consumers who
do not even set
[
https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
RivenSun updated KAFKA-13422:
-
Reviewer: Guozhang Wang (was: Luke Chen)
> Even if the correct username and password are configured, wh
[
https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469084#comment-17469084
]
RivenSun commented on KAFKA-13422:
--
Hi [~guozhang] [~rsivaram] [~ijuma]
I think this
41 matches
Mail list logo
