[GitHub] [kafka] showuon opened a new pull request #11596: MINOR: bump version in kraft readme

2021-12-12 Thread GitBox
showuon opened a new pull request #11596: URL: https://github.com/apache/kafka/pull/11596 Bump the version from 3.0 to 3.1 in kraft readme, since we are basically have the same state in v3.0 and v3.1. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] showuon commented on pull request #11596: MINOR: bump version in kraft readme

2021-12-12 Thread GitBox
showuon commented on pull request #11596: URL: https://github.com/apache/kafka/pull/11596#issuecomment-991854298 @dajac , please take a look. This should be merged for V3.1.0 release. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] vinayakshukre commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-12-12 Thread GitBox
vinayakshukre commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-991894590 @dongjinleekr you must be already aware about the new log4j zero day vulnerability with log4j 2.14.1 versions and below that. Hope when you are done with this merge, you wi

[GitHub] [kafka] vinayakshukre edited a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-12-12 Thread GitBox
vinayakshukre edited a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-991894590 @dongjinleekr you must be already aware about the new log4j zero day vulnerability with log4j 2.14.1 versions and below that. Hope when you will be done with this me

[GitHub] [kafka] cwtrex commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991924921 I am confused by this statement: "that KIP hasn't been created" KIP 678? https://cwiki.apache.org/confluence/display/KAFKA/KIP+678%3A+New+Kafka+Connect+SMT+for+plainText+%3D%3E+

[GitHub] [kafka] OneCricketeer commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
OneCricketeer commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991925594 > it puts a timestamp in front of the object If that's the case, I don't think this specific transform will help as it'd make a Struct wrapper around the extracted js

[GitHub] [kafka] OneCricketeer edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
OneCricketeer edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991925594 > it puts a timestamp in front of the object If that's the case, I don't think this specific transform will help as it'd make a Struct wrapper around the extra

[GitHub] [kafka] cwtrex commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991926328 @OneCricketeer I was reading the above solution as the following: transforms.RegexTransform.regex": "transforms.RegexTransform.mapping": "timestamp,existingjson" struct {"

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991926328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991926328 @OneCricketeer I was reading the above solution as the following: >transforms.RegexTransform.regex": ,"existingjson":{json object here}} > My recommendation inst

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991926328 @OneCricketeer I was reading the above solution as the following: >transforms.RegexTransform.regex": `,"existingjson":{json object here}} > My recommendation ins

[GitHub] [kafka] OneCricketeer commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
OneCricketeer commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991928166 Well, Kafka record have their own timestamps since version 0.10.2, so they shouldn't need to be part of the record string... > no idea how or where to begin with that

[GitHub] [kafka] OneCricketeer edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
OneCricketeer edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991928166 Well, Kafka record have their own timestamps since version 0.10.2, so they shouldn't need to be part of the record string... > no idea how or where to begin wi

[GitHub] [kafka] cwtrex commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991930581 > In the consumer config, set `value.deserializer` to `MyDeserializer.class` > In your poll loop, accept strings and use a JSON library to further process the record I'm utili

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991930581 > In the consumer config, set `value.deserializer` to `MyDeserializer.class` > In your poll loop, accept strings and use a JSON library to further process the record

[GitHub] [kafka] OneCricketeer commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
OneCricketeer commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991931167 The class provided needs to be part of consumer code and must be `value.deserializer` not the Connect API since it's not a converter. You said you're consuming strings, not

[GitHub] [kafka] cwtrex commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 >You said you're consuming strings While I am consuming strings initially, it is the intention to have it as proper JSON before it arrives in Kafka. The full solution is: app

[jira] [Assigned] (KAFKA-13388) Kafka Producer nodes stuck in CHECKING_API_VERSIONS

2021-12-12 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-13388: --- Assignee: David Jacot > Kafka Producer nodes stuck in CHECKING_API_VERSIONS > -

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 >You said you're consuming strings While I am consuming strings initially, it is the intention to have it as proper JSON before it arrives in Kafka. The full solution

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 >You said you're consuming strings While I am consuming strings initially, it is the intention to have it as proper JSON before it arrives in Kafka. The full solution

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 >You said you're consuming strings While I am consuming strings initially, it is the intention to have it as proper JSON before it arrives in Kafka. The full solution

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 >You said you're consuming strings While I am consuming strings initially, it is the intention to have it as proper JSON before it arrives in Kafka. The full solution

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 >You said you're consuming strings While I am consuming strings initially, it is the intention to have it as proper JSON before it arrives in Kafka. The full solution

[GitHub] [kafka] OneCricketeer commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
OneCricketeer commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991934558 > a custom value.converter may work. https://www.confluent.io/blog/kafka-connect-single-message-transformation-tutorial-with-examples/ -- This is an automated mess

[GitHub] [kafka] OneCricketeer edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
OneCricketeer edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991934558 > a custom value.converter may work. Or a transform https://www.confluent.io/blog/kafka-connect-single-message-transformation-tutorial-with-examples/

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [kafka] cwtrex commented on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991935635 > > a custom value.converter may work. > > Or a transform Correct. To be clear, this was the first thought before you suggesting deserializer. This SMT is the only tr

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991935635 > > a custom value.converter may work. > > Or a transform Correct. To be clear, this was the first thought before you suggesting deserializer. This SMT is the

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991935635 > > a custom value.converter may work. > > Or a transform Correct. To be clear, this was the first thought before you suggesting deserializer. This SMT is the

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991935635 > > a custom value.converter may work. > > Or a transform Correct. To be clear, this was the first thought before you suggested a deserializer. This SMT is the

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 >You said you're consuming strings While I am consuming strings initially, it is the intention to have it as proper JSON before it arrives in Kafka. The full soluti

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991932149 >You said you're consuming strings While I am consuming strings initially, it is the intention to have it as proper JSON before it arrives in Kafka. The full soluti

[jira] [Commented] (KAFKA-13535) Workaround for mitigating CVE-2021-44228 Kafka

2021-12-12 Thread Akansh Shandilya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458016#comment-17458016 ] Akansh Shandilya commented on KAFKA-13535: -- Hi [~showuon],   But as long as y

[GitHub] [kafka] vamossagar12 commented on pull request #11592: KAFKA-13501: Avoid state restore via rebalance if standbys are enabled

2021-12-12 Thread GitBox
vamossagar12 commented on pull request #11592: URL: https://github.com/apache/kafka/pull/11592#issuecomment-991944723 @mjsax , plz review whenever you get the chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-12-12 Thread GitBox
vamossagar12 commented on a change in pull request #11424: URL: https://github.com/apache/kafka/pull/11424#discussion_r767309474 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java ## @@ -128,6 +131,22 @@ public static Sens

[GitHub] [kafka] vamossagar12 commented on pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-12-12 Thread GitBox
vamossagar12 commented on pull request #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-991945882 > @mjsax @ableegoldman could you chime in here? @guozhangwang could we also decide upon the next steps here? -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] cwtrex edited a comment on pull request #7965: KAFKA-9436: New Kafka Connect SMT for plainText => Struct(or Map)

2021-12-12 Thread GitBox
cwtrex edited a comment on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-991924921 I am confused by this statement: "that KIP hasn't been created" KIP 678? https://cwiki.apache.org/confluence/display/KAFKA/KIP+678%3A+New+Kafka+Connect+SMT+for+plainText+

[jira] [Commented] (KAFKA-13247) Adding functionality for loading private key entry by alias from the keystore

2021-12-12 Thread Tigran Margaryan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458023#comment-17458023 ] Tigran Margaryan commented on KAFKA-13247: -- Frankly speaking, disagree here as

[GitHub] [kafka] vvcephei commented on a change in pull request #11582: KAFKA-13525: Implement KeyQuery in Streams IQv2

2021-12-12 Thread GitBox
vvcephei commented on a change in pull request #11582: URL: https://github.com/apache/kafka/pull/11582#discussion_r767312544 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -186,6 +203,68 @@ public boolean setFlushLi

[jira] [Created] (KAFKA-13538) Unexpected TopicExistsException related to Admin#createTopics after broker crash

2021-12-12 Thread Haoze Wu (Jira)
Haoze Wu created KAFKA-13538: Summary: Unexpected TopicExistsException related to Admin#createTopics after broker crash Key: KAFKA-13538 URL: https://issues.apache.org/jira/browse/KAFKA-13538 Project: Kaf

[jira] [Updated] (KAFKA-13538) Unexpected TopicExistsException related to Admin#createTopics after broker crash

2021-12-12 Thread Haoze Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated KAFKA-13538: - Attachment: Screenshot from 2021-12-12 16-33-11.png Screenshot from 2021-12-12 16-33-06

[jira] [Updated] (KAFKA-13538) Unexpected TopicExistsException related to Admin#createTopics after broker crash

2021-12-12 Thread Haoze Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated KAFKA-13538: - Attachment: Screenshot from 2021-12-12 16-34-25.png Description: We were using the official Kafka J

[jira] [Updated] (KAFKA-13538) Unexpected TopicExistsException related to Admin#createTopics after broker crash

2021-12-12 Thread Haoze Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated KAFKA-13538: - Attachment: (was: Screenshot from 2021-12-12 16-33-11.png) > Unexpected TopicExistsException related

[jira] [Updated] (KAFKA-13538) Unexpected TopicExistsException related to Admin#createTopics after broker crash

2021-12-12 Thread Haoze Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated KAFKA-13538: - Attachment: (was: Screenshot from 2021-12-12 16-33-06.png) > Unexpected TopicExistsException related

[jira] [Updated] (KAFKA-13538) Unexpected TopicExistsException related to Admin#createTopics after broker crash

2021-12-12 Thread Haoze Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated KAFKA-13538: - Attachment: Screenshot from 2021-12-12 21-17-04.png Screenshot from 2021-12-12 21-16-56

[jira] [Updated] (KAFKA-13538) Unexpected TopicExistsException related to Admin#createTopics after broker crash

2021-12-12 Thread Haoze Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated KAFKA-13538: - Attachment: (was: Screenshot from 2021-12-12 16-34-25.png) > Unexpected TopicExistsException related

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767417471 ## File path: .gitignore ## @@ -56,3 +56,5 @@ jmh-benchmarks/src/main/generated raft/.jqwik-database **/src/generated **/src/generated-test + +storage/

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767425395 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ChildFirstClassLoader.java ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767426396 ## File path: core/src/main/scala/kafka/log/UnifiedLog.scala ## @@ -288,13 +292,21 @@ class UnifiedLog(@volatile var logStartOffset: Long, @volatile

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767427042 ## File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767427379 ## File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767427546 ## File path: core/src/main/scala/kafka/log/remote/RemoteLogManager.scala ## @@ -0,0 +1,287 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767427717 ## File path: core/src/main/scala/kafka/log/remote/RemoteLogManager.scala ## @@ -0,0 +1,287 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767428241 ## File path: core/src/main/scala/kafka/log/remote/RemoteLogManager.scala ## @@ -0,0 +1,287 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767428501 ## File path: core/src/main/scala/kafka/log/remote/RemoteLogManager.scala ## @@ -0,0 +1,287 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767428782 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -504,6 +504,12 @@ class ProducerStateManager(val topicPartition: TopicPartit

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767430230 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String, } /**

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767430483 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String, } /**

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767434452 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String, } /**

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767435783 ## File path: core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala ## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2021-12-12 Thread GitBox
satishd commented on a change in pull request #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r767430230 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -386,11 +396,76 @@ class ReplicaFetcherThread(name: String, } /**