ableegoldman commented on a change in pull request #11584:
URL: https://github.com/apache/kafka/pull/11584#discussion_r765559208
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -288,7 +288,7 @@ private Exception in
mimaison commented on pull request #11575:
URL: https://github.com/apache/kafka/pull/11575#issuecomment-989705328
Hi @twobeeb, thanks for the PR, this looks like a useful addition. However
as this is adding a new configuration, this change requires a KIP before we can
accept it.
Take a
showuon commented on a change in pull request #11584:
URL: https://github.com/apache/kafka/pull/11584#discussion_r765638758
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##
@@ -288,7 +288,7 @@ private Exception invokeO
vpapavas opened a new pull request #11585:
URL: https://github.com/apache/kafka/pull/11585
Clean up some minor things that were left over from PR
https://github.com/apache/kafka/pull/11513
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implement
[
https://issues.apache.org/jira/browse/KAFKA-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456308#comment-17456308
]
Gonzalo Muñoz Fernández commented on KAFKA-10503:
-
[~dhunziker] yes, if
Mickael Maison created KAFKA-13527:
--
Summary: Add top-level error code field to DescribeLogDirsResponse
Key: KAFKA-13527
URL: https://issues.apache.org/jira/browse/KAFKA-13527
Project: Kafka
ableegoldman merged pull request #11562:
URL: https://github.com/apache/kafka/pull/11562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
tombentley commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r765722507
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -1269,24 +909,656 @@ public void
testDeletableTop
tombentley commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r765726907
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -1269,24 +909,656 @@ public void
testDeletableTop
tombentley commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r765733569
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -1098,7 +741,7 @@ public void testJoinGroupRequest
showuon commented on pull request #11408:
URL: https://github.com/apache/kafka/pull/11408#issuecomment-989817483
@hachikuji @mimaison , could you help check this 1 line change PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cadonna commented on pull request #11561:
URL: https://github.com/apache/kafka/pull/11561#issuecomment-989818400
Cherry-picked to 3.1 \cc @dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cadonna commented on pull request #11561:
URL: https://github.com/apache/kafka/pull/11561#issuecomment-989822040
Cherry-picked to 3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjinleekr opened a new pull request #11586:
URL: https://github.com/apache/kafka/pull/11586
Here is the fix. The core of this approach is using a `ConcurrentHashMap` to
manage connection ids and their corresponding sensors.
### Committer Checklist (excluded from commit message)
[
https://issues.apache.org/jira/browse/KAFKA-13516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee reassigned KAFKA-13516:
---
Assignee: Dongjin Lee
> Connection level metrics are not closed
> -
[
https://issues.apache.org/jira/browse/KAFKA-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-9837:
---
Fix Version/s: 3.2.0
(was: 2.9)
> New RPC for notifying controller of failed r
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r765806468
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1959,10 +1969,28 @@ class KafkaConfig private(doLog: Boolean, val props:
jav
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-989875505
Java 8 and Java 11 passed
Java 17 failure unrelated -
`org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveNamedTopologyToRunningApplicationWithM
patrickstuedi commented on a change in pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#discussion_r765750361
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java
##
@@ -62,4 +71,32 @@ public static void updatePo
patrickstuedi commented on pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#issuecomment-989876770
Looks good, thanks John!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
mimaison merged pull request #11450:
URL: https://github.com/apache/kafka/pull/11450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
mimaison commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r765828093
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -1269,24 +909,656 @@ public void
testDeletableTopic
mimaison commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r765833040
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -247,403 +280,123 @@
import static org.junit.jupite
cadonna opened a new pull request #11587:
URL: https://github.com/apache/kafka/pull/11587
grgit 4.1.0 caused the following error with gradle
> Could not resolve all artifacts for configuration ':classpath'.
> Could not resolve org.eclipse.jgit:org.eclipse.jgit:latest.release.
cadonna commented on pull request #11587:
URL: https://github.com/apache/kafka/pull/11587#issuecomment-989908970
Call for review: @ijuma @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
cadonna commented on pull request #11587:
URL: https://github.com/apache/kafka/pull/11587#issuecomment-989909719
I opened this PR instead of cherry-picking
https://github.com/apache/kafka/pull/11561 since the issue is a bit different
on 2.8.
--
This is an automated message from the Apac
mimaison commented on pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#issuecomment-989911761
> A lot (may be all) of the `create*()` methods could be static. Perhaps
that would allow factoring some of the RPC-specific tests into their own
classes which would make this
[
https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reassigned KAFKA-10199:
-
Assignee: Bruno Cadonna (was: Guozhang Wang)
> Separate state restoration into separat
[
https://issues.apache.org/jira/browse/KAFKA-13500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456480#comment-17456480
]
Bruno Cadonna commented on KAFKA-13500:
---
I am planning to maintain also the standb
bbejeck merged pull request #11573:
URL: https://github.com/apache/kafka/pull/11573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-989915792
merged #11573 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
bbejeck commented on pull request #11573:
URL: https://github.com/apache/kafka/pull/11573#issuecomment-989917167
Thanks @tamara-skokova for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/KAFKA-10333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-10333.
Fix Version/s: 2.8.0
Resolution: Duplicate
DUP of KAFKA-10833
> Provide an API to
[
https://issues.apache.org/jira/browse/KAFKA-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-13507:
Fix Version/s: 3.2.0
> GlobalProcessor ignores user specified names
>
[
https://issues.apache.org/jira/browse/KAFKA-13507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-13507:
Affects Version/s: 2.8.0
2.7.0
2.6.0
mimaison commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r765876199
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -206,11 +210,25 @@ object ConsoleProducer {
.describedAs("size")
[
https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456515#comment-17456515
]
Shivakumar commented on KAFKA-13077:
Hi [~junrao]
here is the summary of our issue
[
https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456515#comment-17456515
]
Shivakumar edited comment on KAFKA-13077 at 12/9/21, 3:44 PM:
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r765940228
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1959,10 +1969,28 @@ class KafkaConfig private(doLog: Boolean, val props:
jav
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r765940228
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1959,10 +1969,28 @@ class KafkaConfig private(doLog: Boolean, val props:
jav
jsancio commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r765978037
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -443,7 +443,7 @@ private void onBecomeLeader(long currentTimeMs) {
blcksrx opened a new pull request #11588:
URL: https://github.com/apache/kafka/pull/11588
If a `RetriableException` is raised from `Task::start()`, this doesn't
trigger an attempt to start that connector again. I.e. the restart
functionality currently is only implemented for exceptions rai
[
https://issues.apache.org/jira/browse/KAFKA-13488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456673#comment-17456673
]
Prateek Agarwal commented on KAFKA-13488:
-
Hi [~hachikuji] [~jolshan] I have inc
vvcephei commented on pull request #11585:
URL: https://github.com/apache/kafka/pull/11585#issuecomment-990152230
Failures were unrelated:
```
Build / JDK 11 and Scala 2.13 /
kafka.admin.LeaderElectionCommandTest.[1] Type=Raft,
Name=testElectionResultOutput, Security=PLAINTEXT
vvcephei merged pull request #11585:
URL: https://github.com/apache/kafka/pull/11585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
cadonna commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r765909088
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,229 @@
+
vvcephei commented on a change in pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#discussion_r766152319
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java
##
@@ -62,4 +71,32 @@ public static void updatePositio
guozhangwang commented on a change in pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#discussion_r766163659
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java
##
@@ -62,4 +71,32 @@ public static void updatePos
[
https://issues.apache.org/jira/browse/KAFKA-13512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-13512.
--
Resolution: Fixed
> topicIdsToNames and topicNamesToIds allocate unnecessary maps
> --
[
https://issues.apache.org/jira/browse/KAFKA-13500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456736#comment-17456736
]
Guozhang Wang commented on KAFKA-13500:
---
[~mjsax] What I was wondering is that if
guozhangwang commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r766183746
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java
##
@@ -128,6 +131,22 @@ public static Sens
wcarlson5 opened a new pull request #11589:
URL: https://github.com/apache/kafka/pull/11589
update an unclear log message and method name
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r766186102
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -108,6 +124,44 @@ private void unlock() {
wcarlson5 commented on pull request #11589:
URL: https://github.com/apache/kafka/pull/11589#issuecomment-990318661
@guozhangwang Some changes you requested in a follow up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
guozhangwang commented on pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#issuecomment-990344744
> Actually, the reason why we don't choose `enum` is because that only works
for our built-in state stores, not for **custom state store**. So, with the
`StoreImplementatio
Colin McCabe created KAFKA-13528:
Summary: KRaft RegisterBroker should validate that the cluster ID
matches
Key: KAFKA-13528
URL: https://issues.apache.org/jira/browse/KAFKA-13528
Project: Kafka
vvcephei commented on a change in pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#discussion_r766220034
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java
##
@@ -62,4 +71,32 @@ public static void updatePositio
vvcephei commented on a change in pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#discussion_r766221104
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1764,20 +1764,18 @@ protected void processStreamThread(final
Consu
vvcephei commented on a change in pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#discussion_r766221800
##
File path:
streams/src/main/java/org/apache/kafka/streams/query/StateQueryResult.java
##
@@ -97,11 +97,15 @@ public void addResult(final int partitio
vvcephei commented on a change in pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#discussion_r766223374
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java
##
@@ -107,10 +107,10 @@ private void putAndMaybe
vvcephei commented on a change in pull request #11581:
URL: https://github.com/apache/kafka/pull/11581#discussion_r766226822
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java
##
@@ -125,22 +128,81 @@
final long de
ableegoldman opened a new pull request #11590:
URL: https://github.com/apache/kafka/pull/11590
Followup to
[#11562](https://github.com/apache/kafka/commit/e20f102298cc3e056e079cbd1cb33913a9ade0ce#
) to fix tests
--
This is an automated message from the Apache Git Service.
To respond t
ableegoldman merged pull request #11590:
URL: https://github.com/apache/kafka/pull/11590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
[
https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456854#comment-17456854
]
David Mao commented on KAFKA-13388:
---
[~dhofftgt]
Looking at where the NetworkClient
[
https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456854#comment-17456854
]
David Mao edited comment on KAFKA-13388 at 12/10/21, 1:56 AM:
[
https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456854#comment-17456854
]
David Mao edited comment on KAFKA-13388 at 12/10/21, 2:10 AM:
chengang created KAFKA-13529:
Summary: kafka mm2 consumer configurattion invalid
Key: KAFKA-13529
URL: https://issues.apache.org/jira/browse/KAFKA-13529
Project: Kafka
Issue Type: Bug
Affects
[
https://issues.apache.org/jira/browse/KAFKA-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chengang updated KAFKA-13529:
-
Labels: mirror-maker (was: )
> kafka mm2 consumer configurattion invalid
>
[
https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456888#comment-17456888
]
Lucas Bradstreet commented on KAFKA-13388:
--
I'm pretty sure [~david.mao] is cor
69 matches
Mail list logo
