[GitHub] [kafka] socutes opened a new pull request #11529: KAFKA-12932: Interfaces for SnapshotReader and SnapshotWriter

2021-11-23 Thread GitBox
socutes opened a new pull request #11529: URL: https://github.com/apache/kafka/pull/11529 Change the snapshot API so that SnapshotWriter and SnapshotReader are interfaces. Change the existing types SnapshotWriter and SnapshotReader to use a different name and to implement the interfaces in

[jira] [Commented] (KAFKA-13466) when kafka-console-producer.sh, batch.size defaults is Inconsistent with official documentation

2021-11-23 Thread peterwanner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447834#comment-17447834 ] peterwanner commented on KAFKA-13466: - in fact, the batch-size config is already not

[jira] (KAFKA-13466) when kafka-console-producer.sh, batch.size defaults is Inconsistent with official documentation

2021-11-23 Thread peterwanner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13466 ] peterwanner deleted comment on KAFKA-13466: - was (Author: JIRAUSER280504): in fact, the batch-size config is already not used everywhere in the code anymore, so delete this and may not have

[jira] [Updated] (KAFKA-13466) when kafka-console-producer.sh, batch.size defaults is Inconsistent with official documentation

2021-11-23 Thread peterwanner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peterwanner updated KAFKA-13466: Description:   official docs: !image-2021-11-19-04-05-15-754.png!   shell scripts is: !image-

[GitHub] [kafka] socutes commented on pull request #11529: KAFKA-12932: Interfaces for SnapshotReader and SnapshotWriter

2021-11-23 Thread GitBox
socutes commented on pull request #11529: URL: https://github.com/apache/kafka/pull/11529#issuecomment-976288375 @jsancio @cmccabe ,PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] dajac commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

2021-11-23 Thread GitBox
dajac commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r754898485 ## File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala ## @@ -867,6 +868,39 @@ class SocketServerTest { } } + @Test + def t

[GitHub] [kafka] socutes opened a new pull request #11530: MINOR:Delete unnecessary comment information

2021-11-23 Thread GitBox
socutes opened a new pull request #11530: URL: https://github.com/apache/kafka/pull/11530 Delete unnecessary comment information:SnapshotWriter.createWithHeader() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] socutes commented on pull request #11530: MINOR:Delete unnecessary comment information

2021-11-23 Thread GitBox
socutes commented on pull request #11530: URL: https://github.com/apache/kafka/pull/11530#issuecomment-976295157 @showuon PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] peterwanner commented on pull request #11517: KAFKA-13466:when kafka-console-producer.sh, delete unused config batch.size

2021-11-23 Thread GitBox
peterwanner commented on pull request #11517: URL: https://github.com/apache/kafka/pull/11517#issuecomment-976305262 > ok, jira content and commit title both have changed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac commented on a change in pull request #11452: KAFKA-13412; Ensure initTransactions() safe for retry after timeout

2021-11-23 Thread GitBox
dajac commented on a change in pull request #11452: URL: https://github.com/apache/kafka/pull/11452#discussion_r754969939 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -404,10 +405,12 @@ private TransactionalReque

[jira] [Updated] (KAFKA-13454) kafka has duplicate configuration information log information printing during startup

2021-11-23 Thread zhangzhanchang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangzhanchang updated KAFKA-13454: --- Component/s: core > kafka has duplicate configuration information log information printing d

[GitHub] [kafka] naanagon opened a new pull request #11531: Dependency report generation using owaspSuppression for false positives

2021-11-23 Thread GitBox
naanagon opened a new pull request #11531: URL: https://github.com/apache/kafka/pull/11531 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

[GitHub] [kafka] naanagon commented on pull request #11531: Dependency report generation using owaspSuppression for false positives

2021-11-23 Thread GitBox
naanagon commented on pull request #11531: URL: https://github.com/apache/kafka/pull/11531#issuecomment-976434042 Motivation for this pr: Users shouldn't work on false positive if kafka has a way to suppress false positives then users won't waste time by searching for fixes which are false

[GitHub] [kafka] naanagon commented on a change in pull request #11531: Dependency report generation using owaspSuppression for false positives

2021-11-23 Thread GitBox
naanagon commented on a change in pull request #11531: URL: https://github.com/apache/kafka/pull/11531#discussion_r755045609 ## File path: build.gradle ## @@ -51,6 +51,12 @@ spotless { } } +dependencyCheck { + suppressionFile = "${rootDir}/owaspSuppressions.xml" + failB

[GitHub] [kafka] naanagon edited a comment on pull request #11531: Dependency report generation using owaspSuppression for false positives

2021-11-23 Thread GitBox
naanagon edited a comment on pull request #11531: URL: https://github.com/apache/kafka/pull/11531#issuecomment-976434042 Motivation for this pr: Users shouldn't work on false positive if kafka has a way to suppress false positives then users won't waste time by searching for fixes which ar

[GitHub] [kafka] naanagon commented on pull request #11516: MINOR: Use MessageDigest equals when comparing signature

2021-11-23 Thread GitBox
naanagon commented on pull request #11516: URL: https://github.com/apache/kafka/pull/11516#issuecomment-976437161 > @showuon, thank you. @dajac, Could you please take a look @showuon Can you merge the pr..? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-11-23 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-976480514 Hi @naanagon, > Upgrading from log4j 1.2.17 to log4j 2 can be done because of log4j 2 features but not for this([CVE-2019-17571](https://github.com/advisories/GHSA-2qr

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position information of records to changelog

2021-11-23 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755096395 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java ## @@ -0,0 +1,38 @@ +/* + * L

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position information of records to changelog

2021-11-23 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755097382 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -110,17 +120,26 @@ public RecordCollect

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position information of records to changelog

2021-11-23 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755098773 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -110,17 +120,26 @@ public RecordCollect

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position information of records to changelog

2021-11-23 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755099262 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java ## @@ -155,6 +169,11 @@ private void putInternal(

[jira] [Updated] (KAFKA-13456) Tighten KRaft config checks/constraints

2021-11-23 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13456: -- Fix Version/s: (was: 3.1.0) > Tighten KRaft config checks/constraints > --

[jira] [Updated] (KAFKA-13456) Tighten KRaft config checks/constraints

2021-11-23 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13456: -- Affects Version/s: (was: 3.1.0) > Tighten KRaft config checks/constraints > --

[jira] [Updated] (KAFKA-13456) Tighten KRaft config checks/constraints

2021-11-23 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13456: -- Summary: Tighten KRaft config checks/constraints (was: controller.listener.names is required

[jira] [Updated] (KAFKA-13456) Tighten KRaft config checks/constraints

2021-11-23 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13456: -- Fix Version/s: 3.1.0 > Tighten KRaft config checks/constraints > -

[jira] [Updated] (KAFKA-13456) Tighten KRaft config checks/constraints

2021-11-23 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13456: -- Component/s: kraft > Tighten KRaft config checks/constraints > ---

[GitHub] [kafka] functioner commented on a change in pull request #11504: KAFKA-13457: socketChannel in Acceptor#accept is not closed upon IOException

2021-11-23 Thread GitBox
functioner commented on a change in pull request #11504: URL: https://github.com/apache/kafka/pull/11504#discussion_r755134052 ## File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala ## @@ -867,6 +868,39 @@ class SocketServerTest { } } + @Test +

[jira] [Updated] (KAFKA-13456) Tighten KRaft config checks/constraints

2021-11-23 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13456: -- Description: We need to tighten the configuration constraints/checks related to KRaft configs

[GitHub] [kafka] C0urante commented on pull request #11526: KAFKA-13472: Correct last-committed offsets tracking for sink tasks after partial revocation

2021-11-23 Thread GitBox
C0urante commented on pull request #11526: URL: https://github.com/apache/kafka/pull/11526#issuecomment-976645713 @kkonstantine would you mind taking a look at this 3.1 blocker? There was a small issue in https://github.com/apache/kafka/pull/10563 that causes a regression in some edge case

[GitHub] [kafka] C0urante commented on pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
C0urante commented on pull request #11524: URL: https://github.com/apache/kafka/pull/11524#issuecomment-976648092 @rhauch would you mind taking a look at this 3.1 blocker? There was an issue in https://github.com/apache/kafka/pull/11323 that causes a regression in some fairly-common cases.

[jira] [Commented] (KAFKA-13472) Connect can lose track of last committed offsets for topic partitions after partial consumer revocation

2021-11-23 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448053#comment-17448053 ] Chris Egerton commented on KAFKA-13472: --- Approved as a 3.1 blocker on the [3.1 rel

[jira] [Commented] (KAFKA-13469) End-of-life offset commit for source task can take place before all records are flushed

2021-11-23 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448054#comment-17448054 ] Chris Egerton commented on KAFKA-13469: --- Approved as a 3.1 blocker on the [3.1 rel

[GitHub] [kafka] jsancio commented on a change in pull request #11527: KAFKA-13357: store producer IDs in broker snapshots

2021-11-23 Thread GitBox
jsancio commented on a change in pull request #11527: URL: https://github.com/apache/kafka/pull/11527#discussion_r755272758 ## File path: metadata/src/test/java/org/apache/kafka/image/ProducerIdsImageTest.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] rhauch commented on a change in pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
rhauch commented on a change in pull request #11524: URL: https://github.com/apache/kafka/pull/11524#discussion_r755233693 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -68,6 +75,9 @@ SubmittedRecord submit(Map partiti

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position information of records to changelog

2021-11-23 Thread GitBox
vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755285644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -246,4 +246,4 @@ public TaskType ta

[GitHub] [kafka] C0urante commented on a change in pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
C0urante commented on a change in pull request #11524: URL: https://github.com/apache/kafka/pull/11524#discussion_r755298524 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -132,6 +144,27 @@ public CommittableOffsets com

[GitHub] [kafka] C0urante commented on a change in pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
C0urante commented on a change in pull request #11524: URL: https://github.com/apache/kafka/pull/11524#discussion_r755307964 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -68,6 +75,9 @@ SubmittedRecord submit(Map parti

[GitHub] [kafka] C0urante commented on a change in pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
C0urante commented on a change in pull request #11524: URL: https://github.com/apache/kafka/pull/11524#discussion_r755308105 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -42,9 +46,12 @@ // Visible for testing

[GitHub] [kafka] C0urante commented on pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
C0urante commented on pull request #11524: URL: https://github.com/apache/kafka/pull/11524#issuecomment-976820904 Thanks for the rapid turnaround, @rhauch. I'm not convinced yet that the suggestion to restructure `SubmittedRecords` to remove synchronized blocks will result in correct behav

[GitHub] [kafka] cadonna opened a new pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

2021-11-23 Thread GitBox
cadonna opened a new pull request #11532: URL: https://github.com/apache/kafka/pull/11532 Log messages were changed in the AssignorConfiguration that are also used for verification in system test StreamsCooperativeRebalanceUpgradeTest.test_upgrade_to_cooperative_rebalance. This

[GitHub] [kafka] cadonna commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

2021-11-23 Thread GitBox
cadonna commented on pull request #11532: URL: https://github.com/apache/kafka/pull/11532#issuecomment-976843320 Call for review: @showuon, @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] cadonna commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

2021-11-23 Thread GitBox
cadonna commented on pull request #11532: URL: https://github.com/apache/kafka/pull/11532#issuecomment-976849574 The system test passes locally with this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] hachikuji commented on a change in pull request #11452: KAFKA-13412; Ensure initTransactions() safe for retry after timeout

2021-11-23 Thread GitBox
hachikuji commented on a change in pull request #11452: URL: https://github.com/apache/kafka/pull/11452#discussion_r755351132 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -1183,20 +1183,42 @@ private TxnOffsetCom

[GitHub] [kafka] hachikuji commented on a change in pull request #11452: KAFKA-13412; Ensure initTransactions() safe for retry after timeout

2021-11-23 Thread GitBox
hachikuji commented on a change in pull request #11452: URL: https://github.com/apache/kafka/pull/11452#discussion_r755352383 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -423,34 +426,31 @@ public synchronized Tr

[GitHub] [kafka] C0urante commented on a change in pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
C0urante commented on a change in pull request #11524: URL: https://github.com/apache/kafka/pull/11524#discussion_r755382470 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -132,6 +144,27 @@ public CommittableOffsets com

[jira] [Updated] (KAFKA-13456) Tighten KRaft config checks/constraints

2021-11-23 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino updated KAFKA-13456: -- Priority: Blocker (was: Major) > Tighten KRaft config checks/constraints > --

[GitHub] [kafka] cadonna commented on a change in pull request #11455: KAFKA-13423: GlobalThread should not log ERROR on clean shutdown

2021-11-23 Thread GitBox
cadonna commented on a change in pull request #11455: URL: https://github.com/apache/kafka/pull/11455#discussion_r755399596 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java ## @@ -337,7 +341,18 @@ public void shouldGetTo

[GitHub] [kafka] jlprat commented on pull request #11432: KAFKA-13399 towards scala3

2021-11-23 Thread GitBox
jlprat commented on pull request #11432: URL: https://github.com/apache/kafka/pull/11432#issuecomment-977013245 Hi @cmccabe and @ijuma, I would highly appreciate your feedback on this PR. Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] cmccabe commented on a change in pull request #11457: MINOR: guard against calls to exit in QuorumTestHarness tests

2021-11-23 Thread GitBox
cmccabe commented on a change in pull request #11457: URL: https://github.com/apache/kafka/pull/11457#discussion_r755422333 ## File path: core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala ## @@ -163,6 +163,26 @@ abstract class QuorumTestHarness extends Loggin

[GitHub] [kafka] cmccabe commented on pull request #11457: MINOR: guard against calls to exit in QuorumTestHarness tests

2021-11-23 Thread GitBox
cmccabe commented on pull request #11457: URL: https://github.com/apache/kafka/pull/11457#issuecomment-977021255 > Thanks for the change @cmccabe . Which tests are impacted by this change? I could only find ReplicationQuotasTestRig does that matches your understanding? We have actual

[GitHub] [kafka] dajac commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

2021-11-23 Thread GitBox
dajac commented on pull request #11532: URL: https://github.com/apache/kafka/pull/11532#issuecomment-977035425 @cadonna Could we mention the commit which changed it in the description? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] florin-akermann commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-11-23 Thread GitBox
florin-akermann commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-977040250 @dajac Thanks for the guidance so far. The KIP seems to be approved - thanks for the vote :). What else is needed to bring this across the finish line? -- This is a

[GitHub] [kafka] rhauch commented on a change in pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
rhauch commented on a change in pull request #11524: URL: https://github.com/apache/kafka/pull/11524#discussion_r755438613 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -132,6 +141,28 @@ public CommittableOffsets commi

[GitHub] [kafka] kkonstantine commented on a change in pull request #11526: KAFKA-13472: Correct last-committed offsets tracking for sink tasks after partial revocation

2021-11-23 Thread GitBox
kkonstantine commented on a change in pull request #11526: URL: https://github.com/apache/kafka/pull/11526#discussion_r755431755 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -654,6 +655,7 @@ private void closePartitions

[jira] [Commented] (KAFKA-13009) Metrics recorder is re-initialised with different task

2021-11-23 Thread Frank Pestke (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448237#comment-17448237 ] Frank Pestke commented on KAFKA-13009: -- We experienced the same problem with KStrea

[GitHub] [kafka] dajac commented on pull request #11456: KAFKA-13351: Add possibility to write kafka headers in Kafka Console Producer

2021-11-23 Thread GitBox
dajac commented on pull request #11456: URL: https://github.com/apache/kafka/pull/11456#issuecomment-977129809 @florin-akermann Awesome! I will try to make a pass on the PR in the next few days. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] vvcephei commented on pull request #11514: Tracking latest seen offset in state stores

2021-11-23 Thread GitBox
vvcephei commented on pull request #11514: URL: https://github.com/apache/kafka/pull/11514#issuecomment-977151342 Hey @patrickstuedi , I just manually kicked off a build of your PR: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11514/7/console Not sure why it didn't buil

[GitHub] [kafka] dajac commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

2021-11-23 Thread GitBox
dajac commented on pull request #11532: URL: https://github.com/apache/kafka/pull/11532#issuecomment-977155971 @cadonna LGTM. Could you cherry-pick it to 3.1 as well? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] C0urante commented on pull request #11526: KAFKA-13472: Correct last-committed offsets tracking for sink tasks after partial revocation

2021-11-23 Thread GitBox
C0urante commented on pull request #11526: URL: https://github.com/apache/kafka/pull/11526#issuecomment-977168354 Thanks @kkonstantine. My description may have been a little misleading; to clarify, none of this was caught by automated testing (unit, integration, or system); it was discover

[GitHub] [kafka] C0urante commented on a change in pull request #11526: KAFKA-13472: Correct last-committed offsets tracking for sink tasks after partial revocation

2021-11-23 Thread GitBox
C0urante commented on a change in pull request #11526: URL: https://github.com/apache/kafka/pull/11526#discussion_r755504329 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -654,6 +655,7 @@ private void closePartitions(Col

[GitHub] [kafka] C0urante commented on a change in pull request #11526: KAFKA-13472: Correct last-committed offsets tracking for sink tasks after partial revocation

2021-11-23 Thread GitBox
C0urante commented on a change in pull request #11526: URL: https://github.com/apache/kafka/pull/11526#discussion_r755504329 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -654,6 +655,7 @@ private void closePartitions(Col

[GitHub] [kafka] C0urante commented on a change in pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
C0urante commented on a change in pull request #11524: URL: https://github.com/apache/kafka/pull/11524#discussion_r755508174 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -132,6 +141,28 @@ public CommittableOffsets com

[GitHub] [kafka] C0urante commented on a change in pull request #11524: KAFKA-13469: Block for in-flight record delivery before end-of-life source task offset commit

2021-11-23 Thread GitBox
C0urante commented on a change in pull request #11524: URL: https://github.com/apache/kafka/pull/11524#discussion_r755508174 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java ## @@ -132,6 +141,28 @@ public CommittableOffsets com

[jira] [Created] (KAFKA-13473) Log cleaner Dynamic configs aren't applied after a restart

2021-11-23 Thread Tim Patterson (Jira)
Tim Patterson created KAFKA-13473: - Summary: Log cleaner Dynamic configs aren't applied after a restart Key: KAFKA-13473 URL: https://issues.apache.org/jira/browse/KAFKA-13473 Project: Kafka

[jira] [Updated] (KAFKA-13473) Log cleaner Dynamic configs aren't applied after a restart

2021-11-23 Thread Tim Patterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Patterson updated KAFKA-13473: -- Description: Upon restarting kafka, dynamically configured log cleaner configs aren't picked

[GitHub] [kafka] lbradstreet commented on pull request #11376: KAFKA-13342: LeaderAndIsrRequest should not be sent for topic queued for deletion

2021-11-23 Thread GitBox
lbradstreet commented on pull request #11376: URL: https://github.com/apache/kafka/pull/11376#issuecomment-977323145 @dajac I forgot about this change. Do you have some time to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] lbradstreet opened a new pull request #11533: MINOR: reduce log cleaner offset memory usage in KRaftClusterTestKit

2021-11-23 Thread GitBox
lbradstreet opened a new pull request #11533: URL: https://github.com/apache/kafka/pull/11533 We now use 2MB as with the other test harnesses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (KAFKA-13289) Bulk processing correctly ordered input data through a join with kafka-streams results in `Skipping record for expired segment`

2021-11-23 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447676#comment-17447676 ] Eugen Dück edited comment on KAFKA-13289 at 11/24/21, 12:49 AM: --

[jira] [Commented] (KAFKA-13465) when auto create topics enable,server create inner topic of MirrorMaker unexpectedly

2021-11-23 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448316#comment-17448316 ] Dongjin Lee commented on KAFKA-13465: - It seems like you created the topic 'mm2-conf

[GitHub] [kafka] showuon commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

2021-11-23 Thread GitBox
showuon commented on pull request #11532: URL: https://github.com/apache/kafka/pull/11532#issuecomment-977433641 > @cadonna LGTM. Could you cherry-pick it to 3.1 as well? Thanks. I agree this PR to be cherry-pick into 3.1 branch since it'll also affect 3.1. Thank you. -- This is a

[GitHub] [kafka] showuon commented on pull request #11532: MINOR: Fix system test test_upgrade_to_cooperative_rebalance

2021-11-23 Thread GitBox
showuon commented on pull request #11532: URL: https://github.com/apache/kafka/pull/11532#issuecomment-977436124 > @cadonna Could we mention the commit which changed it in the description? This issue is caused by the PR https://github.com/apache/kafka/pull/11490 changed log message.

[GitHub] [kafka] JooKS-me closed pull request #11521: MINOR: Polish code in test of streams

2021-11-23 Thread GitBox
JooKS-me closed pull request #11521: URL: https://github.com/apache/kafka/pull/11521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[jira] [Resolved] (KAFKA-13117) After processors, migrate TupleForwarder and CacheFlushListener

2021-11-23 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya resolved KAFKA-13117. -- Resolution: Fixed [https://github.com/apache/kafka/pull/11481]

[jira] [Created] (KAFKA-13474) Regression in dynamic update of client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
Igor Shipenkov created KAFKA-13474: -- Summary: Regression in dynamic update of client-side SSL factory Key: KAFKA-13474 URL: https://issues.apache.org/jira/browse/KAFKA-13474 Project: Kafka I

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Attachment: failed-controller-single-session-2029.pcap.gz > Regression in dynamic update

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic conf

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Summary: Regression in dynamic update of broker client-side SSL factory (was: Regression in

[jira] [Commented] (KAFKA-13465) when auto create topics enable,server create inner topic of MirrorMaker unexpectedly

2021-11-23 Thread ZhenChun Pan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448344#comment-17448344 ] ZhenChun Pan commented on KAFKA-13465: -- Yeah,  I already check it.  Except MM2, no

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic conf

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic conf

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic conf

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic conf

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic conf

[GitHub] [kafka] showuon commented on a change in pull request #11376: KAFKA-13342: LeaderAndIsrRequest should not be sent for topic queued for deletion

2021-11-23 Thread GitBox
showuon commented on a change in pull request #11376: URL: https://github.com/apache/kafka/pull/11376#discussion_r755680018 ## File path: core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala ## @@ -394,6 +394,23 @@ class ReplicaStateMachineTest { } @

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic bro

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic bro

[GitHub] [kafka] ableegoldman commented on a change in pull request #11479: KAFKA-12648: Make changing the named topologies blocking

2021-11-23 Thread GitBox
ableegoldman commented on a change in pull request #11479: URL: https://github.com/apache/kafka/pull/11479#discussion_r755680080 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -118,40 +

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic bro

[jira] [Updated] (KAFKA-13474) Regression in dynamic update of broker client-side SSL factory

2021-11-23 Thread Igor Shipenkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Shipenkov updated KAFKA-13474: --- Description: h1. Problem It seems, after updating listener SSL certificate with dynamic bro