[GitHub] [kafka] chia7712 commented on a change in pull request #11169: KAFKA-10859: Add test annotation to FileStreamSourceTaskTest.testInvalidFile and speed up the test

2021-09-04 Thread GitBox
chia7712 commented on a change in pull request #11169: URL: https://github.com/apache/kafka/pull/11169#discussion_r702252480 ## File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java ## @@ -220,12 +220,12 @@ public void testMissingFil

[jira] [Commented] (KAFKA-10859) add @Test annotation to FileStreamSourceTaskTest.testInvalidFile and reduce the loop count to speedup the test

2021-09-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409895#comment-17409895 ] Chia-Ping Tsai commented on KAFKA-10859: {quote} could you please take a look a

[GitHub] [kafka] pjfanning commented on a change in pull request #11025: Scala 3 Compilation with 2.12 support

2021-09-04 Thread GitBox
pjfanning commented on a change in pull request #11025: URL: https://github.com/apache/kafka/pull/11025#discussion_r702263941 ## File path: gradle/dependencies.gradle ## @@ -132,7 +145,7 @@ libs += [ jacksonAnnotations: "com.fasterxml.jackson.core:jackson-annotations:$versi

[GitHub] [kafka] ijuma opened a new pull request #11296: MINOR: Replace Java 16 with Java 17 in Jenkins build

2021-09-04 Thread GitBox
ijuma opened a new pull request #11296: URL: https://github.com/apache/kafka/pull/11296 Java 17 is at release candidate stage and it will be a LTS release (first one since Java 11). ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] ijuma commented on pull request #11296: MINOR: Replace Java 16 with Java 17 in Jenkins build

2021-09-04 Thread GitBox
ijuma commented on pull request #11296: URL: https://github.com/apache/kafka/pull/11296#issuecomment-912992178 I expect that this will require some work before it can be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Assigned] (KAFKA-10897) kafka quota optimization

2021-09-04 Thread Kahn Cheny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kahn Cheny reassigned KAFKA-10897: -- Assignee: Kahn Cheny > kafka quota optimization > > >

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11211: KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…

2021-09-04 Thread GitBox
vamossagar12 commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r702306432 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -292,13 +408,46 @@ public V fetch(final K

[jira] [Commented] (KAFKA-12550) Introduce RESTORING state to the KafkaStreams FSM

2021-09-04 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410010#comment-17410010 ] Sagar Rao commented on KAFKA-12550: --- [~ableegoldman]/ [~mjsax], Thanks. it makes sense

[GitHub] [kafka] jasonyanwenl opened a new pull request #11297: KAFKA-10038: Supports default client.id for ConsoleConsumer, ProducerPerformance, ConsumerPerformance

2021-09-04 Thread GitBox
jasonyanwenl opened a new pull request #11297: URL: https://github.com/apache/kafka/pull/11297 Currently in `ConsoleConsumer`/`ProducerPerformance`/`ConsolePerformance`, we will not set `client.id` if it is not provided by the user. Simiarly to what we already did for `ConsoleProducer`([c

[GitHub] [kafka] jasonyanwenl edited a comment on pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-09-04 Thread GitBox
jasonyanwenl edited a comment on pull request #11241: URL: https://github.com/apache/kafka/pull/11241#issuecomment-913083574 Hi @cadonna Could you please help review/approve/merge this PR? Thanks! As for the user exception task we discussed before, I was trying to create a ticket but

[GitHub] [kafka] jasonyanwenl commented on pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-09-04 Thread GitBox
jasonyanwenl commented on pull request #11241: URL: https://github.com/apache/kafka/pull/11241#issuecomment-913083574 Hi @cadonna Could you please help review/approve/merge this PR? Thanks! As for the user exception task we discussed before, I was trying to create a ticket but I real