[GitHub] [kafka] dielhennr commented on a change in pull request #11281: KAFKA-12886: Enable request forwarding to the controller by default for zookeeper mutation protocols in IBP 3.1 and higher [REW

2021-08-29 Thread GitBox
dielhennr commented on a change in pull request #11281: URL: https://github.com/apache/kafka/pull/11281#discussion_r697964085 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2622,6 +2623,32 @@ class KafkaApis(val requestChannel: RequestChannel, .s

[GitHub] [kafka] dengziming commented on a change in pull request #11261: KAFKA-13228: Ensure ApiVersionRequest is properly handled in KRaft

2021-08-29 Thread GitBox
dengziming commented on a change in pull request #11261: URL: https://github.com/apache/kafka/pull/11261#discussion_r698028813 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -98,7 +98,7 @@ END_QUORUM_EPOCH(ApiMessageType.END_QUORUM_

[GitHub] [kafka] dengziming commented on a change in pull request #11261: KAFKA-13228: Ensure ApiVersionRequest is properly handled in KRaft

2021-08-29 Thread GitBox
dengziming commented on a change in pull request #11261: URL: https://github.com/apache/kafka/pull/11261#discussion_r698029148 ## File path: core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala ## @@ -39,15 +39,6 @@ abstract class AbstractApiVersionsReque

[GitHub] [kafka] il-kyun opened a new pull request #11282: MINOR: Fix redundant static modifier for Ops enum

2021-08-29 Thread GitBox
il-kyun opened a new pull request #11282: URL: https://github.com/apache/kafka/pull/11282 Ops enum in KafkaRaftClient.Registration has redundant static modifier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
Oliver Hutchison created KAFKA-13249: Summary: Checkpoints do not contain latest offsets on shutdown when using EOS Key: KAFKA-13249 URL: https://issues.apache.org/jira/browse/KAFKA-13249 Project:

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Description: When using EOS the `.checkpoint` file created when a stateful streams app i

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Description: When using EOS the {{.checkpoint}} file created when a stateful streams app

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Description: When using EOS the {{.checkpoint}} file created when a stateful streams app

[GitHub] [kafka] hutchiko opened a new pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-29 Thread GitBox
hutchiko opened a new pull request #11283: URL: https://github.com/apache/kafka/pull/11283 When using EOS checkpointed offsets are not updated to the latest offsets from the changelog because the `maybeWriteCheckpoint` method is only ever called when `commitNeeded=false`. This change will

[jira] [Commented] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406472#comment-17406472 ] Oliver Hutchison commented on KAFKA-13249: -- I have created a PR with a test whi

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Description: When using EOS the {{.checkpoint}} file created when a stateful streams app

[jira] [Comment Edited] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406472#comment-17406472 ] Oliver Hutchison edited comment on KAFKA-13249 at 8/29/21, 10:27 PM: -

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Description: When using EOS the {{.checkpoint}} file created when a stateful streams app

[jira] [Comment Edited] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406472#comment-17406472 ] Oliver Hutchison edited comment on KAFKA-13249 at 8/29/21, 10:28 PM: -

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Description: When using EOS the {{.checkpoint}} file created when a stateful streams app

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Affects Version/s: 2.7.1 > Checkpoints do not contain latest offsets on shutdown when us

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Affects Version/s: 2.7.0 > Checkpoints do not contain latest offsets on shutdown when us

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Description: When using EOS the {{.checkpoint}} file created when a stateful streams app

[jira] [Updated] (KAFKA-13249) Checkpoints do not contain latest offsets on shutdown when using EOS

2021-08-29 Thread Oliver Hutchison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Hutchison updated KAFKA-13249: - Description: When using EOS the {{.checkpoint}} file created when a stateful streams app

[GitHub] [kafka] dengziming commented on a change in pull request #11261: KAFKA-13228: Ensure ApiVersionRequest is properly handled in KRaft

2021-08-29 Thread GitBox
dengziming commented on a change in pull request #11261: URL: https://github.com/apache/kafka/pull/11261#discussion_r698028813 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -98,7 +98,7 @@ END_QUORUM_EPOCH(ApiMessageType.END_QUORUM_

[GitHub] [kafka] yangdaixai commented on pull request #11226: KAFKA-13175; Optimization TopicExistsException,When a topic is marked…

2021-08-29 Thread GitBox
yangdaixai commented on pull request #11226: URL: https://github.com/apache/kafka/pull/11226#issuecomment-907974299 @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11076: KAFKA-12486: Enforce Rebalance when a TaskCorruptedException is throw…

2021-08-29 Thread GitBox
vamossagar12 commented on a change in pull request #11076: URL: https://github.com/apache/kafka/pull/11076#discussion_r698176806 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -590,7 +590,14 @@ boolean runLoop() {

[GitHub] [kafka] vamossagar12 commented on a change in pull request #11076: KAFKA-12486: Enforce Rebalance when a TaskCorruptedException is throw…

2021-08-29 Thread GitBox
vamossagar12 commented on a change in pull request #11076: URL: https://github.com/apache/kafka/pull/11076#discussion_r698177313 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -590,7 +590,14 @@ boolean runLoop() {