[GitHub] [kafka] clolov commented on pull request #11214: KAFKA-12994 Migrate JoinWindowsTest and SessionWindowsTest to new API

clolov commented on pull request #11214: URL: https://github.com/apache/kafka/pull/11214#issuecomment-903224639 @ableegoldman - I have aimed to re-introduce the tests which explicitly exercise the older API. I was debating whether or not to add back https://github.com/apache/kafka/blob/tru

[jira] [Updated] (KAFKA-13222) Records in newly rolled segment couldn't be fetched by consumer

[ https://issues.apache.org/jira/browse/KAFKA-13222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Liu updated KAFKA-13222: Affects Version/s: 2.0.1 > Records in newly rolled segment couldn't be fetched by consumer > -

[GitHub] [kafka] jeqo commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

jeqo commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r693484448 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorSupplier.java ## @@ -150,16 +153,16 @@ public

[GitHub] [kafka] jeqo commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

jeqo commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r693484714 ## File path: streams/src/test/java/org/apache/kafka/test/MockInternalNewProcessorContext.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeqo commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

jeqo commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r693487470 ## File path: streams/src/test/java/org/apache/kafka/test/MockInternalNewProcessorContext.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeqo commented on a change in pull request #11213: KAFKA-13201: Convert KTable suppress to new PAPI

jeqo commented on a change in pull request #11213: URL: https://github.com/apache/kafka/pull/11213#discussion_r693488664 ## File path: streams/src/test/java/org/apache/kafka/test/MockInternalNewProcessorContext.java ## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] splett2 commented on a change in pull request #11244: KAFKA-12933: Flaky test ReassignPartitionsIntegrationTest.testReassignmentWithAlterIsrDisabled

splett2 commented on a change in pull request #11244: URL: https://github.com/apache/kafka/pull/11244#discussion_r693517822 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -127,7 +127,6 @@ class ReassignPartitionsIntegrat

[GitHub] [kafka] splett2 commented on a change in pull request #11244: KAFKA-12933: Flaky test ReassignPartitionsIntegrationTest.testReassignmentWithAlterIsrDisabled

splett2 commented on a change in pull request #11244: URL: https://github.com/apache/kafka/pull/11244#discussion_r693517822 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -127,7 +127,6 @@ class ReassignPartitionsIntegrat

[GitHub] [kafka] splett2 commented on pull request #11127: KAFKA-13134: Give up group metadata lock before sending heartbeat response

splett2 commented on pull request #11127: URL: https://github.com/apache/kafka/pull/11127#issuecomment-903286581 @dajac do you mind taking a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-903309159 Thanks for your feedback @guozhangwang I thought "simply" killing the thread was the original intention. I'll look into killing the whole instance once @cadona provides his

[GitHub] [kafka] guozhangwang commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

guozhangwang commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r693539139 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -200,6 +201,30 @@ public Rock

[jira] [Commented] (KAFKA-13217) Reconsider skipping the LeaveGroup on close() or add an overload that does so

[ https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402859#comment-17402859 ] Guozhang Wang commented on KAFKA-13217: --- Thanks [~ableegoldman] I think this is a

[jira] [Commented] (KAFKA-8295) Add merge() operator to State Stores.

[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402860#comment-17402860 ] Guozhang Wang commented on KAFKA-8295: -- We do not have a KIP yet, but I hope we can

[GitHub] [kafka] guozhangwang commented on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

guozhangwang commented on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-903313112 Sorry @vamossagar12 for the late reply.. I took a look at the current PR and it looks good to me. The throughput numbers seems promising as well. Could you clean up the PR

[GitHub] [kafka] guozhangwang commented on pull request #11181: MINOR: optimize the OrderedBytes#upperRange for not all query cases

guozhangwang commented on pull request #11181: URL: https://github.com/apache/kafka/pull/11181#issuecomment-903356533 Hi @showuon . I am not sure what do you mean by "not all query cases", could you elaborate a bit? My understanding from your PR is that, the `upperRange` is called fo

[GitHub] [kafka] ijuma commented on pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

ijuma commented on pull request #9590: URL: https://github.com/apache/kafka/pull/9590#issuecomment-903376356 What's remaining to get this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] showuon commented on pull request #11181: MINOR: optimize the OrderedBytes#upperRange for not all query cases

showuon commented on pull request #11181: URL: https://github.com/apache/kafka/pull/11181#issuecomment-903378114 @guozhangwang , thanks for checking the PR... on Sunday. :) > So in practice for window stores, that suffix's first byte has a large chance to be 0, and hence worth optimi

[GitHub] [kafka] showuon edited a comment on pull request #11181: MINOR: optimize the OrderedBytes#upperRange for not all query cases

showuon edited a comment on pull request #11181: URL: https://github.com/apache/kafka/pull/11181#issuecomment-903378114 @guozhangwang , thanks for checking the PR... on Sunday. :) > So in practice for window stores, that suffix's first byte has a large chance to be 0, and hence worth

[GitHub] [kafka] showuon edited a comment on pull request #11181: MINOR: optimize the OrderedBytes#upperRange for not all query cases

showuon edited a comment on pull request #11181: URL: https://github.com/apache/kafka/pull/11181#issuecomment-903378114 @guozhangwang , thanks for checking the PR... on Sunday. :) > So in practice for window stores, that suffix's first byte has a large chance to be 0, and hence worth

[GitHub] [kafka] showuon commented on pull request #11187: [WIP] KAFKA-5966: let CacheFunction#key return ByteBuffer

showuon commented on pull request #11187: URL: https://github.com/apache/kafka/pull/11187#issuecomment-903380258 @guozhangwang , thanks for the response. I closed this PR because I think we need a bigger change (maybe a KIP), to address this `byte[]` change to `ByteBuffer` change, to make

[GitHub] [kafka] showuon edited a comment on pull request #11187: [WIP] KAFKA-5966: let CacheFunction#key return ByteBuffer

showuon edited a comment on pull request #11187: URL: https://github.com/apache/kafka/pull/11187#issuecomment-903380258 @guozhangwang , thanks for the response. I closed this PR because I think we need a bigger change (maybe a KIP), to address this `byte[]` to `ByteBuffer` change, to make

[GitHub] [kafka] showuon edited a comment on pull request #11187: [WIP] KAFKA-5966: let CacheFunction#key return ByteBuffer

showuon edited a comment on pull request #11187: URL: https://github.com/apache/kafka/pull/11187#issuecomment-903380258 @guozhangwang , thanks for the response. I closed this PR because I think we need a bigger change (maybe a KIP), to address this `byte[]` to `ByteBuffer` change, to make

[GitHub] [kafka] jolshan commented on pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on pull request #9590: URL: https://github.com/apache/kafka/pull/9590#issuecomment-903381796 I think just the merge conflicts, a final lookover and an lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] jacky1193610322 commented on pull request #11127: KAFKA-13134: Give up group metadata lock before sending heartbeat response

jacky1193610322 commented on pull request #11127: URL: https://github.com/apache/kafka/pull/11127#issuecomment-903421243 @splett2 do you have the lock profile before and after the patch？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on