[GitHub] [kafka] jlprat opened a new pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

2021-08-03 Thread GitBox
jlprat opened a new pull request #10784: URL: https://github.com/apache/kafka/pull/10784 Updates the scala fmt to the latest stable version Applies all the style fixes (all source code changes are done by scala fmt) Removes setting about dangling parentheses as `true` is already the

[GitHub] [kafka] jlprat closed pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

2021-08-03 Thread GitBox
jlprat closed pull request #10784: URL: https://github.com/apache/kafka/pull/10784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

2021-08-03 Thread GitBox
jlprat commented on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-891795576 I just closed and opened the PR to re-trigger Jenkins build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] tombentley merged pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

2021-08-03 Thread GitBox
tombentley merged pull request #10074: URL: https://github.com/apache/kafka/pull/10074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubs

[GitHub] [kafka] tombentley commented on pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

2021-08-03 Thread GitBox
tombentley commented on pull request #10074: URL: https://github.com/apache/kafka/pull/10074#issuecomment-891822887 @C0urante sorry for the delay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mumrah opened a new pull request #11165: MINOR Enable transaction system tests for KRaft in 3.0

2021-08-03 Thread GitBox
mumrah opened a new pull request #11165: URL: https://github.com/apache/kafka/pull/11165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] mumrah commented on pull request #11165: MINOR Enable transaction system tests for KRaft in 3.0

2021-08-03 Thread GitBox
mumrah commented on pull request #11165: URL: https://github.com/apache/kafka/pull/11165#issuecomment-891852497 http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-07-30--001.system-test-kafka-branch-builder--1627678032--mumrah--3.0-reenable-transaction

[GitHub] [kafka] rondagostino commented on pull request #11165: MINOR Enable transaction system tests for KRaft in 3.0

2021-08-03 Thread GitBox
rondagostino commented on pull request #11165: URL: https://github.com/apache/kafka/pull/11165#issuecomment-891908369 There are other tests we disabled when we didn't have transaction/idempotent producer support in KRaft. Do we want to enable them here? In `replication_test.py`, the

[jira] [Resolved] (KAFKA-12789) Remove Stale comments for meta response handling logic

2021-08-03 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao resolved KAFKA-12789. - Resolution: Fixed > Remove Stale comments for meta response handling logic > ---

[jira] [Resolved] (KAFKA-12615) Correct comments for the method Selector.clear

2021-08-03 Thread HaiyuanZhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HaiyuanZhao resolved KAFKA-12615. - Resolution: Fixed > Correct comments for the method Selector.clear > ---

[jira] [Updated] (KAFKA-12333) KafkaMetadataLog and MockLock should validate that appended epochs are monotonically

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12333: --- Description: Both the MockLog and KafkaMetadataLog should only allow

[jira] [Resolved] (KAFKA-13148) Kraft Controller doesn't handle scheduleAppend returning Long.MAX_VALUE

2021-08-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13148. - Resolution: Fixed Closing this since it was fixed by KAFKA-12158. > Kraft Controller do

[jira] [Updated] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

2021-08-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13142: Affects Version/s: (was: 3.0.0) > KRaft brokers do not validate dynamic configs before

[jira] [Updated] (KAFKA-13099) Message too large error when expiring transactionalIds

2021-08-03 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13099: Fix Version/s: 2.6.3 2.5.2 > Message too large error when expiring tran

[GitHub] [kafka] dielhennr commented on a change in pull request #11159: MINOR: Change default node id in kraft broker properties

2021-08-03 Thread GitBox
dielhennr commented on a change in pull request #11159: URL: https://github.com/apache/kafka/pull/11159#discussion_r681972655 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -239,11 +239,11 @@ public void replay(RegisterBrokerR

[GitHub] [kafka] hachikuji commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
hachikuji commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r681961452 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java ## @@ -80,6 +80,7 @@ public void write(int b) { priva

[jira] [Created] (KAFKA-13157) Kafka-dump-log needs to support snapshot records

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-13157: -- Summary: Kafka-dump-log needs to support snapshot records Key: KAFKA-13157 URL: https://issues.apache.org/jira/browse/KAFKA-13157 Project:

[GitHub] [kafka] mumrah merged pull request #11165: MINOR Enable transaction system tests for KRaft in 3.0

2021-08-03 Thread GitBox
mumrah merged pull request #11165: URL: https://github.com/apache/kafka/pull/11165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] mumrah commented on pull request #11165: MINOR Enable transaction system tests for KRaft in 3.0

2021-08-03 Thread GitBox
mumrah commented on pull request #11165: URL: https://github.com/apache/kafka/pull/11165#issuecomment-892065979 Opening a follow-on PR for the additional tests mentioned by @rondagostino -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mumrah opened a new pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah opened a new pull request #11166: URL: https://github.com/apache/kafka/pull/11166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] mumrah commented on pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892067696 Replication test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4627/ -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] mumrah commented on pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892068421 Produce bench: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4628/ -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Assigned] (KAFKA-12973) Update KIP and dev mailing list

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-12973: -- Assignee: Jose Armando Garcia Sancio > Update KIP and dev mai

[GitHub] [kafka] mumrah commented on pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892068893 Group mode transactions: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4629/ -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mumrah commented on pull request #11166: MINOR Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah commented on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892069170 Streams smoke test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4630/ -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] [Created] (KAFKA-13158) Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest

2021-08-03 Thread YI-CHEN WANG (Jira)
YI-CHEN WANG created KAFKA-13158: Summary: Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest Key: KAFKA-13158 URL: https://issues.apache.org/jira/browse/

[jira] [Resolved] (KAFKA-12997) Expose log record append time to the controller/broker

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-12997. Resolution: Fixed > Expose log record append time to the controlle

[jira] [Created] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2021-08-03 Thread David Arthur (Jira)
David Arthur created KAFKA-13159: Summary: Enable system tests for transactions in KRaft mode Key: KAFKA-13159 URL: https://issues.apache.org/jira/browse/KAFKA-13159 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2021-08-03 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392468#comment-17392468 ] David Arthur commented on KAFKA-13159: -- The main transactions_test.py were enabled

[GitHub] [kafka] rondagostino commented on a change in pull request #11166: KAFKA-13159 Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
rondagostino commented on a change in pull request #11166: URL: https://github.com/apache/kafka/pull/11166#discussion_r682008773 ## File path: tests/kafkatest/tests/core/replication_test.py ## @@ -122,14 +122,16 @@ def min_cluster_size(self): @matrix(failure_mode=["clean_s

[jira] [Updated] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2021-08-03 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-13159: - Fix Version/s: 3.1.0 > Enable system tests for transactions in KRaft mode >

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682012434 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param sourceRecor

[jira] [Created] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13160: - Summary: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft Key: KAFKA-13160 URL: https://issues.apache.org/jira/bro

[GitHub] [kafka] wycccccc opened a new pull request #11167: Kafka-13158 Replace EasyMock and PowerMock with Mockito for ConnectClusterStateImpl Test and ConnectorPluginsResourceTest

2021-08-03 Thread GitBox
wycc opened a new pull request #11167: URL: https://github.com/apache/kafka/pull/11167 Development of EasyMock and PowerMock has stagnated while Mockito continues to be actively developed. With the new Java cadence, it's a problem to depend on libraries that do bytecode generation and

[GitHub] [kafka] dielhennr opened a new pull request #11168: KAFKA-13160: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread GitBox
dielhennr opened a new pull request #11168: URL: https://github.com/apache/kafka/pull/11168 The KRaft brokers are throwing NumberFormatException when processing dynamic default broker config updates because they expect the default entity name that was used in zookeeper to be the resource n

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682018753 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -270,7 +270,8 @@ class Log(@volatile private var _dir: File, val producerStateM

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers/

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682020580 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param sourceRecor

[jira] [Resolved] (KAFKA-12647) Implement loading snapshot in the broker

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-12647. Resolution: Fixed > Implement loading snapshot in the broker > ---

[jira] [Resolved] (KAFKA-12646) Implement snapshot generation on brokers

2021-08-03 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-12646. Resolution: Fixed > Implement snapshot generation on brokers > ---

[GitHub] [kafka] mumrah edited a comment on pull request #11166: KAFKA-13159 Enable additional transaction system tests in KRaft

2021-08-03 Thread GitBox
mumrah edited a comment on pull request #11166: URL: https://github.com/apache/kafka/pull/11166#issuecomment-892069170 Streams smoke test: ~https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4630/~ https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4631/ -

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers/

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers/

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers/

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers

[jira] [Updated] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12994: --- Fix Version/s: (was: 3.0.0) 3.1.0 > Migrate all Tests

[jira] [Commented] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392530#comment-17392530 ] A. Sophie Blee-Goldman commented on KAFKA-12994: Hey [~iekpo], I'm unass

[jira] [Assigned] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12994: -- Assignee: (was: A. Sophie Blee-Goldman) > Migrate all Tests to Ne

[jira] [Assigned] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12994: -- Assignee: A. Sophie Blee-Goldman > Migrate all Tests to New API and R

[jira] [Assigned] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12994: -- Assignee: (was: Israel Ekpo) > Migrate all Tests to New API and R

[jira] [Updated] (KAFKA-12994) Migrate all Tests to New API and Remove Suppression for Deprecation Warnings related to KIP-633

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12994: --- Labels: kip-633 newbie newbie++ (was: kip kip-633) > Migrate all Tests to N

[GitHub] [kafka] Borzoo opened a new pull request #11169: KAFKA-10859: Add test annotation to FileStreamSourceTaskTest.testInvalidFile and speed up the test

2021-08-03 Thread GitBox
Borzoo opened a new pull request #11169: URL: https://github.com/apache/kafka/pull/11169 *More detailed description of your change, Added the missing @Test annotation to a test in FileStreamSourceTaskTest. The test used to loop 100 times, each time blocking for 1 second. Checking the as

[jira] [Reopened] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-08-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reopened KAFKA-13132: Found an issue where we don't sufficiently cover case 2. I have a plan to properly cover. c

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682119041 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -25,15 +25,17 @@ from kafkatest.services.zookeeper import ZookeeperService from

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682119892 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -0,0 +1,299 @@ +/* + * Licensed to th

[GitHub] [kafka] jolshan opened a new pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-03 Thread GitBox
jolshan opened a new pull request #11170: URL: https://github.com/apache/kafka/pull/11170 Before we used the metadata cache to determine whether or not to use topic IDs. Unfortunately, metadata cache updates with ZK controllers are in a separate request and may be too slow for the fetcher

[GitHub] [kafka] mjsax commented on a change in pull request #10602: KAFKA-12724: Add 2.8.0 to system tests and streams upgrade tests.

2021-08-03 Thread GitBox
mjsax commented on a change in pull request #10602: URL: https://github.com/apache/kafka/pull/10602#discussion_r682120783 ## File path: streams/upgrade-system-tests-28/src/test/java/org/apache/kafka/streams/tests/SmokeTestUtil.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the

[jira] [Assigned] (KAFKA-12395) Drop topic mapKey in DeleteTopics response

2021-08-03 Thread Hiro Kuwabara (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiro Kuwabara reassigned KAFKA-12395: - Assignee: Hiro Kuwabara > Drop topic mapKey in DeleteTopics response >

[GitHub] [kafka] codefactor commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-08-03 Thread GitBox
codefactor commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-892207657 Any plans that this will be released? It looks like this upgrade happens to include the following issue fix in rocksdb: https://github.com/facebook/rocksdb/issues/67

[GitHub] [kafka] jolshan opened a new pull request #11171: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 (part 2)

2021-08-03 Thread GitBox
jolshan opened a new pull request #11171: URL: https://github.com/apache/kafka/pull/11171 Most of [KAFKA-13132](https://issues.apache.org/jira/browse/KAFKA-13132) has been resolved, but there is one part of one case not covered. From the ticket: `2. We only assign the topic ID when we

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682164477 ## File path: clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java ## @@ -483,6 +486,49 @@ public void testBuildEndTxnMarker()

[GitHub] [kafka] cmccabe commented on pull request #11168: KAFKA-13160: Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread GitBox
cmccabe commented on pull request #11168: URL: https://github.com/apache/kafka/pull/11168#issuecomment-892230644 I don't think this is the right place to make this change. BrokerMetadataPublisher should be calling `processConfigChanges` with the expected name, instead. -- This is an aut

[GitHub] [kafka] ableegoldman commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-08-03 Thread GitBox
ableegoldman commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-892231916 @codefactor it will be released in 3.0, which is currently in the final stages of testing and preparing for release. -- This is an automated message from the Apache Git

[GitHub] [kafka] guozhangwang commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
guozhangwang commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682090255 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTaskCreator.java ## @@ -66,14 +72,26 @@ ); }

[GitHub] [kafka] mjsax opened a new pull request #11172: MINOR: update stream-stream join docs

2021-08-03 Thread GitBox
mjsax opened a new pull request #11172: URL: https://github.com/apache/kafka/pull/11172 Call for review @JimGalasyn @spena @ableegoldman (cf https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Streams+Join+Semantics) Must be cherry-picked to `3.0` branch. -- This is an automat

[GitHub] [kafka] mjsax commented on pull request #11172: MINOR: update stream-stream join docs

2021-08-03 Thread GitBox
mjsax commented on pull request #11172: URL: https://github.com/apache/kafka/pull/11172#issuecomment-892239651 \cc @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Created] (KAFKA-13161) Follower leader and ISR state not updated after partition change in KRaft

2021-08-03 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13161: --- Summary: Follower leader and ISR state not updated after partition change in KRaft Key: KAFKA-13161 URL: https://issues.apache.org/jira/browse/KAFKA-13161 Proje

[GitHub] [kafka] mjsax merged pull request #11157: MINOR: Replace EasyMock with Mockito in test-utils module

2021-08-03 Thread GitBox
mjsax merged pull request #11157: URL: https://github.com/apache/kafka/pull/11157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] mjsax commented on pull request #11157: MINOR: Replace EasyMock with Mockito in test-utils module

2021-08-03 Thread GitBox
mjsax commented on pull request #11157: URL: https://github.com/apache/kafka/pull/11157#issuecomment-892262404 Thanks for the PR @dengziming! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (KAFKA-13162) ElectLeader API must be forwarded to Controller

2021-08-03 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13162: --- Summary: ElectLeader API must be forwarded to Controller Key: KAFKA-13162 URL: https://issues.apache.org/jira/browse/KAFKA-13162 Project: Kafka Issue T

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers

[jira] [Updated] (KAFKA-13160) Fix BrokerConfigHandler to expect empty string as the resource name for dynamic default broker configs in KRaft

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Description: In a ZK cluster, dynamic default broker configs are stored in the zNode /brokers

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682018753 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -270,7 +270,8 @@ class Log(@volatile private var _dir: File, val producerStateM

[GitHub] [kafka] mjsax commented on a change in pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

2021-08-03 Thread GitBox
mjsax commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r682192656 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindow.java ## @@ -19,33 +19,24 @@ import org.apache.kafka.streams.kstr

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682020580 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param sourceRecor

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392610#comment-17392610 ] A. Sophie Blee-Goldman commented on KAFKA-12559: [~brz] I'd say give [~m

[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392611#comment-17392611 ] Matthias J. Sax commented on KAFKA-13145: - Personally, I am not a fan on `Inclus

[jira] [Updated] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13152: Labels: needs-kip (was: ) > Replace "buffered.records.per.partition" with "input.buffer.m

[GitHub] [kafka] codefactor commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-08-03 Thread GitBox
codefactor commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-892269776 @ableegoldman , Thanks a lot - do you have any links where I can find out the following: 1. are there any breaking changes if I upgrade from version 2.6 to 3.0? 2. whe

[jira] [Commented] (KAFKA-13150) How is Kafkastream configured to consume data from a specified offset ?

2021-08-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392612#comment-17392612 ] Matthias J. Sax commented on KAFKA-13150: - To subscribe, follow instruction on t

[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392615#comment-17392615 ] A. Sophie Blee-Goldman commented on KAFKA-13145: Fine with me. FWIW the

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682018753 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -270,7 +270,8 @@ class Log(@volatile private var _dir: File, val producerStateM

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-08-03 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r682020580 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param sourceRecor

[jira] [Updated] (KAFKA-13160) Fix the code the calls the broker’s config handler to pass the expected default resource name for dynamic broker configs

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Summary: Fix the code the calls the broker’s config handler to pass the expected default resou

[jira] [Updated] (KAFKA-13160) Fix the code that calls the broker’s config handler to pass the expected default resource name when using KRaft.

2021-08-03 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13160: -- Summary: Fix the code that calls the broker’s config handler to pass the expected default reso

[GitHub] [kafka] ableegoldman commented on pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

2021-08-03 Thread GitBox
ableegoldman commented on pull request #10568: URL: https://github.com/apache/kafka/pull/10568#issuecomment-892279085 1) Possibly -- you can check out the [Streams upgrade guide](https://kafka.apache.org/28/documentation/streams/upgrade-guide), which describes any public API changes in eac

[GitHub] [kafka] hachikuji commented on a change in pull request #11171: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 (part 2)

2021-08-03 Thread GitBox
hachikuji commented on a change in pull request #11171: URL: https://github.com/apache/kafka/pull/11171#discussion_r682206623 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -313,14 +313,20 @@ class Partition(val topicPartition: TopicPartition, } d

[jira] [Commented] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392626#comment-17392626 ] Luke Chen commented on KAFKA-13145: --- I'm good. I'll close this ticket and add `Sliding

[jira] [Resolved] (KAFKA-13145) Renaming the time interval window for better understanding

2021-08-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13145. --- Resolution: Won't Fix > Renaming the time interval window for better understanding > ---

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682230209 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java ## @@ -64,6 +65,9 @@ private final Map

[GitHub] [kafka] ccding commented on pull request #11110: MINOR: move tiered storage related configs to a separate class within LogConfig

2021-08-03 Thread GitBox
ccding commented on pull request #0: URL: https://github.com/apache/kafka/pull/0#issuecomment-892299485 Included the motivation and updated the PR. PTAL @ijuma @junrao @kowshik @satishd -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] showuon commented on a change in pull request #11124: KAFKA-12839: Let SlidingWindows aggregation support window size of 0

2021-08-03 Thread GitBox
showuon commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r682231711 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,79 @@ priv

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682231789 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -105,31 +

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682233727 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -53,44 +56,162 @@ private static f

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-08-03 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r682234726 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -53,44 +56,162 @@ private static f

  1   2   >