[jira] [Updated] (KAFKA-13144) Change the LOG level from DEBUG to WARN/ERROR for error traces when obtaining topic metadata

2021-07-29 Thread Fernando Blanch Calvete (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fernando Blanch Calvete updated KAFKA-13144: Description: As a suggestion, it would be very useful that when obtaining

[GitHub] [kafka] showuon commented on a change in pull request #11124: KAFKA-12839: use sessionWindow to represent SlidingWindows

2021-07-29 Thread GitBox
showuon commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r678905114 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,79 @@ priv

[GitHub] [kafka] showuon commented on a change in pull request #11124: KAFKA-12839: use sessionWindow to represent SlidingWindows

2021-07-29 Thread GitBox
showuon commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r678903334 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -351,7 +351,8 @@ private void pro

[GitHub] [kafka] showuon commented on a change in pull request #11124: KAFKA-12839: use sessionWindow to represent SlidingWindows

2021-07-29 Thread GitBox
showuon commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r678908862 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,79 @@ priv

[GitHub] [kafka] showuon commented on pull request #11124: KAFKA-12839: use sessionWindow to represent SlidingWindows

2021-07-29 Thread GitBox
showuon commented on pull request #11124: URL: https://github.com/apache/kafka/pull/11124#issuecomment-83904 @mjsax @ableegoldman @lct45 , I've added tests. Please help review. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] showuon opened a new pull request #11143: MINOR: close TopologyTestDriver to release resources

2021-07-29 Thread GitBox
showuon opened a new pull request #11143: URL: https://github.com/apache/kafka/pull/11143 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Commented] (KAFKA-10897) kafka quota optimization

2021-07-29 Thread Kahn Cheny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389732#comment-17389732 ] Kahn Cheny commented on KAFKA-10897: Is this feature scheduled?  > kafka quota opti

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11129: Fix for flaky test in StoreQueryIntegrationTest

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11129: URL: https://github.com/apache/kafka/pull/11129#discussion_r678945688 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -152,11 +150,17 @@ public void shoul

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r678965032 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyKeyValueStore.java ## @@ -65,9 +66,10 @@ * Order is not guaranteed

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r678972106 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableEfficientRangeQueryTest.java ## @@ -0,0 +1,259 @@ +/* + * Licensed t

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r678991669 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RangeQueryIntegrationTest.java ## @@ -0,0 +1,304 @@ +/* + * Licensed to th

[GitHub] [kafka] showuon commented on a change in pull request #11129: Fix for flaky test in StoreQueryIntegrationTest

2021-07-29 Thread GitBox
showuon commented on a change in pull request #11129: URL: https://github.com/apache/kafka/pull/11129#discussion_r679004926 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -153,10 +152,15 @@ public void shouldQuery

[jira] [Created] (KAFKA-13150) How is Kafkastream configured to consume data from a specified offset ?

2021-07-29 Thread wangjh (Jira)
wangjh created KAFKA-13150: -- Summary: How is Kafkastream configured to consume data from a specified offset ? Key: KAFKA-13150 URL: https://issues.apache.org/jira/browse/KAFKA-13150 Project: Kafka

[jira] [Commented] (KAFKA-2729) Cached zkVersion not equal to that in zookeeper, broker not recovering.

2021-07-29 Thread Raj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389844#comment-17389844 ] Raj commented on KAFKA-2729: Hi [~junrao] , This was just hit in our production as well alth

[GitHub] [kafka] gklijs opened a new pull request #11144: Call the serialize method including headers from the MockProducer

2021-07-29 Thread GitBox
gklijs opened a new pull request #11144: URL: https://github.com/apache/kafka/pull/11144 Currently when using serializers like the Cloud Event Serializer, we need to do a work around so it doesn't throw an error. Using the method taking the headers would prevent this. Since the default imp

[GitHub] [kafka] ijuma commented on pull request #11091: MINOR: Fix `testResolveDnsLookup` by using a mocked dns resolver

2021-07-29 Thread GitBox
ijuma commented on pull request #11091: URL: https://github.com/apache/kafka/pull/11091#issuecomment-889066685 Cherry-picked to older branches (2.2...2.8). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-13146) Consider client use cases for accessing controller endpoints

2021-07-29 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389899#comment-17389899 ] Tom Bentley commented on KAFKA-13146: - {quote}We have also considered whether the in

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r679163645 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java ## @@ -81,6 +82,16 @@ public void after

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r679163645 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java ## @@ -81,6 +82,16 @@ public void after

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r679166423 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java ## @@ -383,13 +394,29 @@ public void sh

[jira] [Commented] (KAFKA-10897) kafka quota optimization

2021-07-29 Thread yangyijun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389911#comment-17389911 ] yangyijun commented on KAFKA-10897: --- Not yet > kafka quota optimization > ---

[jira] [Issue Comment Deleted] (KAFKA-10897) kafka quota optimization

2021-07-29 Thread yangyijun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yangyijun updated KAFKA-10897: -- Comment: was deleted (was: Not yet) > kafka quota optimization > > >

[jira] [Commented] (KAFKA-10897) kafka quota optimization

2021-07-29 Thread yangyijun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389913#comment-17389913 ] yangyijun commented on KAFKA-10897: --- It has not started yet > kafka quota optimizatio

[jira] [Commented] (KAFKA-10897) kafka quota optimization

2021-07-29 Thread yangyijun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389918#comment-17389918 ] yangyijun commented on KAFKA-10897: --- Dear [~KahnCheny] , will you start this part of t

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r679180578 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractKeyValueStoreTest.java ## @@ -383,13 +394,29 @@ public void sh

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r679214947 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableEfficientRangeQueryTest.java ## @@ -0,0 +1,259 @@ +/* + * Licensed t

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11129: Fix for flaky test in StoreQueryIntegrationTest

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11129: URL: https://github.com/apache/kafka/pull/11129#discussion_r679220475 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -153,10 +152,15 @@ public void shoul

[GitHub] [kafka] rhauch commented on pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

2021-07-29 Thread GitBox
rhauch commented on pull request #10978: URL: https://github.com/apache/kafka/pull/10978#issuecomment-889222564 @mimaison, @omkreddy, @rajinisivaram, @ijuma: would some of you be able to review these changes? Thanks! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] vvcephei commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
vvcephei commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r679231292 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableEfficientRangeQueryTest.java ## @@ -0,0 +1,264 @@ +/* + * Licensed to the

[GitHub] [kafka] vvcephei commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
vvcephei commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r679242346 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableEfficientRangeQueryTest.java ## @@ -0,0 +1,259 @@ +/* + * Licensed to the

[jira] [Commented] (KAFKA-2376) Add Kafka Connect metrics

2021-07-29 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389959#comment-17389959 ] Randall Hauch commented on KAFKA-2376: -- [~ramkrish1489], it's not uncommon for a KIP

[GitHub] [kafka] wycccccc commented on pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for Streams…

2021-07-29 Thread GitBox
wycc commented on pull request #10881: URL: https://github.com/apache/kafka/pull/10881#issuecomment-889261189 @ableegoldman Have resloved conflict, thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] hachikuji merged pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

2021-07-29 Thread GitBox
hachikuji merged pull request #11135: URL: https://github.com/apache/kafka/pull/11135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Resolved] (KAFKA-13143) Disable Metadata endpoint for KRaft controller

2021-07-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13143. - Resolution: Fixed > Disable Metadata endpoint for KRaft controller > ---

[GitHub] [kafka] dielhennr commented on pull request #10463: KAFKA-12670: support unclean.leader.election.enable in KRaft mode

2021-07-29 Thread GitBox
dielhennr commented on pull request #10463: URL: https://github.com/apache/kafka/pull/10463#issuecomment-889296194 I stacked https://github.com/cmccabe/kafka/pull/6 on this PR to address some of Jun's comments. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] hachikuji commented on a change in pull request #11140: MINOR: log epoch and offset truncation similarly to HWM truncation

2021-07-29 Thread GitBox
hachikuji commented on a change in pull request #11140: URL: https://github.com/apache/kafka/pull/11140#discussion_r679314640 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -247,7 +247,7 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jsancio commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

2021-07-29 Thread GitBox
jsancio commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r679326328 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -2248,24 +2248,23 @@ public void poll() { } @Override -p

[GitHub] [kafka] vincent81jiang commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-07-29 Thread GitBox
vincent81jiang commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r679342991 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -171,38 +179,40 @@ private static FilterResult filterT

[GitHub] [kafka] vincent81jiang commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-07-29 Thread GitBox
vincent81jiang commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r679343797 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -628,26 +634,43 @@ private[log] class Cleaner(val id: Int, * @param sourceRe

[GitHub] [kafka] vincent81jiang commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-07-29 Thread GitBox
vincent81jiang commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r679346836 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -239,9 +249,68 @@ private static FilterResult filterTo

[jira] [Updated] (KAFKA-13095) TransactionsTest is failing in kraft mode

2021-07-29 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13095: - Description: TransactionsTest#testSendOffsetsToTransactionTimeout keeps flaking on Jenkins. > T

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679367945 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,142 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679367945 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,142 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679380487 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,142 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679380487 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,142 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679381726 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,142 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679381726 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,142 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679381726 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,142 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] hachikuji commented on a change in pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-29 Thread GitBox
hachikuji commented on a change in pull request #11126: URL: https://github.com/apache/kafka/pull/11126#discussion_r679344612 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1392,11 +1393,24 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Commented] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

2021-07-29 Thread Ming Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390068#comment-17390068 ] Ming Liu commented on KAFKA-12713: -- Certainly, [~kaihuang], please take the ownership o

[GitHub] [kafka] mattwong949 commented on a change in pull request #10914: [KAKFA-8522] Streamline tombstone and transaction marker removal

2021-07-29 Thread GitBox
mattwong949 commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r679386530 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java ## @@ -239,9 +249,68 @@ private static FilterResult filterTo(To

[GitHub] [kafka] jolshan commented on a change in pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-29 Thread GitBox
jolshan commented on a change in pull request #11126: URL: https://github.com/apache/kafka/pull/11126#discussion_r679387634 ## File path: core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala ## @@ -1115,6 +1115,63 @@ class ControllerIntegrationTest extends

[GitHub] [kafka] jolshan commented on a change in pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-29 Thread GitBox
jolshan commented on a change in pull request #11126: URL: https://github.com/apache/kafka/pull/11126#discussion_r679390415 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1392,11 +1393,24 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Resolved] (KAFKA-9858) CVE-2016-3189 Use-after-free vulnerability in bzip2recover in bzip2 1.0.6 allows remote attackers to cause a denial of service (crash) via a crafted bzip2 file, related

2021-07-29 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9858. -- Fix Version/s: 3.0.0 Resolution: Fixed > CVE-2016-3189 Use-after-free vulnerability in

[jira] [Commented] (KAFKA-9858) CVE-2016-3189 Use-after-free vulnerability in bzip2recover in bzip2 1.0.6 allows remote attackers to cause a denial of service (crash) via a crafted bzip2 file, relate

2021-07-29 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390071#comment-17390071 ] Guozhang Wang commented on KAFKA-9858: -- Hi [~sihuan][~microle.dong] in https://issue

[GitHub] [kafka] jolshan commented on a change in pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-29 Thread GitBox
jolshan commented on a change in pull request #11126: URL: https://github.com/apache/kafka/pull/11126#discussion_r679404417 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1392,11 +1393,24 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] vvcephei merged pull request #10693: KAFKA-12625: Fix the NOTICE file

2021-07-29 Thread GitBox
vvcephei merged pull request #10693: URL: https://github.com/apache/kafka/pull/10693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] ableegoldman commented on a change in pull request #11124: KAFKA-12839: use sessionWindow to represent SlidingWindows

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r679413628 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,79 @@

[jira] [Commented] (KAFKA-13150) How is Kafkastream configured to consume data from a specified offset ?

2021-07-29 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390096#comment-17390096 ] A. Sophie Blee-Goldman commented on KAFKA-13150: [~wangjh] Jira is inten

[jira] [Resolved] (KAFKA-13150) How is Kafkastream configured to consume data from a specified offset ?

2021-07-29 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-13150. Resolution: Invalid > How is Kafkastream configured to consume data from a

[GitHub] [kafka] jlprat commented on pull request #10693: KAFKA-12625: Fix the NOTICE file

2021-07-29 Thread GitBox
jlprat commented on pull request #10693: URL: https://github.com/apache/kafka/pull/10693#issuecomment-889393251 Thanks @vvcephei for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Assigned] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

2021-07-29 Thread Kai Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kai Huang reassigned KAFKA-12713: - Assignee: Kai Huang > Report "REAL" follower/consumer fetch latency > -

[GitHub] [kafka] bbejeck commented on pull request #11143: MINOR: close TopologyTestDriver to release resources

2021-07-29 Thread GitBox
bbejeck commented on pull request #11143: URL: https://github.com/apache/kafka/pull/11143#issuecomment-889413715 failure unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] bbejeck merged pull request #11143: MINOR: close TopologyTestDriver to release resources

2021-07-29 Thread GitBox
bbejeck merged pull request #11143: URL: https://github.com/apache/kafka/pull/11143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] bbejeck commented on pull request #11143: MINOR: close TopologyTestDriver to release resources

2021-07-29 Thread GitBox
bbejeck commented on pull request #11143: URL: https://github.com/apache/kafka/pull/11143#issuecomment-889414313 Merged #11143 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] hachikuji merged pull request #11131: KAFKA-13137: KRaft Controller Metric MBean names incorrectly quoted

2021-07-29 Thread GitBox
hachikuji merged pull request #11131: URL: https://github.com/apache/kafka/pull/11131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Updated] (KAFKA-13137) KRaft Controller Metric MBean names are incorrectly quoted

2021-07-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13137: Affects Version/s: (was: 3.0.0) > KRaft Controller Metric MBean names are incorrectly

[GitHub] [kafka] hachikuji commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

2021-07-29 Thread GitBox
hachikuji commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r679390697 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -186,13 +186,18 @@ class KafkaRaftManager[T]( records: Seq[T], isAtomic:

[GitHub] [kafka] hachikuji commented on a change in pull request #10909: KAFKA-12158: Better return type of RaftClient.scheduleAppend

2021-07-29 Thread GitBox
hachikuji commented on a change in pull request #10909: URL: https://github.com/apache/kafka/pull/10909#discussion_r679391787 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -61,10 +61,12 @@ public synchronized void increment() { i

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679380487 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -22,20 +22,142 @@ import java.util.{Collections, Properties} import kafka.log.L

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

2021-07-29 Thread GitBox
patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r679468196 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RangeQueryIntegrationTest.java ## @@ -0,0 +1,304 @@ +/* + * Licensed to th

[GitHub] [kafka] jsancio commented on a change in pull request #11116: KAFKA-13114: Revert state and reregister raft listener

2021-07-29 Thread GitBox
jsancio commented on a change in pull request #6: URL: https://github.com/apache/kafka/pull/6#discussion_r679475174 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -580,12 +580,17 @@ public void run() throws Exception {

[GitHub] [kafka] vvcephei merged pull request #11129: Fix for flaky test in StoreQueryIntegrationTest

2021-07-29 Thread GitBox
vvcephei merged pull request #11129: URL: https://github.com/apache/kafka/pull/11129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] vvcephei commented on pull request #11129: MINOR: Fix for flaky test in StoreQueryIntegrationTest

2021-07-29 Thread GitBox
vvcephei commented on pull request #11129: URL: https://github.com/apache/kafka/pull/11129#issuecomment-889472160 Oy. I didn't notice the commit title was wrongly formatted before merging. Fixed in the PR title anyway. Thanks for this contribution, @patrickstuedi ! And thanks for the

[jira] [Created] (KAFKA-13151) KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

2021-07-29 Thread Ryan Dielhenn (Jira)
Ryan Dielhenn created KAFKA-13151: - Summary: KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured. Key: KAFKA-13151 URL: https://issues.apache.org/jira/bro

[GitHub] [kafka] hachikuji merged pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-29 Thread GitBox
hachikuji merged pull request #11126: URL: https://github.com/apache/kafka/pull/11126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Updated] (KAFKA-13151) KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

2021-07-29 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13151: -- Description: alter.config.policy.class.name and create.topic.policy.class.name are unsupported

[jira] [Updated] (KAFKA-13151) KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

2021-07-29 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13151: -- Description: alter.config.policy.class.name and create.topic.policy.class.name are all unsuppo

[jira] [Assigned] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-13132: --- Assignee: Justine Olshan (was: Jose Armando Garcia Sancio) > Upgrading to topic ID

[jira] [Resolved] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13132. - Resolution: Fixed > Upgrading to topic IDs in LISR requests has gaps introduced in 3.0 >

[jira] [Updated] (KAFKA-13132) Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

2021-07-29 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13132: Affects Version/s: (was: 3.0.0) > Upgrading to topic IDs in LISR requests has gaps int

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679517755 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2740,23 +2798,78 @@ class KafkaApis(val requestChannel: RequestChannel, }.t

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679517755 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2740,23 +2798,78 @@ class KafkaApis(val requestChannel: RequestChannel, }.t

[GitHub] [kafka] dielhennr commented on a change in pull request #11141: KAFKA-13142: Validate dynamic config alterations prior to forwarding them to the KRaft controller.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11141: URL: https://github.com/apache/kafka/pull/11141#discussion_r679517755 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2740,23 +2798,78 @@ class KafkaApis(val requestChannel: RequestChannel, }.t

[GitHub] [kafka] dielhennr opened a new pull request #11145: KAFKA-13151: KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

2021-07-29 Thread GitBox
dielhennr opened a new pull request #11145: URL: https://github.com/apache/kafka/pull/11145 alter.config.policy.class.name and create.topic.policy.class.name are unsupported by KRaft. KRaft servers should fail startup if any of these are configured. Tested this manually by enabling/

[GitHub] [kafka] ableegoldman commented on a change in pull request #10788: KAFKA-12648: Pt. 3 - addNamedTopology API

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #10788: URL: https://github.com/apache/kafka/pull/10788#discussion_r679531569 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/NamedTopologyTest.java ## @@ -112,15 +103,15 @@ public void shouldR

[jira] [Updated] (KAFKA-13151) KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

2021-07-29 Thread Ryan Dielhenn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13151: -- Fix Version/s: 3.0.0 > KRaft does not support Policies (e.g. AlterConfigPolicy). The server sh

[GitHub] [kafka] hachikuji commented on a change in pull request #11145: KAFKA-13151: KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

2021-07-29 Thread GitBox
hachikuji commented on a change in pull request #11145: URL: https://github.com/apache/kafka/pull/11145#discussion_r679533321 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2008,5 +2008,10 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boo

[GitHub] [kafka] dielhennr commented on a change in pull request #11145: KAFKA-13151: KRaft does not support Policies (e.g. AlterConfigPolicy). The server should fail startup if any are configured.

2021-07-29 Thread GitBox
dielhennr commented on a change in pull request #11145: URL: https://github.com/apache/kafka/pull/11145#discussion_r679539020 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2008,5 +2008,10 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boo

[GitHub] [kafka] ableegoldman commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r679571374 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -16,10 +16,304 @@ */ package org.apa

[GitHub] [kafka] ableegoldman commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r679572637 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java ## @@ -16,17 +16,240 @@ */ package org

[GitHub] [kafka] ableegoldman commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r679572946 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java ## @@ -16,17 +16,240 @@ */ package org

[GitHub] [kafka] ableegoldman commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r679581108 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java ## @@ -16,17 +16,240 @@ */ package org

[GitHub] [kafka] ableegoldman commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r679589984 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -16,10 +16,304 @@ */ package org.apa

[GitHub] [kafka] ableegoldman commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r679589984 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -16,10 +16,304 @@ */ package org.apa

[GitHub] [kafka] showuon commented on a change in pull request #11124: KAFKA-12839: use sessionWindow to represent SlidingWindows

2021-07-29 Thread GitBox
showuon commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r679596497 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,79 @@ priv

[GitHub] [kafka] ableegoldman opened a new pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests

2021-07-29 Thread GitBox
ableegoldman opened a new pull request #11146: URL: https://github.com/apache/kafka/pull/11146 Addresses the handful of remaining feedback from [Pt. 2](https://github.com/apache/kafka/pull/10683), plus adds two new tests: one verifying a multi-topology application with a FKJ and its intern

[GitHub] [kafka] ableegoldman commented on a change in pull request #11124: KAFKA-12839: use sessionWindow to represent SlidingWindows

2021-07-29 Thread GitBox
ableegoldman commented on a change in pull request #11124: URL: https://github.com/apache/kafka/pull/11124#discussion_r679607519 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -100,17 +99,79 @@

[GitHub] [kafka] ableegoldman commented on pull request #11146: KAFKA-12648: minor followup from Pt. 2 and some new tests

2021-07-29 Thread GitBox
ableegoldman commented on pull request #11146: URL: https://github.com/apache/kafka/pull/11146#issuecomment-889585580 also cc @wcarlson5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] showuon opened a new pull request #11147: KAFKA-13108: improve ConfigCommandTest test coverage

2021-07-29 Thread GitBox
showuon opened a new pull request #11147: URL: https://github.com/apache/kafka/pull/11147 Follow up PR for this: https://github.com/apache/kafka/pull/10811#issuecomment-883408956, to improve `ConfigCommandTest` test coverage. Tests added: `shouldNotAllowAddEntityDefaultBrokerQuot

  1   2   >